)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"c6da55f1e5e4c4cc04fdde225c893b8f026f8fa0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to True, a happy path tempest test is executed. This test asserts that"},{"line_number":11,"context_line":"the volume has a greater size after the extending operation."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"However, not every volume backend supports this operation. The API call"},{"line_number":14,"context_line":"to extend an attached volume succeeds, but the scheduler fails to"},{"line_number":15,"context_line":"perform the operation, and the volume remains with the original size. In"},{"line_number":16,"context_line":"such case, the tempest test fails."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"A config option was added to tell if the backend being tested supports"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_b73b099a","line":15,"range":{"start_line":13,"start_character":59,"end_line":15,"end_character":68},"updated":"2018-09-06 00:46:06.000000000","message":"imo if this is true, extend_attached_volume should be deemed as False?","commit_id":"341b046c42de229ddef86e8e2193b12872164457"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"efeec6f3d09f1d115cefb44fd8ba4e7f003264cd","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to True, a happy path tempest test is executed. This test asserts that"},{"line_number":11,"context_line":"the volume has a greater size after the extending operation."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"However, not every volume backend supports this operation. The API call"},{"line_number":14,"context_line":"to extend an attached volume succeeds, but the scheduler fails to"},{"line_number":15,"context_line":"perform the operation, and the volume remains with the original size. In"},{"line_number":16,"context_line":"such case, the tempest test fails."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"A config option was added to tell if the backend being tested supports"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_0e37d8b1","line":15,"range":{"start_line":13,"start_character":59,"end_line":15,"end_character":68},"in_reply_to":"3f79a3b5_b73b099a","updated":"2018-10-07 13:01:53.000000000","message":"+1, we need to keep config options False by default.","commit_id":"341b046c42de229ddef86e8e2193b12872164457"}],"tempest/config.py":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"92a2ad5e4bd7430ae80a90bad78f26de58f6107b","unresolved":false,"context_lines":[{"line_number":863,"context_line":"                     \u0027enables the API test, regardless of the volume backend \u0027"},{"line_number":864,"context_line":"                     \u0027supporting this feature or not.\u0027),"},{"line_number":865,"context_line":"    cfg.BoolOpt(\u0027extend_attached_volume_support\u0027,"},{"line_number":866,"context_line":"                default\u003dFalse,"},{"line_number":867,"context_line":"                help\u003d\u0027Does the volume backend support extending the size of a \u0027"},{"line_number":868,"context_line":"                     \u0027volume which is currently attached to a server \u0027"},{"line_number":869,"context_line":"                     \u0027instance? This depends on the extend_attached_volume \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_16491b8d","line":866,"range":{"start_line":866,"start_character":24,"end_line":866,"end_character":29},"updated":"2018-09-12 17:42:01.000000000","message":"-1: The default value for this should be True. Cinder assumes that all backends (except the one that explicitly reports so) supports online_extend.","commit_id":"341b046c42de229ddef86e8e2193b12872164457"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"00258ad53feef077f3eb27d03faad0f6e334ab6a","unresolved":false,"context_lines":[{"line_number":863,"context_line":"                     \u0027enables the API test, regardless of the volume backend \u0027"},{"line_number":864,"context_line":"                     \u0027supporting this feature or not.\u0027),"},{"line_number":865,"context_line":"    cfg.BoolOpt(\u0027extend_attached_volume_support\u0027,"},{"line_number":866,"context_line":"                default\u003dFalse,"},{"line_number":867,"context_line":"                help\u003d\u0027Does the volume backend support extending the size of a \u0027"},{"line_number":868,"context_line":"                     \u0027volume which is currently attached to a server \u0027"},{"line_number":869,"context_line":"                     \u0027instance? This depends on the extend_attached_volume \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_b7c61068","line":866,"range":{"start_line":866,"start_character":24,"end_line":866,"end_character":29},"in_reply_to":"3f79a3b5_16491b8d","updated":"2018-09-13 14:30:26.000000000","message":"Done","commit_id":"341b046c42de229ddef86e8e2193b12872164457"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"f0ccd88590395dd029c4af9a74f4d6f9addf83c9","unresolved":false,"context_lines":[{"line_number":862,"context_line":"                     \u0027compute backends support this operation. This option \u0027"},{"line_number":863,"context_line":"                     \u0027enables the API test, regardless of the volume backend \u0027"},{"line_number":864,"context_line":"                     \u0027supporting this feature or not.\u0027),"},{"line_number":865,"context_line":"    cfg.BoolOpt(\u0027extend_attached_volume_support\u0027,"},{"line_number":866,"context_line":"                default\u003dFalse,"},{"line_number":867,"context_line":"                help\u003d\u0027Does the volume backend support extending the size of a \u0027"},{"line_number":868,"context_line":"                     \u0027volume which is currently attached to a server \u0027"},{"line_number":869,"context_line":"                     \u0027instance? This depends on the extend_attached_volume \u0027"},{"line_number":870,"context_line":"                     \u0027option to be set to True.\u0027)"},{"line_number":871,"context_line":"]"},{"line_number":872,"context_line":""},{"line_number":873,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_74030a0d","line":870,"range":{"start_line":865,"start_character":0,"end_line":870,"end_character":49},"updated":"2018-07-09 18:58:13.000000000","message":"Why introduce this option when `extend_attached_volume` already exists and its purpose is clear: \"Also, not all volume or compute backends support this operation.\" This echos the issue in your commit message: \"However, not every volume backend supports this operation.\"\n\nPerhaps consider updating the devstack condition around this instead: http://git.openstack.org/cgit/openstack-dev/devstack/tree/lib/tempest#n455","commit_id":"341b046c42de229ddef86e8e2193b12872164457"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"b8a714b699a21f95856660039e87ee5fbc530f36","unresolved":false,"context_lines":[{"line_number":862,"context_line":"                     \u0027compute backends support this operation. This option \u0027"},{"line_number":863,"context_line":"                     \u0027enables the API test, regardless of the volume backend \u0027"},{"line_number":864,"context_line":"                     \u0027supporting this feature or not.\u0027),"},{"line_number":865,"context_line":"    cfg.BoolOpt(\u0027extend_attached_volume_support\u0027,"},{"line_number":866,"context_line":"                default\u003dFalse,"},{"line_number":867,"context_line":"                help\u003d\u0027Does the volume backend support extending the size of a \u0027"},{"line_number":868,"context_line":"                     \u0027volume which is currently attached to a server \u0027"},{"line_number":869,"context_line":"                     \u0027instance? This depends on the extend_attached_volume \u0027"},{"line_number":870,"context_line":"                     \u0027option to be set to True.\u0027)"},{"line_number":871,"context_line":"]"},{"line_number":872,"context_line":""},{"line_number":873,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_ba54ac23","line":870,"range":{"start_line":865,"start_character":0,"end_line":870,"end_character":49},"in_reply_to":"3f79a3b5_4eb71023","updated":"2018-10-09 20:06:26.000000000","message":"If the backend does not support online extend 2 situations can happen:\n\n - driver is aware and reports \u0027online_extend\u003dFalse\u0027. In this case the operation\n   will fail with \u0027NoValidHostFound\u0027, the negative test will PASS, positive FAIL.\n\n - driver is not aware and does not report online_extend (scheduler will\n  proceed with creation). In this case, the driver can extend the volume, but\n  nothing will actually happen on Nova side. Or, the driver might trhow and error\n  leaving the volume in error state, the negative test will FAIL, positive can\n  FAIL or PASS depending on backend.","commit_id":"341b046c42de229ddef86e8e2193b12872164457"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"500ef7ed38d2ea9b6bf8cdb9dedff90dea7cdfa1","unresolved":false,"context_lines":[{"line_number":862,"context_line":"                     \u0027compute backends support this operation. This option \u0027"},{"line_number":863,"context_line":"                     \u0027enables the API test, regardless of the volume backend \u0027"},{"line_number":864,"context_line":"                     \u0027supporting this feature or not.\u0027),"},{"line_number":865,"context_line":"    cfg.BoolOpt(\u0027extend_attached_volume_support\u0027,"},{"line_number":866,"context_line":"                default\u003dFalse,"},{"line_number":867,"context_line":"                help\u003d\u0027Does the volume backend support extending the size of a \u0027"},{"line_number":868,"context_line":"                     \u0027volume which is currently attached to a server \u0027"},{"line_number":869,"context_line":"                     \u0027instance? This depends on the extend_attached_volume \u0027"},{"line_number":870,"context_line":"                     \u0027option to be set to True.\u0027)"},{"line_number":871,"context_line":"]"},{"line_number":872,"context_line":""},{"line_number":873,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_0f1ebd5e","line":870,"range":{"start_line":865,"start_character":0,"end_line":870,"end_character":49},"in_reply_to":"3f79a3b5_ba54ac23","updated":"2018-10-10 01:23:28.000000000","message":"Thanks Erlon. It seems unpredictable behaviour from driver when online extend is not supported. there can be 2-3 cases in this situation and depends on driver. ANd we will not be able to guarantee that what behaviour this negative test should verify.\n\nso i do not think we should test such negative case with unpredictable behaviour. Testing the positive case with exiting test and existing config options makes much more sense.","commit_id":"341b046c42de229ddef86e8e2193b12872164457"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"efeec6f3d09f1d115cefb44fd8ba4e7f003264cd","unresolved":false,"context_lines":[{"line_number":862,"context_line":"                     \u0027compute backends support this operation. This option \u0027"},{"line_number":863,"context_line":"                     \u0027enables the API test, regardless of the volume backend \u0027"},{"line_number":864,"context_line":"                     \u0027supporting this feature or not.\u0027),"},{"line_number":865,"context_line":"    cfg.BoolOpt(\u0027extend_attached_volume_support\u0027,"},{"line_number":866,"context_line":"                default\u003dFalse,"},{"line_number":867,"context_line":"                help\u003d\u0027Does the volume backend support extending the size of a \u0027"},{"line_number":868,"context_line":"                     \u0027volume which is currently attached to a server \u0027"},{"line_number":869,"context_line":"                     \u0027instance? This depends on the extend_attached_volume \u0027"},{"line_number":870,"context_line":"                     \u0027option to be set to True.\u0027)"},{"line_number":871,"context_line":"]"},{"line_number":872,"context_line":""},{"line_number":873,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_4eb71023","line":870,"range":{"start_line":865,"start_character":0,"end_line":870,"end_character":49},"in_reply_to":"3f79a3b5_d6d96356","updated":"2018-10-07 13:01:53.000000000","message":"Got your point that we need this variable for negative tests where this feature is not supported and tests can verify that size is unchanged. \n\nFrom this, i understood that if extended_volume is not present and it is requested then, cinder will not error and keep the original size. Will user get same success code as they get then it is success ? if so then, is it not confusing or false success ? \n\nIf cinder behaviour is success in above case then, we can go with below approach\n- Check the variable behaviour (whether size is changed or not) based on existing \u0027extend_attached_volume\u0027 config option instead of skipping the tests itself. \n- Run the tests always as no side effect if this test run against env where this feature is not supported. \n\nIf Cinder is error or there is other side effect (on nova etc) then,\n- we just check the positive case, we do not need to check error case of this feature is not available which is obvious and can be covered on cinder unit test itself.","commit_id":"341b046c42de229ddef86e8e2193b12872164457"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"92a2ad5e4bd7430ae80a90bad78f26de58f6107b","unresolved":false,"context_lines":[{"line_number":862,"context_line":"                     \u0027compute backends support this operation. This option \u0027"},{"line_number":863,"context_line":"                     \u0027enables the API test, regardless of the volume backend \u0027"},{"line_number":864,"context_line":"                     \u0027supporting this feature or not.\u0027),"},{"line_number":865,"context_line":"    cfg.BoolOpt(\u0027extend_attached_volume_support\u0027,"},{"line_number":866,"context_line":"                default\u003dFalse,"},{"line_number":867,"context_line":"                help\u003d\u0027Does the volume backend support extending the size of a \u0027"},{"line_number":868,"context_line":"                     \u0027volume which is currently attached to a server \u0027"},{"line_number":869,"context_line":"                     \u0027instance? This depends on the extend_attached_volume \u0027"},{"line_number":870,"context_line":"                     \u0027option to be set to True.\u0027)"},{"line_number":871,"context_line":"]"},{"line_number":872,"context_line":""},{"line_number":873,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_d6d96356","line":870,"range":{"start_line":865,"start_character":0,"end_line":870,"end_character":49},"in_reply_to":"5f7c97a3_74030a0d","updated":"2018-09-12 17:42:01.000000000","message":"This is tricky, so, this new option says to tempest whether the backend being tested supports online_extend or not.\n\nSo, with this patch, we have now 2 tests for online_extend. One tests the behavior of backends that supports online_extend, the other tests the behaviour of backends that does not support it.\n\nThe existent extend_attached_volume will say whether to run those tests or not.","commit_id":"341b046c42de229ddef86e8e2193b12872164457"}]}