)]}'
{"tempest/api/compute/servers/test_device_tagging.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4679060e34db42316a61f80dcfa5b285e0e5dd2f","unresolved":false,"context_lines":[{"line_number":318,"context_line":"    def verify_empty_devices(self, md_json):"},{"line_number":319,"context_line":"        md_dict \u003d json.loads(md_json)"},{"line_number":320,"context_line":"        try:"},{"line_number":321,"context_line":"            self.assertEmpty(md_dict[\u0027devices\u0027])"},{"line_number":322,"context_line":"            return True"},{"line_number":323,"context_line":"        except Exception:"},{"line_number":324,"context_line":"            LOG.debug(\"Devices dict is not empty: %s\", md_dict[\u0027devices\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_f674b506","line":321,"range":{"start_line":321,"start_character":12,"end_line":321,"end_character":48},"updated":"2018-06-29 00:22:30.000000000","message":"or what we can check here is to check the non presence of specified tags [\u0027nic-tag\u0027, \u0027volume-tag\u0027] so that if any other devices is there we do not keep trying in wait loop.","commit_id":"972bb7e991486d7816de25921f50b9230c0c77c1"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d27dd1642227e2ffb63c4ef394befa265646ed44","unresolved":false,"context_lines":[{"line_number":318,"context_line":"    def verify_empty_devices(self, md_json):"},{"line_number":319,"context_line":"        md_dict \u003d json.loads(md_json)"},{"line_number":320,"context_line":"        try:"},{"line_number":321,"context_line":"            self.assertEmpty(md_dict[\u0027devices\u0027])"},{"line_number":322,"context_line":"            return True"},{"line_number":323,"context_line":"        except Exception:"},{"line_number":324,"context_line":"            LOG.debug(\"Devices dict is not empty: %s\", md_dict[\u0027devices\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_cf68b7f5","line":321,"range":{"start_line":321,"start_character":12,"end_line":321,"end_character":48},"in_reply_to":"5f7c97a3_f674b506","updated":"2018-07-16 12:35:03.000000000","message":"I can propose such patch also but first I would like to know what is still in this dict :)","commit_id":"972bb7e991486d7816de25921f50b9230c0c77c1"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"e0fb8034b81f04788a68e35fc775c80729b0d8b9","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        try:"},{"line_number":321,"context_line":"            self.assertEmpty(md_dict[\u0027devices\u0027])"},{"line_number":322,"context_line":"            return True"},{"line_number":323,"context_line":"        except Exception:"},{"line_number":324,"context_line":"            LOG.debug(\"Devices dict is not empty: %s\", md_dict[\u0027devices\u0027])"},{"line_number":325,"context_line":"            return False"},{"line_number":326,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_c46c519f","line":323,"range":{"start_line":323,"start_character":15,"end_line":323,"end_character":24},"updated":"2018-06-29 14:47:28.000000000","message":"This should\u0027ve been as AssertionError","commit_id":"972bb7e991486d7816de25921f50b9230c0c77c1"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d27dd1642227e2ffb63c4ef394befa265646ed44","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        try:"},{"line_number":321,"context_line":"            self.assertEmpty(md_dict[\u0027devices\u0027])"},{"line_number":322,"context_line":"            return True"},{"line_number":323,"context_line":"        except Exception:"},{"line_number":324,"context_line":"            LOG.debug(\"Devices dict is not empty: %s\", md_dict[\u0027devices\u0027])"},{"line_number":325,"context_line":"            return False"},{"line_number":326,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_122498b1","line":323,"range":{"start_line":323,"start_character":15,"end_line":323,"end_character":24},"in_reply_to":"5f7c97a3_c46c519f","updated":"2018-07-16 12:35:03.000000000","message":"yes, right. It might also be the reason why it\u0027s still returning False. Maybe there is some other issue happens instead of not empty devices list.\nThx for catching it.","commit_id":"972bb7e991486d7816de25921f50b9230c0c77c1"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"9963c1bf58f80423a4a57d95ede124b5d2920cf0","unresolved":false,"context_lines":[{"line_number":324,"context_line":"            LOG.debug(\"Devices dict is not empty: %s\", md_dict[\u0027devices\u0027])"},{"line_number":325,"context_line":"            return False"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    @decorators.idempotent_id(\u00273e41c782-2a89-4922-a9d2-9a188c4e7c7c\u0027)"},{"line_number":328,"context_line":"    @utils.services(\u0027network\u0027, \u0027volume\u0027, \u0027image\u0027)"},{"line_number":329,"context_line":"    def test_tagged_attachment(self):"},{"line_number":330,"context_line":"        # Create network"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_a091fcf9","line":327,"updated":"2018-06-29 17:50:42.000000000","message":"Maybe we can add @decorators.related_bug(1775947) to track this better?","commit_id":"972bb7e991486d7816de25921f50b9230c0c77c1"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"455e826e4d9aab794e30e6943feff6531877cae7","unresolved":false,"context_lines":[{"line_number":324,"context_line":"            LOG.debug(\"Devices dict is not empty: %s\", md_dict[\u0027devices\u0027])"},{"line_number":325,"context_line":"            return False"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    @decorators.idempotent_id(\u00273e41c782-2a89-4922-a9d2-9a188c4e7c7c\u0027)"},{"line_number":328,"context_line":"    @utils.services(\u0027network\u0027, \u0027volume\u0027, \u0027image\u0027)"},{"line_number":329,"context_line":"    def test_tagged_attachment(self):"},{"line_number":330,"context_line":"        # Create network"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_f4bff1fa","line":327,"updated":"2018-07-11 07:05:07.000000000","message":"yeah, it might be useful but I\u0027m not sure. Because the error message is a bit confusing: \"Hints: This test was made for the bug 1775947\".... So, I think adding a NOTE for that debug log is simple enough.","commit_id":"972bb7e991486d7816de25921f50b9230c0c77c1"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d27dd1642227e2ffb63c4ef394befa265646ed44","unresolved":false,"context_lines":[{"line_number":324,"context_line":"            LOG.debug(\"Devices dict is not empty: %s\", md_dict[\u0027devices\u0027])"},{"line_number":325,"context_line":"            return False"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    @decorators.idempotent_id(\u00273e41c782-2a89-4922-a9d2-9a188c4e7c7c\u0027)"},{"line_number":328,"context_line":"    @utils.services(\u0027network\u0027, \u0027volume\u0027, \u0027image\u0027)"},{"line_number":329,"context_line":"    def test_tagged_attachment(self):"},{"line_number":330,"context_line":"        # Create network"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_ef125361","line":327,"in_reply_to":"5f7c97a3_f4bff1fa","updated":"2018-07-16 12:35:03.000000000","message":"I added related bug info to debug log","commit_id":"972bb7e991486d7816de25921f50b9230c0c77c1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e7327addffc4d5757b95c5351e769b35e8bf06bb","unresolved":false,"context_lines":[{"line_number":321,"context_line":"            self.assertEmpty(md_dict[\u0027devices\u0027])"},{"line_number":322,"context_line":"            return True"},{"line_number":323,"context_line":"        except AssertionError:"},{"line_number":324,"context_line":"            LOG.debug(\"Related bug 1775947. Devices dict is not empty: %s\","},{"line_number":325,"context_line":"                      md_dict[\u0027devices\u0027])"},{"line_number":326,"context_line":"            return False"},{"line_number":327,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_b6c08bfb","line":324,"range":{"start_line":324,"start_character":16,"end_line":324,"end_character":21},"updated":"2018-07-23 20:11:30.000000000","message":"Make this at least INFO so it can be indexed by our logstash server.","commit_id":"eb70a96ee3f7e56dbf57aefa2a1aa768aeb559ab"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c8bf608d7d4a0776a308bfd1fdb80cbaf625c66e","unresolved":false,"context_lines":[{"line_number":321,"context_line":"            self.assertEmpty(md_dict[\u0027devices\u0027])"},{"line_number":322,"context_line":"            return True"},{"line_number":323,"context_line":"        except AssertionError:"},{"line_number":324,"context_line":"            LOG.debug(\"Related bug 1775947. Devices dict is not empty: %s\","},{"line_number":325,"context_line":"                      md_dict[\u0027devices\u0027])"},{"line_number":326,"context_line":"            return False"},{"line_number":327,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_a491159e","line":324,"range":{"start_line":324,"start_character":16,"end_line":324,"end_character":21},"in_reply_to":"5f7c97a3_b6c08bfb","updated":"2018-07-24 19:29:44.000000000","message":"Otherwise yeah seeing this here:\n\nhttp://logs.openstack.org/70/551370/30/gate/tempest-full/5b2e7d5/controller/logs/tempest_log.txt\n\n2018-07-24 17:58:39.474 24028 DEBUG tempest.api.compute.servers.test_device_tagging [-] Related bug 1775947. Devices dict is not empty: [{u\u0027serial\u0027: u\u002705a39dab-85e1-4490-8464-0f87b858d449\u0027, u\u0027tags\u0027: [u\u0027volume-tag\u0027], u\u0027address\u0027: u\u00270000:00:07.0\u0027, u\u0027bus\u0027: u\u0027pci\u0027, u\u0027type\u0027: u\u0027disk\u0027}] verify_empty_devices tempest/api/compute/servers/test_device_tagging.py:325","commit_id":"eb70a96ee3f7e56dbf57aefa2a1aa768aeb559ab"}]}