)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2a4518a9ba426a80293f9e7f4309d5acd6b48e71","unresolved":false,"context_lines":[{"line_number":9,"context_line":"assertEmpty and assertNotEmpty methods are used to"},{"line_number":10,"context_line":"raise assertion when data exist and data not exist."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"assertTrue function used under them is working"},{"line_number":13,"context_line":"on boolean type value."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"To check data exist or not, we are sending data"},{"line_number":16,"context_line":"which is not always of boolean type."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_e12ebbf7","line":13,"range":{"start_line":12,"start_character":39,"end_line":13,"end_character":22},"updated":"2018-07-05 08:51:59.000000000","message":"Thats not correct, actually it work on expression and check if expression is true or false.\n\nIt check \u0027if not expr\u0027 not \u0027if expr is True\u0027\n\nsame is explained in link you mentioned below.","commit_id":"66a324aee3e5679c760e4016b595feb2bdbba2ed"}],"tempest/test.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"378f8f969d1d632349f5d5cd943fbfa3d03592f0","unresolved":false,"context_lines":[{"line_number":860,"context_line":"        \"\"\""},{"line_number":861,"context_line":"        if msg is None:"},{"line_number":862,"context_line":"            msg \u003d \"sequence or collection is not empty: %s\" % items"},{"line_number":863,"context_line":"        self.assertFalse(bool(items), msg)"},{"line_number":864,"context_line":""},{"line_number":865,"context_line":"    def assertNotEmpty(self, items, msg\u003dNone):"},{"line_number":866,"context_line":"        \"\"\"Asserts whether a sequence or collection is not empty"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_e1555b53","line":863,"updated":"2018-07-05 08:58:04.000000000","message":"According to the document note[0], this change is like this? If so, I don\u0027t understand this change. And could you add unit tests? I think it should make it clearer if the current code is wrong. \n\n bool(bool(items)) is True\n\n????\n\n[0] Note that this is equivalent to bool(expr) is True and not to expr is True (use assertIs(expr, True) for the latter).","commit_id":"66a324aee3e5679c760e4016b595feb2bdbba2ed"}]}
