)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"541acd503219a5cf89f84c78a882fa0c3cd97119","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Skip agent tests if not available."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"SDN plugins like Tungsten Fabric (OpenContrail) do not have any agents."},{"line_number":10,"context_line":"This fix checks if any agents available before running tests"},{"line_number":11,"context_line":"on agenets."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_c674ac9e","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":71},"updated":"2018-07-10 00:48:08.000000000","message":"If the Tungsten plugin does not support agents, should neutron not list the extension as enabled?","commit_id":"0f64f26ad58530b0c3c87c41a30a61fad5de5749"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"dbd9d0b89e78571ee53ee4bb3cef68b6c2f11221","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Skip agent tests if not available."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"SDN plugins like Tungsten Fabric (OpenContrail) do not have any agents."},{"line_number":10,"context_line":"This fix checks if any agents available before running tests"},{"line_number":11,"context_line":"on agenets."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_cd702445","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":71},"in_reply_to":"5f7c97a3_38deaf3c","updated":"2018-07-23 09:10:15.000000000","message":"In this situation, can we remove agent extension from network-feature-enabled.api_extensions in tempest.conf?\nBecause we have no way to decide is it a bug if agent extension is enabled but no agents are returned by list_agents.","commit_id":"0f64f26ad58530b0c3c87c41a30a61fad5de5749"},{"author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"change_message_id":"4728761202a8457c991b183bd14c6b4789ca8a72","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Skip agent tests if not available."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"SDN plugins like Tungsten Fabric (OpenContrail) do not have any agents."},{"line_number":10,"context_line":"This fix checks if any agents available before running tests"},{"line_number":11,"context_line":"on agenets."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_38deaf3c","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":71},"in_reply_to":"5f7c97a3_c674ac9e","updated":"2018-07-11 16:02:54.000000000","message":"As it appears from the code, Tungsten fabric supports agent extension but it does not have any agents.\n\nhttps://github.com/Juniper/contrail-neutron-plugin/blob/R3.2/neutron_plugin_contrail/plugins/opencontrail/contrail_plugin_base.py#L187\n\nAlso, let\u0027s generalize the solution instead of targeting just Tungsten Fabric alone.","commit_id":"0f64f26ad58530b0c3c87c41a30a61fad5de5749"}],"tempest/api/network/admin/test_agent_management.py":[{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"541acd503219a5cf89f84c78a882fa0c3cd97119","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def resource_setup(cls):"},{"line_number":32,"context_line":"        super(AgentManagementTestJSON, cls).resource_setup()"},{"line_number":33,"context_line":"        body \u003d cls.admin_agents_client.list_agents()"},{"line_number":34,"context_line":"        if not body[\u0027agents\u0027]:"},{"line_number":35,"context_line":"            msg \u003d \"No agents available.\""},{"line_number":36,"context_line":"            raise cls.skipException(msg)"},{"line_number":37,"context_line":"        agents \u003d body[\u0027agents\u0027]"},{"line_number":38,"context_line":"        cls.agent \u003d agents[0]"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_0645c443","line":36,"range":{"start_line":34,"start_character":8,"end_line":36,"end_character":40},"updated":"2018-07-10 00:48:08.000000000","message":"why is line 26 above not able handle the skip check for neutron?","commit_id":"0f64f26ad58530b0c3c87c41a30a61fad5de5749"},{"author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"change_message_id":"591151ec9db93fcd21790b10799661dba4a584e3","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def resource_setup(cls):"},{"line_number":32,"context_line":"        super(AgentManagementTestJSON, cls).resource_setup()"},{"line_number":33,"context_line":"        body \u003d cls.admin_agents_client.list_agents()"},{"line_number":34,"context_line":"        if not body[\u0027agents\u0027]:"},{"line_number":35,"context_line":"            msg \u003d \"No agents available.\""},{"line_number":36,"context_line":"            raise cls.skipException(msg)"},{"line_number":37,"context_line":"        agents \u003d body[\u0027agents\u0027]"},{"line_number":38,"context_line":"        cls.agent \u003d agents[0]"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_583b6b9a","line":36,"range":{"start_line":34,"start_character":8,"end_line":36,"end_character":40},"in_reply_to":"5f7c97a3_0645c443","updated":"2018-07-11 16:00:33.000000000","message":"They are two different checks.\nLine 26 checks if an extension by name \"agent\" is supported.\nLine 34 checks if there are any agents exist.","commit_id":"0f64f26ad58530b0c3c87c41a30a61fad5de5749"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8b7d6bd8258520e5def3416b0f9d30fbfd86d551","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            agent.pop(\u0027configurations\u0027, None)"},{"line_number":50,"context_line":"        self.assertIn(self.agent, agents)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @decorators.idempotent_id(\u0027e335be47-b9a1-46fd-be30-0874c0b751e6\u0027)"},{"line_number":53,"context_line":"    def test_list_agents_non_admin(self):"},{"line_number":54,"context_line":"        body \u003d self.agents_client.list_agents()"},{"line_number":55,"context_line":"        self.assertEmpty(body[\"agents\"])"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @decorators.idempotent_id(\u0027869bc8e8-0fda-4a30-9b71-f8a7cf58ca9f\u0027)"},{"line_number":58,"context_line":"    def test_show_agent(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_9ca14998","line":55,"range":{"start_line":52,"start_character":0,"end_line":55,"end_character":40},"updated":"2018-07-06 23:16:42.000000000","message":"This test should still. be able to be executed. Also IMO it doesn\u0027t belong here because it\u0027s non-admin but this is the admin directory (this test class is in network/admin). \n\nIt\u0027s not in interop either: http://codesearch.openstack.org/?q\u003dtest_list_agents_non_admin\u0026i\u003dnope\u0026files\u003d\u0026repos\u003dinterop\n\nSo should be able to move this test into the non-admin directory in a similar test class.","commit_id":"0f64f26ad58530b0c3c87c41a30a61fad5de5749"},{"author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"change_message_id":"591151ec9db93fcd21790b10799661dba4a584e3","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            agent.pop(\u0027configurations\u0027, None)"},{"line_number":50,"context_line":"        self.assertIn(self.agent, agents)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @decorators.idempotent_id(\u0027e335be47-b9a1-46fd-be30-0874c0b751e6\u0027)"},{"line_number":53,"context_line":"    def test_list_agents_non_admin(self):"},{"line_number":54,"context_line":"        body \u003d self.agents_client.list_agents()"},{"line_number":55,"context_line":"        self.assertEmpty(body[\"agents\"])"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @decorators.idempotent_id(\u0027869bc8e8-0fda-4a30-9b71-f8a7cf58ca9f\u0027)"},{"line_number":58,"context_line":"    def test_show_agent(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_780e67e5","line":55,"range":{"start_line":52,"start_character":0,"end_line":55,"end_character":40},"in_reply_to":"5f7c97a3_2d25265b","updated":"2018-07-11 16:00:33.000000000","message":"Good suggestion and should be handled as part of a separate bug/patchset.","commit_id":"0f64f26ad58530b0c3c87c41a30a61fad5de5749"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"25f16cb4e85615a8b4a622cb799851acb1a61da2","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            agent.pop(\u0027configurations\u0027, None)"},{"line_number":50,"context_line":"        self.assertIn(self.agent, agents)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @decorators.idempotent_id(\u0027e335be47-b9a1-46fd-be30-0874c0b751e6\u0027)"},{"line_number":53,"context_line":"    def test_list_agents_non_admin(self):"},{"line_number":54,"context_line":"        body \u003d self.agents_client.list_agents()"},{"line_number":55,"context_line":"        self.assertEmpty(body[\"agents\"])"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @decorators.idempotent_id(\u0027869bc8e8-0fda-4a30-9b71-f8a7cf58ca9f\u0027)"},{"line_number":58,"context_line":"    def test_show_agent(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_2d25265b","line":55,"range":{"start_line":52,"start_character":0,"end_line":55,"end_character":40},"in_reply_to":"5f7c97a3_9ca14998","updated":"2018-07-10 20:12:08.000000000","message":"As an aside this can be done in a separate patchset as this is out of scope here.","commit_id":"0f64f26ad58530b0c3c87c41a30a61fad5de5749"}]}