)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8b7b77da79b2aa937fa48280452ca00426f62c3c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    * ``PUT /os-services/force-down`` (``update_forced_down``)"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Negative tests were added for all the APIs above. In addition,"},{"line_number":19,"context_line":"the negative tests handle both the microversion \u003c 2.52 and"},{"line_number":20,"context_line":"microversion \u003e\u003d 2.53 cases: in the first case the old APIs"},{"line_number":21,"context_line":"are called (with bad parameters) and in the second case the"},{"line_number":22,"context_line":"new udpate_service API is called (also with bad parameters)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5f7c97a3_1a0c3840","line":19,"range":{"start_line":19,"start_character":26,"end_line":19,"end_character":54},"updated":"2018-07-10 03:06:16.000000000","message":"This part isn\u0027t true anymore.... I kept getting issues with the nova-cells-v1 job. Basically with nova-cells-v1 I was passing in a hostname that with nova-cells-v1 has a regex of something like \"[A-Za-z]@[A-Za-z0-9]\" (simplified) which is rejected by the schema request check in Nova API for the \u003c 2.52 APIs because it assumes a different schema which only works for non-cells v1 hostname patterns, as far as I could tell. I wasn\u0027t sure if it was a bug or not...","commit_id":"ae8faa5591bd3647320c04f3ca1285513384d520"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"21f7a2c7ceb4c282d60be81bc9921ca7f99783b5","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    * ``PUT /os-services/force-down`` (``update_forced_down``)"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Negative tests were added for all the APIs above. In addition,"},{"line_number":19,"context_line":"the negative tests handle both the microversion \u003c 2.52 and"},{"line_number":20,"context_line":"microversion \u003e\u003d 2.53 cases: in the first case the old APIs"},{"line_number":21,"context_line":"are called (with bad parameters) and in the second case the"},{"line_number":22,"context_line":"new udpate_service API is called (also with bad parameters)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5f7c97a3_bcbaceb6","line":19,"range":{"start_line":19,"start_character":26,"end_line":19,"end_character":54},"in_reply_to":"5f7c97a3_1a0c3840","updated":"2018-07-10 17:56:34.000000000","message":"Done","commit_id":"ae8faa5591bd3647320c04f3ca1285513384d520"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c61503c62634065069a521fca50b91f36b86b2ef","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Finally, unit tests and releasenotes are included."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Partially implements: blueprint api-extensions-merge-rocky"},{"line_number":32,"context_line":"Change-Id: I5e7b81496cbb87cda81413124b5f82bd5356e666"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5f7c97a3_6eb00afe","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":58},"updated":"2018-07-10 07:01:35.000000000","message":"this BP link is not the right one to mention here.","commit_id":"ae8faa5591bd3647320c04f3ca1285513384d520"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"21f7a2c7ceb4c282d60be81bc9921ca7f99783b5","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Finally, unit tests and releasenotes are included."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Partially implements: blueprint api-extensions-merge-rocky"},{"line_number":32,"context_line":"Change-Id: I5e7b81496cbb87cda81413124b5f82bd5356e666"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5f7c97a3_5cdb7a1f","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":58},"in_reply_to":"5f7c97a3_6eb00afe","updated":"2018-07-10 17:56:34.000000000","message":"Done","commit_id":"ae8faa5591bd3647320c04f3ca1285513384d520"}],"tempest/api/compute/admin/test_services_negative.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"123e7af88ec47c1484a4b4a983c77ca2a0c161a8","unresolved":false,"context_lines":[{"line_number":21,"context_line":"class ServicesAdminNegativeV21TestJSON(base.BaseV2ComputeAdminTest):"},{"line_number":22,"context_line":"    \"\"\"Tests Services API. List and Enable/Disable require admin privileges.\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    max_microversion \u003d \u00272.52\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    @classmethod"},{"line_number":27,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_99fdd60a","line":24,"range":{"start_line":24,"start_character":4,"end_line":24,"end_character":29},"updated":"2018-07-08 00:38:40.000000000","message":"Can remove this","commit_id":"b7a6c6e260bdfc84fb9de75f8190f2cdeb0767e1"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"31f4759d984ef16f4588709115faf6250326cf1f","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"class ServicesAdminNegativeV211TestJSON(ServicesAdminNegativeV21TestJSON):"},{"line_number":118,"context_line":"    min_microversion \u003d \u00272.11\u0027"},{"line_number":119,"context_line":"    max_microversion \u003d \u0027latest\u0027"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    # NOTE(felipemonteiro): This class tests the services APIs response schema"},{"line_number":122,"context_line":"    # for the 2.53 microversion. forced_down is available for microversions"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_ac116e55","line":119,"range":{"start_line":119,"start_character":4,"end_line":119,"end_character":31},"updated":"2018-07-08 00:40:52.000000000","message":"Actually I think this one can be removed since it overwrites the one on L24. The class below handles the rest of the microversion testing.","commit_id":"b7a6c6e260bdfc84fb9de75f8190f2cdeb0767e1"}],"tempest/lib/api_schema/response/compute/v2_11/services.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c61503c62634065069a521fca50b91f36b86b2ef","unresolved":false,"context_lines":[{"line_number":50,"context_line":"# need to keep this schema in this file to have the generic way to select the"},{"line_number":51,"context_line":"# right schema based on self.schema_versions_info mapping in service client."},{"line_number":52,"context_line":"enable_disable_service \u003d copy.deepcopy(services.enable_disable_service)"},{"line_number":53,"context_line":"disable_log_reason \u003d copy.deepcopy(services.disable_log_reason)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_eee09a29","line":53,"range":{"start_line":53,"start_character":62,"end_line":53,"end_character":63},"updated":"2018-07-10 07:01:35.000000000","message":"thanks for fixing this.","commit_id":"ae8faa5591bd3647320c04f3ca1285513384d520"}],"tempest/lib/api_schema/response/compute/v2_53/services.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c61503c62634065069a521fca50b91f36b86b2ef","unresolved":false,"context_lines":[{"line_number":30,"context_line":"list_services \u003d copy.deepcopy(servicesv211.list_services)"},{"line_number":31,"context_line":"# The ID of the service is a uuid, so v2.1 pattern does not apply."},{"line_number":32,"context_line":"list_services[\u0027response_body\u0027][\u0027properties\u0027][\u0027services\u0027][\u0027items\u0027]["},{"line_number":33,"context_line":"    \u0027properties\u0027][\u0027id\u0027] \u003d {\u0027type\u0027: \u0027string\u0027}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"update_service \u003d {"},{"line_number":36,"context_line":"    \u0027status_code\u0027: [200],"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_aed14231","line":33,"range":{"start_line":33,"start_character":26,"end_line":33,"end_character":44},"updated":"2018-07-10 07:01:35.000000000","message":"this will be strict uuid from 2.53 so let\u0027s use \u0027format\u0027: \u0027uuid\u0027 also with string type.","commit_id":"ae8faa5591bd3647320c04f3ca1285513384d520"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"21f7a2c7ceb4c282d60be81bc9921ca7f99783b5","unresolved":false,"context_lines":[{"line_number":30,"context_line":"list_services \u003d copy.deepcopy(servicesv211.list_services)"},{"line_number":31,"context_line":"# The ID of the service is a uuid, so v2.1 pattern does not apply."},{"line_number":32,"context_line":"list_services[\u0027response_body\u0027][\u0027properties\u0027][\u0027services\u0027][\u0027items\u0027]["},{"line_number":33,"context_line":"    \u0027properties\u0027][\u0027id\u0027] \u003d {\u0027type\u0027: \u0027string\u0027}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"update_service \u003d {"},{"line_number":36,"context_line":"    \u0027status_code\u0027: [200],"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_fcf2869a","line":33,"range":{"start_line":33,"start_character":26,"end_line":33,"end_character":44},"in_reply_to":"5f7c97a3_aed14231","updated":"2018-07-10 17:56:34.000000000","message":"Done","commit_id":"ae8faa5591bd3647320c04f3ca1285513384d520"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c61503c62634065069a521fca50b91f36b86b2ef","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            \u0027service\u0027: {"},{"line_number":41,"context_line":"                \u0027type\u0027: \u0027object\u0027,"},{"line_number":42,"context_line":"                \u0027properties\u0027: {"},{"line_number":43,"context_line":"                    \u0027id\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":44,"context_line":"                    \u0027binary\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":45,"context_line":"                    \u0027disabled_reason\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":46,"context_line":"                    \u0027host\u0027: {\u0027type\u0027: \u0027string\u0027},"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_ced4be21","line":43,"range":{"start_line":43,"start_character":26,"end_line":43,"end_character":44},"updated":"2018-07-10 07:01:35.000000000","message":"ditto","commit_id":"ae8faa5591bd3647320c04f3ca1285513384d520"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"21f7a2c7ceb4c282d60be81bc9921ca7f99783b5","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            \u0027service\u0027: {"},{"line_number":41,"context_line":"                \u0027type\u0027: \u0027object\u0027,"},{"line_number":42,"context_line":"                \u0027properties\u0027: {"},{"line_number":43,"context_line":"                    \u0027id\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":44,"context_line":"                    \u0027binary\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":45,"context_line":"                    \u0027disabled_reason\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":46,"context_line":"                    \u0027host\u0027: {\u0027type\u0027: \u0027string\u0027},"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_bce88ea6","line":43,"range":{"start_line":43,"start_character":26,"end_line":43,"end_character":44},"in_reply_to":"5f7c97a3_ced4be21","updated":"2018-07-10 17:56:34.000000000","message":"Done","commit_id":"ae8faa5591bd3647320c04f3ca1285513384d520"}]}
