)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8d8ed66fc7138fb79e3cae6be0d538631bc30a7b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The test_create_server_with_scheduler_hint_group_anti_affinity used a"},{"line_number":10,"context_line":"single server create REST request to boot two servers with"},{"line_number":11,"context_line":"anti-affinity. I suspect that when two two server booted in two separate"},{"line_number":12,"context_line":"requests then nova fails apply anti affinty. So this patch changes the"},{"line_number":13,"context_line":"test to use separate server create requests."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"TODO:"},{"line_number":16,"context_line":"* Create two separate test cases one for the single request and one for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_0bd4dab9","line":13,"range":{"start_line":12,"start_character":45,"end_line":13,"end_character":44},"updated":"2018-07-10 15:49:00.000000000","message":"This is racy *unless* we wait to issue the 2nd request until the server from the first request is ACTIVE (so that the instance.host field is set and can be reported into the scheduler during the 2nd request). You should mention why this isn\u0027t racy in the commit message (if the test has that condition).","commit_id":"63d7771b08f3f91bae8eb9bcea8a873593d5b669"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e47f306c75471e61bafdb4c28490d05fcecdba45","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The test_create_server_with_scheduler_hint_group_anti_affinity used a"},{"line_number":10,"context_line":"single server create REST request to boot two servers with"},{"line_number":11,"context_line":"anti-affinity. I suspect that when two two server booted in two separate"},{"line_number":12,"context_line":"requests then nova fails apply anti affinty. So this patch changes the"},{"line_number":13,"context_line":"test to use separate server create requests."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"TODO:"},{"line_number":16,"context_line":"* Create two separate test cases one for the single request and one for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_03390d3f","line":13,"range":{"start_line":12,"start_character":45,"end_line":13,"end_character":44},"in_reply_to":"5f7c97a3_0bd4dab9","updated":"2018-07-11 11:31:07.000000000","message":"Done","commit_id":"63d7771b08f3f91bae8eb9bcea8a873593d5b669"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e47f306c75471e61bafdb4c28490d05fcecdba45","unresolved":false,"context_lines":[{"line_number":12,"context_line":"requests then nova fails apply anti affinty. So this patch changes the"},{"line_number":13,"context_line":"test to use separate server create requests."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"TODO:"},{"line_number":16,"context_line":"* Create two separate test cases one for the single request and one for"},{"line_number":17,"context_line":"  the multiple requests case"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I120db36fa6e94cf02e46a770e5cae5e0444e89f3"},{"line_number":20,"context_line":"Related-Bug: #1770434"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_e33f3120","line":17,"range":{"start_line":15,"start_character":1,"end_line":17,"end_character":7},"updated":"2018-07-11 11:31:07.000000000","message":"Done","commit_id":"63d7771b08f3f91bae8eb9bcea8a873593d5b669"}],"tempest/api/compute/admin/test_servers_on_multinodes.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8d8ed66fc7138fb79e3cae6be0d538631bc30a7b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    def _create_servers_with_group(self, policy):"},{"line_number":47,"context_line":"        group_id \u003d self.create_test_server_group(policy\u003d[policy])[\u0027id\u0027]"},{"line_number":48,"context_line":"        hints \u003d {\u0027group\u0027: group_id}"},{"line_number":49,"context_line":"        reservation_id \u003d self.create_test_server("},{"line_number":50,"context_line":"            scheduler_hints\u003dhints, wait_until\u003d\u0027ACTIVE\u0027, min_count\u003d2,"},{"line_number":51,"context_line":"            return_reservation_id\u003dTrue)[\u0027reservation_id\u0027]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        # Get the servers using the reservation_id."},{"line_number":54,"context_line":"        servers \u003d self.servers_client.list_servers("}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_2be436a7","side":"PARENT","line":51,"range":{"start_line":49,"start_character":8,"end_line":51,"end_character":57},"updated":"2018-07-10 15:49:00.000000000","message":"We still want this multi-create / single-request scenario, so your TODO in the commit message is valid.","commit_id":"7627aee7fa5698cefde7127b8d34a1c19787d302"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e47f306c75471e61bafdb4c28490d05fcecdba45","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    def _create_servers_with_group(self, policy):"},{"line_number":47,"context_line":"        group_id \u003d self.create_test_server_group(policy\u003d[policy])[\u0027id\u0027]"},{"line_number":48,"context_line":"        hints \u003d {\u0027group\u0027: group_id}"},{"line_number":49,"context_line":"        reservation_id \u003d self.create_test_server("},{"line_number":50,"context_line":"            scheduler_hints\u003dhints, wait_until\u003d\u0027ACTIVE\u0027, min_count\u003d2,"},{"line_number":51,"context_line":"            return_reservation_id\u003dTrue)[\u0027reservation_id\u0027]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        # Get the servers using the reservation_id."},{"line_number":54,"context_line":"        servers \u003d self.servers_client.list_servers("}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_a31379b7","side":"PARENT","line":51,"range":{"start_line":49,"start_character":8,"end_line":51,"end_character":57},"in_reply_to":"5f7c97a3_2be436a7","updated":"2018-07-11 11:31:07.000000000","message":"Added the single request cases back as well","commit_id":"7627aee7fa5698cefde7127b8d34a1c19787d302"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d3fe44c7f4b7b7bdfa1a27833959bfd51dab9eff","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        self.assertNotEqual(hostnames[0], hostnames[1],"},{"line_number":112,"context_line":"                            \u0027Servers are on the same host: %s\u0027 % hosts)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        # create a third server and expect that it fails as we only have two"},{"line_number":115,"context_line":"        # compute hosts"},{"line_number":116,"context_line":"        self.create_test_server(scheduler_hints\u003d{\u0027group\u0027: group_id},"},{"line_number":117,"context_line":"                                wait_until\u003d\u0027ERROR\u0027)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    @decorators.idempotent_id(\u00279d2e924a-baf4-11e7-b856-fa163e65f5ce\u0027)"},{"line_number":120,"context_line":"    @testtools.skipUnless("}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_4d08947f","line":117,"range":{"start_line":114,"start_character":0,"end_line":117,"end_character":51},"updated":"2018-07-11 10:01:59.000000000","message":"this we can guarantee in case of multinode \u003e 2. \n\nWe need to check  CONF.compute.min_compute_nodes \u003d\u003d 2 (which is gate setup). you can add this extra condition in new tests.","commit_id":"63d7771b08f3f91bae8eb9bcea8a873593d5b669"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e47f306c75471e61bafdb4c28490d05fcecdba45","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        self.assertNotEqual(hostnames[0], hostnames[1],"},{"line_number":112,"context_line":"                            \u0027Servers are on the same host: %s\u0027 % hosts)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        # create a third server and expect that it fails as we only have two"},{"line_number":115,"context_line":"        # compute hosts"},{"line_number":116,"context_line":"        self.create_test_server(scheduler_hints\u003d{\u0027group\u0027: group_id},"},{"line_number":117,"context_line":"                                wait_until\u003d\u0027ERROR\u0027)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    @decorators.idempotent_id(\u00279d2e924a-baf4-11e7-b856-fa163e65f5ce\u0027)"},{"line_number":120,"context_line":"    @testtools.skipUnless("}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_638241ca","line":117,"range":{"start_line":114,"start_character":0,"end_line":117,"end_character":51},"in_reply_to":"5f7c97a3_4d08947f","updated":"2018-07-11 11:31:07.000000000","message":"Done","commit_id":"63d7771b08f3f91bae8eb9bcea8a873593d5b669"}]}