)]}'
{"tempest/api/identity/admin/v3/test_credentials.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"851991592eab518833a0137fdf75841bcbd688a5","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        cls.projects \u003d list()"},{"line_number":32,"context_line":"        cls.creds_list \u003d [[\u0027project_id\u0027, \u0027user_id\u0027, \u0027id\u0027],"},{"line_number":33,"context_line":"                          [\u0027access\u0027, \u0027secret\u0027]]"},{"line_number":34,"context_line":"        p1 \u003d cls.projects_client.show_project("},{"line_number":35,"context_line":"            cls.os_primary.credentials.project_id)[\u0027project\u0027]"},{"line_number":36,"context_line":"        cls.projects.append(p1[\u0027id\u0027])"},{"line_number":37,"context_line":"        p2 \u003d cls.projects_client.show_project("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_e2087828","line":34,"updated":"2018-07-12 02:46:31.000000000","message":"These tests are definitely in interop: http://codesearch.openstack.org/?q\u003dtest_credentials\u0026i\u003dnope\u0026files\u003d\u0026repos\u003dinterop\n\nBut I don\u0027t see anything disruptive about this change. The project and user creation from before did nothing special. This basically simplifies the previous logic while making it compatible with pre-provisioned credentials so LGTM.","commit_id":"c4669e0317803d4721623d70ff8fcb14663633f8"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"bba9c48918281d36065ea2b18b8923981336674b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        cls.projects \u003d list()"},{"line_number":32,"context_line":"        cls.creds_list \u003d [[\u0027project_id\u0027, \u0027user_id\u0027, \u0027id\u0027],"},{"line_number":33,"context_line":"                          [\u0027access\u0027, \u0027secret\u0027]]"},{"line_number":34,"context_line":"        p1 \u003d cls.projects_client.show_project("},{"line_number":35,"context_line":"            cls.os_primary.credentials.project_id)[\u0027project\u0027]"},{"line_number":36,"context_line":"        cls.projects.append(p1[\u0027id\u0027])"},{"line_number":37,"context_line":"        p2 \u003d cls.projects_client.show_project("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_e530c058","line":34,"in_reply_to":"3f79a3b5_85a9cc90","updated":"2018-08-15 19:31:13.000000000","message":"@Gmann, that has been done already, check the latest patchset, https://review.openstack.org/#/c/581891/3/tempest/api/identity/admin/v3/test_credentials.py@34","commit_id":"c4669e0317803d4721623d70ff8fcb14663633f8"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"b92d818449f63121f19c126bc67eef06cf62a47e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        cls.projects \u003d list()"},{"line_number":32,"context_line":"        cls.creds_list \u003d [[\u0027project_id\u0027, \u0027user_id\u0027, \u0027id\u0027],"},{"line_number":33,"context_line":"                          [\u0027access\u0027, \u0027secret\u0027]]"},{"line_number":34,"context_line":"        p1 \u003d cls.projects_client.show_project("},{"line_number":35,"context_line":"            cls.os_primary.credentials.project_id)[\u0027project\u0027]"},{"line_number":36,"context_line":"        cls.projects.append(p1[\u0027id\u0027])"},{"line_number":37,"context_line":"        p2 \u003d cls.projects_client.show_project("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_d2ad8ee7","line":34,"in_reply_to":"5f7c97a3_51bf57c9","updated":"2018-07-18 02:26:04.000000000","message":"I am wondering: is dynamic project creation always compatible with pre-provisioned credentials?","commit_id":"c4669e0317803d4721623d70ff8fcb14663633f8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ba350a736856c780ef42cac9ba249edc0e09d2ac","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        cls.projects \u003d list()"},{"line_number":32,"context_line":"        cls.creds_list \u003d [[\u0027project_id\u0027, \u0027user_id\u0027, \u0027id\u0027],"},{"line_number":33,"context_line":"                          [\u0027access\u0027, \u0027secret\u0027]]"},{"line_number":34,"context_line":"        p1 \u003d cls.projects_client.show_project("},{"line_number":35,"context_line":"            cls.os_primary.credentials.project_id)[\u0027project\u0027]"},{"line_number":36,"context_line":"        cls.projects.append(p1[\u0027id\u0027])"},{"line_number":37,"context_line":"        p2 \u003d cls.projects_client.show_project("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_de1f79b7","line":34,"in_reply_to":"5f7c97a3_61b92614","updated":"2018-08-02 15:27:12.000000000","message":"How cloud provider disable the project creation? via policy or there are some way in keystone to do that. \n\nI think we need to make these dynamic creation of resources for pre-provisioned cred according to what keystone provide in term of disable and enable those crud opertion.","commit_id":"c4669e0317803d4721623d70ff8fcb14663633f8"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"1f45a450936659dff9f45e2e9a0503f6b81e2248","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        cls.projects \u003d list()"},{"line_number":32,"context_line":"        cls.creds_list \u003d [[\u0027project_id\u0027, \u0027user_id\u0027, \u0027id\u0027],"},{"line_number":33,"context_line":"                          [\u0027access\u0027, \u0027secret\u0027]]"},{"line_number":34,"context_line":"        p1 \u003d cls.projects_client.show_project("},{"line_number":35,"context_line":"            cls.os_primary.credentials.project_id)[\u0027project\u0027]"},{"line_number":36,"context_line":"        cls.projects.append(p1[\u0027id\u0027])"},{"line_number":37,"context_line":"        p2 \u003d cls.projects_client.show_project("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_e0d21dfe","line":34,"in_reply_to":"5f7c97a3_d2ad8ee7","updated":"2018-07-18 18:45:37.000000000","message":"@Gmann, Done\n@Felipe, I would say if the pre-provisioned credential provider requires projects, then it\u0027s not compatible. From an LDAP stand point it is compatible. To make the test execution more flexible, can we support a dynamic project pre-provisioned credential provider such that only a list of users and passwords are needed and the projects are created dynamically?","commit_id":"c4669e0317803d4721623d70ff8fcb14663633f8"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"638055177db0ac19009884bc6a58e642e0772810","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        cls.projects \u003d list()"},{"line_number":32,"context_line":"        cls.creds_list \u003d [[\u0027project_id\u0027, \u0027user_id\u0027, \u0027id\u0027],"},{"line_number":33,"context_line":"                          [\u0027access\u0027, \u0027secret\u0027]]"},{"line_number":34,"context_line":"        p1 \u003d cls.projects_client.show_project("},{"line_number":35,"context_line":"            cls.os_primary.credentials.project_id)[\u0027project\u0027]"},{"line_number":36,"context_line":"        cls.projects.append(p1[\u0027id\u0027])"},{"line_number":37,"context_line":"        p2 \u003d cls.projects_client.show_project("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_85a9cc90","line":34,"in_reply_to":"5f7c97a3_de1f79b7","updated":"2018-08-15 16:28:17.000000000","message":"ok I will work on making the projects dynamic here.","commit_id":"c4669e0317803d4721623d70ff8fcb14663633f8"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"fbc2e24e7e39746d8af80c5a93d1e6f33dfd8cf5","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        cls.projects \u003d list()"},{"line_number":32,"context_line":"        cls.creds_list \u003d [[\u0027project_id\u0027, \u0027user_id\u0027, \u0027id\u0027],"},{"line_number":33,"context_line":"                          [\u0027access\u0027, \u0027secret\u0027]]"},{"line_number":34,"context_line":"        p1 \u003d cls.projects_client.show_project("},{"line_number":35,"context_line":"            cls.os_primary.credentials.project_id)[\u0027project\u0027]"},{"line_number":36,"context_line":"        cls.projects.append(p1[\u0027id\u0027])"},{"line_number":37,"context_line":"        p2 \u003d cls.projects_client.show_project("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_61b92614","line":34,"in_reply_to":"5f7c97a3_e0d21dfe","updated":"2018-07-19 05:26:42.000000000","message":"Well accounts.yaml does support tenant_name: https://github.com/openstack/tempest/blob/b286ad402e6bd60f33dfd8251d6cf1ed1ceae69d/etc/accounts.yaml.sample#L27\n\nSo I\u0027m assuming that pre-provisioned credentials won\u0027t always work with dynamic project creation, as in here. But that assumes that the cloud has project creation disabled, and I\u0027m not sure under what circumstances that is possible (if at all).\n\nI think it would be useful if Tempest has documentation that listed which types of resources can break on clouds that require pre-provisioned credentials.","commit_id":"c4669e0317803d4721623d70ff8fcb14663633f8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5943dae74e1cb73e17815ba2037945d14f0ddb44","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        cls.projects \u003d list()"},{"line_number":32,"context_line":"        cls.creds_list \u003d [[\u0027project_id\u0027, \u0027user_id\u0027, \u0027id\u0027],"},{"line_number":33,"context_line":"                          [\u0027access\u0027, \u0027secret\u0027]]"},{"line_number":34,"context_line":"        p1 \u003d cls.projects_client.show_project("},{"line_number":35,"context_line":"            cls.os_primary.credentials.project_id)[\u0027project\u0027]"},{"line_number":36,"context_line":"        cls.projects.append(p1[\u0027id\u0027])"},{"line_number":37,"context_line":"        p2 \u003d cls.projects_client.show_project("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_51bf57c9","line":34,"in_reply_to":"5f7c97a3_e2087828","updated":"2018-07-17 07:44:23.000000000","message":"I was thinking about disruptive effect of using test account projects. And i think we should avoid using tests account projects here as creating cred under those can effect other tests listing or asserting on number of cred etc.\n\nOriginal code of creating the separate project and using them for credential crud looks good to me. It will not be too costly to do so. \n\nLet\u0027s keep the separate project creation in these tests.","commit_id":"c4669e0317803d4721623d70ff8fcb14663633f8"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"8df3cdc840b2fd6da3078441566364d4ba32a623","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        blob \u003d \u0027{\"access\": \"%s\", \"secret\": \"%s\"}\u0027 % ("},{"line_number":51,"context_line":"            data_utils.rand_name(\u0027Access\u0027), data_utils.rand_name(\u0027Secret\u0027))"},{"line_number":52,"context_line":"        cred \u003d self.creds_client.create_credential("},{"line_number":53,"context_line":"            user_id\u003dself.user_body[\u0027id\u0027], project_id\u003dself.projects[0],"},{"line_number":54,"context_line":"            blob\u003dblob, type\u003d\u0027ec2\u0027)[\u0027credential\u0027]"},{"line_number":55,"context_line":"        self.addCleanup(self._delete_credential, cred[\u0027id\u0027])"},{"line_number":56,"context_line":"        for value1 in self.creds_list[0]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_285941fd","line":53,"range":{"start_line":53,"start_character":12,"end_line":53,"end_character":69},"updated":"2018-08-21 07:28:46.000000000","message":"Here user_id\u0027s project id is not self.projects[0], so I try a fake project id, and it also works.\n\"user_id\u003dself.user_body[\u0027id\u0027], project_id\u003d\u0027fake_project_id\u0027\", so wonder why we need to create projects in this test file?","commit_id":"5f65e2ecc6b118f237152656ff2419e212a41f82"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"fbd10660ef13dd30a264a4dd919ce188cb38c970","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        blob \u003d \u0027{\"access\": \"%s\", \"secret\": \"%s\"}\u0027 % ("},{"line_number":51,"context_line":"            data_utils.rand_name(\u0027Access\u0027), data_utils.rand_name(\u0027Secret\u0027))"},{"line_number":52,"context_line":"        cred \u003d self.creds_client.create_credential("},{"line_number":53,"context_line":"            user_id\u003dself.user_body[\u0027id\u0027], project_id\u003dself.projects[0],"},{"line_number":54,"context_line":"            blob\u003dblob, type\u003d\u0027ec2\u0027)[\u0027credential\u0027]"},{"line_number":55,"context_line":"        self.addCleanup(self._delete_credential, cred[\u0027id\u0027])"},{"line_number":56,"context_line":"        for value1 in self.creds_list[0]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_2422c502","line":53,"range":{"start_line":53,"start_character":12,"end_line":53,"end_character":69},"in_reply_to":"3f79a3b5_285941fd","updated":"2018-08-21 13:22:01.000000000","message":"i\u0027m not sure if one is better than the other with respect to pre-provisioned credentials. I\u0027m happy to make the change if it\u0027s needed to support per-provisioned credentials in your case but I haven\u0027t found the need to.","commit_id":"5f65e2ecc6b118f237152656ff2419e212a41f82"}]}