)]}'
{"tempest/api/volume/test_volumes_get.py":[{"author":{"_account_id":7148,"name":"Zhu Zhu","email":"bjzzu.zz@gmail.com","username":"zhuzhubj"},"change_message_id":"5a5fb4494bdbbd5e6dbbf8d2da842020302f9a51","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        # json returns None, while xml returns \u0027None\u0027"},{"line_number":54,"context_line":"        self.assertEqual(str(volume[\u0027display_name\u0027]), \u0027None\u0027,"},{"line_number":55,"context_line":"                         \"The created volume name is not equal \""},{"line_number":56,"context_line":"                         \"to the requested name\")"},{"line_number":57,"context_line":"        self.assertTrue(volume[\u0027id\u0027] is not None,"},{"line_number":58,"context_line":"                        \"Field volume id is empty or not found.\")"},{"line_number":59,"context_line":"        self.client.wait_for_volume_status(volume[\u0027id\u0027], \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BhWQ%3D","line":56,"updated":"2013-11-25 07:11:33.000000000","message":"since actually does not set the display_name when request. Do u think it possible to remove this message here?","commit_id":"9fcbddd1453ffe1378045311d3986143e3aa3e8c"},{"author":{"_account_id":7148,"name":"Zhu Zhu","email":"bjzzu.zz@gmail.com","username":"zhuzhubj"},"change_message_id":"5a5fb4494bdbbd5e6dbbf8d2da842020302f9a51","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        self.assertEqual(str(volume[\u0027display_name\u0027]), \u0027None\u0027,"},{"line_number":55,"context_line":"                         \"The created volume name is not equal \""},{"line_number":56,"context_line":"                         \"to the requested name\")"},{"line_number":57,"context_line":"        self.assertTrue(volume[\u0027id\u0027] is not None,"},{"line_number":58,"context_line":"                        \"Field volume id is empty or not found.\")"},{"line_number":59,"context_line":"        self.client.wait_for_volume_status(volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BhWc%3D","line":57,"updated":"2013-11-25 07:11:33.000000000","message":"Please consider using assertIsNotNone","commit_id":"9fcbddd1453ffe1378045311d3986143e3aa3e8c"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"e3b0ff34af0a720cf8d3ca7ac352540c7938fe98","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        else:"},{"line_number":44,"context_line":"            return False"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _volume_create_without_display_name(self, **kwargs):"},{"line_number":47,"context_line":"        # Create a volume"},{"line_number":48,"context_line":"        resp, volume \u003d self.client.create_volume(size\u003d1, **kwargs)"},{"line_number":49,"context_line":"        self.assertEqual(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BgAw%3D","line":46,"updated":"2013-11-25 13:02:26.000000000","message":"I guess this function would not be reused in other tests. I suggest moving the code into test method.","commit_id":"c5a14a6e7e4f250c7fd1f8a213183536aba592e4"},{"author":{"_account_id":7148,"name":"Zhu Zhu","email":"bjzzu.zz@gmail.com","username":"zhuzhubj"},"change_message_id":"7018ae0f1648128a002172a89f58c731feb9bd82","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        else:"},{"line_number":44,"context_line":"            return False"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _volume_create_without_display_name(self, **kwargs):"},{"line_number":47,"context_line":"        # Create a volume"},{"line_number":48,"context_line":"        resp, volume \u003d self.client.create_volume(size\u003d1, **kwargs)"},{"line_number":49,"context_line":"        self.assertEqual(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BhQ0%3D","line":46,"updated":"2013-11-25 07:45:41.000000000","message":"why still need **kwargs argument? As this method indicated without display name, suggest remove this argument.","commit_id":"c5a14a6e7e4f250c7fd1f8a213183536aba592e4"},{"author":{"_account_id":9483,"name":"LiShaokai","email":"lshaokai@cn.ibm.com","username":"lshaokai"},"change_message_id":"9f4df04d4dd5785975305be270d229af94430f76","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        else:"},{"line_number":44,"context_line":"            return False"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _volume_create_without_display_name(self, **kwargs):"},{"line_number":47,"context_line":"        # Create a volume"},{"line_number":48,"context_line":"        resp, volume \u003d self.client.create_volume(size\u003d1, **kwargs)"},{"line_number":49,"context_line":"        self.assertEqual(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BcH8%3D","line":46,"in_reply_to":"AAAATn%2F%2BgAw%3D","updated":"2013-11-26 02:27:27.000000000","message":"I will rename this function and remove the below function","commit_id":"c5a14a6e7e4f250c7fd1f8a213183536aba592e4"},{"author":{"_account_id":9483,"name":"LiShaokai","email":"lshaokai@cn.ibm.com","username":"lshaokai"},"change_message_id":"378f342b3a60defd38dc2ab1673cf062b102cd2a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        else:"},{"line_number":44,"context_line":"            return False"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _volume_create_without_display_name(self, **kwargs):"},{"line_number":47,"context_line":"        # Create a volume"},{"line_number":48,"context_line":"        resp, volume \u003d self.client.create_volume(size\u003d1, **kwargs)"},{"line_number":49,"context_line":"        self.assertEqual(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BhNc%3D","line":46,"in_reply_to":"AAAATn%2F%2BhQ0%3D","updated":"2013-11-25 08:14:31.000000000","message":"This parameter just make this like other function\u0027s style","commit_id":"c5a14a6e7e4f250c7fd1f8a213183536aba592e4"}]}