)]}'
{"tempest/api/compute/admin/test_servers_on_multinodes.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"7e3116a6dc0934c6328e26d12638150a632ad35f","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            self.assertIn(server[\u0027id\u0027], server_group[\u0027members\u0027])"},{"line_number":64,"context_line":"            hosts[server[\u0027id\u0027]] \u003d self._get_host(server[\u0027id\u0027])"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        return hosts, servers"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @decorators.idempotent_id(\u002726a9d5df-6890-45f2-abc4-a659290cb130\u0027)"},{"line_number":69,"context_line":"    @testtools.skipUnless("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_72fb5a14","line":66,"range":{"start_line":66,"start_character":22,"end_line":66,"end_character":29},"updated":"2018-07-18 02:20:43.000000000","message":"Not sure if you want to return the whole body or just server IDs as per commit message in which case this should be [s[\u0027id\u0027] for s in servers]","commit_id":"fc7eb0fbd3c40a82d876d1608bc9216d17639271"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"ea1610bf2b5d751308663d416bf466aac689a7be","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            self.assertIn(server[\u0027id\u0027], server_group[\u0027members\u0027])"},{"line_number":64,"context_line":"            hosts[server[\u0027id\u0027]] \u003d self._get_host(server[\u0027id\u0027])"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        return hosts, servers"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @decorators.idempotent_id(\u002726a9d5df-6890-45f2-abc4-a659290cb130\u0027)"},{"line_number":69,"context_line":"    @testtools.skipUnless("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_d22029b4","line":66,"range":{"start_line":66,"start_character":22,"end_line":66,"end_character":29},"in_reply_to":"5f7c97a3_72fb5a14","updated":"2018-07-18 08:14:41.000000000","message":"It seems server ids are already contained in the dict of hosts whose key is server_id, like:\nAssertionError: u\u0027ubuntu-xenial-ovh-bhs1-0000743859\u0027 \u003d\u003d u\u0027ubuntu-xenial-ovh-bhs1-0000743859\u0027 : Servers are on the same host: {u\u002774cc2072-77b1-4e46-8760-dd8d1c2f2b24\u0027: u\u0027ubuntu-xenial-ovh-bhs1-0000743859\u0027, u\u0027b18802f1-5fd9-4381-9de1-62f76fea9d31\u0027: u\u0027ubuntu-xenial-ovh-bhs1-0000743859\u0027}","commit_id":"fc7eb0fbd3c40a82d876d1608bc9216d17639271"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a8b27a7a5268e132f63796414a55e455bc2d0a34","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            self.assertIn(server[\u0027id\u0027], server_group[\u0027members\u0027])"},{"line_number":64,"context_line":"            hosts[server[\u0027id\u0027]] \u003d self._get_host(server[\u0027id\u0027])"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        return hosts, servers"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @decorators.idempotent_id(\u002726a9d5df-6890-45f2-abc4-a659290cb130\u0027)"},{"line_number":69,"context_line":"    @testtools.skipUnless("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_4a3e88e3","line":66,"range":{"start_line":66,"start_character":22,"end_line":66,"end_character":29},"in_reply_to":"5f7c97a3_d22029b4","updated":"2018-07-18 23:40:15.000000000","message":"Then maybe we can change the message to:\n\n    \u0027Servers (%s) are on the same host: %s\u0027 % (hosts.keys(), hostnames[0])","commit_id":"fc7eb0fbd3c40a82d876d1608bc9216d17639271"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"898f977d159cf94ad633e3197401f8ce407a6366","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            self.assertIn(server[\u0027id\u0027], server_group[\u0027members\u0027])"},{"line_number":64,"context_line":"            hosts[server[\u0027id\u0027]] \u003d self._get_host(server[\u0027id\u0027])"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        return hosts, servers"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @decorators.idempotent_id(\u002726a9d5df-6890-45f2-abc4-a659290cb130\u0027)"},{"line_number":69,"context_line":"    @testtools.skipUnless("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_baf99282","line":66,"range":{"start_line":66,"start_character":22,"end_line":66,"end_character":29},"in_reply_to":"5f7c97a3_d22029b4","updated":"2018-07-19 21:07:04.000000000","message":"Yeah, you are right.\nCurrent patch just makes a mess.\nI will try making it better soon.","commit_id":"fc7eb0fbd3c40a82d876d1608bc9216d17639271"}]}