)]}'
{"tempest/api/network/admin/test_agents.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"189c085826255e510fd2e80c3cd1f70fa9edc8f0","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        # We do know the exact network agent configuration, but a particular setup"},{"line_number":47,"context_line":"        # should at least have a single agent"},{"line_number":48,"context_line":"        self.assertTrue(len(agents) \u003e\u003d 1)"},{"line_number":49,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @attr(type\u003d\u0027smoke\u0027)"},{"line_number":52,"context_line":"    def test_show_agent(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BIbc%3D","line":49,"updated":"2013-12-02 09:28:25.000000000","message":"better to put self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027]) just after self.admin_client.list_agents() for safe test.","commit_id":"588b4d737f69ffbb10e174e0546afbafee501043"},{"author":{"_account_id":8861,"name":"Joris Roovers","email":"jroovers@cisco.com","username":"joris.roovers"},"change_message_id":"8b59e1b725ec6dc033e327ce5d44c4149bc93357","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        # We do know the exact network agent configuration, but a particular setup"},{"line_number":47,"context_line":"        # should at least have a single agent"},{"line_number":48,"context_line":"        self.assertTrue(len(agents) \u003e\u003d 1)"},{"line_number":49,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @attr(type\u003d\u0027smoke\u0027)"},{"line_number":52,"context_line":"    def test_show_agent(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BIH4%3D","line":49,"in_reply_to":"AAAATn%2F%2BIbc%3D","updated":"2013-12-02 09:56:44.000000000","message":"Done","commit_id":"588b4d737f69ffbb10e174e0546afbafee501043"}],"tempest/services/network/xml/network_client.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"189c085826255e510fd2e80c3cd1f70fa9edc8f0","unresolved":false,"context_lines":[{"line_number":564,"context_line":"    def show_agent(self, agent_id):"},{"line_number":565,"context_line":"        uri \u003d \u0027%s/agents/%s\u0027 % (self.uri_prefix, agent_id)"},{"line_number":566,"context_line":"        resp, body \u003d self.get(uri, self.headers)"},{"line_number":567,"context_line":"        body \u003d _root_tag_fetcher_and_xml_to_json_parse(body)"},{"line_number":568,"context_line":"        return resp, body"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    def delete_agent(self, agent_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BINc%3D","line":567,"updated":"2013-12-02 09:28:25.000000000","message":"The JSON test_show_agent(tempest.api.network.admin.test_agents.AgentManagementTestJSON) succeeded, but the XML one failed.\n\nIn addition, debug message shows \"{\u0027{http://www.w3.org/2001/XMLSchema-instance}nil\u0027: \u0027true\u0027}\" as the description in XML list_agent(). So the existing list_agent() seems wrong.","commit_id":"588b4d737f69ffbb10e174e0546afbafee501043"},{"author":{"_account_id":8861,"name":"Joris Roovers","email":"jroovers@cisco.com","username":"joris.roovers"},"change_message_id":"8b59e1b725ec6dc033e327ce5d44c4149bc93357","unresolved":false,"context_lines":[{"line_number":564,"context_line":"    def show_agent(self, agent_id):"},{"line_number":565,"context_line":"        uri \u003d \u0027%s/agents/%s\u0027 % (self.uri_prefix, agent_id)"},{"line_number":566,"context_line":"        resp, body \u003d self.get(uri, self.headers)"},{"line_number":567,"context_line":"        body \u003d _root_tag_fetcher_and_xml_to_json_parse(body)"},{"line_number":568,"context_line":"        return resp, body"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    def delete_agent(self, agent_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BIHE%3D","line":567,"in_reply_to":"AAAATn%2F%2BINc%3D","updated":"2013-12-02 09:56:44.000000000","message":"I agree the issue is with list_agents (the method above this one).\n\nI believe the cause might be an issue with the conversion of XML \u0027nil\u0027 values to python \u0027None\u0027 values.\nself._parse_array uses an xml_to_json method from here:\nhttps://github.com/openstack/tempest/blob/master/tempest/services/compute/xml/common.py#L102\n\nI think there should be some logic there that does the conversion of nil to None properly. Any thoughts?","commit_id":"588b4d737f69ffbb10e174e0546afbafee501043"}]}