)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"b26d622dcee1deaf4846ff16b2310e913774ae99","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     adisky \u003caditi.s@india.nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-07-26 10:27:19 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fill servers schema for microversion 2.3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch fills servers schema for microversion 2.3"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I92e774e19c618b5c5fcf495fbb2de77bfe18904c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_dd73841b","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":52},"updated":"2018-07-27 04:42:34.000000000","message":"Can you please add more description to understand","commit_id":"92a05b095500c1d97ffc32b13a8f4682c3132762"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"34d52931e845933dd8a60f3c445704129f37437c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fill servers schema for microversion 2.3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch fills servers schema for microversion 2.3"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I92e774e19c618b5c5fcf495fbb2de77bfe18904c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_3e23a4ac","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":0},"updated":"2018-07-26 12:10:38.000000000","message":"add this BP here Implements blueprint: full-schema-for-all-microversions\n\nalso little more explanation like done in https://review.openstack.org/#/c/584766/3","commit_id":"92a05b095500c1d97ffc32b13a8f4682c3132762"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cd2c00912165bacc0aa499e92bf1aeb55ea7714b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fill servers schema for microversion 2.3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch fills servers schema for microversion 2.3"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I92e774e19c618b5c5fcf495fbb2de77bfe18904c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_5e99c0cc","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":0},"in_reply_to":"5f7c97a3_3e23a4ac","updated":"2018-07-26 12:15:00.000000000","message":"Partially Implements ..","commit_id":"92a05b095500c1d97ffc32b13a8f4682c3132762"}],"tempest/lib/api_schema/response/compute/v2_3/servers.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"34d52931e845933dd8a60f3c445704129f37437c","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    }"},{"line_number":164,"context_line":"}"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"list_servers \u003d copy.deepcopy(servers.list_servers)"},{"line_number":167,"context_line":"update_server \u003d copy.deepcopy(servers.update_server)"},{"line_number":168,"context_line":"rebuild_server \u003d copy.deepcopy(servers.rebuild_server)"},{"line_number":169,"context_line":"rebuild_server_with_admin_pass \u003d copy.deepcopy("},{"line_number":170,"context_line":"                                     servers.rebuild_server_with_admin_pass)"},{"line_number":171,"context_line":"show_server_diagnostics \u003d copy.deepcopy(servers.show_server_diagnostics)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_6302e50e","line":171,"range":{"start_line":166,"start_character":0,"end_line":171,"end_character":72},"updated":"2018-07-26 12:10:38.000000000","message":"can you add a NOTE before these like-\n\n# Below are the unchanged schema in this microversion. We need\n# to keep this schema in this file to have the generic way to select the\n# right schema based on self.schema_versions_info mapping in service client.\n# ****** Schemas unchanged since microversion 2.1 ***","commit_id":"92a05b095500c1d97ffc32b13a8f4682c3132762"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"32f67c43f6cf8f78ac6ab462a96077233564193b","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    \u0027^[a-zA-Z0-9-_.]+$\u0027][\u0027items\u0027][\u0027properties\u0027].update({"},{"line_number":129,"context_line":"        \u0027OS-EXT-IPS:type\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":130,"context_line":"        \u0027OS-EXT-IPS-MAC:mac_addr\u0027: parameter_types.mac_address})"},{"line_number":131,"context_line":"# NOTE(gmann)dd: Update OS-EXT-IPS:type and OS-EXT-IPS-MAC:mac_addr"},{"line_number":132,"context_line":"# attributes in server address. Those are API extension,"},{"line_number":133,"context_line":"# and some environments return a response without"},{"line_number":134,"context_line":"# these attributes. So they are not \u0027required\u0027."}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_424c633f","line":131,"range":{"start_line":131,"start_character":13,"end_line":131,"end_character":15},"updated":"2018-07-27 16:27:40.000000000","message":"I noticed this while looking at this file. I will try to justify cleaning this up at some point.","commit_id":"fe2058bdc26b17a0f197017ff1356421ccf000d6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"224091efc787b28eca4594f9b2719266cc0b62df","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    \u0027^[a-zA-Z0-9-_.]+$\u0027][\u0027items\u0027][\u0027properties\u0027].update({"},{"line_number":129,"context_line":"        \u0027OS-EXT-IPS:type\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":130,"context_line":"        \u0027OS-EXT-IPS-MAC:mac_addr\u0027: parameter_types.mac_address})"},{"line_number":131,"context_line":"# NOTE(gmann)dd: Update OS-EXT-IPS:type and OS-EXT-IPS-MAC:mac_addr"},{"line_number":132,"context_line":"# attributes in server address. Those are API extension,"},{"line_number":133,"context_line":"# and some environments return a response without"},{"line_number":134,"context_line":"# these attributes. So they are not \u0027required\u0027."}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_90fcf70d","line":131,"range":{"start_line":131,"start_character":13,"end_line":131,"end_character":15},"in_reply_to":"5f7c97a3_424c633f","updated":"2018-07-29 10:19:58.000000000","message":"who added this :). yes we need to clean this but separate changes.","commit_id":"fe2058bdc26b17a0f197017ff1356421ccf000d6"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"32f67c43f6cf8f78ac6ab462a96077233564193b","unresolved":false,"context_lines":[{"line_number":169,"context_line":"# ****** Schemas unchanged since microversion 2.1 ***"},{"line_number":170,"context_line":"list_servers \u003d copy.deepcopy(servers.list_servers)"},{"line_number":171,"context_line":"update_server \u003d copy.deepcopy(servers.update_server)"},{"line_number":172,"context_line":"rebuild_server \u003d copy.deepcopy(servers.rebuild_server)"},{"line_number":173,"context_line":"rebuild_server_with_admin_pass \u003d copy.deepcopy("},{"line_number":174,"context_line":"    servers.rebuild_server_with_admin_pass)"},{"line_number":175,"context_line":"show_server_diagnostics \u003d copy.deepcopy(servers.show_server_diagnostics)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_62e5df06","line":172,"range":{"start_line":172,"start_character":0,"end_line":172,"end_character":54},"updated":"2018-07-27 16:27:40.000000000","message":"Is this true? It was updated here: https://github.com/openstack/tempest/blob/4e6b46e1969dbcb1b4c13f3a011b6f66dbe39df7/tempest/lib/api_schema/response/compute/v2_19/servers.py#L41\n\n\"A free form description of the server. Limited to 255 characters in length. Before microversion 2.19 this was set to the server name.\n\nNew in version 2.19\"\n\nhttps://developer.openstack.org/api-ref/compute/#rebuild-server-rebuild-action","commit_id":"fe2058bdc26b17a0f197017ff1356421ccf000d6"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"c11bc816da7a533666776dec00986f4756cfd5a0","unresolved":false,"context_lines":[{"line_number":169,"context_line":"# ****** Schemas unchanged since microversion 2.1 ***"},{"line_number":170,"context_line":"list_servers \u003d copy.deepcopy(servers.list_servers)"},{"line_number":171,"context_line":"update_server \u003d copy.deepcopy(servers.update_server)"},{"line_number":172,"context_line":"rebuild_server \u003d copy.deepcopy(servers.rebuild_server)"},{"line_number":173,"context_line":"rebuild_server_with_admin_pass \u003d copy.deepcopy("},{"line_number":174,"context_line":"    servers.rebuild_server_with_admin_pass)"},{"line_number":175,"context_line":"show_server_diagnostics \u003d copy.deepcopy(servers.show_server_diagnostics)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_18d3ee38","line":172,"range":{"start_line":172,"start_character":0,"end_line":172,"end_character":54},"in_reply_to":"5f7c97a3_297a59ee","updated":"2018-08-01 06:56:13.000000000","message":"Ok you are right, I misread this file as 2.30, so I have no objections :)","commit_id":"fe2058bdc26b17a0f197017ff1356421ccf000d6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"224091efc787b28eca4594f9b2719266cc0b62df","unresolved":false,"context_lines":[{"line_number":169,"context_line":"# ****** Schemas unchanged since microversion 2.1 ***"},{"line_number":170,"context_line":"list_servers \u003d copy.deepcopy(servers.list_servers)"},{"line_number":171,"context_line":"update_server \u003d copy.deepcopy(servers.update_server)"},{"line_number":172,"context_line":"rebuild_server \u003d copy.deepcopy(servers.rebuild_server)"},{"line_number":173,"context_line":"rebuild_server_with_admin_pass \u003d copy.deepcopy("},{"line_number":174,"context_line":"    servers.rebuild_server_with_admin_pass)"},{"line_number":175,"context_line":"show_server_diagnostics \u003d copy.deepcopy(servers.show_server_diagnostics)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_70ffdb02","line":172,"range":{"start_line":172,"start_character":0,"end_line":172,"end_character":54},"in_reply_to":"5f7c97a3_62e5df06","updated":"2018-07-29 10:19:58.000000000","message":"did not get your point. rebuild server schema in microverion 2.3 is unchanged which is this file. This was change in 2.19 as you mentioned so to consume the schema file for microversion till 2.19 (means run rebuild tests with microversion 2.4), we need to add the rebuild schema in this file. other test fail with error of not finding the schema in file.","commit_id":"fe2058bdc26b17a0f197017ff1356421ccf000d6"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"2c5b4e5578a16d649e0d54edc0664800a1046dea","unresolved":false,"context_lines":[{"line_number":169,"context_line":"# ****** Schemas unchanged since microversion 2.1 ***"},{"line_number":170,"context_line":"list_servers \u003d copy.deepcopy(servers.list_servers)"},{"line_number":171,"context_line":"update_server \u003d copy.deepcopy(servers.update_server)"},{"line_number":172,"context_line":"rebuild_server \u003d copy.deepcopy(servers.rebuild_server)"},{"line_number":173,"context_line":"rebuild_server_with_admin_pass \u003d copy.deepcopy("},{"line_number":174,"context_line":"    servers.rebuild_server_with_admin_pass)"},{"line_number":175,"context_line":"show_server_diagnostics \u003d copy.deepcopy(servers.show_server_diagnostics)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_e60b312a","line":172,"range":{"start_line":172,"start_character":0,"end_line":172,"end_character":54},"in_reply_to":"5f7c97a3_70ffdb02","updated":"2018-07-29 20:50:11.000000000","message":"The comment above says \"Schemas unchanged since microversion 2.1\" but the link above shows that it was changed in microversion 2.19.","commit_id":"fe2058bdc26b17a0f197017ff1356421ccf000d6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bdfd7d8862ece898600b5aa0ccc8498e645a0f8d","unresolved":false,"context_lines":[{"line_number":169,"context_line":"# ****** Schemas unchanged since microversion 2.1 ***"},{"line_number":170,"context_line":"list_servers \u003d copy.deepcopy(servers.list_servers)"},{"line_number":171,"context_line":"update_server \u003d copy.deepcopy(servers.update_server)"},{"line_number":172,"context_line":"rebuild_server \u003d copy.deepcopy(servers.rebuild_server)"},{"line_number":173,"context_line":"rebuild_server_with_admin_pass \u003d copy.deepcopy("},{"line_number":174,"context_line":"    servers.rebuild_server_with_admin_pass)"},{"line_number":175,"context_line":"show_server_diagnostics \u003d copy.deepcopy(servers.show_server_diagnostics)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_297a59ee","line":172,"range":{"start_line":172,"start_character":0,"end_line":172,"end_character":54},"in_reply_to":"5f7c97a3_e60b312a","updated":"2018-07-30 01:30:37.000000000","message":"yeah 2.19 is later than 2.1 and 2.3. Comments says schema is unchanged since 2.1 till 2.3 microversion which is this file. compute/v2_3/servers.py file is for schema of microversion 2.3 and have schema changed or unchanged in 2.3 w.r.t to its immediate previous microversion changed for /servers APIs(2.1)","commit_id":"fe2058bdc26b17a0f197017ff1356421ccf000d6"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"32f67c43f6cf8f78ac6ab462a96077233564193b","unresolved":false,"context_lines":[{"line_number":170,"context_line":"list_servers \u003d copy.deepcopy(servers.list_servers)"},{"line_number":171,"context_line":"update_server \u003d copy.deepcopy(servers.update_server)"},{"line_number":172,"context_line":"rebuild_server \u003d copy.deepcopy(servers.rebuild_server)"},{"line_number":173,"context_line":"rebuild_server_with_admin_pass \u003d copy.deepcopy("},{"line_number":174,"context_line":"    servers.rebuild_server_with_admin_pass)"},{"line_number":175,"context_line":"show_server_diagnostics \u003d copy.deepcopy(servers.show_server_diagnostics)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_22bda7d6","line":173,"range":{"start_line":173,"start_character":0,"end_line":173,"end_character":30},"updated":"2018-07-27 16:27:40.000000000","message":"Ditto for this one.","commit_id":"fe2058bdc26b17a0f197017ff1356421ccf000d6"}]}