)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"822e048ba2610f0669f913e480ff2f545786f4bf","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Adding unit test of setting config path for \"tempest run\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding unit tests for below patch"},{"line_number":10,"context_line":"Patch Id:  #I8a65ee0f82e41f9659b3f40e2685c0ee0f290342"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"It will check the positive and negative case for sending data"},{"line_number":13,"context_line":"and sending no data to ensure path variable is set properly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_8f2352aa","line":10,"range":{"start_line":10,"start_character":11,"end_line":10,"end_character":12},"updated":"2018-07-31 06:03:45.000000000","message":"nit: should not add # here","commit_id":"a169056bb45eb0650514386c4025674056669598"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"822e048ba2610f0669f913e480ff2f545786f4bf","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"It will check the positive and negative case for sending data"},{"line_number":13,"context_line":"and sending no data to ensure path variable is set properly."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I996ec912ed39ecc3c3ca293c257126b910b3e958"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_af288e84","line":14,"updated":"2018-07-31 06:03:45.000000000","message":"Should also add:\n\nDepends-On: I8a65ee0f82e41f9659b3f40e2685c0ee0f290342","commit_id":"a169056bb45eb0650514386c4025674056669598"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"ad1fa7c80159f1bfd22dc11e8bd371ef8695e8fd","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Adding unit test of setting config path for \"tempest run\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding unit tests for below patch"},{"line_number":10,"context_line":"Depends-On: I8a65ee0f82e41f9659b3f40e2685c0ee0f290342"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"It will check the positive and negative case for sending data"},{"line_number":13,"context_line":"and sending no data to ensure path variable is set properly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_988ffe74","line":10,"updated":"2018-08-01 06:42:43.000000000","message":"I think we don\u0027t need this directive because this patch doesn\u0027t have cross-repo dependencies.\nhttps://docs.openstack.org/infra/manual/developers.html#cross-repository-dependencies\n\nSo, for adding a dependency, I think we just need to do like this.\n\nhttps://docs.openstack.org/infra/manual/developers.html#adding-a-dependency","commit_id":"bf1dd0976a1b9e00bab5ebf71835a45f20733286"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"e6a23d858482df5ba9acfd15e6f8591b64a39377","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Adding unit test of setting config path for \"tempest run\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding unit tests for below patch"},{"line_number":10,"context_line":"Depends-On: I8a65ee0f82e41f9659b3f40e2685c0ee0f290342"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"It will check the positive and negative case for sending data"},{"line_number":13,"context_line":"and sending no data to ensure path variable is set properly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_f4c15a50","line":10,"in_reply_to":"5f7c97a3_988ffe74","updated":"2018-10-03 05:25:32.000000000","message":"It\u0027s already rebased on dependent patch. So I will remove \"Depends-On\" from here","commit_id":"bf1dd0976a1b9e00bab5ebf71835a45f20733286"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"ad1fa7c80159f1bfd22dc11e8bd371ef8695e8fd","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"It will check the positive and negative case for sending data"},{"line_number":13,"context_line":"and sending no data to ensure path variable is set properly."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I996ec912ed39ecc3c3ca293c257126b910b3e958"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_388a6a64","line":14,"updated":"2018-08-01 06:42:43.000000000","message":"Could you add this?\n\n Related-Bug: #1783751","commit_id":"bf1dd0976a1b9e00bab5ebf71835a45f20733286"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d80c3acbfad9f750b1d8af6d985c63aa839f4d4d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It will check the positive and negative case for sending data"},{"line_number":10,"context_line":"and sending no data to ensure path variable is set properly."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related-Bug: #1783751"},{"line_number":13,"context_line":"Change-Id: I996ec912ed39ecc3c3ca293c257126b910b3e958"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_7847321f","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":0},"updated":"2018-08-07 06:36:03.000000000","message":"also add below BP link for tracking\n\n\nPartially-Implements: blueprint tempest-cli-unit-test-coverage","commit_id":"53396807f8c1544e665d4d6832d7b4fd6b575f84"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"081e59da44b1c85733ac9e4e51acade10f0d4f85","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Manik Bindlish \u003cmanikbindlish19@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-08-13 05:01:48 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Adding unit test of setting config path for \"tempest run\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It will check the positive and negative case for sending data"},{"line_number":10,"context_line":"and sending no data to ensure path variable is set properly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_0e1e1f74","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":5},"updated":"2018-09-10 14:09:02.000000000","message":"@Manik is this still a WIP?","commit_id":"a035cf2acc71c81ec7ce448713de31b0c53de478"}],"tempest/tests/cmd/test_run.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"dba20e9092698fe0f50c5831e3eceb4a5da75f6a","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def test_tempest_run_set_config_path(self):"},{"line_number":158,"context_line":"        self.run_cmd._set_env(\"/fakedir/fakefile\")"},{"line_number":159,"context_line":"        CONF.auth"},{"line_number":160,"context_line":"        self.assertEqual(\"/fakedir/fakefile\", CONF._path)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def test_tempest_run_set_config_no_path(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_dc3b58c6","line":159,"range":{"start_line":159,"start_character":8,"end_line":159,"end_character":17},"updated":"2018-07-30 15:18:56.000000000","message":"Why is this here? This is a noop.","commit_id":"a169056bb45eb0650514386c4025674056669598"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"252cc8b526d28beeaac11da77977aeb8e4e24419","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def test_tempest_run_set_config_path(self):"},{"line_number":158,"context_line":"        self.run_cmd._set_env(\"/fakedir/fakefile\")"},{"line_number":159,"context_line":"        CONF.auth"},{"line_number":160,"context_line":"        self.assertEqual(\"/fakedir/fakefile\", CONF._path)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def test_tempest_run_set_config_no_path(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_f4fbbf12","line":159,"updated":"2018-07-31 05:57:43.000000000","message":"yeah, but I think this assert is a bit tricky. So, how about adding a NOTE or comment? And can you assert the returned value here?","commit_id":"a169056bb45eb0650514386c4025674056669598"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"7e3e76ad146bcd959dca84c8694c79c63840cd38","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def test_tempest_run_set_config_path(self):"},{"line_number":158,"context_line":"        self.run_cmd._set_env(\"/fakedir/fakefile\")"},{"line_number":159,"context_line":"        CONF.auth"},{"line_number":160,"context_line":"        self.assertEqual(\"/fakedir/fakefile\", CONF._path)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def test_tempest_run_set_config_no_path(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_d6aec29f","line":159,"in_reply_to":"5f7c97a3_cf138a59","updated":"2018-07-31 11:27:11.000000000","message":"@Felipie: 1 more case\nIn tempest run command we need to call \"set_config_path\", only when config file exists which is called in \"_set_env\"\n\nIf no config file then if we will call \"set_config_path\" directly then environment variable(\u0027TEMPEST_CONFIG_DIR\u0027 and \u0027TEMPEST_CONFIG\u0027) will get set with blank value \nBut in actual test run it will never set when config parameter will not be passed.\nFor the time being, I am calling \"_set_env\", If you are not convinced then I can change accordingly.","commit_id":"a169056bb45eb0650514386c4025674056669598"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"ce01090d676b271eb44257c050be598cf8c660d9","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def test_tempest_run_set_config_path(self):"},{"line_number":158,"context_line":"        self.run_cmd._set_env(\"/fakedir/fakefile\")"},{"line_number":159,"context_line":"        CONF.auth"},{"line_number":160,"context_line":"        self.assertEqual(\"/fakedir/fakefile\", CONF._path)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def test_tempest_run_set_config_no_path(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_8501f36f","line":159,"in_reply_to":"5f7c97a3_cf138a59","updated":"2018-07-31 08:21:48.000000000","message":"I have a thinking it\u0027s better to check from the \"_set_env\" , just to ensure whatever we are passing here that should not be changed abnormally, till last. So not sure about this change.","commit_id":"a169056bb45eb0650514386c4025674056669598"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"087f25cfaf23a614077c284be44f42f439f19742","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def test_tempest_run_set_config_path(self):"},{"line_number":158,"context_line":"        self.run_cmd._set_env(\"/fakedir/fakefile\")"},{"line_number":159,"context_line":"        CONF.auth"},{"line_number":160,"context_line":"        self.assertEqual(\"/fakedir/fakefile\", CONF._path)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def test_tempest_run_set_config_no_path(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_3dd33c04","line":159,"in_reply_to":"5f7c97a3_d6aec29f","updated":"2018-08-01 05:44:32.000000000","message":"Makes sense, as it is the func called by CLI and I see the set_config_path invocation here: http://git.openstack.org/cgit/openstack/tempest/tree/tempest/cmd/run.py#n115\n\nWill review more carefully tomorrow","commit_id":"a169056bb45eb0650514386c4025674056669598"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"384c0624b6f3e0e47e4f0804af0ba1b380ab78ea","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def test_tempest_run_set_config_path(self):"},{"line_number":158,"context_line":"        self.run_cmd._set_env(\"/fakedir/fakefile\")"},{"line_number":159,"context_line":"        CONF.auth"},{"line_number":160,"context_line":"        self.assertEqual(\"/fakedir/fakefile\", CONF._path)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def test_tempest_run_set_config_no_path(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_99264422","line":159,"range":{"start_line":159,"start_character":8,"end_line":159,"end_character":17},"in_reply_to":"5f7c97a3_dc3b58c6","updated":"2018-07-31 03:24:34.000000000","message":"This is used to call the getter method: https://github.com/openstack/tempest/blob/master/tempest/config.py#L1194\n\nIf we get anything using object(CONF) of class(TempestConfigProxy) then \"__getattr__\" will be called.\nThere we have to check the path.","commit_id":"a169056bb45eb0650514386c4025674056669598"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"ce01090d676b271eb44257c050be598cf8c660d9","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def test_tempest_run_set_config_path(self):"},{"line_number":158,"context_line":"        self.run_cmd._set_env(\"/fakedir/fakefile\")"},{"line_number":159,"context_line":"        CONF.auth"},{"line_number":160,"context_line":"        self.assertEqual(\"/fakedir/fakefile\", CONF._path)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def test_tempest_run_set_config_no_path(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_e5922755","line":159,"in_reply_to":"5f7c97a3_f4fbbf12","updated":"2018-07-31 08:21:48.000000000","message":"I will add the note here. Thanks!","commit_id":"a169056bb45eb0650514386c4025674056669598"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"822e048ba2610f0669f913e480ff2f545786f4bf","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def test_tempest_run_set_config_path(self):"},{"line_number":158,"context_line":"        self.run_cmd._set_env(\"/fakedir/fakefile\")"},{"line_number":159,"context_line":"        CONF.auth"},{"line_number":160,"context_line":"        self.assertEqual(\"/fakedir/fakefile\", CONF._path)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def test_tempest_run_set_config_no_path(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_cf138a59","line":159,"in_reply_to":"5f7c97a3_f4fbbf12","updated":"2018-07-31 06:03:45.000000000","message":"Why not calling https://github.com/openstack/tempest/blob/2e1ed28a135821cf5313bdf5e2b87a47131ebdc2/tempest/config.py#L1218 directly which is where the fix is included?","commit_id":"a169056bb45eb0650514386c4025674056669598"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"822e048ba2610f0669f913e480ff2f545786f4bf","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    def test_tempest_run_set_config_path(self):"},{"line_number":158,"context_line":"        self.run_cmd._set_env(\"/fakedir/fakefile\")"},{"line_number":159,"context_line":"        CONF.auth"},{"line_number":160,"context_line":"        self.assertEqual(\"/fakedir/fakefile\", CONF._path)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def test_tempest_run_set_config_no_path(self):"},{"line_number":163,"context_line":"        self.run_cmd._set_env(\"\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_6f1ef65e","line":160,"updated":"2018-07-31 06:03:45.000000000","message":"We should also assert that:\n\nos.environ[\u0027TEMPEST_CONFIG_DIR\u0027] \u003d\u003d \"/fakedir/fakefile\"\nos.environ[\u0027TEMPEST_CONFIG\u0027] \u003d\u003d \"/fakedir/\"\n\nExample:\n\n    self.assertIn(\u0027TEMPEST_CONFIG_DIR\u0027, os.environ)\n    self.assertEqual(\"/fakedir/fakefile\", os.environ[\u0027TEMPEST_CONFIG_DIR\u0027])\n    [...]","commit_id":"a169056bb45eb0650514386c4025674056669598"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"ce01090d676b271eb44257c050be598cf8c660d9","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    def test_tempest_run_set_config_path(self):"},{"line_number":158,"context_line":"        self.run_cmd._set_env(\"/fakedir/fakefile\")"},{"line_number":159,"context_line":"        CONF.auth"},{"line_number":160,"context_line":"        self.assertEqual(\"/fakedir/fakefile\", CONF._path)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def test_tempest_run_set_config_no_path(self):"},{"line_number":163,"context_line":"        self.run_cmd._set_env(\"\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_258d7f34","line":160,"in_reply_to":"5f7c97a3_6f1ef65e","updated":"2018-07-31 08:21:48.000000000","message":"Yeah, its good to add like this, I will add for this.","commit_id":"a169056bb45eb0650514386c4025674056669598"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"dba20e9092698fe0f50c5831e3eceb4a5da75f6a","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def test_tempest_run_set_config_no_path(self):"},{"line_number":163,"context_line":"        self.run_cmd._set_env(\"\")"},{"line_number":164,"context_line":"        CONF.auth"},{"line_number":165,"context_line":"        self.assertFalse(CONF._path)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_7c76c4a5","line":164,"range":{"start_line":164,"start_character":8,"end_line":164,"end_character":17},"updated":"2018-07-30 15:18:56.000000000","message":"Ditto.","commit_id":"a169056bb45eb0650514386c4025674056669598"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"384c0624b6f3e0e47e4f0804af0ba1b380ab78ea","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def test_tempest_run_set_config_no_path(self):"},{"line_number":163,"context_line":"        self.run_cmd._set_env(\"\")"},{"line_number":164,"context_line":"        CONF.auth"},{"line_number":165,"context_line":"        self.assertFalse(CONF._path)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_b92b00e8","line":164,"range":{"start_line":164,"start_character":8,"end_line":164,"end_character":17},"in_reply_to":"5f7c97a3_7c76c4a5","updated":"2018-07-31 03:24:34.000000000","message":"Same response as above!","commit_id":"a169056bb45eb0650514386c4025674056669598"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"ad1fa7c80159f1bfd22dc11e8bd371ef8695e8fd","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        # set the environment."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        self.run_cmd._set_env(\"/fakedir/fakefile\")"},{"line_number":164,"context_line":"        self.assertEqual(\"/fakedir/fakefile\", CONF._path)"},{"line_number":165,"context_line":"        self.assertIn(\u0027TEMPEST_CONFIG_DIR\u0027, os.environ)"},{"line_number":166,"context_line":"        self.assertEqual(\"/fakedir/fakefile\","},{"line_number":167,"context_line":"                         os.path.join(os.environ[\u0027TEMPEST_CONFIG_DIR\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_5885e651","line":164,"updated":"2018-08-01 06:42:43.000000000","message":"so, why do we need to check _path here? I feel it\u0027s a bit too tight coupling with the internal logic.","commit_id":"bf1dd0976a1b9e00bab5ebf71835a45f20733286"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"e6a23d858482df5ba9acfd15e6f8591b64a39377","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        # set the environment."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        self.run_cmd._set_env(\"/fakedir/fakefile\")"},{"line_number":164,"context_line":"        self.assertEqual(\"/fakedir/fakefile\", CONF._path)"},{"line_number":165,"context_line":"        self.assertIn(\u0027TEMPEST_CONFIG_DIR\u0027, os.environ)"},{"line_number":166,"context_line":"        self.assertEqual(\"/fakedir/fakefile\","},{"line_number":167,"context_line":"                         os.path.join(os.environ[\u0027TEMPEST_CONFIG_DIR\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_9494a636","line":164,"in_reply_to":"5f7c97a3_5885e651","updated":"2018-10-03 05:25:32.000000000","message":"This is just to check the _path is assigned(in scope of \"TempestConfigProxy\") with some value which is getting set in \"set_config_path\"","commit_id":"bf1dd0976a1b9e00bab5ebf71835a45f20733286"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"ad1fa7c80159f1bfd22dc11e8bd371ef8695e8fd","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        self.assertIn(\u0027TEMPEST_CONFIG_DIR\u0027, os.environ)"},{"line_number":166,"context_line":"        self.assertEqual(\"/fakedir/fakefile\","},{"line_number":167,"context_line":"                         os.path.join(os.environ[\u0027TEMPEST_CONFIG_DIR\u0027],"},{"line_number":168,"context_line":"                                      os.environ[\u0027TEMPEST_CONFIG\u0027]))"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def test_tempest_run_set_config_no_path(self):"},{"line_number":171,"context_line":"        # Note: (mbindlish) This test is created for the bug id: 1783751"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_f8e5d23e","line":168,"updated":"2018-08-01 06:42:43.000000000","message":"hmm, yeah, we should check this and we should have a document this behavior, too. I think adding the document is not for this patch but in a following patch, though.","commit_id":"bf1dd0976a1b9e00bab5ebf71835a45f20733286"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"e6a23d858482df5ba9acfd15e6f8591b64a39377","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        self.assertIn(\u0027TEMPEST_CONFIG_DIR\u0027, os.environ)"},{"line_number":166,"context_line":"        self.assertEqual(\"/fakedir/fakefile\","},{"line_number":167,"context_line":"                         os.path.join(os.environ[\u0027TEMPEST_CONFIG_DIR\u0027],"},{"line_number":168,"context_line":"                                      os.environ[\u0027TEMPEST_CONFIG\u0027]))"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def test_tempest_run_set_config_no_path(self):"},{"line_number":171,"context_line":"        # Note: (mbindlish) This test is created for the bug id: 1783751"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_d4b77ed6","line":168,"in_reply_to":"5f7c97a3_f8e5d23e","updated":"2018-10-03 05:25:32.000000000","message":"Yeah, after merging of this patch, we can create a document patch for this","commit_id":"bf1dd0976a1b9e00bab5ebf71835a45f20733286"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"ad1fa7c80159f1bfd22dc11e8bd371ef8695e8fd","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        # in os environment when no data has passed to set the environment."},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        self.run_cmd._set_env(\"\")"},{"line_number":176,"context_line":"        self.assertFalse(CONF._path)"},{"line_number":177,"context_line":"        self.assertNotIn(\u0027TEMPEST_CONFIG_DIR\u0027, os.environ)"},{"line_number":178,"context_line":"        self.assertNotIn(\u0027TEMPEST_CONFIG\u0027, os.environ)"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_18e9ae17","line":176,"updated":"2018-08-01 06:42:43.000000000","message":"ditto","commit_id":"bf1dd0976a1b9e00bab5ebf71835a45f20733286"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"e6a23d858482df5ba9acfd15e6f8591b64a39377","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        # in os environment when no data has passed to set the environment."},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        self.run_cmd._set_env(\"\")"},{"line_number":176,"context_line":"        self.assertFalse(CONF._path)"},{"line_number":177,"context_line":"        self.assertNotIn(\u0027TEMPEST_CONFIG_DIR\u0027, os.environ)"},{"line_number":178,"context_line":"        self.assertNotIn(\u0027TEMPEST_CONFIG\u0027, os.environ)"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_54c36e39","line":176,"in_reply_to":"5f7c97a3_18e9ae17","updated":"2018-10-03 05:25:32.000000000","message":"This is just to check the _path shouldn\u0027t be assigned(in scope of \"TempestConfigProxy\") with any value by \"set_config_path\"","commit_id":"bf1dd0976a1b9e00bab5ebf71835a45f20733286"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1d3d6b7998bfc29d7b4eb8af1fde639f5e85f7f2","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        self.assertFalse(CONF._path)"},{"line_number":177,"context_line":"        self.assertNotIn(\u0027TEMPEST_CONFIG_DIR\u0027, os.environ)"},{"line_number":178,"context_line":"        self.assertNotIn(\u0027TEMPEST_CONFIG\u0027, os.environ)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"class TestTakeAction(base.TestCase):"},{"line_number":182,"context_line":"    def test_workspace_not_registered(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_9d0c9597","line":179,"range":{"start_line":179,"start_character":0,"end_line":179,"end_character":0},"updated":"2018-08-03 07:54:26.000000000","message":"these test case are not enough to capture the regressions. i want to have one positive and one negative test case at least where we can check passing the non default config path by --config-path arg and test case gets the credential set on this dummy non default config file.\n\nyou can have a dummy test class derived from tempest.test.base.TestCase and there you can check the config options value there which will be set on non-default config file passed via --config-file on tempest run","commit_id":"53396807f8c1544e665d4d6832d7b4fd6b575f84"}]}