)]}'
{"tempest/scenario/base_network_ops.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"2a97cbacb91d2586311e28e6feda1ede6acd27a4","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#    under the License."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from tempest.api.network import common as net_common"},{"line_number":20,"context_line":"from tempest.common.utils.data_utils import rand_name"},{"line_number":21,"context_line":"from tempest import config"},{"line_number":22,"context_line":"from tempest.openstack.common import log as logging"},{"line_number":23,"context_line":"from tempest.scenario import manager"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BJAA%3D","line":20,"updated":"2013-12-02 04:29:53.000000000","message":"Could you please change here like the following?\n\n from tempest.common.utils import data_utils\n\nWe were changing this kind of import and now most code is like the above.","commit_id":"17644b06a2c087439b1b17e167ba200df7ee55ca"},{"author":{"_account_id":8622,"name":"Feng Ju","email":"jufeng@cn.ibm.com","username":"jufeng"},"change_message_id":"91057cbb33c6635f6d9b2ac929313f3fb585ff6a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#    under the License."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from tempest.api.network import common as net_common"},{"line_number":20,"context_line":"from tempest.common.utils.data_utils import rand_name"},{"line_number":21,"context_line":"from tempest import config"},{"line_number":22,"context_line":"from tempest.openstack.common import log as logging"},{"line_number":23,"context_line":"from tempest.scenario import manager"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BIyA%3D","line":20,"in_reply_to":"AAAATn%2F%2BJAA%3D","updated":"2013-12-02 05:29:48.000000000","message":"Done, thanks","commit_id":"17644b06a2c087439b1b17e167ba200df7ee55ca"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"c231b2848c4bd71a028f31a16524870fb6107989","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class BaseNetworkOps(manager.NetworkScenarioTest):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    CONF \u003d config.TempestConfig()"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @classmethod"},{"line_number":33,"context_line":"    def check_preconditions(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9%2BoM%3D","line":30,"updated":"2013-12-03 20:35:00.000000000","message":"I don\u0027t think you need this, if you follow the inheritance chain config should already be set to a class level variable. (which you\u0027re actually using unlike CONF added here)","commit_id":"956cfb292d627e8922d95d12aa5f1d5114cacc83"}],"tempest/scenario/manager.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"2a97cbacb91d2586311e28e6feda1ede6acd27a4","unresolved":false,"context_lines":[{"line_number":632,"context_line":"        return tempest.test.call_until_true("},{"line_number":633,"context_line":"            ping, self.config.compute.ping_timeout, 1)"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"    def _ping_ip_address(self, ip_address):"},{"line_number":636,"context_line":"        cmd \u003d [\u0027ping\u0027, \u0027-c1\u0027, \u0027-w1\u0027, ip_address]"},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"        def ping():"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BI6w%3D","line":635,"updated":"2013-12-02 04:29:53.000000000","message":"How about renaming this method to _ping_ip_address_from_tempest() or something?\n\nIf doing it, we would understand the difference between similar name\u0027s methods.","commit_id":"17644b06a2c087439b1b17e167ba200df7ee55ca"},{"author":{"_account_id":8622,"name":"Feng Ju","email":"jufeng@cn.ibm.com","username":"jufeng"},"change_message_id":"91057cbb33c6635f6d9b2ac929313f3fb585ff6a","unresolved":false,"context_lines":[{"line_number":632,"context_line":"        return tempest.test.call_until_true("},{"line_number":633,"context_line":"            ping, self.config.compute.ping_timeout, 1)"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"    def _ping_ip_address(self, ip_address):"},{"line_number":636,"context_line":"        cmd \u003d [\u0027ping\u0027, \u0027-c1\u0027, \u0027-w1\u0027, ip_address]"},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"        def ping():"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BIyM%3D","line":635,"in_reply_to":"AAAATn%2F%2BI6w%3D","updated":"2013-12-02 05:29:48.000000000","message":"Done, thanks","commit_id":"17644b06a2c087439b1b17e167ba200df7ee55ca"}],"tempest/scenario/test_network_advanced_ops.py":[{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"39788590aaafdfac7daeba9148d24d03cd2db00b","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":17,"context_line":"#    under the License."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from tempest.common.utils.data_utils import rand_name"},{"line_number":20,"context_line":"from tempest.openstack.common import log as logging"},{"line_number":21,"context_line":"from tempest.scenario import base_network_ops as base"},{"line_number":22,"context_line":"from tempest.test import attr"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BICw%3D","line":19,"updated":"2013-12-02 10:35:07.000000000","message":"need import module\u0027s name \"from tempest.common.utils import data_utils","commit_id":"b5543677cf591e45bd6d9c67d235af0ce3c8a80c"},{"author":{"_account_id":8622,"name":"Feng Ju","email":"jufeng@cn.ibm.com","username":"jufeng"},"change_message_id":"b7b6a154b49cff0fd3a65ce2679a7e4ff4513a8f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":17,"context_line":"#    under the License."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from tempest.common.utils.data_utils import rand_name"},{"line_number":20,"context_line":"from tempest.openstack.common import log as logging"},{"line_number":21,"context_line":"from tempest.scenario import base_network_ops as base"},{"line_number":22,"context_line":"from tempest.test import attr"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BDHM%3D","line":19,"in_reply_to":"AAAATn%2F%2BICw%3D","updated":"2013-12-03 03:48:23.000000000","message":"Done, thanks","commit_id":"b5543677cf591e45bd6d9c67d235af0ce3c8a80c"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"39788590aaafdfac7daeba9148d24d03cd2db00b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class TestNetworkAdvancedOps(base.BaseNetworkOps):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def _check_instance_connectivity(self, instance):"},{"line_number":31,"context_line":"        if not self.config.network.tenant_networks_reachable:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BH%2Bk%3D","line":28,"updated":"2013-12-02 10:35:07.000000000","message":"better to use \"base_network_ops.BaseNetworkOps\" , keep the same name with test_network_basic_ops.py","commit_id":"b5543677cf591e45bd6d9c67d235af0ce3c8a80c"},{"author":{"_account_id":8622,"name":"Feng Ju","email":"jufeng@cn.ibm.com","username":"jufeng"},"change_message_id":"b7b6a154b49cff0fd3a65ce2679a7e4ff4513a8f","unresolved":false,"context_lines":[{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class TestNetworkAdvancedOps(base.BaseNetworkOps):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def _check_instance_connectivity(self, instance):"},{"line_number":31,"context_line":"        if not self.config.network.tenant_networks_reachable:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BDHI%3D","line":28,"in_reply_to":"AAAATn%2F%2BH%2Bk%3D","updated":"2013-12-03 03:48:23.000000000","message":"Done, thanks","commit_id":"b5543677cf591e45bd6d9c67d235af0ce3c8a80c"}],"tempest/scenario/test_network_basic_ops.py":[{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"39788590aaafdfac7daeba9148d24d03cd2db00b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#    under the License."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from tempest.common import debug"},{"line_number":20,"context_line":"from tempest.common.utils.data_utils import rand_name"},{"line_number":21,"context_line":"from tempest.openstack.common import log as logging"},{"line_number":22,"context_line":"from tempest.scenario import base_network_ops"},{"line_number":23,"context_line":"from tempest.test import attr"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BIE8%3D","line":20,"updated":"2013-12-02 10:35:07.000000000","message":"need import module\u0027s name: \"from tempest.common.utils import data_utils\"","commit_id":"b5543677cf591e45bd6d9c67d235af0ce3c8a80c"},{"author":{"_account_id":8622,"name":"Feng Ju","email":"jufeng@cn.ibm.com","username":"jufeng"},"change_message_id":"b7b6a154b49cff0fd3a65ce2679a7e4ff4513a8f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#    under the License."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from tempest.common import debug"},{"line_number":20,"context_line":"from tempest.common.utils.data_utils import rand_name"},{"line_number":21,"context_line":"from tempest.openstack.common import log as logging"},{"line_number":22,"context_line":"from tempest.scenario import base_network_ops"},{"line_number":23,"context_line":"from tempest.test import attr"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BDG8%3D","line":20,"in_reply_to":"AAAATn%2F%2BIE8%3D","updated":"2013-12-03 03:48:23.000000000","message":"Done, thanks","commit_id":"b5543677cf591e45bd6d9c67d235af0ce3c8a80c"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"39788590aaafdfac7daeba9148d24d03cd2db00b","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        self.assertTrue(self._ping_ip_address_from_vm(ips[0], ssh_login,"},{"line_number":153,"context_line":"                        private_key, ips[1]))"},{"line_number":154,"context_line":"        self.assertTrue(self._ping_ip_address_from_vm(ips[1], ssh_login,"},{"line_number":155,"context_line":"                        private_key, ips[0]))"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    @attr(type\u003d\u0027smoke\u0027)"},{"line_number":158,"context_line":"    @services(\u0027compute\u0027, \u0027network\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BIF4%3D","line":155,"updated":"2013-12-02 10:35:07.000000000","message":"please add a message for \u0027assertTrue\u0027 to help figure out the error.","commit_id":"b5543677cf591e45bd6d9c67d235af0ce3c8a80c"},{"author":{"_account_id":8622,"name":"Feng Ju","email":"jufeng@cn.ibm.com","username":"jufeng"},"change_message_id":"b7b6a154b49cff0fd3a65ce2679a7e4ff4513a8f","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        self.assertTrue(self._ping_ip_address_from_vm(ips[0], ssh_login,"},{"line_number":153,"context_line":"                        private_key, ips[1]))"},{"line_number":154,"context_line":"        self.assertTrue(self._ping_ip_address_from_vm(ips[1], ssh_login,"},{"line_number":155,"context_line":"                        private_key, ips[0]))"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    @attr(type\u003d\u0027smoke\u0027)"},{"line_number":158,"context_line":"    @services(\u0027compute\u0027, \u0027network\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BDG4%3D","line":155,"in_reply_to":"AAAATn%2F%2BIF4%3D","updated":"2013-12-03 03:48:23.000000000","message":"Done, thanks","commit_id":"b5543677cf591e45bd6d9c67d235af0ce3c8a80c"}]}