)]}'
{"tempest/common/ssh.py":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"5b74b68683086be0424b431f12c914addb6f4c9d","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                            password\u003dself.password,"},{"line_number":63,"context_line":"                            look_for_keys\u003dself.look_for_keys,"},{"line_number":64,"context_line":"                            key_filename\u003dself.key_filename,"},{"line_number":65,"context_line":"                            timeout\u003dself.channel_timeout, pkey\u003dself.pkey)"},{"line_number":66,"context_line":"                _timeout \u003d False"},{"line_number":67,"context_line":"                break"},{"line_number":68,"context_line":"            except (socket.error,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BGZ8%3D","line":65,"updated":"2013-12-02 15:44:13.000000000","message":"so from what I can tell, you want the timeout value here to be much smaller then the timeout value used in _is_timed_out, so ssh.connection can be called multiple times.   The only part I am caught up on is why re-use the self.channel_timeout variable -- which has a different usage below.","commit_id":"b20cf3a30d42ed2ce0c34e338edf498258dfd721"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"91ad731b2a08387bd4ec96b010f3516184979778","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                            password\u003dself.password,"},{"line_number":63,"context_line":"                            look_for_keys\u003dself.look_for_keys,"},{"line_number":64,"context_line":"                            key_filename\u003dself.key_filename,"},{"line_number":65,"context_line":"                            timeout\u003dself.channel_timeout, pkey\u003dself.pkey)"},{"line_number":66,"context_line":"                _timeout \u003d False"},{"line_number":67,"context_line":"                break"},{"line_number":68,"context_line":"            except (socket.error,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BBxQ%3D","line":65,"in_reply_to":"AAAATn%2F%2BB1A%3D","updated":"2013-12-03 10:02:01.000000000","message":"that would make things a little more clear but I am fine with this as is.","commit_id":"b20cf3a30d42ed2ce0c34e338edf498258dfd721"},{"author":{"_account_id":518,"name":"Soren Hansen","email":"soren@linux2go.dk","username":"soren"},"change_message_id":"937194c78f36a9d55c0abab62caa4e1d789e25bd","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                            password\u003dself.password,"},{"line_number":63,"context_line":"                            look_for_keys\u003dself.look_for_keys,"},{"line_number":64,"context_line":"                            key_filename\u003dself.key_filename,"},{"line_number":65,"context_line":"                            timeout\u003dself.channel_timeout, pkey\u003dself.pkey)"},{"line_number":66,"context_line":"                _timeout \u003d False"},{"line_number":67,"context_line":"                break"},{"line_number":68,"context_line":"            except (socket.error,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BB1A%3D","line":65,"in_reply_to":"AAAATn%2F%2BGZ8%3D","updated":"2013-12-03 09:50:06.000000000","message":"I think of channel_timeout as \"the amount of time within which something must happen on this connection before I give up\". If we renamed channel_timeout to connection_timeout at the same time, would that make you happier?","commit_id":"b20cf3a30d42ed2ce0c34e338edf498258dfd721"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"5b74b68683086be0424b431f12c914addb6f4c9d","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        while True:"},{"line_number":121,"context_line":"            ready \u003d poll.poll(self.channel_timeout)"},{"line_number":122,"context_line":"            if not any(ready):"},{"line_number":123,"context_line":"                if not self._is_timed_out(start_time):"},{"line_number":124,"context_line":"                    continue"},{"line_number":125,"context_line":"                raise exceptions.TimeoutException("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BGcc%3D","line":122,"updated":"2013-12-02 15:44:13.000000000","message":"original use of channel_timeout.","commit_id":"b20cf3a30d42ed2ce0c34e338edf498258dfd721"}]}
