)]}'
{"tempest/api/compute/servers/test_server_actions.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"2184e08c976b99bff5b816f7da53547876bbc82c","unresolved":false,"context_lines":[{"line_number":711,"context_line":"class ServerActionsV28TestJSON(BaseServerActionsTestJSON):"},{"line_number":712,"context_line":"    min_microversion \u003d \u00272.8\u0027"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"    # NOTE(felipemonteiro): These tests test the server APIs response schema"},{"line_number":715,"context_line":"    # for microversions \u003e\u003d 2.8."},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"    @decorators.idempotent_id(\u0027c3abb932-b751-4517-bd3d-41b6532c3298\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_4cb7873b","line":714,"range":{"start_line":714,"start_character":49,"end_line":714,"end_character":55},"updated":"2018-08-14 04:22:23.000000000","message":"server console","commit_id":"2c6419570f8f4ee1c543e878f697d247682ff854"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"2b4fff1573a90f55b3014cb78560a27c28a702df","unresolved":false,"context_lines":[{"line_number":717,"context_line":"    @decorators.idempotent_id(\u0027c3abb932-b751-4517-bd3d-41b6532c3298\u0027)"},{"line_number":718,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.mks_console,"},{"line_number":719,"context_line":"                          \u0027MKS Console feature is disabled.\u0027)"},{"line_number":720,"context_line":"    def test_get_mks_console(self):"},{"line_number":721,"context_line":"        # Get the mks console of type \u0027webmks\u0027"},{"line_number":722,"context_line":"        console_type \u003d \u0027webmks\u0027"},{"line_number":723,"context_line":"        body \u003d self.client.get_remote_console("}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_8c24bf5f","line":720,"range":{"start_line":720,"start_character":8,"end_line":720,"end_character":28},"updated":"2018-08-14 04:48:16.000000000","message":"Not clear to me how to test this for microversion 2.8. This won\u0027t be run in the gates I don\u0027t think as MKS protocol won\u0027t be enabled so we shouldn\u0027t add this test.\n\nBut then adding this for VNC protocol as above doesn\u0027t add much value either as all the new microversion does is allow new values to be returned for \"protocol\" and \"type\" field so the response should be the exact same for 2.6 microversion (since it will just return VNC information, not MKS). But if that is OK then I will make the change.","commit_id":"2c6419570f8f4ee1c543e878f697d247682ff854"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"190505736685dde89cb0ad51c7f77b68eea60adb","unresolved":false,"context_lines":[{"line_number":717,"context_line":"    @decorators.idempotent_id(\u0027c3abb932-b751-4517-bd3d-41b6532c3298\u0027)"},{"line_number":718,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.mks_console,"},{"line_number":719,"context_line":"                          \u0027MKS Console feature is disabled.\u0027)"},{"line_number":720,"context_line":"    def test_get_mks_console(self):"},{"line_number":721,"context_line":"        # Get the mks console of type \u0027webmks\u0027"},{"line_number":722,"context_line":"        console_type \u003d \u0027webmks\u0027"},{"line_number":723,"context_line":"        body \u003d self.client.get_remote_console("}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_58064b54","line":720,"range":{"start_line":720,"start_character":8,"end_line":720,"end_character":28},"in_reply_to":"3f79a3b5_8c24bf5f","updated":"2018-08-15 01:21:38.000000000","message":"I\u0027d prefer not adding any testcase for mks protocol, and I think to add mks in the schema is enough:)","commit_id":"2c6419570f8f4ee1c543e878f697d247682ff854"}],"tempest/lib/api_schema/response/compute/v2_9/servers.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6ce57031532dafe789fa38c985e2a2c921d70dcc","unresolved":false,"context_lines":[{"line_number":50,"context_line":"rebuild_server_with_admin_pass[\u0027response_body\u0027][\u0027properties\u0027][\u0027server\u0027]["},{"line_number":51,"context_line":"    \u0027required\u0027].append(\u0027locked\u0027)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"# NOTE: Below are the unchanged schema in this microversion. We need"},{"line_number":54,"context_line":"# to keep this schema in this file to have the generic way to select the"},{"line_number":55,"context_line":"# right schema based on self.schema_versions_info mapping in service client."},{"line_number":56,"context_line":"# ****** Schemas unchanged since microversion 2.8 ******"},{"line_number":57,"context_line":"show_server_diagnostics \u003d copy.deepcopy(servers.show_server_diagnostics)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_7244eab7","line":57,"range":{"start_line":53,"start_character":0,"end_line":57,"end_character":72},"updated":"2018-08-09 16:22:05.000000000","message":"this was already added, you need to rebase on master  - https://github.com/openstack/tempest/blob/8130712d6723e99f96fb14640e434070f3f7384d/tempest/lib/api_schema/response/compute/v2_9/servers.py#L25","commit_id":"3d2f423cd0f9f09439cb2f5825ae0a5c6722236d"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"4f030e346627c2c8a2d1db2323ba9dd9fee2ff38","unresolved":false,"context_lines":[{"line_number":50,"context_line":"rebuild_server_with_admin_pass[\u0027response_body\u0027][\u0027properties\u0027][\u0027server\u0027]["},{"line_number":51,"context_line":"    \u0027required\u0027].append(\u0027locked\u0027)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"# NOTE: Below are the unchanged schema in this microversion. We need"},{"line_number":54,"context_line":"# to keep this schema in this file to have the generic way to select the"},{"line_number":55,"context_line":"# right schema based on self.schema_versions_info mapping in service client."},{"line_number":56,"context_line":"# ****** Schemas unchanged since microversion 2.8 ******"},{"line_number":57,"context_line":"show_server_diagnostics \u003d copy.deepcopy(servers.show_server_diagnostics)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_86ddc871","line":57,"range":{"start_line":53,"start_character":0,"end_line":57,"end_character":72},"in_reply_to":"3f79a3b5_7244eab7","updated":"2018-08-09 17:40:03.000000000","message":"Thanks, just saw that.","commit_id":"3d2f423cd0f9f09439cb2f5825ae0a5c6722236d"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"807bd00483c97c09c8a56dbcb45ac50fe471536e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"# NOTE: Below are the unchanged schema in this microversion. We need"},{"line_number":51,"context_line":"# to keep this schema in this file to have the generic way to select the"},{"line_number":52,"context_line":"# right schema based on self.schema_versions_info mapping in service client."},{"line_number":53,"context_line":"# ****** Schemas unchanged since microversion 2.6 ******"},{"line_number":54,"context_line":"list_servers \u003d copy.deepcopy(servers.list_servers)"},{"line_number":55,"context_line":"show_server_diagnostics \u003d copy.deepcopy(servers.show_server_diagnostics)"},{"line_number":56,"context_line":"# ****** Schemas unchanged since microversion 2.8 ******"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_74064f23","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":56},"updated":"2018-08-20 07:08:04.000000000","message":"as discussed, all unchanged schemas can be commented with \"# ****** Schemas unchanged since microversion 2.8 ******\"","commit_id":"8d327144c72352bdd105b7ff55d45e7803f693f8"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"6895526951f44c6700166d22bcb91c40c06adbf9","unresolved":false,"context_lines":[{"line_number":50,"context_line":"# NOTE: Below are the unchanged schema in this microversion. We need"},{"line_number":51,"context_line":"# to keep this schema in this file to have the generic way to select the"},{"line_number":52,"context_line":"# right schema based on self.schema_versions_info mapping in service client."},{"line_number":53,"context_line":"# ****** Schemas unchanged since microversion 2.6 ******"},{"line_number":54,"context_line":"list_servers \u003d copy.deepcopy(servers.list_servers)"},{"line_number":55,"context_line":"show_server_diagnostics \u003d copy.deepcopy(servers.show_server_diagnostics)"},{"line_number":56,"context_line":"# ****** Schemas unchanged since microversion 2.8 ******"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_42f4ae87","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":56},"in_reply_to":"3f79a3b5_74064f23","updated":"2018-08-20 14:06:06.000000000","message":"Thanks, I probably missed that comment, discussion somewhere.","commit_id":"8d327144c72352bdd105b7ff55d45e7803f693f8"}]}