)]}'
{"tempest/api/network/admin/test_routers.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"ee904f3da7528af53bbd41a9df04f91fad1b5c83","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    # as some router operations, such as enabling or disabling SNAT"},{"line_number":31,"context_line":"    # require admin credentials by default"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _cleanup_router(self, router):"},{"line_number":34,"context_line":"        self.delete_router(router)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _create_router(self, name\u003dNone, admin_state_up\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_f6cdca65","line":33,"range":{"start_line":33,"start_character":4,"end_line":33,"end_character":38},"updated":"2018-08-16 05:55:22.000000000","message":"ditto","commit_id":"906e284b7822c0beb3c873bfe57b593c38f006b6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"04429601ef1d57a1227d5be58018357063d9ae31","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    # as some router operations, such as enabling or disabling SNAT"},{"line_number":31,"context_line":"    # require admin credentials by default"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _cleanup_router(self, router):"},{"line_number":34,"context_line":"        self.delete_router(router)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _create_router(self, name\u003dNone, admin_state_up\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_15685cb8","line":33,"range":{"start_line":33,"start_character":4,"end_line":33,"end_character":38},"in_reply_to":"3f79a3b5_f6cdca65","updated":"2018-08-17 07:18:32.000000000","message":"ditto","commit_id":"906e284b7822c0beb3c873bfe57b593c38f006b6"}],"tempest/api/network/test_dhcp_ipv6.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"559a562e6ad727aee65f3d4d1d49fbcc55a7ca45","unresolved":false,"context_lines":[{"line_number":371,"context_line":"        self.routers.append(router)"},{"line_number":372,"context_line":"        port \u003d self.create_router_interface(router[\u0027id\u0027],"},{"line_number":373,"context_line":"                                            subnet[\u0027id\u0027])"},{"line_number":374,"context_line":"        body \u003d self.ports_client.show_port(port[\u0027port_id\u0027])"},{"line_number":375,"context_line":"        return subnet, body[\u0027port\u0027]"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"    @decorators.idempotent_id(\u0027e98f65db-68f4-4330-9fea-abd8c5192d4d\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_31dabe4a","line":374,"updated":"2018-08-12 16:30:18.000000000","message":"self.ports.append(port)","commit_id":"906e284b7822c0beb3c873bfe57b593c38f006b6"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"4f42e382ede85c1c2ca2b1a6f2856b4a24b69678","unresolved":false,"context_lines":[{"line_number":371,"context_line":"        self.routers.append(router)"},{"line_number":372,"context_line":"        port \u003d self.create_router_interface(router[\u0027id\u0027],"},{"line_number":373,"context_line":"                                            subnet[\u0027id\u0027])"},{"line_number":374,"context_line":"        body \u003d self.ports_client.show_port(port[\u0027port_id\u0027])"},{"line_number":375,"context_line":"        return subnet, body[\u0027port\u0027]"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"    @decorators.idempotent_id(\u0027e98f65db-68f4-4330-9fea-abd8c5192d4d\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_36826201","line":374,"in_reply_to":"3f79a3b5_31dabe4a","updated":"2018-08-16 05:49:33.000000000","message":"I tried it and found the port disappeared without \"self.ports.append(port)\", so I guess maybe remove_router_interface will remove the port.","commit_id":"906e284b7822c0beb3c873bfe57b593c38f006b6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"04429601ef1d57a1227d5be58018357063d9ae31","unresolved":false,"context_lines":[{"line_number":371,"context_line":"        self.routers.append(router)"},{"line_number":372,"context_line":"        port \u003d self.create_router_interface(router[\u0027id\u0027],"},{"line_number":373,"context_line":"                                            subnet[\u0027id\u0027])"},{"line_number":374,"context_line":"        body \u003d self.ports_client.show_port(port[\u0027port_id\u0027])"},{"line_number":375,"context_line":"        return subnet, body[\u0027port\u0027]"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"    @decorators.idempotent_id(\u0027e98f65db-68f4-4330-9fea-abd8c5192d4d\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_75a8b0da","line":374,"in_reply_to":"3f79a3b5_36826201","updated":"2018-08-17 07:18:32.000000000","message":"yeah that should be cleaned up automatically by remove_router_interface. main idea to append created resource in self.ports/routers etc is few list tests use them.","commit_id":"906e284b7822c0beb3c873bfe57b593c38f006b6"}],"tempest/api/network/test_routers.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"ee904f3da7528af53bbd41a9df04f91fad1b5c83","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class RoutersTest(base.BaseNetworkTest):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def _cleanup_router(self, router):"},{"line_number":31,"context_line":"        self.delete_router(router)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _create_router(self, name\u003dNone, admin_state_up\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_f6a4eaa7","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":38},"updated":"2018-08-16 05:55:22.000000000","message":"now this helper is only one line, so we can use delete_router directly.","commit_id":"906e284b7822c0beb3c873bfe57b593c38f006b6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"04429601ef1d57a1227d5be58018357063d9ae31","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class RoutersTest(base.BaseNetworkTest):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def _cleanup_router(self, router):"},{"line_number":31,"context_line":"        self.delete_router(router)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _create_router(self, name\u003dNone, admin_state_up\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_b5796894","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":38},"in_reply_to":"3f79a3b5_f6a4eaa7","updated":"2018-08-17 07:18:32.000000000","message":"that is being removed in other patch which leads me to push this patch. I will leave cleaning of these wrapper to that patch. - https://review.openstack.org/#/c/582832/","commit_id":"906e284b7822c0beb3c873bfe57b593c38f006b6"}]}