)]}'
{"tempest/api/compute/admin/test_quotas.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"acd58cc3747e4bb6e4c1e5f7ed1db9123c3557b8","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        self.assertEqual(ram_default, quota_set_new[\u0027ram\u0027])"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"class QuotasAdminTestV236(QuotasAdminTestBase):"},{"line_number":165,"context_line":"    min_microversion \u003d \u00272.36\u0027"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    @decorators.idempotent_id(\u0027ce9e0815-8091-4abd-8345-7fe5b85faa1d\u0027)"},{"line_number":168,"context_line":"    def test_get_updated_quotas(self):"},{"line_number":169,"context_line":"        self._get_updated_quotas()"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"class QuotasAdminTestV257(QuotasAdminTestBase):"},{"line_number":173,"context_line":"    min_microversion \u003d \u00272.57\u0027"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @decorators.idempotent_id(\u0027ce9e0815-8091-4abd-8345-7fe5b85faa1d\u0027)"},{"line_number":176,"context_line":"    def test_get_updated_quotas(self):"},{"line_number":177,"context_line":"        self._get_updated_quotas()"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"class QuotaClassesAdminTestJSON(base.BaseV2ComputeAdminTest):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_50aa34d2","line":177,"range":{"start_line":164,"start_character":0,"end_line":177,"end_character":34},"updated":"2018-08-08 03:05:09.000000000","message":"you need to add show_default_quota_set call also. may be use test at L98","commit_id":"7c9aae64ad4e844c34a7fecbaddfcf55b3f0087b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d3c1df4553ef58681e09d4a00d7593d7a32b3efc","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        self.assertEqual(ram_default, quota_set_new[\u0027ram\u0027])"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"class QuotasAdminTestV236(QuotasAdminTestBase):"},{"line_number":165,"context_line":"    min_microversion \u003d \u00272.36\u0027"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    @decorators.idempotent_id(\u0027ce9e0815-8091-4abd-8345-7fe5b85faa1d\u0027)"},{"line_number":168,"context_line":"    def test_get_updated_quotas(self):"},{"line_number":169,"context_line":"        self._get_updated_quotas()"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"class QuotasAdminTestV257(QuotasAdminTestBase):"},{"line_number":173,"context_line":"    min_microversion \u003d \u00272.57\u0027"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @decorators.idempotent_id(\u0027ce9e0815-8091-4abd-8345-7fe5b85faa1d\u0027)"},{"line_number":176,"context_line":"    def test_get_updated_quotas(self):"},{"line_number":177,"context_line":"        self._get_updated_quotas()"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"class QuotaClassesAdminTestJSON(base.BaseV2ComputeAdminTest):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_369669f2","line":177,"range":{"start_line":164,"start_character":0,"end_line":177,"end_character":34},"in_reply_to":"3f79a3b5_16c1142f","updated":"2018-08-09 14:24:09.000000000","message":"i see what you mean, so in that case either one work, calling show_quota_set with detail true OR call show_default_quota_set","commit_id":"7c9aae64ad4e844c34a7fecbaddfcf55b3f0087b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0ce02df71680e7edc423cb699c1363631899f960","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        self.assertEqual(ram_default, quota_set_new[\u0027ram\u0027])"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"class QuotasAdminTestV236(QuotasAdminTestBase):"},{"line_number":165,"context_line":"    min_microversion \u003d \u00272.36\u0027"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    @decorators.idempotent_id(\u0027ce9e0815-8091-4abd-8345-7fe5b85faa1d\u0027)"},{"line_number":168,"context_line":"    def test_get_updated_quotas(self):"},{"line_number":169,"context_line":"        self._get_updated_quotas()"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"class QuotasAdminTestV257(QuotasAdminTestBase):"},{"line_number":173,"context_line":"    min_microversion \u003d \u00272.57\u0027"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @decorators.idempotent_id(\u0027ce9e0815-8091-4abd-8345-7fe5b85faa1d\u0027)"},{"line_number":176,"context_line":"    def test_get_updated_quotas(self):"},{"line_number":177,"context_line":"        self._get_updated_quotas()"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"class QuotaClassesAdminTestJSON(base.BaseV2ComputeAdminTest):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_6b22e5a6","line":177,"range":{"start_line":164,"start_character":0,"end_line":177,"end_character":34},"in_reply_to":"3f79a3b5_501d540d","updated":"2018-08-08 04:37:29.000000000","message":"it is different. \n\nshow_quota_set use get_quota_set_details schema and show_default_quota_set use get_quota_set\n\n- https://review.openstack.org/#/c/589042/3/tempest/lib/services/compute/quotas_client.py","commit_id":"7c9aae64ad4e844c34a7fecbaddfcf55b3f0087b"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"b3cf3216887a9fca289511738f14c5601d67af2f","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        self.assertEqual(ram_default, quota_set_new[\u0027ram\u0027])"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"class QuotasAdminTestV236(QuotasAdminTestBase):"},{"line_number":165,"context_line":"    min_microversion \u003d \u00272.36\u0027"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    @decorators.idempotent_id(\u0027ce9e0815-8091-4abd-8345-7fe5b85faa1d\u0027)"},{"line_number":168,"context_line":"    def test_get_updated_quotas(self):"},{"line_number":169,"context_line":"        self._get_updated_quotas()"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"class QuotasAdminTestV257(QuotasAdminTestBase):"},{"line_number":173,"context_line":"    min_microversion \u003d \u00272.57\u0027"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @decorators.idempotent_id(\u0027ce9e0815-8091-4abd-8345-7fe5b85faa1d\u0027)"},{"line_number":176,"context_line":"    def test_get_updated_quotas(self):"},{"line_number":177,"context_line":"        self._get_updated_quotas()"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"class QuotaClassesAdminTestJSON(base.BaseV2ComputeAdminTest):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_501d540d","line":177,"range":{"start_line":164,"start_character":0,"end_line":177,"end_character":34},"in_reply_to":"3f79a3b5_50aa34d2","updated":"2018-08-08 03:22:35.000000000","message":"o, show_default_quota_set uses the same schema \"get_quota_set\" as show_quota_set, then do we need to call show_default_quota_set?","commit_id":"7c9aae64ad4e844c34a7fecbaddfcf55b3f0087b"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"ddf6decdb3726a57b1ace03a32ec062744864b84","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        self.assertEqual(ram_default, quota_set_new[\u0027ram\u0027])"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"class QuotasAdminTestV236(QuotasAdminTestBase):"},{"line_number":165,"context_line":"    min_microversion \u003d \u00272.36\u0027"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    @decorators.idempotent_id(\u0027ce9e0815-8091-4abd-8345-7fe5b85faa1d\u0027)"},{"line_number":168,"context_line":"    def test_get_updated_quotas(self):"},{"line_number":169,"context_line":"        self._get_updated_quotas()"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"class QuotasAdminTestV257(QuotasAdminTestBase):"},{"line_number":173,"context_line":"    min_microversion \u003d \u00272.57\u0027"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @decorators.idempotent_id(\u0027ce9e0815-8091-4abd-8345-7fe5b85faa1d\u0027)"},{"line_number":176,"context_line":"    def test_get_updated_quotas(self):"},{"line_number":177,"context_line":"        self._get_updated_quotas()"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"class QuotaClassesAdminTestJSON(base.BaseV2ComputeAdminTest):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_16c1142f","line":177,"range":{"start_line":164,"start_character":0,"end_line":177,"end_character":34},"in_reply_to":"3f79a3b5_6b22e5a6","updated":"2018-08-08 06:39:38.000000000","message":"Because show_quota_set uses schema get_quota_set when detail is False and uses schema get_quota_set_details when detail is True,\nso this is also to change one get_quota_set calling to be with detail\u003dTrue, so to cover the schema check of get_quota_set_details.","commit_id":"7c9aae64ad4e844c34a7fecbaddfcf55b3f0087b"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"0a1d32df654ed88b0aea861e9eb26be44b077275","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                        project_id)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        self.adm_client.update_quota_set(project_id, ram\u003d\u00275120\u0027)"},{"line_number":52,"context_line":"        quota_set \u003d self.adm_client.show_quota_set("},{"line_number":53,"context_line":"            project_id, detail\u003dTrue)[\u0027quota_set\u0027]"},{"line_number":54,"context_line":"        self.assertEqual(5120, quota_set[\u0027ram\u0027][\u0027limit\u0027])"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        # Verify that GET shows the updated quota set of user"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_9f79a294","line":53,"range":{"start_line":52,"start_character":8,"end_line":53,"end_character":49},"updated":"2018-08-09 01:29:07.000000000","message":"A NOTE above this saying why this one is detail\u003dTrue and why the one on L70 is detail\u003dFalse for schema response body coverage would be helpful","commit_id":"f0752377e577db5c085d251808401c0048cd77cb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e14a62a2aaac72238f2f0ee6e2e65923ae03cde9","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                        project_id)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        self.adm_client.update_quota_set(project_id, ram\u003d\u00275120\u0027)"},{"line_number":52,"context_line":"        quota_set \u003d self.adm_client.show_quota_set("},{"line_number":53,"context_line":"            project_id, detail\u003dTrue)[\u0027quota_set\u0027]"},{"line_number":54,"context_line":"        self.assertEqual(5120, quota_set[\u0027ram\u0027][\u0027limit\u0027])"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        # Verify that GET shows the updated quota set of user"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_314e736f","line":53,"range":{"start_line":52,"start_character":8,"end_line":53,"end_character":49},"in_reply_to":"3f79a3b5_36642922","updated":"2018-08-09 14:33:15.000000000","message":"Done","commit_id":"f0752377e577db5c085d251808401c0048cd77cb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ed1db05af3b94e25b3ac869554f487fa6752aa2b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                        project_id)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        self.adm_client.update_quota_set(project_id, ram\u003d\u00275120\u0027)"},{"line_number":52,"context_line":"        quota_set \u003d self.adm_client.show_quota_set("},{"line_number":53,"context_line":"            project_id, detail\u003dTrue)[\u0027quota_set\u0027]"},{"line_number":54,"context_line":"        self.assertEqual(5120, quota_set[\u0027ram\u0027][\u0027limit\u0027])"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        # Verify that GET shows the updated quota set of user"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_36642922","line":53,"range":{"start_line":52,"start_character":8,"end_line":53,"end_character":49},"in_reply_to":"3f79a3b5_9f79a294","updated":"2018-08-09 14:25:18.000000000","message":"i think Note on microvesion test can be added instead of here as this is used for other tests class also.","commit_id":"f0752377e577db5c085d251808401c0048cd77cb"}],"tempest/lib/api_schema/response/compute/v2_36/quotas.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"753348490d8aec4e3864a19cbfe21f80fcebe8b2","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        \u0027properties\u0027].pop(item)"},{"line_number":40,"context_line":"    get_quota_set[\u0027response_body\u0027][\u0027properties\u0027][\u0027quota_set\u0027]["},{"line_number":41,"context_line":"        \u0027required\u0027].remove(item)"},{"line_number":42,"context_line":"    "},{"line_number":43,"context_line":"get_quota_set_details \u003d copy.deepcopy(quotasv21.get_quota_set_details)"},{"line_number":44,"context_line":"for item in remove_item_list:"},{"line_number":45,"context_line":"    get_quota_set_details[\u0027response_body\u0027][\u0027properties\u0027][\u0027quota_set\u0027]["}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_d2e18fd2","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":4},"updated":"2018-08-06 15:51:08.000000000","message":"WS","commit_id":"413fdd30fac4b34d55a31c4103dfd0232a9d857a"}],"tempest/lib/api_schema/response/compute/v2_57/quotas.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"753348490d8aec4e3864a19cbfe21f80fcebe8b2","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        \u0027properties\u0027].pop(item)"},{"line_number":39,"context_line":"    get_quota_set[\u0027response_body\u0027][\u0027properties\u0027][\u0027quota_set\u0027]["},{"line_number":40,"context_line":"        \u0027required\u0027].remove(item)"},{"line_number":41,"context_line":"    "},{"line_number":42,"context_line":"get_quota_set_details \u003d copy.deepcopy(quotasv236.get_quota_set_details)"},{"line_number":43,"context_line":"for item in remove_item_list:"},{"line_number":44,"context_line":"    get_quota_set_details[\u0027response_body\u0027][\u0027properties\u0027][\u0027quota_set\u0027]["}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_12c2a734","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":4},"updated":"2018-08-06 15:51:08.000000000","message":"WS","commit_id":"413fdd30fac4b34d55a31c4103dfd0232a9d857a"}]}