)]}'
{"tempest/api/compute/servers/test_server_actions.py":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"8a4638bb6a1d324439a447d69ecfb6a14a6ed24e","unresolved":false,"context_lines":[{"line_number":294,"context_line":"    def test_get_console_output_server_id_in_reboot_status(self):"},{"line_number":295,"context_line":"        # Positive test:Should be able to GET the console output"},{"line_number":296,"context_line":"        # for a given server_id in reboot status"},{"line_number":297,"context_line":"        resp, output \u003d self.servers_client.reboot(self.server_id, \u0027SOFT\u0027)"},{"line_number":298,"context_line":"        self.servers_client.wait_for_server_status(self.server_id,"},{"line_number":299,"context_line":"                                                   \u0027REBOOT\u0027)"},{"line_number":300,"context_line":"        resp, output \u003d self.servers_client.get_console_output(self.server_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BLVk%3D","side":"PARENT","line":297,"updated":"2013-11-29 17:16:47.000000000","message":"Do a HARD reboot.","commit_id":"e6967905a9d4e86d6c1374dbab10d8d980389d6c"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"8a4638bb6a1d324439a447d69ecfb6a14a6ed24e","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        resp, output \u003d self.servers_client.reboot(self.server_id, \u0027SOFT\u0027)"},{"line_number":298,"context_line":"        self.servers_client.wait_for_server_status(self.server_id,"},{"line_number":299,"context_line":"                                                   \u0027REBOOT\u0027)"},{"line_number":300,"context_line":"        resp, output \u003d self.servers_client.get_console_output(self.server_id,"},{"line_number":301,"context_line":"                                                              10)"},{"line_number":302,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":303,"context_line":"        self.assertIsNotNone(output)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BLVU%3D","side":"PARENT","line":300,"updated":"2013-11-29 17:16:47.000000000","message":"Wait for 10 lines instead of the REBOOT status.","commit_id":"e6967905a9d4e86d6c1374dbab10d8d980389d6c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"70a7fddfd3092593836fc8913194dc2107a4325e","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        resp, output \u003d self.servers_client.reboot(self.server_id, \u0027SOFT\u0027)"},{"line_number":298,"context_line":"        self.servers_client.wait_for_server_status(self.server_id,"},{"line_number":299,"context_line":"                                                   \u0027REBOOT\u0027)"},{"line_number":300,"context_line":"        resp, output \u003d self.servers_client.get_console_output(self.server_id,"},{"line_number":301,"context_line":"                                                              10)"},{"line_number":302,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":303,"context_line":"        self.assertIsNotNone(output)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BJQ0%3D","side":"PARENT","line":300,"in_reply_to":"AAAATn%2F%2BLVU%3D","updated":"2013-12-02 00:32:59.000000000","message":"I guess this test purpose is verifying we can get console log in any server states such as \"REBOOT\". If just waiting for 10 lines instead, we don\u0027t necessarily verify it.\n\nHow about the following test case instead of current one?\n\n 1. stop a server\n 2. get console log of the stopped server\n 3. re-start the server\n\n\"REBOOT\" is ephemeral, but \"SHUTOFF\" is not. So we can verify it is possible to get console log in non \"ACTIVE\" state server.","commit_id":"e6967905a9d4e86d6c1374dbab10d8d980389d6c"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"9393316d27c9576052e8ddba5180de50863c78d4","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":303,"context_line":"        self.assertIsNotNone(output)"},{"line_number":304,"context_line":"        lines \u003d len(output.split(\u0027\\n\u0027))"},{"line_number":305,"context_line":"        self.assertEqual(lines, 10)"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        resp, server \u003d self.servers_client.start(self.server_id)"},{"line_number":308,"context_line":"        self.assertEqual(202, resp.status)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F92R0%3D","line":305,"updated":"2013-12-05 09:34:31.000000000","message":"why not merge this in the test: test_stop_start_server ? or use addCleanup to restart the server?","commit_id":"df72dacd7cf4b662998b12a6513de7ced789d927"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"9233f3ce7e47b9b05d47d13cc405e9d96b03ae21","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":303,"context_line":"        self.assertIsNotNone(output)"},{"line_number":304,"context_line":"        lines \u003d len(output.split(\u0027\\n\u0027))"},{"line_number":305,"context_line":"        self.assertEqual(lines, 10)"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        resp, server \u003d self.servers_client.start(self.server_id)"},{"line_number":308,"context_line":"        self.assertEqual(202, resp.status)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F92LI%3D","line":305,"in_reply_to":"AAAATn%2F92R0%3D","updated":"2013-12-05 09:56:04.000000000","message":"\u003e why not merge this in the test: test_stop_start_server ?\n\nbecause the purpose seems different.\nThis test is for getting console output during \"SHUTOFF\"(the original is \"REBOOT\").\nBy separating these tests, we can understand the situation easily if either test fails.\n\n\u003e use addCleanup to restart the server?\n\nThat would be good idea, thanks!\nI will apply it.","commit_id":"df72dacd7cf4b662998b12a6513de7ced789d927"}]}