)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a7d0cc6fc32c8cec33419f1869abbdc87aaf79af","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replace assertGreaterEqual - is not in py26 testtools"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes Bug 1256187"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I57c7a3b7645228deafcb409866acc1b6a00e2851"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F%2BL3A%3D","line":9,"updated":"2013-11-29 14:25:59.000000000","message":"The link to launchpad isn\u0027t working, should be:\n\nCloses-Bug: #1256187","commit_id":"7dedb3642e16d2b4285ea9978dca724d944d6cc6"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"07e53770d286a49dea4c6a7e06c2e84f95e31fda","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replace assertGreaterEqual - is not in py26 testtools"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes Bug 1256187"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I57c7a3b7645228deafcb409866acc1b6a00e2851"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F%2BJHs%3D","line":9,"in_reply_to":"AAAATn%2F%2BL3A%3D","updated":"2013-12-02 02:01:04.000000000","message":"Thank you, Matt!","commit_id":"7dedb3642e16d2b4285ea9978dca724d944d6cc6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"78aa421a3174c2238fada1e907d5e5bcb67d90a5","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2013-12-02 10:00:42 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replace assertGreaterEqual - is not in py26 testtools"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1256187"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I57c7a3b7645228deafcb409866acc1b6a00e2851"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2BG%2FU%3D","line":8,"updated":"2013-12-02 14:40:40.000000000","message":"The commit message is a bit sparse for my tastes, even copying in your bug report information would be better. Don\u0027t assume that someone has an internet connection when checking the git logs, i.e. can\u0027t assume they can get to the bug report in launchpad.\n\nSee the 2nd bullet here:\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages","commit_id":"1cecbf89ebfebe3dc378a1281bce9d6862ef601d"}],"tempest/api/volume/test_volume_transfers.py":[{"author":{"_account_id":97,"name":"Daryl Walleck","email":"daryl.walleck@rackspace.com","username":"dwalleck"},"change_message_id":"c0dc3a090f2f1e2706733622231f534db30be588","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        # or equal to 1"},{"line_number":84,"context_line":"        resp, body \u003d self.client.list_volume_transfers()"},{"line_number":85,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":86,"context_line":"        self.assertTrue(len(body) \u003e\u003d 1, str(body))"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # Accept a volume transfer by alt_tenant"},{"line_number":89,"context_line":"        resp, body \u003d self.alt_client.accept_volume_transfer(transfer_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BI9c%3D","line":86,"updated":"2013-12-02 03:51:41.000000000","message":"By switching to assertTrue, you\u0027re losing any useful messaging that comes along with using the specialized asserts. To me this seems like a step back","commit_id":"1cecbf89ebfebe3dc378a1281bce9d6862ef601d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"78aa421a3174c2238fada1e907d5e5bcb67d90a5","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        # or equal to 1"},{"line_number":84,"context_line":"        resp, body \u003d self.client.list_volume_transfers()"},{"line_number":85,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":86,"context_line":"        self.assertTrue(len(body) \u003e\u003d 1, str(body))"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # Accept a volume transfer by alt_tenant"},{"line_number":89,"context_line":"        resp, body \u003d self.alt_client.accept_volume_transfer(transfer_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BHAg%3D","line":86,"in_reply_to":"AAAATn%2F%2BI9c%3D","updated":"2013-12-02 14:40:40.000000000","message":"Could you use testtools.matchers.GreaterThan and then do something like this?\n\nfrom testtools.matchers import GreaterThan\n\n...\n\nself.assertThat(len(body), GreaterThan(0))\n\n?\n\nI use testtools.matchers in this nova patch per Robert Collins\u0027 (lifeless) suggestion:\n\nhttps://review.openstack.org/#/c/52519/5/nova/tests/compute/test_compute.py","commit_id":"1cecbf89ebfebe3dc378a1281bce9d6862ef601d"}]}