)]}'
{"tempest/api/compute/v3/servers/test_instance_actions.py":[{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"88ac80db67d161dc7ada3fd6e122afdcf33993dc","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        cls.request_id \u003d resp[\u0027x-compute-request-id\u0027]"},{"line_number":33,"context_line":"        cls.server_id \u003d server[\u0027id\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @skip_because(bug\u003d\"1206032\")"},{"line_number":36,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":37,"context_line":"    def test_list_server_actions(self):"},{"line_number":38,"context_line":"        # List actions of the provided server"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F83d4%3D","line":35,"updated":"2013-12-19 12:28:48.000000000","message":"why do you need to skip this test and don\u0027t need to skip the negatives? after all they use the same resource in the same url so they probably should get a 400/badrequest instead of 404 as L67 expects","commit_id":"9f46aafacb126f36a8281eb318a7ca7b1e8f86d0"},{"author":{"_account_id":6124,"name":"Rohan Kanade","email":"openstack@rohankanade.com","username":"kanaderohan"},"change_message_id":"e196e8b40cb62744c45728db6fb625de6987e8ea","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        cls.request_id \u003d resp[\u0027x-compute-request-id\u0027]"},{"line_number":33,"context_line":"        cls.server_id \u003d server[\u0027id\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @skip_because(bug\u003d\"1206032\")"},{"line_number":36,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":37,"context_line":"    def test_list_server_actions(self):"},{"line_number":38,"context_line":"        # List actions of the provided server"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F821U%3D","line":35,"in_reply_to":"AAAATn%2F83d4%3D","updated":"2013-12-19 14:37:00.000000000","message":"it is because both negative tests check if \"NotFound\" exception is raised, which is the actual exception raised since the extension path \"os-instance-actions/\" is not found (because name of ext is changed to \"os-server-actions/\").\n\nAnd since this change is temporary, it doesnt matter much, I have explained this same issue in a comment earlier in this review","commit_id":"9f46aafacb126f36a8281eb318a7ca7b1e8f86d0"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"88ac80db67d161dc7ada3fd6e122afdcf33993dc","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        resp, body \u003d self.client.get_server_action(self.server_id,"},{"line_number":53,"context_line":"                                                   self.request_id)"},{"line_number":54,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":55,"context_line":"        self.assertEqual(self.server_id, body[\u0027instance_uuid\u0027])"},{"line_number":56,"context_line":"        self.assertEqual(\u0027create\u0027, body[\u0027action\u0027])"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027gate\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F83cM%3D","line":55,"updated":"2013-12-19 12:28:48.000000000","message":"to be consistent, body[\u0027instance_uuid\u0027] should become body[\u0027server_id\u0027] or body[\u0027server_uuid\u0027]... of course that is a change on nova first and following their standards ( if it server_uuid or server_id)","commit_id":"9f46aafacb126f36a8281eb318a7ca7b1e8f86d0"},{"author":{"_account_id":6124,"name":"Rohan Kanade","email":"openstack@rohankanade.com","username":"kanaderohan"},"change_message_id":"e196e8b40cb62744c45728db6fb625de6987e8ea","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        resp, body \u003d self.client.get_server_action(self.server_id,"},{"line_number":53,"context_line":"                                                   self.request_id)"},{"line_number":54,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":55,"context_line":"        self.assertEqual(self.server_id, body[\u0027instance_uuid\u0027])"},{"line_number":56,"context_line":"        self.assertEqual(\u0027create\u0027, body[\u0027action\u0027])"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027gate\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F821M%3D","line":55,"in_reply_to":"AAAATn%2F83cM%3D","updated":"2013-12-19 14:37:00.000000000","message":"Sure, once the Nova patch gets in, this will be changed in another patch to \"server_uuid\" and the @skip decorator will be reverted.","commit_id":"9f46aafacb126f36a8281eb318a7ca7b1e8f86d0"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"0db0db304d27ff5931d26fa7e13a0057296f2c55","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        resp, body \u003d self.client.get_server_action(self.server_id,"},{"line_number":53,"context_line":"                                                   self.request_id)"},{"line_number":54,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":55,"context_line":"        self.assertEqual(self.server_id, body[\u0027instance_uuid\u0027])"},{"line_number":56,"context_line":"        self.assertEqual(\u0027create\u0027, body[\u0027action\u0027])"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027gate\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2FAO0%3D","line":55,"updated":"2014-01-19 13:56:24.000000000","message":"This will need to change to server_uuid now","commit_id":"5ac16e1766af93b88dd1219837582ce05404f0a1"},{"author":{"_account_id":6124,"name":"Rohan Kanade","email":"openstack@rohankanade.com","username":"kanaderohan"},"change_message_id":"d616139abdedb46fd0e1034ae42d08d522c94b57","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        resp, body \u003d self.client.get_server_action(self.server_id,"},{"line_number":53,"context_line":"                                                   self.request_id)"},{"line_number":54,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":55,"context_line":"        self.assertEqual(self.server_id, body[\u0027instance_uuid\u0027])"},{"line_number":56,"context_line":"        self.assertEqual(\u0027create\u0027, body[\u0027action\u0027])"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027gate\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2B%2Fs0%3D","line":55,"in_reply_to":"AAAAUH%2F%2FAO0%3D","updated":"2014-01-19 20:34:36.000000000","message":"Done","commit_id":"5ac16e1766af93b88dd1219837582ce05404f0a1"}]}
