)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"622fc39d82d37eeb36f7405112d6fdd76793b427","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Part 1 does some initial refactoring and Part 2 will move the tests"},{"line_number":13,"context_line":"and finish any other refactoring that\u0027s needed."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Notes on refactor:"},{"line_number":16,"context_line":"  * removing usage of non_domain_enabled_user so that I can run the"},{"line_number":17,"context_line":"    tests with os_primary\u0027s user except for tests that are not targeted"},{"line_number":18,"context_line":"    for pre-prov."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_a455a3fc","line":15,"updated":"2018-08-18 15:24:44.000000000","message":"We shouldn\u0027t be removing coverage for email validation and so forth. This change is too invasive as is. Sanity-checking important functionality is more important than compatibility with pre-provisioned credentials. If this can\u0027t be refactored in a way that works with pre-provisioned credentials, then a decorator can be applied to selective tests to skip them.","commit_id":"c1a941c7a16139254040297e64a0cb2ca2d53be4"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"e92fd3e5df24eaed6c2a66ef06c94f73dcb354d1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Part 1 does some initial refactoring and Part 2 will move the tests"},{"line_number":13,"context_line":"and finish any other refactoring that\u0027s needed."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Notes on refactor:"},{"line_number":16,"context_line":"  * removing usage of non_domain_enabled_user so that I can run the"},{"line_number":17,"context_line":"    tests with os_primary\u0027s user except for tests that are not targeted"},{"line_number":18,"context_line":"    for pre-prov."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_5f080727","line":15,"in_reply_to":"3f79a3b5_a455a3fc","updated":"2018-08-20 12:53:55.000000000","message":"so every test must do email validation, or is one enough to satisfy the coverage? I can implement my note on test_list_users and see if that looks better.","commit_id":"c1a941c7a16139254040297e64a0cb2ca2d53be4"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"7a5734c4ef008532b0e486bd12080ef82c1bea10","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  * removing alt_email as os_primary\u0027s user does not have the email"},{"line_number":20,"context_line":"    attribute."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Warning on test completeness:"},{"line_number":23,"context_line":"  * I realize some of these tests are intended to check for exclusion of"},{"line_number":24,"context_line":"    certain users in the user list which is now lost due to the removal"},{"line_number":25,"context_line":"    of the non_domain_enabled_user."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_387f85ac","line":22,"updated":"2018-08-17 15:55:49.000000000","message":"I may have to exclude test_list_users from the moved tests in order to complete the testing of the user list api w.r.t domains because the non_domain_enabled_user does not have a domain given on creation where the other user does.\n\nThe other tests are testing that listing users with non-default attributes still works.","commit_id":"c1a941c7a16139254040297e64a0cb2ca2d53be4"}],"tempest/api/identity/admin/v3/test_list_users.py":[{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"82c4a833c8eceaaf7d9c3ee1c57c851c08135436","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def _list_users_with_params(self, params, key, included, excluded):"},{"line_number":27,"context_line":"        # Helper method to list users filtered with params and"},{"line_number":28,"context_line":"        # assert the response based on expected and not_expected"},{"line_number":29,"context_line":"        # included: users expected in the list response"},{"line_number":30,"context_line":"        # excluded: users, which should not be present in list response"},{"line_number":31,"context_line":"        body \u003d self.users_client.list_users(**params)[\u0027users\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_adeca7f3","line":28,"range":{"start_line":28,"start_character":39,"end_line":28,"end_character":64},"updated":"2018-08-19 07:18:38.000000000","message":"nit: \nexpected -\u003e included\nnot_expected -\u003e excluded","commit_id":"c1a941c7a16139254040297e64a0cb2ca2d53be4"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"82c4a833c8eceaaf7d9c3ee1c57c851c08135436","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        cls.users.append(cls.domain_enabled_user)"},{"line_number":56,"context_line":"        # Create default not enabled user"},{"line_number":57,"context_line":"        cls.non_domain_enabled_user \u003d cls.users_client.create_user("},{"line_number":58,"context_line":"            name\u003dalt_user, password\u003dalt_password, enabled\u003dFalse)[\u0027user\u0027]"},{"line_number":59,"context_line":"        cls.addClassResourceCleanup(cls.users_client.delete_user,"},{"line_number":60,"context_line":"                                    cls.non_domain_enabled_user[\u0027id\u0027])"},{"line_number":61,"context_line":"        cls.users.append(cls.non_domain_enabled_user)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_2dbad7dd","line":58,"range":{"start_line":58,"start_character":17,"end_line":58,"end_character":25},"updated":"2018-08-19 07:18:38.000000000","message":"nit: I think both users should be in same convention.\ne.g. user1: u1_name then user2 should be u2_name\nor\nprimary_user/main_user for user1 if we user alt_user for user2","commit_id":"c1a941c7a16139254040297e64a0cb2ca2d53be4"}]}