)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"1c925e18568394976768b30d3e5acf052b5765a2","unresolved":false,"context_lines":[{"line_number":334,"context_line":"                    raise"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"            new_status \u003d thing.status"},{"line_number":337,"context_line":"            if new_status.lower() \u003d\u003d error_status.lower():"},{"line_number":338,"context_line":"                message \u003d \"%s failed to get to expected status. \\"},{"line_number":339,"context_line":"                          In %s state.\" % (thing, new_status)"},{"line_number":340,"context_line":"                raise exceptions.BuildErrorException(message)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9SKA%3D","line":337,"updated":"2013-12-13 02:28:57.000000000","message":"is this mentioned in the commit message?","commit_id":"20cdb872da6de63f433a99a7e24ff0c836761bba"}],"tempest/scenario/test_network_basic_ops.py":[{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"1c925e18568394976768b30d3e5acf052b5765a2","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        for to_del in to_delete:"},{"line_number":67,"context_line":"            del self.unchecked[to_del]"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        return len(self.unchecked) \u003d\u003d 0"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"class TestNetworkBasicOps(manager.NetworkScenarioTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9SKY%3D","line":69,"updated":"2013-12-13 02:28:57.000000000","message":"Can we please print (log.debug) what is in self.unchecked? hoping this information would be useful when searching logs/debugging.","commit_id":"20cdb872da6de63f433a99a7e24ff0c836761bba"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"85236d71e8ee900c0c8d98d627396847f4fd1e94","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        cls.servers \u003d []"},{"line_number":162,"context_line":"        cls.floating_ips \u003d {}"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    @classmethod"},{"line_number":165,"context_line":"    def tearDownClass(cls):"},{"line_number":166,"context_line":"        super(TestNetworkBasicOps, cls).tearDownClass()"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9k9c%3D","line":164,"updated":"2013-12-10 01:51:16.000000000","message":"This method is not needed.","commit_id":"20cdb872da6de63f433a99a7e24ff0c836761bba"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"1c925e18568394976768b30d3e5acf052b5765a2","unresolved":false,"context_lines":[{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        self.assertTrue("},{"line_number":291,"context_line":"            tempest.test.call_until_true("},{"line_number":292,"context_line":"                ip_tracker.run_checks, self.config.compute.build_timeout, 5),"},{"line_number":293,"context_line":"            \"Timed out while waiting for the floating IP assignments \""},{"line_number":294,"context_line":"            \"to propagate\")"},{"line_number":295,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9SKk%3D","line":292,"updated":"2013-12-13 02:28:57.000000000","message":"is 5 seconds enough?","commit_id":"20cdb872da6de63f433a99a7e24ff0c836761bba"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3a749f0d573c3fc0e86ac5efcef76246337e3334","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        \"\"\""},{"line_number":57,"context_line":"        to_delete \u003d []"},{"line_number":58,"context_line":"        loggable_map \u003d {}"},{"line_number":59,"context_line":"        for k, check_addrs in self.unchecked.iteritems():"},{"line_number":60,"context_line":"            serverdata \u003d self.compute_client.servers.get(k.id)"},{"line_number":61,"context_line":"            for net_name, ip_addr in serverdata.networks.iteritems():"},{"line_number":62,"context_line":"                for addr in ip_addr:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9M0Y%3D","line":59,"updated":"2013-12-14 11:10:52.000000000","message":"it\u0027s better to use .items() if python3 compatibility is concerned.","commit_id":"c26d452730a88b7ede922acdd17683457298f93d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3a749f0d573c3fc0e86ac5efcef76246337e3334","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        loggable_map \u003d {}"},{"line_number":59,"context_line":"        for k, check_addrs in self.unchecked.iteritems():"},{"line_number":60,"context_line":"            serverdata \u003d self.compute_client.servers.get(k.id)"},{"line_number":61,"context_line":"            for net_name, ip_addr in serverdata.networks.iteritems():"},{"line_number":62,"context_line":"                for addr in ip_addr:"},{"line_number":63,"context_line":"                    if addr in check_addrs:"},{"line_number":64,"context_line":"                        check_addrs.remove(addr)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9M0U%3D","line":61,"updated":"2013-12-14 11:10:52.000000000","message":"same as above","commit_id":"c26d452730a88b7ede922acdd17683457298f93d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3a749f0d573c3fc0e86ac5efcef76246337e3334","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                for addr in ip_addr:"},{"line_number":63,"context_line":"                    if addr in check_addrs:"},{"line_number":64,"context_line":"                        check_addrs.remove(addr)"},{"line_number":65,"context_line":"            if len(check_addrs) \u003d\u003d 0:"},{"line_number":66,"context_line":"                to_delete.append(k)"},{"line_number":67,"context_line":"            else:"},{"line_number":68,"context_line":"                loggable_map[k.id] \u003d check_addrs"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9M0g%3D","line":65,"updated":"2013-12-14 11:10:52.000000000","message":"python stylistic nit: \n if not check_addrs:","commit_id":"c26d452730a88b7ede922acdd17683457298f93d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3a749f0d573c3fc0e86ac5efcef76246337e3334","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        LOG.debug(\u0027Unchecked floating IPs: %s\u0027,"},{"line_number":74,"context_line":"                  jsonutils.dumps(loggable_map))"},{"line_number":75,"context_line":"        return len(self.unchecked) \u003d\u003d 0"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"class TestNetworkBasicOps(manager.NetworkScenarioTest):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9M0Q%3D","line":75,"updated":"2013-12-14 11:10:52.000000000","message":"nit: return not self.unchecked","commit_id":"c26d452730a88b7ede922acdd17683457298f93d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3a749f0d573c3fc0e86ac5efcef76246337e3334","unresolved":false,"context_lines":[{"line_number":276,"context_line":"        private_key \u003d self.keypairs[self.tenant_id].private_key"},{"line_number":277,"context_line":"        try:"},{"line_number":278,"context_line":"            for server in self.servers:"},{"line_number":279,"context_line":"                for net_name, ip_addresses in server.networks.iteritems():"},{"line_number":280,"context_line":"                    for ip_address in ip_addresses:"},{"line_number":281,"context_line":"                        self._check_vm_connectivity(ip_address, ssh_login,"},{"line_number":282,"context_line":"                                                    private_key)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9M0M%3D","line":279,"updated":"2013-12-14 11:10:52.000000000","message":"same on iteritems","commit_id":"c26d452730a88b7ede922acdd17683457298f93d"}]}