)]}'
{"tempest/api/compute/admin/test_live_migration.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"59e4d65203fff9da164777f356291b3f29102fa9","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class LiveMigrationTestBase(base.BaseV2ComputeAdminTest):"},{"line_number":33,"context_line":"    max_microversion \u003d \u00272.24\u0027"},{"line_number":34,"context_line":"    block_migration \u003d None"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_937ac1b7","line":33,"range":{"start_line":33,"start_character":4,"end_line":33,"end_character":29},"updated":"2018-08-23 05:17:12.000000000","message":"nit: we should remove this now","commit_id":"58a7325e768703d2123e1be83e89bb01c5078b84"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"a400394d1556f01c0b5280b6fc13bcd9d46ca7aa","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class LiveMigrationTestBase(base.BaseV2ComputeAdminTest):"},{"line_number":33,"context_line":"    max_microversion \u003d \u00272.24\u0027"},{"line_number":34,"context_line":"    block_migration \u003d None"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_d6f6e7d7","line":33,"range":{"start_line":33,"start_character":4,"end_line":33,"end_character":29},"in_reply_to":"3f79a3b5_937ac1b7","updated":"2018-08-23 05:47:03.000000000","message":"nice catch, done","commit_id":"58a7325e768703d2123e1be83e89bb01c5078b84"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8a9240c05381cfc3dbcb3203323d7007702cfcff","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class LiveMigrationTest(base.BaseV2ComputeAdminTest):"},{"line_number":33,"context_line":"    max_microversion \u003d \u00272.24\u0027"},{"line_number":34,"context_line":"    block_migration \u003d None"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @classmethod"},{"line_number":37,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_80efb01b","side":"PARENT","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":26},"updated":"2018-08-24 01:23:56.000000000","message":"nit: I think block_migration was OK here because it is used on L66 and classes like LiveMigrationRemoteConsolesV26Test inherit from this but don\u0027t specify block_migration. Which means that if those classes call `_migrate_server_to` they will blow up with a NameError.\n\nSo we should re-include this line here in case in the future those classes decide to use `_migrate_server_to`.","commit_id":"4959096c662b3e98334acf9ff02e752527bf5cc6"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"2306d672c4904f359216a8cb25b44fc724de4d03","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class LiveMigrationTest(base.BaseV2ComputeAdminTest):"},{"line_number":33,"context_line":"    max_microversion \u003d \u00272.24\u0027"},{"line_number":34,"context_line":"    block_migration \u003d None"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @classmethod"},{"line_number":37,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_e0946439","side":"PARENT","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":26},"in_reply_to":"3f79a3b5_80efb01b","updated":"2018-08-24 01:40:34.000000000","message":"Yes I ever thought of keeping this, and I finally remove it because \"getattr(self, \u0027block_migration\u0027, None)\" won\u0027t throw exception even if attr \u0027block_migration\u0027 doesn\u0027t exist.","commit_id":"4959096c662b3e98334acf9ff02e752527bf5cc6"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"eb11fd9d7ce1b40d6af5cc56045e99ffbb9a62c0","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class LiveMigrationTest(base.BaseV2ComputeAdminTest):"},{"line_number":33,"context_line":"    max_microversion \u003d \u00272.24\u0027"},{"line_number":34,"context_line":"    block_migration \u003d None"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @classmethod"},{"line_number":37,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ae065d85","side":"PARENT","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":26},"in_reply_to":"3f79a3b5_e0946439","updated":"2018-08-24 03:44:32.000000000","message":"Oh, I see. I missed that line, so this change is OK then.","commit_id":"4959096c662b3e98334acf9ff02e752527bf5cc6"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"eb11fd9d7ce1b40d6af5cc56045e99ffbb9a62c0","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        self.assertIn(data, console_output)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"class LiveAutoBlockMigrationV225Test(LiveMigrationTest):"},{"line_number":246,"context_line":"    min_microversion \u003d \u00272.25\u0027"},{"line_number":247,"context_line":"    max_microversion \u003d \u0027latest\u0027"},{"line_number":248,"context_line":"    block_migration \u003d \u0027auto\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_2efa4d74","line":245,"range":{"start_line":245,"start_character":37,"end_line":245,"end_character":54},"updated":"2018-08-24 03:44:32.000000000","message":"Is there a reason this one isn\u0027t LiveMigrationTestBase?","commit_id":"0d784ebf040c53636a072805637232eb60520c37"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"f128f8f6614ba59c4c3e3831c018b5d07a8b200a","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        self.assertIn(data, console_output)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"class LiveAutoBlockMigrationV225Test(LiveMigrationTest):"},{"line_number":246,"context_line":"    min_microversion \u003d \u00272.25\u0027"},{"line_number":247,"context_line":"    max_microversion \u003d \u0027latest\u0027"},{"line_number":248,"context_line":"    block_migration \u003d \u0027auto\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_b4d30a38","line":245,"range":{"start_line":245,"start_character":37,"end_line":245,"end_character":54},"in_reply_to":"3f79a3b5_2efa4d74","updated":"2018-08-24 05:54:42.000000000","message":"Yes, this one hasn\u0027t its own testcases, it will inherit all testcases from LiveMigrationTest.","commit_id":"0d784ebf040c53636a072805637232eb60520c37"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"01a44be57d4a247dda02b7d0d282cd3f23cef65e","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        self.assertIn(data, console_output)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"class LiveAutoBlockMigrationV225Test(LiveMigrationTest):"},{"line_number":246,"context_line":"    min_microversion \u003d \u00272.25\u0027"},{"line_number":247,"context_line":"    max_microversion \u003d \u0027latest\u0027"},{"line_number":248,"context_line":"    block_migration \u003d \u0027auto\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_a63c3993","line":245,"range":{"start_line":245,"start_character":37,"end_line":245,"end_character":54},"in_reply_to":"3f79a3b5_b4d30a38","updated":"2018-08-24 13:25:46.000000000","message":"Ok, this one is block_migration\u003d\u0027auto\u0027. Makes sense. I do some reviews too late at night :P","commit_id":"0d784ebf040c53636a072805637232eb60520c37"}]}