)]}'
{"tempest/api/compute/servers/test_device_tagging.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"8168dfa99ad53bb79d53b1287672f340d9536c75","unresolved":false,"context_lines":[{"line_number":364,"context_line":"        interface \u003d self.interfaces_client.create_interface("},{"line_number":365,"context_line":"            server[\u0027id\u0027], net_id\u003dnet[\u0027id\u0027],"},{"line_number":366,"context_line":"            tag\u003d\u0027nic-tag\u0027)[\u0027interfaceAttachment\u0027]"},{"line_number":367,"context_line":"        self.attach_volume(server, volume, tag\u003d\u0027volume-tag\u0027)"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        ssh_client \u003d remote_client.RemoteClient("},{"line_number":370,"context_line":"            self.get_server_ip(server, validation_resources),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_6374decf","line":367,"range":{"start_line":367,"start_character":8,"end_line":367,"end_character":60},"updated":"2018-08-24 02:50:41.000000000","message":"This testcase is for \"tagged attachment\", not only nic tag, but also volume tag, so, skipping whole testcase if interface_attach is False seems not appropriate.","commit_id":"1cf27bb14c06326ad3d31e5ab33adb2b1941810e"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"b1aaadb75a40bc424c27c479fdd67bbca15c280b","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        found_devices \u003d [d[\u0027tags\u0027][0] for d in md_dict[\u0027devices\u0027]"},{"line_number":311,"context_line":"                         if d.get(\u0027tags\u0027)]"},{"line_number":312,"context_line":"        try:"},{"line_number":313,"context_line":"            self.assertItemsEqual(found_devices, [\u0027nic-tag\u0027, \u0027volume-tag\u0027])"},{"line_number":314,"context_line":"            return True"},{"line_number":315,"context_line":"        except Exception:"},{"line_number":316,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_48f19a94","line":313,"range":{"start_line":313,"start_character":50,"end_line":313,"end_character":58},"updated":"2018-08-27 01:49:59.000000000","message":"this also needs modification?","commit_id":"e319b7eb4223918b150b12f7bba724509420c018"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"89e80e5374d3294e703e6ab69f0528bae1df05ae","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        found_devices \u003d [d[\u0027tags\u0027][0] for d in md_dict[\u0027devices\u0027]"},{"line_number":311,"context_line":"                         if d.get(\u0027tags\u0027)]"},{"line_number":312,"context_line":"        try:"},{"line_number":313,"context_line":"            self.assertItemsEqual(found_devices, [\u0027nic-tag\u0027, \u0027volume-tag\u0027])"},{"line_number":314,"context_line":"            return True"},{"line_number":315,"context_line":"        except Exception:"},{"line_number":316,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_90283033","line":313,"range":{"start_line":313,"start_character":50,"end_line":313,"end_character":58},"in_reply_to":"3f79a3b5_48f19a94","updated":"2018-08-27 10:28:53.000000000","message":"Done","commit_id":"e319b7eb4223918b150b12f7bba724509420c018"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"1ec31234c7d47bb63476ba0bc3e00db94bc801b1","unresolved":false,"context_lines":[{"line_number":311,"context_line":"                         if d.get(\u0027tags\u0027)]"},{"line_number":312,"context_line":"        expected_devices \u003d [\u0027volume-tag\u0027]"},{"line_number":313,"context_line":"        if CONF.compute_feature_enabled.interface_attach:"},{"line_number":314,"context_line":"            expected_devices +\u003d [\u0027nic-tag\u0027]"},{"line_number":315,"context_line":"        try:"},{"line_number":316,"context_line":"            self.assertItemsEqual(found_devices, expected_devices)"},{"line_number":317,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_33c31b3b","line":314,"range":{"start_line":314,"start_character":12,"end_line":314,"end_character":43},"updated":"2018-08-30 01:48:20.000000000","message":"nit: expected_devices.append(\u0027nic-tag\u0027)","commit_id":"fa73ff78227da4c864a6fdf086615ed6c35f4f92"}]}