)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"729f4882172e1cebe1b09daba0eca85b4b844ad4","unresolved":false,"context_lines":[{"line_number":11,"context_line":"alternative_flavor. The condition used to decide whether"},{"line_number":12,"context_line":"the flavor_alt should be used can never return true because"},{"line_number":13,"context_line":"a integer never equals to a string."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ib4f06d0a93580d84fcea0f475695f2c9fd34856b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F9%2BlI%3D","line":14,"updated":"2013-12-03 20:46:32.000000000","message":"This is for bug 1257181 right?  Then you should have this on it\u0027s own line:\n\nCloses-Bug: #1257181","commit_id":"739a84c10c075f3f4583ea540c9fba70966d4d03"}],"tempest/api/compute/servers/test_disk_config.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d35ea682103690fedb6afaffec1d252093b77dcc","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    def _get_alternative_flavor(self):"},{"line_number":81,"context_line":"        resp, server \u003d self.client.get_server(self.server_id)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        if int(server[\u0027flavor\u0027][\u0027id\u0027]) \u003d\u003d int(self.flavor_ref):"},{"line_number":84,"context_line":"            return self.flavor_ref_alt"},{"line_number":85,"context_line":"        else:"},{"line_number":86,"context_line":"            return self.flavor_ref"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F97co%3D","line":83,"updated":"2013-12-04 11:09:03.000000000","message":"We can specify uuid as flavor-id, so this change breaks it.\n\nHow about removing int() from int(server[\u0027flavor\u0027][\u0027id\u0027]) instead?","commit_id":"92ecbf912599d6def933299bee9c42c8b3e297e7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"295f7089dd585b9eb0125dcf0a563f571566a72c","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    def _get_alternative_flavor(self):"},{"line_number":81,"context_line":"        resp, server \u003d self.client.get_server(self.server_id)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        if int(server[\u0027flavor\u0027][\u0027id\u0027]) \u003d\u003d int(self.flavor_ref):"},{"line_number":84,"context_line":"            return self.flavor_ref_alt"},{"line_number":85,"context_line":"        else:"},{"line_number":86,"context_line":"            return self.flavor_ref"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F93XM%3D","line":83,"in_reply_to":"AAAATn%2F94CM%3D","updated":"2013-12-05 03:39:10.000000000","message":"Yeah, you\u0027re right, I agree with removing the int cast and just comparing the values as strings.","commit_id":"92ecbf912599d6def933299bee9c42c8b3e297e7"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"8c473963e326ab4b0320c0f08abe864156809bfe","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    def _get_alternative_flavor(self):"},{"line_number":81,"context_line":"        resp, server \u003d self.client.get_server(self.server_id)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        if int(server[\u0027flavor\u0027][\u0027id\u0027]) \u003d\u003d int(self.flavor_ref):"},{"line_number":84,"context_line":"            return self.flavor_ref_alt"},{"line_number":85,"context_line":"        else:"},{"line_number":86,"context_line":"            return self.flavor_ref"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F94CM%3D","line":83,"in_reply_to":"AAAATn%2F94SU%3D","updated":"2013-12-05 00:04:17.000000000","message":"I guess you mean \"id\" in instance_type table of nova.\nHowever, I mean \"flavorid\" in the table. Also here refers to \"flavorid\".\nThe \"id\" is internal value but we cannot see it from outside like Tempest.\n\n mysql\u003e desc  instance_types;\n +--------------+--------------+------+-----+---------+----------------+\n | Field        | Type         | Null | Key | Default | Extra          |\n +--------------+--------------+------+-----+---------+----------------+\n | created_at   | datetime     | YES  |     | NULL    |                |\n | updated_at   | datetime     | YES  |     | NULL    |                |\n | deleted_at   | datetime     | YES  |     | NULL    |                |\n | name         | varchar(255) | YES  | MUL | NULL    |                |\n | id           | int(11)      | NO   | PRI | NULL    | auto_increment |\n | memory_mb    | int(11)      | NO   |     | NULL    |                |\n | vcpus        | int(11)      | NO   |     | NULL    |                |\n | swap         | int(11)      | NO   |     | NULL    |                |\n | vcpu_weight  | int(11)      | YES  |     | NULL    |                |\n | flavorid     | varchar(255) | YES  | MUL | NULL    |                |\n | rxtx_factor  | float        | YES  |     | NULL    |                |\n | root_gb      | int(11)      | YES  |     | NULL    |                |\n | ephemeral_gb | int(11)      | YES  |     | NULL    |                |\n | disabled     | tinyint(1)   | YES  |     | NULL    |                |\n | is_public    | tinyint(1)   | YES  |     | NULL    |                |\n | deleted      | int(11)      | YES  |     | NULL    |                |\n +--------------+--------------+------+-----+---------+----------------+\n 16 rows in set (0.02 sec)\n mysql\u003e\n\nWe can create a flavor with uuid flavorid by the following command:\n\n $ nova flavor-create cpu_1vcpu auto 512 0 1\n\nThe point is \"auto\", that means nova generates uuid flavor automatically:\n\n $ nova flavor-list\n +--------------------------------------+-----------+-----------+------+-----------+------+-------+-------------+-----------+\n | ID                                   | Name      | Memory_MB | Disk | Ephemeral | Swap | VCPUs | RXTX_Factor | Is_Public |\n +--------------------------------------+-----------+-----------+------+-----------+------+-------+-------------+-----------+\n | e4a378dc-d766-45cc-910e-0b033dc881b5 | cpu_1vcpu | 512       | 0    | 0         |      | 1     | 1.0         | True      |\n +--------------------------------------+-----------+-----------+------+-----------+------+-------+-------------+-----------+\n\nIf creating a vm with the flavor, the server[\"flavor\"][\"id\"] is uuid:\n\n $ nova --debug show vm01\n [..]\n RESP BODY: {\"server\": [..], \"flavor\": {\"id\": \"e4a378dc-d766-45cc-910e-0b033dc881b5\",","commit_id":"92ecbf912599d6def933299bee9c42c8b3e297e7"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"8d5913c132a5b9051bf9ca1739e03cf0d2d77ba3","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    def _get_alternative_flavor(self):"},{"line_number":81,"context_line":"        resp, server \u003d self.client.get_server(self.server_id)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        if int(server[\u0027flavor\u0027][\u0027id\u0027]) \u003d\u003d int(self.flavor_ref):"},{"line_number":84,"context_line":"            return self.flavor_ref_alt"},{"line_number":85,"context_line":"        else:"},{"line_number":86,"context_line":"            return self.flavor_ref"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F93m4%3D","line":83,"in_reply_to":"AAAATn%2F94SU%3D","updated":"2013-12-05 02:01:10.000000000","message":"flavor.id in the db is an int; but the flavor id in the API is an int or UUID. So I think we should just compare the two sides as strings.","commit_id":"92ecbf912599d6def933299bee9c42c8b3e297e7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"27fab286714a94ebfd1a63626d83f6fa22905b44","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    def _get_alternative_flavor(self):"},{"line_number":81,"context_line":"        resp, server \u003d self.client.get_server(self.server_id)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        if int(server[\u0027flavor\u0027][\u0027id\u0027]) \u003d\u003d int(self.flavor_ref):"},{"line_number":84,"context_line":"            return self.flavor_ref_alt"},{"line_number":85,"context_line":"        else:"},{"line_number":86,"context_line":"            return self.flavor_ref"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F94SU%3D","line":83,"in_reply_to":"AAAATn%2F97co%3D","updated":"2013-12-04 22:47:11.000000000","message":"I don\u0027t think so, flavor.id in the nova model is an integer.  Do you need to get the flavor by id and then compare the flavor_id?","commit_id":"92ecbf912599d6def933299bee9c42c8b3e297e7"}]}