)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2191a989e85963e72024775514930c953a11bd1f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"In most cases, the service will resutn the request that queries"},{"line_number":14,"context_line":"the backups before the rotation function completes its work,"},{"line_number":15,"context_line":"and then 3 backups will be returned and the test will fail"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ic6443e3835fdb9d53f5ab643a04312c59ecb4c58"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F9%2BJY%3D","line":16,"updated":"2013-12-03 21:50:08.000000000","message":"Shouldn\u0027t there be a bug report for this?","commit_id":"fd8a080801af93b7b5937a90388ba7dcdba1b56a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fc5e2d059b35c61c55fe1a3f526ddf68593cb5e2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This commit is for test:"},{"line_number":10,"context_line":"tempest.api.compute.servers.test_server_actions:\\"},{"line_number":11,"context_line":"ServerActionsTestJSON.test_create_backup"},{"line_number":12,"context_line":"In most cases, the service will resutn the request that queries"},{"line_number":13,"context_line":"the backups before the rotation function completes its work,"},{"line_number":14,"context_line":"and then 3 backups will be returned and the test will fail"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAATn%2F94Uo%3D","line":12,"updated":"2013-12-04 22:40:39.000000000","message":"s/resutn/return/","commit_id":"6b5b29872e03f3bfdde2ea42e1c500a157a2c6b4"},{"author":{"_account_id":8105,"name":"wang_changye","email":"93342715@qq.com","username":"wangchy"},"change_message_id":"8901cc5b6751667a884d97354f64a72997d89ede","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This commit is for test:"},{"line_number":10,"context_line":"tempest.api.compute.servers.test_server_actions:\\"},{"line_number":11,"context_line":"ServerActionsTestJSON.test_create_backup"},{"line_number":12,"context_line":"In most cases, the service will resutn the request that queries"},{"line_number":13,"context_line":"the backups before the rotation function completes its work,"},{"line_number":14,"context_line":"and then 3 backups will be returned and the test will fail"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAATn%2F92tY%3D","line":12,"in_reply_to":"AAAATn%2F94Uo%3D","updated":"2013-12-05 07:47:40.000000000","message":"Done","commit_id":"6b5b29872e03f3bfdde2ea42e1c500a157a2c6b4"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a8d7e0f9fec7752c83372faa8762d1050fa101e0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This commit is for test:"},{"line_number":10,"context_line":"tempest.api.compute.servers.test_server_actions:\\"},{"line_number":11,"context_line":"ServerActionsTestJSON.test_create_backup"},{"line_number":12,"context_line":"In most cases, the service will return the request that queries"},{"line_number":13,"context_line":"the backups before the rotation function completes its work,"},{"line_number":14,"context_line":"and then 3 backups will be returned and the test will fail"},{"line_number":15,"context_line":"Wait for the server to become active to ensure rotation"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"AAAAUH%2F%2F5Sk%3D","line":12,"updated":"2014-01-07 05:28:05.000000000","message":"I\u0027d like to know this problem clearly.\nI guess the above line should be changed to the following:\n\ns/the service/tempest service/\n\ns/return/send/\n\nIs that right?","commit_id":"0d5afb22e980ef4df87cdf603274383fca727159"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a8d7e0f9fec7752c83372faa8762d1050fa101e0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"ServerActionsTestJSON.test_create_backup"},{"line_number":12,"context_line":"In most cases, the service will return the request that queries"},{"line_number":13,"context_line":"the backups before the rotation function completes its work,"},{"line_number":14,"context_line":"and then 3 backups will be returned and the test will fail"},{"line_number":15,"context_line":"Wait for the server to become active to ensure rotation"},{"line_number":16,"context_line":"task has completed before the verification."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"AAAAUH%2F%2F5P0%3D","line":14,"updated":"2014-01-07 05:28:05.000000000","message":"I guess a period is necessary at the end of this line.","commit_id":"0d5afb22e980ef4df87cdf603274383fca727159"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a8d7e0f9fec7752c83372faa8762d1050fa101e0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"the backups before the rotation function completes its work,"},{"line_number":14,"context_line":"and then 3 backups will be returned and the test will fail"},{"line_number":15,"context_line":"Wait for the server to become active to ensure rotation"},{"line_number":16,"context_line":"task has completed before the verification."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #1257614"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"AAAAUH%2F%2F5PE%3D","line":16,"updated":"2014-01-07 05:28:05.000000000","message":"line15-16 seems this patch\u0027s purpose.\nbetter to change here for explaining it clearly.","commit_id":"0d5afb22e980ef4df87cdf603274383fca727159"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"2ff329ee44648b8738505073dcf0b8ae4ae6a06d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"In most cases, the nova service sends the response of"},{"line_number":13,"context_line":"the request that queries the backups before the rotation"},{"line_number":14,"context_line":"function completes its work, and then 3 backups will be"},{"line_number":15,"context_line":"and the test will fail."},{"line_number":16,"context_line":"This commit makes the use case wait for the server to"},{"line_number":17,"context_line":"become active before sends the query request to ensure"},{"line_number":18,"context_line":"rotation task has completed before the verification."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"AAAAUH%2F%2F5MY%3D","line":15,"updated":"2014-01-07 05:55:32.000000000","message":"Each create_backup() has wait_for_server_status(marked as \"here\"). Can they prevent this problem now?","commit_id":"0297057da5f7436b62d851d289b58479d90e2af2"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ef1d4c4930640a57ca3019d2a203b1557c2e2c63","unresolved":false,"context_lines":[{"line_number":12,"context_line":"In most cases, the nova service sends the response of"},{"line_number":13,"context_line":"the request that queries the backups before the rotation"},{"line_number":14,"context_line":"function completes its work, and then 3 backups will be"},{"line_number":15,"context_line":"and the test will fail."},{"line_number":16,"context_line":"This commit makes the use case wait for the server to"},{"line_number":17,"context_line":"become active before sends the query request to ensure"},{"line_number":18,"context_line":"rotation task has completed before the verification."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"AAAAUH%2F%2F5Bg%3D","line":15,"in_reply_to":"AAAAUH%2F%2F5DE%3D","updated":"2014-01-07 06:20:13.000000000","message":"Thanks for your quick response, I see.","commit_id":"0297057da5f7436b62d851d289b58479d90e2af2"},{"author":{"_account_id":8105,"name":"wang_changye","email":"93342715@qq.com","username":"wangchy"},"change_message_id":"5abd39a7c34bb767f0c658075f306b4a6e5ed047","unresolved":false,"context_lines":[{"line_number":12,"context_line":"In most cases, the nova service sends the response of"},{"line_number":13,"context_line":"the request that queries the backups before the rotation"},{"line_number":14,"context_line":"function completes its work, and then 3 backups will be"},{"line_number":15,"context_line":"and the test will fail."},{"line_number":16,"context_line":"This commit makes the use case wait for the server to"},{"line_number":17,"context_line":"become active before sends the query request to ensure"},{"line_number":18,"context_line":"rotation task has completed before the verification."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"AAAAUH%2F%2F5DE%3D","line":15,"in_reply_to":"AAAAUH%2F%2F5MY%3D","updated":"2014-01-07 06:09:08.000000000","message":"No, what we need here is to wait  \"after\" the \"third\" create_backup(), prior to self.os.image_client.image_list_detail().","commit_id":"0297057da5f7436b62d851d289b58479d90e2af2"}],"tempest/api/compute/servers/test_server_actions.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2191a989e85963e72024775514930c953a11bd1f","unresolved":false,"context_lines":[{"line_number":257,"context_line":"        # the first back up should be deleted"},{"line_number":258,"context_line":"        self.os.image_client.wait_for_resource_deletion(image1_id)"},{"line_number":259,"context_line":"        oldest_backup_exist \u003d False"},{"line_number":260,"context_line":"        time.sleep(4)"},{"line_number":261,"context_line":"        resp, image_list \u003d self.os.image_client.image_list_detail("},{"line_number":262,"context_line":"            properties,"},{"line_number":263,"context_line":"            sort_key\u003d\u0027created_at\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9%2BJg%3D","line":260,"updated":"2013-12-03 21:50:08.000000000","message":"Rather than an arbitrary sleep, is there some value we can poll on instead?","commit_id":"fd8a080801af93b7b5937a90388ba7dcdba1b56a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fc5e2d059b35c61c55fe1a3f526ddf68593cb5e2","unresolved":false,"context_lines":[{"line_number":257,"context_line":"        # the first back up should be deleted"},{"line_number":258,"context_line":"        self.os.image_client.wait_for_resource_deletion(image1_id)"},{"line_number":259,"context_line":"        oldest_backup_exist \u003d False"},{"line_number":260,"context_line":"        time.sleep(4)"},{"line_number":261,"context_line":"        resp, image_list \u003d self.os.image_client.image_list_detail("},{"line_number":262,"context_line":"            properties,"},{"line_number":263,"context_line":"            sort_key\u003d\u0027created_at\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F94Us%3D","line":260,"updated":"2013-12-04 22:40:39.000000000","message":"I\u0027ll ask this again (from patch set 2):\n\nRather than an arbitrary sleep, is there some value we can poll on instead?","commit_id":"6b5b29872e03f3bfdde2ea42e1c500a157a2c6b4"},{"author":{"_account_id":8105,"name":"wang_changye","email":"93342715@qq.com","username":"wangchy"},"change_message_id":"8901cc5b6751667a884d97354f64a72997d89ede","unresolved":false,"context_lines":[{"line_number":257,"context_line":"        # the first back up should be deleted"},{"line_number":258,"context_line":"        self.os.image_client.wait_for_resource_deletion(image1_id)"},{"line_number":259,"context_line":"        oldest_backup_exist \u003d False"},{"line_number":260,"context_line":"        time.sleep(4)"},{"line_number":261,"context_line":"        resp, image_list \u003d self.os.image_client.image_list_detail("},{"line_number":262,"context_line":"            properties,"},{"line_number":263,"context_line":"            sort_key\u003d\u0027created_at\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F92s8%3D","line":260,"in_reply_to":"AAAATn%2F94Us%3D","updated":"2013-12-05 07:47:40.000000000","message":"A section of roll poling last for 16 seconds was added.","commit_id":"6b5b29872e03f3bfdde2ea42e1c500a157a2c6b4"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"e47e49064bcfbbb4cbed55c466a86a2772444795","unresolved":false,"context_lines":[{"line_number":257,"context_line":"        # the first back up should be deleted"},{"line_number":258,"context_line":"        # Notice: The following waiting does work in fact, v1 API"},{"line_number":259,"context_line":"        # does not return image that is not in active status"},{"line_number":260,"context_line":"        self.os.image_client.wait_for_resource_deletion(image1_id)"},{"line_number":261,"context_line":"        oldest_backup_exist \u003d False"},{"line_number":262,"context_line":"        timer \u003d 0"},{"line_number":263,"context_line":"        # Wait 16 seconds for rotation to remove the first backup"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F92dQ%3D","line":260,"updated":"2013-12-05 08:55:34.000000000","message":"Before using the sleeping await, could you have a try to add a line code to wait \u0027ACTIVE\u0027 status of self.server_id before line 260? I think the rotation task should be complete when server\u0027s state gets \u0027ACTIVE\u0027 and its task_state is \u0027None\"\n\nself.servers_client.wait_for_server_status(self.server_id, \u0027ACTIVE\u0027)\nself.os.image_client.wait_for_resource_deletion(image1_id)\n\nIf this does not work, I\u0027ll revoke my -1.","commit_id":"9ff1ad7a3a8f7a6fa0fc4c584f16c120478243b0"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"2ff329ee44648b8738505073dcf0b8ae4ae6a06d","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":250,"context_line":"        self.os.image_client.wait_for_image_status(image1_id, \u0027active\u0027)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        backup2 \u003d data_utils.rand_name(\u0027backup\u0027)"},{"line_number":253,"context_line":"        self.servers_client.wait_for_server_status(self.server_id, \u0027ACTIVE\u0027)"},{"line_number":254,"context_line":"        resp, _ \u003d self.servers_client.create_backup(self.server_id,"},{"line_number":255,"context_line":"                                                    \u0027daily\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2F5Ms%3D","line":252,"updated":"2014-01-07 05:55:32.000000000","message":"here","commit_id":"0297057da5f7436b62d851d289b58479d90e2af2"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"2ff329ee44648b8738505073dcf0b8ae4ae6a06d","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        # create the third one, due to the rotation is 2,"},{"line_number":279,"context_line":"        # the first one will be deleted"},{"line_number":280,"context_line":"        backup3 \u003d data_utils.rand_name(\u0027backup\u0027)"},{"line_number":281,"context_line":"        self.servers_client.wait_for_server_status(self.server_id, \u0027ACTIVE\u0027)"},{"line_number":282,"context_line":"        resp, _ \u003d self.servers_client.create_backup(self.server_id,"},{"line_number":283,"context_line":"                                                    \u0027daily\u0027,"},{"line_number":284,"context_line":"                                                    2,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2F5Mo%3D","line":281,"updated":"2014-01-07 05:55:32.000000000","message":"here","commit_id":"0297057da5f7436b62d851d289b58479d90e2af2"}]}