)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"6e83d3cc90ffd907d67a19920faa08fbba8eb36a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix QuotasNegativeTest to use non dynamic credentials"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The tests with enabled force_tenant_isolation option always use dynamic credentials."},{"line_number":10,"context_line":"Made changes to QuotasNegativeTest and QuotasTest class, implemented BaseQuotasTest"},{"line_number":11,"context_line":"class to provide a common functionality."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I62ce52fda632eaa27f8145ce0cead0b13ff8587a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_9c0a221e","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":83},"updated":"2018-08-31 05:09:16.000000000","message":"Lines exceeding maximum length.","commit_id":"c59b31a7ef483c3b1f01a710ac713d993bf7aaa7"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"d7247754d69c9b81b936145d6449fd528cbeea99","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix QuotasNegativeTest to use non dynamic credentials"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The tests with enabled force_tenant_isolation option always use dynamic credentials."},{"line_number":10,"context_line":"Made changes to QuotasNegativeTest and QuotasTest class, implemented BaseQuotasTest"},{"line_number":11,"context_line":"class to provide a common functionality."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I62ce52fda632eaa27f8145ce0cead0b13ff8587a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_0b68fcb7","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":83},"in_reply_to":"3f79a3b5_9c0a221e","updated":"2018-08-31 15:27:11.000000000","message":"Done","commit_id":"c59b31a7ef483c3b1f01a710ac713d993bf7aaa7"}],"tempest/api/network/admin/base_quotas.py":[{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"6e83d3cc90ffd907d67a19920faa08fbba8eb36a","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        # Add a project to conduct the test"},{"line_number":43,"context_line":"        project \u003d data_utils.rand_name(\u0027test_project_\u0027)"},{"line_number":44,"context_line":"        description \u003d data_utils.rand_name(\u0027desc_\u0027)"},{"line_number":45,"context_line":"        project \u003d identity.identity_utils(self.os_admin).create_project("},{"line_number":46,"context_line":"            name\u003dproject, description\u003ddescription)"},{"line_number":47,"context_line":"        project_id \u003d project[\u0027id\u0027]"},{"line_number":48,"context_line":"        self.addCleanup(identity.identity_utils(self.os_admin).delete_project,"},{"line_number":49,"context_line":"                        project_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_bc827e51","line":46,"range":{"start_line":45,"start_character":57,"end_line":46,"end_character":50},"updated":"2018-08-31 05:09:16.000000000","message":"I think test is creating project with quota but it seems to be more about updating quota. Are you creating project here with quota. If not then test name be changed accordingly.","commit_id":"c59b31a7ef483c3b1f01a710ac713d993bf7aaa7"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"d7247754d69c9b81b936145d6449fd528cbeea99","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        # Add a project to conduct the test"},{"line_number":43,"context_line":"        project \u003d data_utils.rand_name(\u0027test_project_\u0027)"},{"line_number":44,"context_line":"        description \u003d data_utils.rand_name(\u0027desc_\u0027)"},{"line_number":45,"context_line":"        project \u003d identity.identity_utils(self.os_admin).create_project("},{"line_number":46,"context_line":"            name\u003dproject, description\u003ddescription)"},{"line_number":47,"context_line":"        project_id \u003d project[\u0027id\u0027]"},{"line_number":48,"context_line":"        self.addCleanup(identity.identity_utils(self.os_admin).delete_project,"},{"line_number":49,"context_line":"                        project_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_8b4bac5d","line":46,"range":{"start_line":45,"start_character":57,"end_line":46,"end_character":50},"in_reply_to":"3f79a3b5_bc827e51","updated":"2018-08-31 15:27:11.000000000","message":"It\u0027s not a test, just helper to create a project/tenant with quotas","commit_id":"c59b31a7ef483c3b1f01a710ac713d993bf7aaa7"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"ad0cf81ef210c35fb07096f0b0b3d64c5d98fc67","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            msg \u003d \"quotas extension not enabled.\""},{"line_number":39,"context_line":"            raise cls.skipException(msg)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def create_project_with_quotas(self, **quotas):"},{"line_number":42,"context_line":"        # Add a project to conduct the test"},{"line_number":43,"context_line":"        project \u003d data_utils.rand_name(\u0027test_project_\u0027)"},{"line_number":44,"context_line":"        description \u003d data_utils.rand_name(\u0027desc_\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_1bbd9167","line":41,"updated":"2018-09-03 06:13:49.000000000","message":"+1","commit_id":"487c88b294188b67d57cf760ebf42d37d2cbba4f"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"82810004877520f4701720bd7b778c3b177f82eb","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            msg \u003d \"quotas extension not enabled.\""},{"line_number":39,"context_line":"            raise cls.skipException(msg)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def create_project_with_quotas(self, **quotas):"},{"line_number":42,"context_line":"        # Add a project to conduct the test"},{"line_number":43,"context_line":"        project \u003d data_utils.rand_name(\u0027test_project_\u0027)"},{"line_number":44,"context_line":"        description \u003d data_utils.rand_name(\u0027desc_\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_98ce8781","line":41,"range":{"start_line":41,"start_character":8,"end_line":41,"end_character":34},"updated":"2018-09-03 02:12:56.000000000","message":"Why not add  this helper in base.BaseAdminNetworkTest? Deep hierarchy is not recommended generally.","commit_id":"487c88b294188b67d57cf760ebf42d37d2cbba4f"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"b6ac62dec938b39145b231dd3ac9fd75d7d7e214","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            msg \u003d \"quotas extension not enabled.\""},{"line_number":39,"context_line":"            raise cls.skipException(msg)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def create_project_with_quotas(self, **quotas):"},{"line_number":42,"context_line":"        # Add a project to conduct the test"},{"line_number":43,"context_line":"        project \u003d data_utils.rand_name(\u0027test_project_\u0027)"},{"line_number":44,"context_line":"        description \u003d data_utils.rand_name(\u0027desc_\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_705fe540","line":41,"range":{"start_line":41,"start_character":8,"end_line":41,"end_character":34},"in_reply_to":"3f79a3b5_98ce8781","updated":"2018-09-04 15:39:26.000000000","message":"We need this function for Quota tests only and I don\u0027t thin It is good idea to move it into base class.","commit_id":"487c88b294188b67d57cf760ebf42d37d2cbba4f"}],"tempest/api/network/admin/test_negative_quotas.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"82810004877520f4701720bd7b778c3b177f82eb","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    @decorators.attr(type\u003d[\u0027negative\u0027])"},{"line_number":28,"context_line":"    @decorators.idempotent_id(\u0027644f4e1b-1bf9-4af0-9fd8-eb56ac0f51cf\u0027)"},{"line_number":29,"context_line":"    def test_network_quota_exceeding(self):"},{"line_number":30,"context_line":"        project_id \u003d self.create_project_with_quotas(network\u003d2)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        # Create two networks"},{"line_number":33,"context_line":"        n1 \u003d self.admin_networks_client.create_network(tenant_id\u003dproject_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_58c8ef72","line":30,"range":{"start_line":30,"start_character":26,"end_line":30,"end_character":52},"updated":"2018-09-03 02:12:56.000000000","message":"What\u0027s the benefit of creating a project instead of using force_tenant_isolation \u003d True?","commit_id":"487c88b294188b67d57cf760ebf42d37d2cbba4f"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"dfd2e8a7a2170ae686d378ad4f884b2ee36549c4","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        self.admin_quotas_client.update_quotas(self.project[\u0027id\u0027], network\u003d2)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        # Create two networks"},{"line_number":59,"context_line":"        n1 \u003d self.admin_networks_client.create_network("},{"line_number":60,"context_line":"            tenant_id\u003dself.project[\u0027id\u0027])"},{"line_number":61,"context_line":"        self.addCleanup(self.admin_networks_client.delete_network,"},{"line_number":62,"context_line":"                        n1[\u0027network\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_9430a0eb","line":59,"range":{"start_line":59,"start_character":18,"end_line":59,"end_character":39},"updated":"2018-10-22 15:01:40.000000000","message":"Why did you switch to admin client here for all these operations? create_network doesn\u0027t require admin: https://github.com/openstack/neutron/blob/cf4992cab740bcaac4f213b25058de7f538a9ecc/etc/policy.json#L42","commit_id":"e094bbade2b719fd531c2c8a7284ebfb1fb32efc"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"0ab083077809ce75d592a1c213d0f6647352a924","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        self.admin_quotas_client.update_quotas(self.project[\u0027id\u0027], network\u003d2)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        # Create two networks"},{"line_number":59,"context_line":"        n1 \u003d self.admin_networks_client.create_network("},{"line_number":60,"context_line":"            tenant_id\u003dself.project[\u0027id\u0027])"},{"line_number":61,"context_line":"        self.addCleanup(self.admin_networks_client.delete_network,"},{"line_number":62,"context_line":"                        n1[\u0027network\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_d4c05880","line":59,"range":{"start_line":59,"start_character":18,"end_line":59,"end_character":39},"in_reply_to":"3f79a3b5_9430a0eb","updated":"2018-10-22 15:07:09.000000000","message":"Because now this test works in the tenant created in L47, so it needs to be admin to create a network in another tenant.","commit_id":"e094bbade2b719fd531c2c8a7284ebfb1fb32efc"}]}