)]}'
{"tempest/tests/cmd/test_verify_tempest_config.py":[{"author":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"change_message_id":"318f4c3d14d15b0db3a3982b7caa42bd4fdd99a0","unresolved":false,"context_lines":[{"line_number":509,"context_line":""},{"line_number":510,"context_line":"    def test_get_config_file(self):"},{"line_number":511,"context_line":"        default_config_dir \u003d os.path.join(os.getcwd(), \"etc\")"},{"line_number":512,"context_line":"        default_config_file \u003d \"tempest.conf\""},{"line_number":513,"context_line":"        conf_dir \u003d os.environ.get(\u0027TEMPEST_CONFIG_DIR\u0027, default_config_dir)"},{"line_number":514,"context_line":"        conf_file \u003d os.environ.get(\u0027TEMPEST_CONFIG\u0027, default_config_file)"},{"line_number":515,"context_line":"        path \u003d os.path.join(conf_dir, conf_file)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_62462d53","line":512,"range":{"start_line":512,"start_character":31,"end_line":512,"end_character":44},"updated":"2018-09-05 02:06:10.000000000","message":"Where to get tempest.conf.\nSeems this file is missing.","commit_id":"452e4423009e976f4094d9b4e78fae6e48749bec"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"c52dd965220ba508a538d2ea42d8a5be89c057be","unresolved":false,"context_lines":[{"line_number":509,"context_line":""},{"line_number":510,"context_line":"    def test_get_config_file(self):"},{"line_number":511,"context_line":"        default_config_dir \u003d os.path.join(os.getcwd(), \"etc\")"},{"line_number":512,"context_line":"        default_config_file \u003d \"tempest.conf\""},{"line_number":513,"context_line":"        conf_dir \u003d os.environ.get(\u0027TEMPEST_CONFIG_DIR\u0027, default_config_dir)"},{"line_number":514,"context_line":"        conf_file \u003d os.environ.get(\u0027TEMPEST_CONFIG\u0027, default_config_file)"},{"line_number":515,"context_line":"        path \u003d os.path.join(conf_dir, conf_file)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_f8a4f7ba","line":512,"range":{"start_line":512,"start_character":31,"end_line":512,"end_character":44},"in_reply_to":"3f79a3b5_62462d53","updated":"2018-09-07 05:32:54.000000000","message":"It\u0027s default file which creates under \"tempest/etc\" \nL[511] is the directory where this file exists.\n\nL[513-514]: If directory location and config file name are set in env. then value from env. will be get\nelse default values from L[511-512] will get.\n\nSo file is not missing","commit_id":"452e4423009e976f4094d9b4e78fae6e48749bec"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"046364a0edbaf557f125907327b7e5050aa6503a","unresolved":false,"context_lines":[{"line_number":511,"context_line":"    def test_get_config_file(self):"},{"line_number":512,"context_line":"        default_config_dir \u003d os.path.join(os.getcwd(), \u0027etc/\u0027)"},{"line_number":513,"context_line":"        default_config_file \u003d \"tempest.conf\""},{"line_number":514,"context_line":"        conf_dir \u003d os.environ.get(\u0027TEMPEST_CONFIG_DIR\u0027, default_config_dir)"},{"line_number":515,"context_line":"        conf_file \u003d os.environ.get(\u0027TEMPEST_CONFIG\u0027, default_config_file)"},{"line_number":516,"context_line":"        local_sample_conf_file \u003d os.path.join(conf_dir, conf_file)"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"        init_cmd \u003d init.TempestInit(None, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_388d0c35","line":515,"range":{"start_line":514,"start_character":0,"end_line":515,"end_character":73},"updated":"2018-09-13 18:15:37.000000000","message":"This looks like copy/paste from the implementation of _get_config_file() itself. How about we do:\n\n    default_config_dir \u003d os.path.join(os.getcwd(), \u0027etc/\u0027)\n    default_config_file \u003d \"tempest.conf\"\n    local_sample_conf_file \u003d os.path.join(conf_dir, conf_file)\n    self.assertTrue(os.path.isfile(local_sample_conf_file))\n\n    def fake_environ_get(key, default):\n        return default\n\n    with mock.patch(\u0027os.environ.get\u0027, side_effect\u003dfake_environ_get):\n        file_pointer \u003d verify_tempest_config._get_config_file()\n    self.assertEqual(local_sample_conf_file, file_pointer.name)\n\n    with open(local_sample_conf_file, \u0027r+\u0027) as f:\n        local_sample_conf_contents \u003d f.read()\n    self.assertEqual(local_sample_conf_contents, file_pointer.read())","commit_id":"c426d9124fa448d139ee513cec15bc61c1030a42"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"5d5f50e412d99be6a0464cc439235ffaac7602ec","unresolved":false,"context_lines":[{"line_number":511,"context_line":"    def test_get_config_file(self):"},{"line_number":512,"context_line":"        default_config_dir \u003d os.path.join(os.getcwd(), \u0027etc/\u0027)"},{"line_number":513,"context_line":"        default_config_file \u003d \"tempest.conf\""},{"line_number":514,"context_line":"        conf_dir \u003d os.environ.get(\u0027TEMPEST_CONFIG_DIR\u0027, default_config_dir)"},{"line_number":515,"context_line":"        conf_file \u003d os.environ.get(\u0027TEMPEST_CONFIG\u0027, default_config_file)"},{"line_number":516,"context_line":"        local_sample_conf_file \u003d os.path.join(conf_dir, conf_file)"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"        init_cmd \u003d init.TempestInit(None, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_a9df8964","line":515,"range":{"start_line":514,"start_character":0,"end_line":515,"end_character":73},"in_reply_to":"3f79a3b5_388d0c35","updated":"2018-09-14 06:06:26.000000000","message":"Seems fine to me but here is a small issue.\nI need to create tempest.conf in test which actually doesn\u0027t exist, so gate gets failed. I added for this in my current patch set\nIf system already has tempest.conf then this test will run fine.","commit_id":"c426d9124fa448d139ee513cec15bc61c1030a42"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"2d24b44801f281187849856f9632a40706394937","unresolved":false,"context_lines":[{"line_number":511,"context_line":"    def test_get_config_file(self):"},{"line_number":512,"context_line":"        default_config_dir \u003d os.path.join(os.getcwd(), \u0027etc/\u0027)"},{"line_number":513,"context_line":"        default_config_file \u003d \"tempest.conf\""},{"line_number":514,"context_line":"        conf_dir \u003d os.environ.get(\u0027TEMPEST_CONFIG_DIR\u0027, default_config_dir)"},{"line_number":515,"context_line":"        conf_file \u003d os.environ.get(\u0027TEMPEST_CONFIG\u0027, default_config_file)"},{"line_number":516,"context_line":"        local_sample_conf_file \u003d os.path.join(conf_dir, conf_file)"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"        init_cmd \u003d init.TempestInit(None, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_34b3cceb","line":515,"range":{"start_line":514,"start_character":0,"end_line":515,"end_character":73},"in_reply_to":"3f79a3b5_a9df8964","updated":"2018-09-14 07:59:05.000000000","message":"How about below:\n\n    def test_get_config_file(self):\n        default_config_dir \u003d os.path.join(os.getcwd(), \u0027etc/\u0027)\n        default_config_file \u003d \"tempest.conf\"\n        conf_dir \u003d os.environ.get(\u0027TEMPEST_CONFIG_DIR\u0027, default_config_dir)\n        conf_file \u003d os.environ.get(\u0027TEMPEST_CONFIG\u0027, default_config_file)\n        local_sample_conf_file \u003d os.path.join(conf_dir, conf_file)\n\n        init_cmd \u003d init.TempestInit(None, None)\n        init_cmd.generate_sample_config(os.getcwd())\n        self.assertTrue(\n            os.path.isfile(\u0027%s/tempest.conf.sample\u0027 % (conf_dir)))\n        os.rename(\u0027%s/tempest.conf.sample\u0027\n                  % (conf_dir), \u0027%s\u0027 % (local_sample_conf_file))\n\n        def fake_environ_get(key, default):\n            return default\n\n        with mock.patch(\u0027os.environ.get\u0027, side_effect\u003dfake_environ_get):\n            file_pointer \u003d verify_tempest_config._get_config_file()\n        self.assertEqual(local_sample_conf_file, file_pointer.name)\n\n        with open(local_sample_conf_file, \u0027r+\u0027) as f:\n            local_sample_conf_contents \u003d f.read()\n        self.assertEqual(local_sample_conf_contents, file_pointer.read())","commit_id":"c426d9124fa448d139ee513cec15bc61c1030a42"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"046364a0edbaf557f125907327b7e5050aa6503a","unresolved":false,"context_lines":[{"line_number":525,"context_line":"        self.assertEqual(local_sample_conf_file, file_pointer.name)"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"    def test_print_and_or_update_true(self):"},{"line_number":528,"context_line":"            with mock.patch.object("},{"line_number":529,"context_line":"                verify_tempest_config, \u0027change_option\u0027) as test_mock:"},{"line_number":530,"context_line":"                verify_tempest_config.print_and_or_update("},{"line_number":531,"context_line":"                    \u0027fakeservice\u0027, \u0027fake-service-available\u0027, False, True)"},{"line_number":532,"context_line":"                test_mock.assert_called_once_with("},{"line_number":533,"context_line":"                    \u0027fakeservice\u0027, \u0027fake-service-available\u0027, False)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    def test_print_and_or_update_false(self):"},{"line_number":536,"context_line":"            with mock.patch.object("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_38f18cdf","line":533,"range":{"start_line":528,"start_character":0,"end_line":533,"end_character":67},"updated":"2018-09-13 18:15:37.000000000","message":"This is overindented 4 spaces, please de-indent.","commit_id":"c426d9124fa448d139ee513cec15bc61c1030a42"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"5d5f50e412d99be6a0464cc439235ffaac7602ec","unresolved":false,"context_lines":[{"line_number":525,"context_line":"        self.assertEqual(local_sample_conf_file, file_pointer.name)"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"    def test_print_and_or_update_true(self):"},{"line_number":528,"context_line":"            with mock.patch.object("},{"line_number":529,"context_line":"                verify_tempest_config, \u0027change_option\u0027) as test_mock:"},{"line_number":530,"context_line":"                verify_tempest_config.print_and_or_update("},{"line_number":531,"context_line":"                    \u0027fakeservice\u0027, \u0027fake-service-available\u0027, False, True)"},{"line_number":532,"context_line":"                test_mock.assert_called_once_with("},{"line_number":533,"context_line":"                    \u0027fakeservice\u0027, \u0027fake-service-available\u0027, False)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    def test_print_and_or_update_false(self):"},{"line_number":536,"context_line":"            with mock.patch.object("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_09f1dd01","line":533,"range":{"start_line":528,"start_character":0,"end_line":533,"end_character":67},"in_reply_to":"3f79a3b5_38f18cdf","updated":"2018-09-14 06:06:26.000000000","message":"Thanks for correction!","commit_id":"c426d9124fa448d139ee513cec15bc61c1030a42"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"046364a0edbaf557f125907327b7e5050aa6503a","unresolved":false,"context_lines":[{"line_number":533,"context_line":"                    \u0027fakeservice\u0027, \u0027fake-service-available\u0027, False)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    def test_print_and_or_update_false(self):"},{"line_number":536,"context_line":"            with mock.patch.object("},{"line_number":537,"context_line":"                verify_tempest_config, \u0027change_option\u0027) as test_mock:"},{"line_number":538,"context_line":"                verify_tempest_config.print_and_or_update("},{"line_number":539,"context_line":"                    \u0027fakeservice\u0027, \u0027fake-service-available\u0027, False, False)"},{"line_number":540,"context_line":"                test_mock.assert_not_called()"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"    def test_contains_version_positive_data(self):"},{"line_number":543,"context_line":"        self.assertTrue("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_18f610da","line":540,"range":{"start_line":536,"start_character":0,"end_line":540,"end_character":45},"updated":"2018-09-13 18:15:37.000000000","message":"This is overindented 4 spaces, please de-indent.","commit_id":"c426d9124fa448d139ee513cec15bc61c1030a42"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"5d5f50e412d99be6a0464cc439235ffaac7602ec","unresolved":false,"context_lines":[{"line_number":533,"context_line":"                    \u0027fakeservice\u0027, \u0027fake-service-available\u0027, False)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    def test_print_and_or_update_false(self):"},{"line_number":536,"context_line":"            with mock.patch.object("},{"line_number":537,"context_line":"                verify_tempest_config, \u0027change_option\u0027) as test_mock:"},{"line_number":538,"context_line":"                verify_tempest_config.print_and_or_update("},{"line_number":539,"context_line":"                    \u0027fakeservice\u0027, \u0027fake-service-available\u0027, False, False)"},{"line_number":540,"context_line":"                test_mock.assert_not_called()"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"    def test_contains_version_positive_data(self):"},{"line_number":543,"context_line":"        self.assertTrue("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_29f4d9f0","line":540,"range":{"start_line":536,"start_character":0,"end_line":540,"end_character":45},"in_reply_to":"3f79a3b5_18f610da","updated":"2018-09-14 06:06:26.000000000","message":"Thanks for correction!","commit_id":"c426d9124fa448d139ee513cec15bc61c1030a42"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d4a69746ea983ffdbddfee200ea5828bb430df85","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import fixtures"},{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_serialization import jsonutils as json"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from tempest import clients"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_738c6134","line":19,"updated":"2018-09-21 18:07:47.000000000","message":"We should not add a new blank line here in the same 3rd party libraries\u0027 block.","commit_id":"abbf2ddaebd45416004a75bfc7b22d9f9f04c00b"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"16af5f5d002bb168fd60b847deabdb46288e36ca","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import fixtures"},{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_serialization import jsonutils as json"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from tempest import clients"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_c38859c4","line":19,"in_reply_to":"3f79a3b5_738c6134","updated":"2018-10-01 13:35:45.000000000","message":"+1, I mean -1.\n\nLooks like this change did not get 2th +2 for long, \nPlease make the cores to not hesitate about nits and try to address this kind of nits.","commit_id":"abbf2ddaebd45416004a75bfc7b22d9f9f04c00b"}]}