)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"6931583f50d4c2e8f9ea21edc6effe42bcf2ff1f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"pass device when calling compute.base.attach_volume."},{"line_number":12,"context_line":"https://developer.openstack.org/api-ref/compute/#attach-a-volume-to-an-instance"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"NOTE: We still keep passing device in test_attach_detach_volume,"},{"line_number":15,"context_line":"because it will ssh to vm to check the device name, in that case,"},{"line_number":16,"context_line":"CONF.compute.volume_device_name must be set the equal value as"},{"line_number":17,"context_line":"the libvirt auto-assigned one. Whether to remove that check"},{"line_number":18,"context_line":"is out of the range of this patch."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I4483836abedab2550731fef5b2625282d7a2298d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_6daa5684","line":17,"range":{"start_line":14,"start_character":0,"end_line":17,"end_character":30},"updated":"2018-09-07 23:31:54.000000000","message":"This NOTE is well written and it is better to write this in test_attach_detach_volume itself.","commit_id":"bf5cf4757b4b62980d8554bc70135fada0e0a12e"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"9d430713c772a275efd14e1f69a49f9dd9dd7f2f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"pass device when calling compute.base.attach_volume."},{"line_number":12,"context_line":"https://developer.openstack.org/api-ref/compute/#attach-a-volume-to-an-instance"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"NOTE: We still keep passing device in test_attach_detach_volume,"},{"line_number":15,"context_line":"because it will ssh to vm to check the device name, in that case,"},{"line_number":16,"context_line":"CONF.compute.volume_device_name must be set the equal value as"},{"line_number":17,"context_line":"the libvirt auto-assigned one. Whether to remove that check"},{"line_number":18,"context_line":"is out of the range of this patch."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I4483836abedab2550731fef5b2625282d7a2298d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_b86e5861","line":17,"range":{"start_line":14,"start_character":0,"end_line":17,"end_character":30},"in_reply_to":"3f79a3b5_6daa5684","updated":"2018-09-10 03:32:48.000000000","message":"Thanks, makes sense, done","commit_id":"bf5cf4757b4b62980d8554bc70135fada0e0a12e"}],"tempest/api/compute/volumes/test_attach_volume.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"beefb762410aa7bb984f765288d9839e97abaa53","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            linux_client.validate_authentication()"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        volume \u003d self.create_volume()"},{"line_number":91,"context_line":"        attachment \u003d self.attach_volume(server, volume,"},{"line_number":92,"context_line":"                                        device\u003d(\u0027/dev/%s\u0027 % self.device))"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        self.servers_client.stop_server(server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_3e9bed73","line":91,"updated":"2018-09-11 16:43:26.000000000","message":"better to add NOTE here for easy understanding.","commit_id":"261a4d3f4665fb250df4e9371fd35988e63a3d21"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"1eb0ee8e2a67e79a86421e40a5e591ae056a680b","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        # CONF.compute.volume_device_name must be set the equal value as"},{"line_number":91,"context_line":"        # the libvirt auto-assigned one"},{"line_number":92,"context_line":"        attachment \u003d self.attach_volume(server, volume,"},{"line_number":93,"context_line":"                                        device\u003d(\u0027/dev/%s\u0027 % self.device))"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        self.servers_client.stop_server(server[\u0027id\u0027])"},{"line_number":96,"context_line":"        waiters.wait_for_server_status(self.servers_client, server[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_9860e00f","line":93,"range":{"start_line":93,"start_character":40,"end_line":93,"end_character":72},"updated":"2018-09-13 18:23:17.000000000","message":"Why keep this here if it\u0027s ignored? Can\u0027t we still do the check on L106,L122 regardless of this being passed in?","commit_id":"2c9d9625d94f716bf3afd86cdc9606d6e95ba4b8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3f2527c72ad9631c1a755faf64ac70816144d34c","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        # CONF.compute.volume_device_name must be set the equal value as"},{"line_number":91,"context_line":"        # the libvirt auto-assigned one"},{"line_number":92,"context_line":"        attachment \u003d self.attach_volume(server, volume,"},{"line_number":93,"context_line":"                                        device\u003d(\u0027/dev/%s\u0027 % self.device))"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        self.servers_client.stop_server(server[\u0027id\u0027])"},{"line_number":96,"context_line":"        waiters.wait_for_server_status(self.servers_client, server[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_99666dee","line":93,"range":{"start_line":93,"start_character":40,"end_line":93,"end_character":72},"in_reply_to":"3f79a3b5_502bc97a","updated":"2018-10-11 13:44:29.000000000","message":"thanks mriedem. let\u0027s keep it then to cover the API compatibility in term or request param.","commit_id":"2c9d9625d94f716bf3afd86cdc9606d6e95ba4b8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6c71a1c4848f5966f50db1408fca208a8d1f2f4a","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        # CONF.compute.volume_device_name must be set the equal value as"},{"line_number":91,"context_line":"        # the libvirt auto-assigned one"},{"line_number":92,"context_line":"        attachment \u003d self.attach_volume(server, volume,"},{"line_number":93,"context_line":"                                        device\u003d(\u0027/dev/%s\u0027 % self.device))"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        self.servers_client.stop_server(server[\u0027id\u0027])"},{"line_number":96,"context_line":"        waiters.wait_for_server_status(self.servers_client, server[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_502bc97a","line":93,"range":{"start_line":93,"start_character":40,"end_line":93,"end_character":72},"in_reply_to":"3f79a3b5_68742038","updated":"2018-10-11 12:35:56.000000000","message":"The reason this passes is mostly just based on luck and because there is one volume. A more predictable way to find the device within the guest is if the volume is tagged and then that shows up in the guest config drive or via the metadata API, but not all virt drivers in nova support device tagging, and it\u0027s not supported until a newer microversion, so it wouldn\u0027t be appropriate here really.\n\nIt wouldn\u0027t matter to me either way if this test remains as-is given it\u0027s been this way forever and as mentioned then at least one test is still hitting that part of the API, even if the backend driver ignores it.","commit_id":"2c9d9625d94f716bf3afd86cdc9606d6e95ba4b8"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"5e419c409698c20764b5a422a46d73bc92214b11","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        # CONF.compute.volume_device_name must be set the equal value as"},{"line_number":91,"context_line":"        # the libvirt auto-assigned one"},{"line_number":92,"context_line":"        attachment \u003d self.attach_volume(server, volume,"},{"line_number":93,"context_line":"                                        device\u003d(\u0027/dev/%s\u0027 % self.device))"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        self.servers_client.stop_server(server[\u0027id\u0027])"},{"line_number":96,"context_line":"        waiters.wait_for_server_status(self.servers_client, server[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_c05dfa48","line":93,"range":{"start_line":93,"start_character":40,"end_line":93,"end_character":72},"in_reply_to":"3f79a3b5_9860e00f","updated":"2018-09-14 01:17:28.000000000","message":"Good question.\nThe reason finally I didn\u0027t remove it is:\n1. device is a parameter of interface attach_volume, so better to remain at least one passing.\n2. before Liberty 12.0.0 release, device parameter may take effect","commit_id":"2c9d9625d94f716bf3afd86cdc9606d6e95ba4b8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dc4c9f4514ed0615c9c1f6f454fa16e60c8b1481","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        # CONF.compute.volume_device_name must be set the equal value as"},{"line_number":91,"context_line":"        # the libvirt auto-assigned one"},{"line_number":92,"context_line":"        attachment \u003d self.attach_volume(server, volume,"},{"line_number":93,"context_line":"                                        device\u003d(\u0027/dev/%s\u0027 % self.device))"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        self.servers_client.stop_server(server[\u0027id\u0027])"},{"line_number":96,"context_line":"        waiters.wait_for_server_status(self.servers_client, server[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_68742038","line":93,"range":{"start_line":93,"start_character":40,"end_line":93,"end_character":72},"in_reply_to":"3f79a3b5_c05dfa48","updated":"2018-10-09 08:33:02.000000000","message":"i think we can remove it completely as liberty is not supported. \n\nalso can we remove from base classes also ?- \n\n1. https://github.com/openstack/tempest/blob/master/tempest/api/compute/base.py#L529\n\n2. https://github.com/openstack/tempest/blob/837726a9ede64e33d0def018da24e146dd6b5af3/tempest/api/volume/base.py#L186","commit_id":"2c9d9625d94f716bf3afd86cdc9606d6e95ba4b8"}]}