)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"ea385b975854016861775a95e86f43dd086429bf","unresolved":false,"context_lines":[{"line_number":677,"context_line":"            client\u003dself.network_client,"},{"line_number":678,"context_line":"            **result[\u0027floatingip\u0027])"},{"line_number":679,"context_line":"        self.set_resource(data_utils.rand_name(\u0027floatingip-\u0027), floating_ip)"},{"line_number":680,"context_line":"        self._wait_for_floating_ip_association(server,"},{"line_number":681,"context_line":"                                               floating_ip.floating_ip_address)"},{"line_number":682,"context_line":"        return floating_ip"},{"line_number":683,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAATn%2F8%2BBM%3D","line":680,"updated":"2013-12-18 09:41:30.000000000","message":"do we really want this to run and wait on every FLIP creation?\nI think checking a list of (FLIP,VM) tuples/dict is the way to go. combining it with a admin compute_client in a separated class will allow to run the check after all FLIPs are assigned.","commit_id":"225c7c4709f05a79761611dd10856ad27ea0afc3"},{"author":{"_account_id":8622,"name":"Feng Ju","email":"jufeng@cn.ibm.com","username":"jufeng"},"change_message_id":"bcf267f7fa66440526fe9395463527442ef5b282","unresolved":false,"context_lines":[{"line_number":677,"context_line":"            client\u003dself.network_client,"},{"line_number":678,"context_line":"            **result[\u0027floatingip\u0027])"},{"line_number":679,"context_line":"        self.set_resource(data_utils.rand_name(\u0027floatingip-\u0027), floating_ip)"},{"line_number":680,"context_line":"        self._wait_for_floating_ip_association(server,"},{"line_number":681,"context_line":"                                               floating_ip.floating_ip_address)"},{"line_number":682,"context_line":"        return floating_ip"},{"line_number":683,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAATn%2F894s%3D","line":680,"in_reply_to":"AAAATn%2F8%2BBM%3D","updated":"2013-12-18 10:06:43.000000000","message":"I think to verify the FLIP association on every FLIP creation is the right way, when you associate a FLIP to VM, you need to make sure the FLIP successfully associate with the VM. This is the _create_floating_ip function\u0027s work. If you check that after many VM created and with many FLIP associated, you always need to care about the association. right?","commit_id":"225c7c4709f05a79761611dd10856ad27ea0afc3"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"910b85c08581021deef69e96cdd7152da0aa3576","unresolved":false,"context_lines":[{"line_number":677,"context_line":"            client\u003dself.network_client,"},{"line_number":678,"context_line":"            **result[\u0027floatingip\u0027])"},{"line_number":679,"context_line":"        self.set_resource(data_utils.rand_name(\u0027floatingip-\u0027), floating_ip)"},{"line_number":680,"context_line":"        self._wait_for_floating_ip_association(server,"},{"line_number":681,"context_line":"                                               floating_ip.floating_ip_address)"},{"line_number":682,"context_line":"        return floating_ip"},{"line_number":683,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAATn%2F89hw%3D","line":680,"in_reply_to":"AAAATn%2F894s%3D","updated":"2013-12-18 11:19:59.000000000","message":"OK, you talked me into it.\nBUT:\nplease keep it in an independent class so we can control the verification method.\nI\u0027m thinking it should check the port list rather than the VM for faster verification","commit_id":"225c7c4709f05a79761611dd10856ad27ea0afc3"},{"author":{"_account_id":8622,"name":"Feng Ju","email":"jufeng@cn.ibm.com","username":"jufeng"},"change_message_id":"da23c1a2ab4d0bc023970c3e985b2cffe19c8cd4","unresolved":false,"context_lines":[{"line_number":677,"context_line":"            client\u003dself.network_client,"},{"line_number":678,"context_line":"            **result[\u0027floatingip\u0027])"},{"line_number":679,"context_line":"        self.set_resource(data_utils.rand_name(\u0027floatingip-\u0027), floating_ip)"},{"line_number":680,"context_line":"        self._wait_for_floating_ip_association(server,"},{"line_number":681,"context_line":"                                               floating_ip.floating_ip_address)"},{"line_number":682,"context_line":"        return floating_ip"},{"line_number":683,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAATn%2F85Jc%3D","line":680,"in_reply_to":"AAAATn%2F89hw%3D","updated":"2013-12-19 03:48:36.000000000","message":"Thanks, Yair, checking floating_ip_association just a step in creating floating_ip, there is run_checks funtion to check the association, and I think there is no need to put it in an independent class. If you insist, I will put it in an independent class.","commit_id":"225c7c4709f05a79761611dd10856ad27ea0afc3"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"ea385b975854016861775a95e86f43dd086429bf","unresolved":false,"context_lines":[{"line_number":681,"context_line":"                                               floating_ip.floating_ip_address)"},{"line_number":682,"context_line":"        return floating_ip"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"    def _wait_for_floating_ip_association(self, server, floating_ip):"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"        def run_checks():"},{"line_number":687,"context_line":"            \"\"\"Check floating IP association"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAATn%2F8%2BC8%3D","line":684,"updated":"2013-12-18 09:41:30.000000000","message":"please put this in a different, and independent patch. I would like to rebase my stuff on this, and I think it will be merged much faster","commit_id":"225c7c4709f05a79761611dd10856ad27ea0afc3"}],"tempest/scenario/network/base_network_ops.py":[{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"e153c90aafd4a271c0c5c1fd0007eb43da8a5121","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":4,"context_line":"# Copyright 2013 Hewlett-Packard Development Company, L.P."},{"line_number":5,"context_line":"# All Rights Reserved."},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F98CE%3D","line":4,"updated":"2013-12-04 09:01:21.000000000","message":"Remove line 3-4, and add \"# Copyright 2013 IBM Corp.\"","commit_id":"2371017d72d159100a65841bace8122195c6fb74"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"ed03d096f98771a966853b224a49c1063abd72e1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":4,"context_line":"# Copyright 2013 Hewlett-Packard Development Company, L.P."},{"line_number":5,"context_line":"# All Rights Reserved."},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F97aM%3D","line":4,"in_reply_to":"AAAATn%2F98CE%3D","updated":"2013-12-04 11:35:53.000000000","message":"No. this is a copy from scenario/test_network_basic_ops.py","commit_id":"2371017d72d159100a65841bace8122195c6fb74"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"3e529314c290e265d1a9260a5b001957c87d71d1","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        super(BaseNetworkOps, cls).setUpClass()"},{"line_number":42,"context_line":"        cls.check_preconditions()"},{"line_number":43,"context_line":"        # TODO(mnewby) Consider looking up entities as needed instead"},{"line_number":44,"context_line":"        # of storing them as collections on the class."},{"line_number":45,"context_line":"        cls.keypairs \u003d {}"},{"line_number":46,"context_line":"        cls.security_groups \u003d {}"},{"line_number":47,"context_line":"        cls.networks \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F97%2B4%3D","line":44,"updated":"2013-12-04 09:15:25.000000000","message":"Is this the best way to track test resources?\nIt was used by network_basic_ops as a local solution and I find it\u0027s not the easiest way to work.\nAll of the other methods are based on these containers and they work for the specific test but I\u0027m not sure they are suitable once you have tests with more than a single instance of each resource  (net, subnet, router, VM, fip, secgroup)","commit_id":"2371017d72d159100a65841bace8122195c6fb74"}],"tempest/scenario/network/test_network_basic_ops.py":[{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"e153c90aafd4a271c0c5c1fd0007eb43da8a5121","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":4,"context_line":"# Copyright 2013 Hewlett-Packard Development Company, L.P."},{"line_number":5,"context_line":"# All Rights Reserved."},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F98Bk%3D","line":4,"updated":"2013-12-04 09:01:21.000000000","message":"Same as the above comment","commit_id":"2371017d72d159100a65841bace8122195c6fb74"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"ed03d096f98771a966853b224a49c1063abd72e1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":4,"context_line":"# Copyright 2013 Hewlett-Packard Development Company, L.P."},{"line_number":5,"context_line":"# All Rights Reserved."},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F97Z0%3D","line":4,"in_reply_to":"AAAATn%2F98Bk%3D","updated":"2013-12-04 11:35:53.000000000","message":"No. this is a copy from scenario/test_network_basic_ops.py","commit_id":"2371017d72d159100a65841bace8122195c6fb74"}],"tempest/scenario/test_network_basic_ops.py":[{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"676cdb4e5772d0e08a8add8acbdd8c2f16e2f149","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    VMs. It only checks for a given IP address once."},{"line_number":39,"context_line":"    \"\"\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def __init__(self, compute_client, server, floating_ips):"},{"line_number":42,"context_line":"        self.compute_client \u003d compute_client"},{"line_number":43,"context_line":"        self.server \u003d server"},{"line_number":44,"context_line":"        self.floating_ips \u003d floating_ips"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F8%2BjY%3D","line":41,"updated":"2013-12-18 07:21:49.000000000","message":"Don\u0027t change this locally.\nThis is actually a good example for a feature we would like to share between all scenarios, so it should be a in a base module (or manager) and get collections as input.\nSome scenarios will use it with a single FLIP, others with more than one.\nConsider having it deal with VMs from multiple tenants - by loading a compute_client with admin creds.","commit_id":"6da2637688b63b6ac0e0ee25dbbeb6baee7ba1bb"}]}