)]}'
{"releasenotes/notes/config-image-api-v1-default-to-false-39d5f2xafc534ab1.yaml":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c3bd6422b2b3e82cf512a0d0955286fd8e0f5bdb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Set \u0027api_v1\u0027 config option in the \u0027image-feature-enabled\u0027 group"},{"line_number":5,"context_line":"    default to False because otherwise it has to be explicitly set to"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_7c624d18","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":5},"updated":"2018-09-05 09:22:33.000000000","message":"this should go in upgrade section.","commit_id":"f2177f08883bd54602d64aa7db9f2a7e0ee80c37"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"173673c6a2c3af4d7ba46654aa4aafd3d8885be5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Set \u0027api_v1\u0027 config option in the \u0027image-feature-enabled\u0027 group"},{"line_number":5,"context_line":"    default to False because otherwise it has to be explicitly set to"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_57a5ea01","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":5},"in_reply_to":"3f79a3b5_7c624d18","updated":"2018-09-05 09:35:02.000000000","message":"Done","commit_id":"f2177f08883bd54602d64aa7db9f2a7e0ee80c37"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"63114ec3d1aa59a68ec8d0aba532ea6ba165e462","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Set \u0027api_v1\u0027 config option in the \u0027image-feature-enabled\u0027 group"},{"line_number":5,"context_line":"    default to False because otherwise it has to be explicitly set to"},{"line_number":6,"context_line":"    False in tempest.conf for now glance v1 APIs are deprecated and v2"},{"line_number":7,"context_line":"    APIs are current one."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_b2a45e08","line":7,"range":{"start_line":4,"start_character":4,"end_line":7,"end_character":25},"updated":"2018-09-07 02:35:37.000000000","message":"TBH, it is a little difficult to read the original.\nHow about\n\n Changed the default value of \u0027api_v1\u0027 config option in the\n \u0027image-feature-enabled\u0027 group to False from True, because\n glance v1 APIs are deprecated. Please set True explicitly\n on the option if still testing glance v1 APIs.","commit_id":"650b98ac2b641b87f9ca528a17b831a5c07c49d4"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"11cab343942d8687cfbc3d5b423bdc3eeaa08cd5","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Set \u0027api_v1\u0027 config option in the \u0027image-feature-enabled\u0027 group"},{"line_number":5,"context_line":"    default to False because otherwise it has to be explicitly set to"},{"line_number":6,"context_line":"    False in tempest.conf for now glance v1 APIs are deprecated and v2"},{"line_number":7,"context_line":"    APIs are current one."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_727a7188","line":7,"range":{"start_line":6,"start_character":26,"end_line":7,"end_character":25},"updated":"2018-09-05 13:02:36.000000000","message":"nit: This should be a separate sentence","commit_id":"650b98ac2b641b87f9ca528a17b831a5c07c49d4"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"25698693fdd2d53b3e91227aa1429a164170f975","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Set \u0027api_v1\u0027 config option in the \u0027image-feature-enabled\u0027 group"},{"line_number":5,"context_line":"    default to False because otherwise it has to be explicitly set to"},{"line_number":6,"context_line":"    False in tempest.conf for now glance v1 APIs are deprecated and v2"},{"line_number":7,"context_line":"    APIs are current one."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_d7b3254d","line":7,"range":{"start_line":6,"start_character":26,"end_line":7,"end_character":25},"in_reply_to":"3f79a3b5_727a7188","updated":"2018-09-06 00:36:08.000000000","message":"Sorry I don\u0027t catch it, can you give an example? I mean that because glance v1 APIS are deprecated so we have to explicitly set api_v1 to False in tempest.conf.","commit_id":"650b98ac2b641b87f9ca528a17b831a5c07c49d4"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"afca6bc19574a1c483b4ccf507bef19bbec7130b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Set \u0027api_v1\u0027 config option in the \u0027image-feature-enabled\u0027 group"},{"line_number":5,"context_line":"    default to False because otherwise it has to be explicitly set to"},{"line_number":6,"context_line":"    False in tempest.conf for now glance v1 APIs are deprecated and v2"},{"line_number":7,"context_line":"    APIs are current one."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_12c67269","line":7,"range":{"start_line":4,"start_character":4,"end_line":7,"end_character":25},"in_reply_to":"3f79a3b5_b2a45e08","updated":"2018-09-07 02:48:13.000000000","message":"That\u0027s ok:)","commit_id":"650b98ac2b641b87f9ca528a17b831a5c07c49d4"}],"tempest/cmd/verify_tempest_config.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c3bd6422b2b3e82cf512a0d0955286fd8e0f5bdb","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    if CONF.image_feature_enabled.api_v1 \u003d\u003d contains_version(\u0027v1.\u0027, versions):"},{"line_number":138,"context_line":"        print_and_or_update(\u0027api_v1\u0027, \u0027image-feature-enabled\u0027,"},{"line_number":139,"context_line":"                            CONF.image_feature_enabled.api_v1, update)"},{"line_number":140,"context_line":"    if CONF.image_feature_enabled.api_v2 !\u003d contains_version(\u0027v2.\u0027, versions):"},{"line_number":141,"context_line":"        print_and_or_update(\u0027api_v2\u0027, \u0027image-feature-enabled\u0027,"},{"line_number":142,"context_line":"                            not CONF.image_feature_enabled.api_v2, update)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_3704ee13","line":139,"range":{"start_line":139,"start_character":69,"end_line":139,"end_character":70},"updated":"2018-09-05 09:22:33.000000000","message":"not sure why we need to change this?","commit_id":"f2177f08883bd54602d64aa7db9f2a7e0ee80c37"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"7d960beb32dcaffd028c8b013056ba655b6b8b2a","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    if CONF.image_feature_enabled.api_v1 \u003d\u003d contains_version(\u0027v1.\u0027, versions):"},{"line_number":138,"context_line":"        print_and_or_update(\u0027api_v1\u0027, \u0027image-feature-enabled\u0027,"},{"line_number":139,"context_line":"                            CONF.image_feature_enabled.api_v1, update)"},{"line_number":140,"context_line":"    if CONF.image_feature_enabled.api_v2 !\u003d contains_version(\u0027v2.\u0027, versions):"},{"line_number":141,"context_line":"        print_and_or_update(\u0027api_v2\u0027, \u0027image-feature-enabled\u0027,"},{"line_number":142,"context_line":"                            not CONF.image_feature_enabled.api_v2, update)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_605d5778","line":139,"updated":"2018-09-10 20:13:51.000000000","message":"yeah, I agree with gmann here.","commit_id":"f2177f08883bd54602d64aa7db9f2a7e0ee80c37"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"173673c6a2c3af4d7ba46654aa4aafd3d8885be5","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    if CONF.image_feature_enabled.api_v1 \u003d\u003d contains_version(\u0027v1.\u0027, versions):"},{"line_number":138,"context_line":"        print_and_or_update(\u0027api_v1\u0027, \u0027image-feature-enabled\u0027,"},{"line_number":139,"context_line":"                            CONF.image_feature_enabled.api_v1, update)"},{"line_number":140,"context_line":"    if CONF.image_feature_enabled.api_v2 !\u003d contains_version(\u0027v2.\u0027, versions):"},{"line_number":141,"context_line":"        print_and_or_update(\u0027api_v2\u0027, \u0027image-feature-enabled\u0027,"},{"line_number":142,"context_line":"                            not CONF.image_feature_enabled.api_v2, update)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_97d6224f","line":139,"range":{"start_line":139,"start_character":69,"end_line":139,"end_character":70},"in_reply_to":"3f79a3b5_3704ee13","updated":"2018-09-05 09:35:02.000000000","message":"Because CONF.image_feature_enabled.api_v1\u0027s default value changes from False to True and the unit tests failed.","commit_id":"f2177f08883bd54602d64aa7db9f2a7e0ee80c37"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"ff5c84676af6195e7f2317958e3933cfccac068b","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    if CONF.image_feature_enabled.api_v1 \u003d\u003d contains_version(\u0027v1.\u0027, versions):"},{"line_number":138,"context_line":"        print_and_or_update(\u0027api_v1\u0027, \u0027image-feature-enabled\u0027,"},{"line_number":139,"context_line":"                            CONF.image_feature_enabled.api_v1, update)"},{"line_number":140,"context_line":"    if CONF.image_feature_enabled.api_v2 !\u003d contains_version(\u0027v2.\u0027, versions):"},{"line_number":141,"context_line":"        print_and_or_update(\u0027api_v2\u0027, \u0027image-feature-enabled\u0027,"},{"line_number":142,"context_line":"                            not CONF.image_feature_enabled.api_v2, update)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_b5eac80b","line":139,"in_reply_to":"3f79a3b5_605d5778","updated":"2018-09-11 00:48:56.000000000","message":"yeah, now tests/cmd/test_verify_tempest_config.py is modified:)","commit_id":"f2177f08883bd54602d64aa7db9f2a7e0ee80c37"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"19c7fa1f25b3b6d7b1cefe25930ad9a0d9bc3750","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    if CONF.image_feature_enabled.api_v1 \u003d\u003d contains_version(\u0027v1.\u0027, versions):"},{"line_number":138,"context_line":"        print_and_or_update(\u0027api_v1\u0027, \u0027image-feature-enabled\u0027,"},{"line_number":139,"context_line":"                            CONF.image_feature_enabled.api_v1, update)"},{"line_number":140,"context_line":"    if CONF.image_feature_enabled.api_v2 !\u003d contains_version(\u0027v2.\u0027, versions):"},{"line_number":141,"context_line":"        print_and_or_update(\u0027api_v2\u0027, \u0027image-feature-enabled\u0027,"},{"line_number":142,"context_line":"                            not CONF.image_feature_enabled.api_v2, update)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_c5b27306","line":139,"range":{"start_line":139,"start_character":69,"end_line":139,"end_character":70},"in_reply_to":"3f79a3b5_97d6224f","updated":"2018-09-07 07:55:19.000000000","message":"yeah so that change should not effect this. old check also can tell user to change the api_v1 from false to True if no their env has v1 endpoints.\n\nI think you can fix the unit test than this cmd\u003e thats what we did in previous cases also where we changed default values.","commit_id":"f2177f08883bd54602d64aa7db9f2a7e0ee80c37"}]}