)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"25a637d62265323b4b0a0d22c7b33137c753e203","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Manik Bindlish \u003cmanikbindlish19@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-09-07 08:38:52 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Handling invalid name of workspace register and rename."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This PS will fix the invalid value handling."},{"line_number":10,"context_line":"Error will be raised if no/blank value will be specified for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_f2831aca","line":7,"updated":"2018-09-14 19:42:50.000000000","message":"very nit: The trailing period is not necessary for the first line.","commit_id":"c5d1c5455fb9d51253a6a21c1afcfdaeb9035394"}],"releasenotes/notes/bug-1791007-328a8b9a43bfb157.yaml":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6176505fc1272844693e3977c6f2b5bb970d68ce","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed bug 1791007. Name of workspace will now throw an error in case of"},{"line_number":5,"context_line":"    empty or no name of workspace. Earlier, blank value was accepted for"},{"line_number":6,"context_line":"    workspace register name and workspace rename."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_2dda33e5","line":6,"range":{"start_line":4,"start_character":0,"end_line":6,"end_character":49},"updated":"2018-10-03 02:27:49.000000000","message":"this is not clear that which CLI or interface workspace name is fixed. How about something below-\n\n    Fixed bug #1791007. ``tempest workspace register`` and ``tempest workspace rename`` CLI will error if None or empty string is passed in --name arguments. Earlier both CLI used to accept the None or empty string as name which was confusing.","commit_id":"c5d1c5455fb9d51253a6a21c1afcfdaeb9035394"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"23562674333fb5ef23d6d1fecd753bbb403cf8fb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed bug 1791007. Name of workspace will now throw an error in case of"},{"line_number":5,"context_line":"    empty or no name of workspace. Earlier, blank value was accepted for"},{"line_number":6,"context_line":"    workspace register name and workspace rename."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_937e0419","line":6,"range":{"start_line":4,"start_character":0,"end_line":6,"end_character":49},"in_reply_to":"3f79a3b5_2dda33e5","updated":"2018-10-03 05:34:17.000000000","message":"Done","commit_id":"c5d1c5455fb9d51253a6a21c1afcfdaeb9035394"}],"tempest/cmd/workspace.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"85b252fe9806f83c15f23f91a61331a8e3515f7e","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            sys.exit(1)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def _invalid_name_check(self, name):"},{"line_number":133,"context_line":"        if not name or name \u003d\u003d \"\":"},{"line_number":134,"context_line":"            print(\"No or invalid name specified.\""},{"line_number":135,"context_line":"                  \" Please specify correct name.\".format(name))"},{"line_number":136,"context_line":"            sys.exit(1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_be98af68","line":133,"range":{"start_line":133,"start_character":20,"end_line":133,"end_character":33},"updated":"2018-09-06 22:01:21.000000000","message":"`not name` covers empty string as well, so this can be reduced to `if not name:`","commit_id":"05c8ab541a3767f907f616e08fd168f01dbfba63"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"85b252fe9806f83c15f23f91a61331a8e3515f7e","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    def _invalid_name_check(self, name):"},{"line_number":133,"context_line":"        if not name or name \u003d\u003d \"\":"},{"line_number":134,"context_line":"            print(\"No or invalid name specified.\""},{"line_number":135,"context_line":"                  \" Please specify correct name.\".format(name))"},{"line_number":136,"context_line":"            sys.exit(1)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def _validate_path(self, path):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_fe92a74a","line":135,"range":{"start_line":135,"start_character":49,"end_line":135,"end_character":62},"updated":"2018-09-06 22:01:21.000000000","message":"This isn\u0027t valid because there\u0027s nothing to substitute this with.","commit_id":"05c8ab541a3767f907f616e08fd168f01dbfba63"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7047a1ad69f5134bc29d28f0c312407cbe77b081","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def _invalid_name_check(self, name):"},{"line_number":133,"context_line":"        if not name:"},{"line_number":134,"context_line":"            print(\"No or invalid name specified.\""},{"line_number":135,"context_line":"                  \" Please specify correct name.\")"},{"line_number":136,"context_line":"            sys.exit(1)"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_85c6bb99","line":134,"range":{"start_line":134,"start_character":19,"end_line":134,"end_character":37},"updated":"2018-09-07 07:50:38.000000000","message":"No name is handle at L189 with required\u003dTrue. this can be to avoid emtptyy string or None so How about below- \n\"None or empty name is specified.\"\n\" Please specify correct name for workspace.\")","commit_id":"3c2b2c0562fa8734eaae559b7484c2546a3a8ce3"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"1b49a460a27a817ffd318fce989e415b157e8270","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def _invalid_name_check(self, name):"},{"line_number":133,"context_line":"        if not name:"},{"line_number":134,"context_line":"            print(\"No or invalid name specified.\""},{"line_number":135,"context_line":"                  \" Please specify correct name.\")"},{"line_number":136,"context_line":"            sys.exit(1)"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_488e7a79","line":134,"range":{"start_line":134,"start_character":19,"end_line":134,"end_character":37},"in_reply_to":"3f79a3b5_85c6bb99","updated":"2018-09-07 08:34:24.000000000","message":"Make sense! will fix it in new patch set","commit_id":"3c2b2c0562fa8734eaae559b7484c2546a3a8ce3"}]}