)]}'
{"tempest/api/compute/admin/test_instance_usage_audit_log.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"25f12d3c7e0dc8fbee6bb6db89ce1846b477451c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        # list instance usage audit logs"},{"line_number":34,"context_line":"        body \u003d (self.adm_client.list_instance_usage_audit_logs()"},{"line_number":35,"context_line":"                [\"instance_usage_audit_logs\"])"},{"line_number":36,"context_line":"        expected_items \u003d [\u0027total_errors\u0027, \u0027total_instances\u0027, \u0027log\u0027,"},{"line_number":37,"context_line":"                          \u0027num_hosts_running\u0027, \u0027num_hosts_done\u0027,"},{"line_number":38,"context_line":"                          \u0027num_hosts\u0027, \u0027hosts_not_run\u0027, \u0027overall_status\u0027,"},{"line_number":39,"context_line":"                          \u0027period_ending\u0027, \u0027period_beginning\u0027,"},{"line_number":40,"context_line":"                          \u0027num_hosts_not_run\u0027]"},{"line_number":41,"context_line":"        for item in expected_items:"},{"line_number":42,"context_line":"            self.assertIn(item, body)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @decorators.idempotent_id(\u00276e40459d-7c5f-400b-9e83-449fbc8e7feb\u0027)"},{"line_number":45,"context_line":"    def test_get_instance_usage_audit_log(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_3ebd7fb0","side":"PARENT","line":42,"range":{"start_line":36,"start_character":0,"end_line":42,"end_character":37},"updated":"2018-09-06 22:10:59.000000000","message":"LGTM, has same keys as schema:\n\n        \u0027log\u0027: {\n            \u0027type\u0027: \u0027object\u0027,\n            \u0027patternProperties\u0027: {\n                # NOTE: Here is a host name.\n                \u0027^.+$\u0027: {\n                    \u0027type\u0027: \u0027object\u0027,\n                    \u0027properties\u0027: {\n                        \u0027state\u0027: {\u0027type\u0027: \u0027string\u0027},\n                        \u0027instances\u0027: {\u0027type\u0027: \u0027integer\u0027},\n                        \u0027errors\u0027: {\u0027type\u0027: \u0027integer\u0027},\n                        \u0027message\u0027: {\u0027type\u0027: \u0027string\u0027}\n                    },\n                    \u0027additionalProperties\u0027: False,\n                    \u0027required\u0027: [\u0027state\u0027, \u0027instances\u0027, \u0027errors\u0027, \u0027message\u0027]\n                }\n            }\n        },\n        \u0027num_hosts\u0027: {\u0027type\u0027: \u0027integer\u0027},\n        \u0027num_hosts_done\u0027: {\u0027type\u0027: \u0027integer\u0027},\n        \u0027num_hosts_not_run\u0027: {\u0027type\u0027: \u0027integer\u0027},\n        \u0027num_hosts_running\u0027: {\u0027type\u0027: \u0027integer\u0027},\n        \u0027overall_status\u0027: {\u0027type\u0027: \u0027string\u0027},\n        \u0027period_beginning\u0027: {\u0027type\u0027: \u0027string\u0027},\n        \u0027period_ending\u0027: {\u0027type\u0027: \u0027string\u0027},\n        \u0027total_errors\u0027: {\u0027type\u0027: \u0027integer\u0027},\n        \u0027total_instances\u0027: {\u0027type\u0027: \u0027integer\u0027}","commit_id":"293e36c61d33c728a9609c678d087f5526c4ed16"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"2d48a6bbc179de9008ebb528a3dfb8fdd102415f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @decorators.idempotent_id(\u002725319919-33d9-424f-9f99-2c203ee48b9d\u0027)"},{"line_number":32,"context_line":"    def test_list_instance_usage_audit_logs(self):"},{"line_number":33,"context_line":"        # list instance usage audit logs"},{"line_number":34,"context_line":"        self.adm_client.list_instance_usage_audit_logs()"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @decorators.idempotent_id(\u00276e40459d-7c5f-400b-9e83-449fbc8e7feb\u0027)"},{"line_number":37,"context_line":"    def test_get_instance_usage_audit_log(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_e07a1275","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":56},"updated":"2018-09-06 11:34:15.000000000","message":"How the test verification is achieved here?\nI mean nothing is checked in test case.","commit_id":"6e7c86e1194c30b93098921a6ce4f704b9216d6c"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"8619d5b38546a531ddc41d2bcbb174deab97f7ae","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @decorators.idempotent_id(\u002725319919-33d9-424f-9f99-2c203ee48b9d\u0027)"},{"line_number":32,"context_line":"    def test_list_instance_usage_audit_logs(self):"},{"line_number":33,"context_line":"        # list instance usage audit logs"},{"line_number":34,"context_line":"        self.adm_client.list_instance_usage_audit_logs()"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @decorators.idempotent_id(\u00276e40459d-7c5f-400b-9e83-449fbc8e7feb\u0027)"},{"line_number":37,"context_line":"    def test_get_instance_usage_audit_log(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_3389306e","line":34,"updated":"2018-09-07 06:33:11.000000000","message":"hmm, yeah, it looks weird at a glance. It\u0027s good to add a NOTE/comment here and following. But we can do it with a following patch if we need it.","commit_id":"6e7c86e1194c30b93098921a6ce4f704b9216d6c"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"67e7d7b11c7883e47f44590fc564619038e822d5","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @decorators.idempotent_id(\u002725319919-33d9-424f-9f99-2c203ee48b9d\u0027)"},{"line_number":32,"context_line":"    def test_list_instance_usage_audit_logs(self):"},{"line_number":33,"context_line":"        # list instance usage audit logs"},{"line_number":34,"context_line":"        self.adm_client.list_instance_usage_audit_logs()"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @decorators.idempotent_id(\u00276e40459d-7c5f-400b-9e83-449fbc8e7feb\u0027)"},{"line_number":37,"context_line":"    def test_get_instance_usage_audit_log(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_586deb2f","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":56},"in_reply_to":"3f79a3b5_deb80bc9","updated":"2018-09-07 05:55:41.000000000","message":"Got it, it\u0027s already validating in:\nhttps://github.com/openstack/tempest/blob/9594233ffd93066677aa601c594d55f3a4f188d8/tempest/lib/services/compute/instance_usage_audit_log_client.py#L30","commit_id":"6e7c86e1194c30b93098921a6ce4f704b9216d6c"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"25f12d3c7e0dc8fbee6bb6db89ce1846b477451c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @decorators.idempotent_id(\u002725319919-33d9-424f-9f99-2c203ee48b9d\u0027)"},{"line_number":32,"context_line":"    def test_list_instance_usage_audit_logs(self):"},{"line_number":33,"context_line":"        # list instance usage audit logs"},{"line_number":34,"context_line":"        self.adm_client.list_instance_usage_audit_logs()"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @decorators.idempotent_id(\u00276e40459d-7c5f-400b-9e83-449fbc8e7feb\u0027)"},{"line_number":37,"context_line":"    def test_get_instance_usage_audit_log(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_deb80bc9","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":56},"in_reply_to":"3f79a3b5_e07a1275","updated":"2018-09-06 22:10:59.000000000","message":"See commit message: \"The response checks in InstanceUsageAuditLogTestJSON are already covered by schema check, so no need to check it in testcases.\"","commit_id":"6e7c86e1194c30b93098921a6ce4f704b9216d6c"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"2d48a6bbc179de9008ebb528a3dfb8fdd102415f","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def test_get_instance_usage_audit_log(self):"},{"line_number":38,"context_line":"        # Get instance usage audit log before specified time"},{"line_number":39,"context_line":"        now \u003d datetime.datetime.now()"},{"line_number":40,"context_line":"        self.adm_client.show_instance_usage_audit_log("},{"line_number":41,"context_line":"            urllib.quote(now.strftime(\"%Y-%m-%d %H:%M:%S\")))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c09356a2","line":41,"range":{"start_line":40,"start_character":7,"end_line":41,"end_character":60},"updated":"2018-09-06 11:34:15.000000000","message":"ditto","commit_id":"6e7c86e1194c30b93098921a6ce4f704b9216d6c"}]}