)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"84643443601edfad1761ea208db65bdca0b79d04","unresolved":false,"context_lines":[{"line_number":12,"context_line":"It will improve tempest workspace CLI."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I06d04acad43533d7f2e912a4a8425da06561b0fa"},{"line_number":15,"context_line":"Partially-Implements: blueprint tempest-cli-unit-test-coverage"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_8016e9f1","line":15,"updated":"2018-09-17 21:57:48.000000000","message":"Should add\n\n   Depends-On: https://review.openstack.org/#/c/600343/\n\nto bottom of commit message.","commit_id":"c6d9a247ab806290f1f62de83960664682c7f822"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8df8e470449a317ec7ba9e1540563019d85354b2","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"It will improve tempest workspace CLI."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-On: https://review.openstack.org/#/c/600343/"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I06d04acad43533d7f2e912a4a8425da06561b0fa"},{"line_number":17,"context_line":"Partially-Implements: blueprint tempest-cli-unit-test-coverage"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_b25865f9","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":52},"updated":"2018-10-09 06:12:54.000000000","message":"this is same repo patch so can be added as dependent directly. Depends-On is used for cross repo dependency. \n\nMore details to add a dependency -  \nhttps://docs.openstack.org/infra/manual/developers.html#adding-a-dependency","commit_id":"0bd567fca41fa0615e759ef66ad9c646f9d007c1"}],"tempest/tests/cmd/test_workspace.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"4c58aa879384aeb6604f085d18ab9ce7cbaad6b1","unresolved":false,"context_lines":[{"line_number":284,"context_line":"                         \"A workspace already exists with name: %s.\\n\""},{"line_number":285,"context_line":"                         % duplicate_name)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def test_workspace_name_exists_check_new_name(self):"},{"line_number":288,"context_line":"        new_name \u003d \"fake_name\""},{"line_number":289,"context_line":"        self.assertIsNone(self.workspace_manager."},{"line_number":290,"context_line":"                          _workspace_name_exists(new_name))"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_b5bea161","line":287,"range":{"start_line":287,"start_character":8,"end_line":287,"end_character":49},"updated":"2018-10-25 19:07:02.000000000","message":"But it doesn\u0027t exist or else sys.exit(1) would be called. This should pass in self.name, not self.path.\n\nShould do what L239-242 above does, approximately.","commit_id":"d726f96e0836f26ad794194f0f9e13d4f6299d59"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"4c58aa879384aeb6604f085d18ab9ce7cbaad6b1","unresolved":false,"context_lines":[{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def test_workspace_name_exists_check_new_name(self):"},{"line_number":288,"context_line":"        new_name \u003d \"fake_name\""},{"line_number":289,"context_line":"        self.assertIsNone(self.workspace_manager."},{"line_number":290,"context_line":"                          _workspace_name_exists(new_name))"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    def test_workspace_manager_path_not_exist(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_75e6c9b1","line":289,"range":{"start_line":289,"start_character":8,"end_line":289,"end_character":25},"updated":"2018-10-25 19:07:02.000000000","message":"nit: This assertion isn\u0027t really needed but doesn\u0027t hurt either. It\u0027s implcitly validated because sys.exit(1) isn\u0027t called.","commit_id":"d726f96e0836f26ad794194f0f9e13d4f6299d59"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"3f68bc57426f438abb14499c3108ac2b52e49293","unresolved":false,"context_lines":[{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def test_workspace_name_exists_check_new_name(self):"},{"line_number":288,"context_line":"        new_name \u003d \"fake_name\""},{"line_number":289,"context_line":"        self.assertIsNone(self.workspace_manager."},{"line_number":290,"context_line":"                          _workspace_name_exists(new_name))"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    def test_workspace_manager_path_not_exist(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_f63975a1","line":289,"range":{"start_line":289,"start_character":8,"end_line":289,"end_character":25},"in_reply_to":"3f79a3b5_75e6c9b1","updated":"2018-10-26 09:23:04.000000000","message":"We are passing any new name here, which is not existing earlier.\nIf name already exist then it will error with sys.exit(1). Already have unit test in L[275-285]. L239-L42 will applicable for test: test_workspace_name_already_exists\n\nNow it is returning none. It will check when condition will not go under if condition or whenever  any new name will be passed. So it will add more value.\nPlease suggest further opinion on it?","commit_id":"d726f96e0836f26ad794194f0f9e13d4f6299d59"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"36e0d79e07470b3a1643597a6b9115bd26bafaf3","unresolved":false,"context_lines":[{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def test_workspace_name_exists_check_new_name(self):"},{"line_number":288,"context_line":"        new_name \u003d \"fake_name\""},{"line_number":289,"context_line":"        self.assertIsNone(self.workspace_manager."},{"line_number":290,"context_line":"                          _workspace_name_exists(new_name))"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    def test_workspace_manager_path_not_exist(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_06af8a9d","line":289,"range":{"start_line":289,"start_character":8,"end_line":289,"end_character":25},"in_reply_to":"3f79a3b5_f63975a1","updated":"2018-11-19 23:15:04.000000000","message":"This test is correct; I think my comment may have been in regards to another test, not sure. Sorry for the confusion.","commit_id":"d726f96e0836f26ad794194f0f9e13d4f6299d59"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"4c58aa879384aeb6604f085d18ab9ce7cbaad6b1","unresolved":false,"context_lines":[{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    def test_validate_path_exists(self):"},{"line_number":303,"context_line":"        new_path \u003d self.path"},{"line_number":304,"context_line":"        self.assertIsNone(self.workspace_manager."},{"line_number":305,"context_line":"                          _workspace_name_exists(new_path))"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    def test_workspace_manager_list_workspaces(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_b5f0e167","line":304,"range":{"start_line":304,"start_character":8,"end_line":304,"end_character":25},"updated":"2018-10-25 19:07:02.000000000","message":"nit: This assertion isn\u0027t really needed but doesn\u0027t hurt either. It\u0027s implcitly validated because sys.exit(1) isn\u0027t called.","commit_id":"d726f96e0836f26ad794194f0f9e13d4f6299d59"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"4c58aa879384aeb6604f085d18ab9ce7cbaad6b1","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    def test_validate_path_exists(self):"},{"line_number":303,"context_line":"        new_path \u003d self.path"},{"line_number":304,"context_line":"        self.assertIsNone(self.workspace_manager."},{"line_number":305,"context_line":"                          _workspace_name_exists(new_path))"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    def test_workspace_manager_list_workspaces(self):"},{"line_number":308,"context_line":"        listed \u003d self.workspace_manager.list_workspaces()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_95b9257d","line":305,"range":{"start_line":305,"start_character":26,"end_line":305,"end_character":48},"updated":"2018-10-25 19:07:02.000000000","message":"Shouldn\u0027t this call get_workspace?","commit_id":"d726f96e0836f26ad794194f0f9e13d4f6299d59"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"3f68bc57426f438abb14499c3108ac2b52e49293","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    def test_validate_path_exists(self):"},{"line_number":303,"context_line":"        new_path \u003d self.path"},{"line_number":304,"context_line":"        self.assertIsNone(self.workspace_manager."},{"line_number":305,"context_line":"                          _workspace_name_exists(new_path))"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    def test_workspace_manager_list_workspaces(self):"},{"line_number":308,"context_line":"        listed \u003d self.workspace_manager.list_workspaces()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_163751ff","line":305,"range":{"start_line":305,"start_character":26,"end_line":305,"end_character":48},"in_reply_to":"3f79a3b5_95b9257d","updated":"2018-10-26 09:23:04.000000000","message":"_validate_path needs to call, mistakenly used \"_workspace_name_exists\", so fix will depend on above comment because same situation here too.","commit_id":"d726f96e0836f26ad794194f0f9e13d4f6299d59"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1bb24f7933fb2d972c06825e093f1bab659c4376","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                         \"A workspace already exists with name: %s.\\n\""},{"line_number":145,"context_line":"                         % new_name)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def test_workspace_manager_rename_no_exist_old_name(self):"},{"line_number":148,"context_line":"        old_name \u003d \"\""},{"line_number":149,"context_line":"        new_name \u003d data_utils.rand_uuid()"},{"line_number":150,"context_line":"        with patch(\u0027sys.stdout\u0027, new_callable\u003dStringIO) as mock_stdout:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_01502cd4","line":147,"range":{"start_line":147,"start_character":38,"end_line":147,"end_character":55},"updated":"2019-02-05 02:12:16.000000000","message":"non_exit_workspace","commit_id":"c825424a54c85d6d716a55c52886333840b63624"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1bb24f7933fb2d972c06825e093f1bab659c4376","unresolved":false,"context_lines":[{"line_number":358,"context_line":"                         \" Please specify correct workspace path.\\n\")"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    def test_register_new_workspace_integer_data(self):"},{"line_number":361,"context_line":"        workspace_name \u003d 12345"},{"line_number":362,"context_line":"        self.workspace_manager.register_new_workspace("},{"line_number":363,"context_line":"            workspace_name, self.path)"},{"line_number":364,"context_line":"        self.assertIsNotNone("}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_c108e4da","line":361,"range":{"start_line":361,"start_character":25,"end_line":361,"end_character":30},"updated":"2019-02-05 02:12:16.000000000","message":"I thought it is only alphabet but it should be ok to allow name as integer.","commit_id":"c825424a54c85d6d716a55c52886333840b63624"}]}