)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5950,"name":"Ilya Shakhat","email":"shakhat@gmail.com","username":"shakhat"},"change_message_id":"02965de793e3560ee8724f2ecfc47f9725be33f6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Masayuki Igawa \u003cmasayuki@igawa.io\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-09-26 14:28:11 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use tempest run command directly for full job"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit makes to use `tempest run` command directly for the full"},{"line_number":10,"context_line":"job. We currently use tempest run command in tox.ini. However, it\u0027s"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3f79a3b5_a3f808c1","line":7,"updated":"2018-10-22 13:43:35.000000000","message":"Consider a project that uses a job `tempest-full`. The job is defined in tempest .zuul.yaml (https://github.com/openstack/tempest/blob/master/.zuul.yaml#L53-L68). One of job\u0027s parameters is called `tox_envlist: full`, and user may logically think that the job uses tox with environment `full`... But with this patch it is not true anymore. A user will have to look to playbook and roles to figure out that Tempest is executed directly. Following that path may be not so obvious for persons from outside of Tempest community and for sure does not make their life easier.","commit_id":"143b6ab7cc0f15d048cd1ab53ccacb83943db102"}],"roles/run-tempest/tasks/main.yaml":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"1a9c9e97391f670ba380efaa210469032b0a248f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    chdir: \"{{devstack_base_dir}}/tempest\""},{"line_number":43,"context_line":"  become: true"},{"line_number":44,"context_line":"  become_user: tempest"},{"line_number":45,"context_line":"  when: tox_envlist !\u003d \u0027full\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: Run Tempest with tempest run"},{"line_number":48,"context_line":"  shell: |"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f79a3b5_538cc52c","line":45,"updated":"2018-10-17 02:15:36.000000000","message":"Maybe it is better to add .zuul.yaml option here to toggle on tempest_run vs tox? Like a new flag called:\n\n    use_tempest_run\n\nAnd then change when to be:\n\n    when: tox_envlist \u003d\u003d \u0027full\u0027 and not use_tempest_run\n\nThen below becomes:\n\n     when: tox_envlist \u003d\u003d \u0027full\u0027 and use_tempest_run\n\nI\u0027m wondering if it matters that this change affects all projects currently gating tempest full?","commit_id":"143b6ab7cc0f15d048cd1ab53ccacb83943db102"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"31883dc66a5d18a4cf58e55a68f090d54e3ac95a","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    chdir: \"{{devstack_base_dir}}/tempest\""},{"line_number":43,"context_line":"  become: true"},{"line_number":44,"context_line":"  become_user: tempest"},{"line_number":45,"context_line":"  when: tox_envlist !\u003d \u0027full\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: Run Tempest with tempest run"},{"line_number":48,"context_line":"  shell: |"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f79a3b5_ba6de968","line":45,"updated":"2018-10-17 07:03:00.000000000","message":"Yeah, that change should be straightforward. But I have the same concern about that. I\u0027ll dig it more..","commit_id":"143b6ab7cc0f15d048cd1ab53ccacb83943db102"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"31883dc66a5d18a4cf58e55a68f090d54e3ac95a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  become_user: tempest"},{"line_number":45,"context_line":"  when: tox_envlist !\u003d \u0027full\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: Run Tempest with tempest run"},{"line_number":48,"context_line":"  shell: |"},{"line_number":49,"context_line":"    set -e"},{"line_number":50,"context_line":"    find . -type f -name \"*.pyc\" -delete"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f79a3b5_5a885519","line":47,"updated":"2018-10-17 07:03:00.000000000","message":"I agree. will do","commit_id":"143b6ab7cc0f15d048cd1ab53ccacb83943db102"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"1a9c9e97391f670ba380efaa210469032b0a248f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  become_user: tempest"},{"line_number":45,"context_line":"  when: tox_envlist !\u003d \u0027full\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: Run Tempest with tempest run"},{"line_number":48,"context_line":"  shell: |"},{"line_number":49,"context_line":"    set -e"},{"line_number":50,"context_line":"    find . -type f -name \"*.pyc\" -delete"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f79a3b5_d391b554","line":47,"updated":"2018-10-17 02:15:36.000000000","message":"Maybe it is good to include comment or description explaining usefulnes of this?","commit_id":"143b6ab7cc0f15d048cd1ab53ccacb83943db102"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"1a9c9e97391f670ba380efaa210469032b0a248f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  shell: |"},{"line_number":49,"context_line":"    set -e"},{"line_number":50,"context_line":"    find . -type f -name \"*.pyc\" -delete"},{"line_number":51,"context_line":"    . .tox/tempest/bin/activate"},{"line_number":52,"context_line":"    tempest --version"},{"line_number":53,"context_line":"    tempest run --regex \u0027(?!.*\\[.*\\bslow\\b.*\\])(^tempest\\.api)\u0027 \\"},{"line_number":54,"context_line":"            {{blacklist_option|default(\u0027\u0027)}} \\"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f79a3b5_f3de313a","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":31},"updated":"2018-10-17 02:15:36.000000000","message":"Is this guaranteed to exist? Else may have to do:\n\n    tox -e venv-tempest\n\nbeforehand.","commit_id":"143b6ab7cc0f15d048cd1ab53ccacb83943db102"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"31883dc66a5d18a4cf58e55a68f090d54e3ac95a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  shell: |"},{"line_number":49,"context_line":"    set -e"},{"line_number":50,"context_line":"    find . -type f -name \"*.pyc\" -delete"},{"line_number":51,"context_line":"    . .tox/tempest/bin/activate"},{"line_number":52,"context_line":"    tempest --version"},{"line_number":53,"context_line":"    tempest run --regex \u0027(?!.*\\[.*\\bslow\\b.*\\])(^tempest\\.api)\u0027 \\"},{"line_number":54,"context_line":"            {{blacklist_option|default(\u0027\u0027)}} \\"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f79a3b5_7a8d1128","line":51,"updated":"2018-10-17 07:03:00.000000000","message":"hm, good point. We should do it. I\u0027ll update this patch.","commit_id":"143b6ab7cc0f15d048cd1ab53ccacb83943db102"}]}