)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"0c36f14f0f4def76bc6b0661e22030aa84d13e59","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add response schema validation for volume services"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is to add response schema validation for volume"},{"line_number":10,"context_line":"servicess."},{"line_number":11,"context_line":"Besides, there are some inconsistencies in volume services api ref,"},{"line_number":12,"context_line":"I2435e3dc7c704de158b479d2ea543409b7686a07 will fix them."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_455f430e","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":9},"updated":"2018-09-20 08:48:35.000000000","message":"very nit: servicess \u003e services","commit_id":"50789df1cc394df52cb79d749e96d9ac706355f4"}],"tempest/lib/api_schema/response/volume/services.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d65559a6e1a661d7fcd85d7dc66b88a5ad9c041f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                        \u0027state\u0027: {\u0027enum\u0027: [\u0027up\u0027, \u0027down\u0027]},"},{"line_number":30,"context_line":"                        \u0027status\u0027: {\u0027enum\u0027: [\u0027enabled\u0027, \u0027disabled\u0027]},"},{"line_number":31,"context_line":"                        \u0027frozen\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":32,"context_line":"                        \u0027updated_at\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":33,"context_line":"                        \u0027zone\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":34,"context_line":"                        \u0027cluster\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":35,"context_line":"                        \u0027replication_status\u0027: {\u0027type\u0027: \u0027string\u0027},"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_f07f7566","line":32,"range":{"start_line":32,"start_character":48,"end_line":32,"end_character":54},"updated":"2018-10-24 05:22:38.000000000","message":"Should probably be parameter_types.datetime_or_null","commit_id":"50789df1cc394df52cb79d749e96d9ac706355f4"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"c886ee17dfe9b0feb8462c0fcdf2982d297538ad","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                        \u0027state\u0027: {\u0027enum\u0027: [\u0027up\u0027, \u0027down\u0027]},"},{"line_number":30,"context_line":"                        \u0027status\u0027: {\u0027enum\u0027: [\u0027enabled\u0027, \u0027disabled\u0027]},"},{"line_number":31,"context_line":"                        \u0027frozen\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":32,"context_line":"                        \u0027updated_at\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":33,"context_line":"                        \u0027zone\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":34,"context_line":"                        \u0027cluster\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":35,"context_line":"                        \u0027replication_status\u0027: {\u0027type\u0027: \u0027string\u0027},"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_b562213c","line":32,"range":{"start_line":32,"start_character":48,"end_line":32,"end_character":54},"in_reply_to":"3f79a3b5_16246ab1","updated":"2018-10-25 19:01:10.000000000","message":"Then why not parameter_types.datetime?","commit_id":"50789df1cc394df52cb79d749e96d9ac706355f4"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"0b8920ae873091d95c089702acd2571ae25f8144","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                        \u0027state\u0027: {\u0027enum\u0027: [\u0027up\u0027, \u0027down\u0027]},"},{"line_number":30,"context_line":"                        \u0027status\u0027: {\u0027enum\u0027: [\u0027enabled\u0027, \u0027disabled\u0027]},"},{"line_number":31,"context_line":"                        \u0027frozen\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":32,"context_line":"                        \u0027updated_at\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":33,"context_line":"                        \u0027zone\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":34,"context_line":"                        \u0027cluster\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":35,"context_line":"                        \u0027replication_status\u0027: {\u0027type\u0027: \u0027string\u0027},"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_fbb16301","line":32,"range":{"start_line":32,"start_character":48,"end_line":32,"end_character":54},"in_reply_to":"3f79a3b5_b562213c","updated":"2018-10-26 04:02:10.000000000","message":"Yes should be datetime","commit_id":"50789df1cc394df52cb79d749e96d9ac706355f4"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"c7054d6f63313ceaad75a8f97ecb013fcc86c579","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                        \u0027state\u0027: {\u0027enum\u0027: [\u0027up\u0027, \u0027down\u0027]},"},{"line_number":30,"context_line":"                        \u0027status\u0027: {\u0027enum\u0027: [\u0027enabled\u0027, \u0027disabled\u0027]},"},{"line_number":31,"context_line":"                        \u0027frozen\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":32,"context_line":"                        \u0027updated_at\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":33,"context_line":"                        \u0027zone\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":34,"context_line":"                        \u0027cluster\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":35,"context_line":"                        \u0027replication_status\u0027: {\u0027type\u0027: \u0027string\u0027},"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_16246ab1","line":32,"range":{"start_line":32,"start_character":48,"end_line":32,"end_character":54},"in_reply_to":"3f79a3b5_f07f7566","updated":"2018-10-24 06:35:56.000000000","message":"Yes if field \u0027created_at\u0027 exists, updated_at can usually be null. Here \u0027updated_at\u0027 is something like \u0027created_at\u0027, so it won\u0027t take null value.","commit_id":"50789df1cc394df52cb79d749e96d9ac706355f4"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d65559a6e1a661d7fcd85d7dc66b88a5ad9c041f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                        \u0027frozen\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":32,"context_line":"                        \u0027updated_at\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":33,"context_line":"                        \u0027zone\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":34,"context_line":"                        \u0027cluster\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":35,"context_line":"                        \u0027replication_status\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":36,"context_line":"                        \u0027active_backend_id\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":37,"context_line":"                        \u0027backend_state\u0027: {\u0027type\u0027: \u0027string\u0027},"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_70aa85d3","line":34,"range":{"start_line":34,"start_character":24,"end_line":34,"end_character":54},"updated":"2018-10-24 05:22:38.000000000","message":"This one is new in 3.7 microversion so this should be added for 3.7 microversion of this api_schema.","commit_id":"50789df1cc394df52cb79d749e96d9ac706355f4"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"c7054d6f63313ceaad75a8f97ecb013fcc86c579","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                        \u0027frozen\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":32,"context_line":"                        \u0027updated_at\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":33,"context_line":"                        \u0027zone\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":34,"context_line":"                        \u0027cluster\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":35,"context_line":"                        \u0027replication_status\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":36,"context_line":"                        \u0027active_backend_id\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":37,"context_line":"                        \u0027backend_state\u0027: {\u0027type\u0027: \u0027string\u0027},"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_364e466e","line":34,"range":{"start_line":34,"start_character":24,"end_line":34,"end_character":54},"in_reply_to":"3f79a3b5_70aa85d3","updated":"2018-10-24 06:35:56.000000000","message":"Thanks, Done.\na TODO is added for it.\n\"cluster is added in 3.7, we should move it to the 3.7 schema file when microversion is supported in volume interfaces\"","commit_id":"50789df1cc394df52cb79d749e96d9ac706355f4"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d65559a6e1a661d7fcd85d7dc66b88a5ad9c041f","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            \u0027host\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":58,"context_line":"            \u0027service\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":59,"context_line":"            \u0027binary\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":60,"context_line":"            \u0027disabled_reason\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]}"},{"line_number":61,"context_line":"        },"},{"line_number":62,"context_line":"        \u0027additionalProperties\u0027: False,"},{"line_number":63,"context_line":"        \u0027required\u0027: [\u0027disabled\u0027, \u0027status\u0027, \u0027host\u0027, \u0027service\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_b0ea5d0a","line":60,"range":{"start_line":60,"start_character":12,"end_line":60,"end_character":59},"updated":"2018-10-24 05:22:38.000000000","message":"I don\u0027t think this is actually returned: https://github.com/openstack/cinder/blob/b405f8c0d428386de743c5b6ab4bf7f8274213dc/cinder/api/contrib/services.py#L260\n\nIt seems to only be included for action disable-log-reason API action.","commit_id":"50789df1cc394df52cb79d749e96d9ac706355f4"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"c7054d6f63313ceaad75a8f97ecb013fcc86c579","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            \u0027host\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":58,"context_line":"            \u0027service\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":59,"context_line":"            \u0027binary\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":60,"context_line":"            \u0027disabled_reason\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]}"},{"line_number":61,"context_line":"        },"},{"line_number":62,"context_line":"        \u0027additionalProperties\u0027: False,"},{"line_number":63,"context_line":"        \u0027required\u0027: [\u0027disabled\u0027, \u0027status\u0027, \u0027host\u0027, \u0027service\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_f015354d","line":60,"range":{"start_line":60,"start_character":12,"end_line":60,"end_character":59},"in_reply_to":"3f79a3b5_b0ea5d0a","updated":"2018-10-24 06:35:56.000000000","message":"\u0027disabled_reaons\u0027 is always returned, and for action like enable-service, the disabled_reason returned is null. (BTW, here \u0027disabled_reason\u0027 is in the required list, and no testcase failed)","commit_id":"50789df1cc394df52cb79d749e96d9ac706355f4"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"6e7373bcd3f5e2311711eee21596432706d9624d","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest.lib.api_schema.response.compute.v2_1 import parameter_types"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"list_services \u003d {"},{"line_number":19,"context_line":"    \u0027status_code\u0027: [200],"},{"line_number":20,"context_line":"    \u0027response_body\u0027: {"},{"line_number":21,"context_line":"        \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_72e34835","line":18,"updated":"2019-08-19 18:40:02.000000000","message":"LGTM as https://docs.openstack.org/api-ref/block-storage/v3/index.html?expanded\u003dlist-all-cinder-services-detail#list-all-cinder-services","commit_id":"38a78be61547c84f65019d38f5c5fd62c5dc842f"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"6e7373bcd3f5e2311711eee21596432706d9624d","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":"}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"enable_service \u003d {"},{"line_number":56,"context_line":"    \u0027status_code\u0027: [200],"},{"line_number":57,"context_line":"    \u0027response_body\u0027: {"},{"line_number":58,"context_line":"        \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_32d39062","line":55,"updated":"2019-08-19 18:40:02.000000000","message":"LGTM as https://docs.openstack.org/api-ref/block-storage/v3/index.html?expanded\u003denable-a-cinder-service-detail#enable-a-cinder-service","commit_id":"38a78be61547c84f65019d38f5c5fd62c5dc842f"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"6e7373bcd3f5e2311711eee21596432706d9624d","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    }"},{"line_number":71,"context_line":"}"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"disable_service \u003d {"},{"line_number":74,"context_line":"    \u0027status_code\u0027: [200],"},{"line_number":75,"context_line":"    \u0027response_body\u0027: {"},{"line_number":76,"context_line":"        \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_d2c1dc81","line":73,"updated":"2019-08-19 18:40:02.000000000","message":"LGTM as https://docs.openstack.org/api-ref/block-storage/v3/index.html?expanded\u003ddisable-a-cinder-service-detail#enable-a-cinder-service","commit_id":"38a78be61547c84f65019d38f5c5fd62c5dc842f"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"6e7373bcd3f5e2311711eee21596432706d9624d","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            \u0027binary\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":83,"context_line":"        },"},{"line_number":84,"context_line":"        \u0027additionalProperties\u0027: False,"},{"line_number":85,"context_line":"        \u0027required\u0027: [\u0027disabled\u0027, \u0027status\u0027, \u0027host\u0027, \u0027service\u0027, \u0027binary\u0027]"},{"line_number":86,"context_line":"    }"},{"line_number":87,"context_line":"}"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_d246bc21","line":85,"range":{"start_line":85,"start_character":51,"end_line":85,"end_character":60},"updated":"2019-08-19 18:40:02.000000000","message":"\u0027service\u0027 seems deprecated, so this required will be necessary to be removed on some microversion in the future.\nAt this time, it is fine to keep here.","commit_id":"38a78be61547c84f65019d38f5c5fd62c5dc842f"}]}