)]}'
{"tempest/api/network/test_ip_availability.py":[{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"bf3c42a50c31869dffd76eb73be07040c3da0c5c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        cls.subnet \u003d cls.create_subnet(cls.network, enable_dhcp\u003dFalse)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @decorators.idempotent_id(\u0027ee76bfaf-ac94-4d74-9ecc-4bbd4c583cb1\u0027)"},{"line_number":29,"context_line":"    def test_create_list_availabile_ip(self):"},{"line_number":30,"context_line":"        available_ips \u003d self.ip_availability_client.\\"},{"line_number":31,"context_line":"            list_available_ip(self.network[\u0027project_id\u0027])"},{"line_number":32,"context_line":"        network_id \u003d available_ips[\u0027network_ip_availabilities\u0027][0]["}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_f29df6ba","line":29,"range":{"start_line":29,"start_character":13,"end_line":29,"end_character":25},"updated":"2018-09-20 05:48:43.000000000","message":"function name seems incorrect, there is nothing related to create","commit_id":"ee447e4d975787cbaf0910216fba99c01a45046d"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"bf3c42a50c31869dffd76eb73be07040c3da0c5c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        cls.subnet \u003d cls.create_subnet(cls.network, enable_dhcp\u003dFalse)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @decorators.idempotent_id(\u0027ee76bfaf-ac94-4d74-9ecc-4bbd4c583cb1\u0027)"},{"line_number":29,"context_line":"    def test_create_list_availabile_ip(self):"},{"line_number":30,"context_line":"        available_ips \u003d self.ip_availability_client.\\"},{"line_number":31,"context_line":"            list_available_ip(self.network[\u0027project_id\u0027])"},{"line_number":32,"context_line":"        network_id \u003d available_ips[\u0027network_ip_availabilities\u0027][0]["}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_1218b273","line":29,"range":{"start_line":29,"start_character":25,"end_line":29,"end_character":35},"updated":"2018-09-20 05:48:43.000000000","message":"nit: available","commit_id":"ee447e4d975787cbaf0910216fba99c01a45046d"},{"author":{"_account_id":27977,"name":"Lakshmi Prasanna Goutham Pratapa","email":"lakshmi.pratapa@imaginea.com","username":"pratapagoutham"},"change_message_id":"b8b685a46ece624ea2842149cb5ba707deb6128f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        cls.subnet \u003d cls.create_subnet(cls.network, enable_dhcp\u003dFalse)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @decorators.idempotent_id(\u0027ee76bfaf-ac94-4d74-9ecc-4bbd4c583cb1\u0027)"},{"line_number":29,"context_line":"    def test_create_list_availabile_ip(self):"},{"line_number":30,"context_line":"        available_ips \u003d self.ip_availability_client.\\"},{"line_number":31,"context_line":"            list_available_ip(self.network[\u0027project_id\u0027])"},{"line_number":32,"context_line":"        network_id \u003d available_ips[\u0027network_ip_availabilities\u0027][0]["}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_856c7b36","line":29,"range":{"start_line":29,"start_character":13,"end_line":29,"end_character":25},"in_reply_to":"3f79a3b5_f29df6ba","updated":"2018-09-20 10:12:20.000000000","message":"Yes its my mistake will update it..","commit_id":"ee447e4d975787cbaf0910216fba99c01a45046d"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"bf3c42a50c31869dffd76eb73be07040c3da0c5c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self.assertEqual(network_id, self.network[\u0027id\u0027])"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @decorators.idempotent_id(\u0027ee76bfaf-ac94-4d74-9ecc-4bbd4c583cb2\u0027)"},{"line_number":37,"context_line":"    def test_create_show_availabile_ip(self):"},{"line_number":38,"context_line":"        show_ips \u003d self.ip_availability_client.\\"},{"line_number":39,"context_line":"            show_available_ip(self.network[\u0027id\u0027])"},{"line_number":40,"context_line":"        self.assertEqual("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_b2a3fefe","line":37,"range":{"start_line":37,"start_character":8,"end_line":37,"end_character":20},"updated":"2018-09-20 05:48:43.000000000","message":"function name seems incorrect, there is nothing related to create","commit_id":"ee447e4d975787cbaf0910216fba99c01a45046d"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"bf3c42a50c31869dffd76eb73be07040c3da0c5c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self.assertEqual(network_id, self.network[\u0027id\u0027])"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @decorators.idempotent_id(\u0027ee76bfaf-ac94-4d74-9ecc-4bbd4c583cb2\u0027)"},{"line_number":37,"context_line":"    def test_create_show_availabile_ip(self):"},{"line_number":38,"context_line":"        show_ips \u003d self.ip_availability_client.\\"},{"line_number":39,"context_line":"            show_available_ip(self.network[\u0027id\u0027])"},{"line_number":40,"context_line":"        self.assertEqual("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_125f520f","line":37,"range":{"start_line":37,"start_character":25,"end_line":37,"end_character":35},"updated":"2018-09-20 05:48:43.000000000","message":"nit: available","commit_id":"ee447e4d975787cbaf0910216fba99c01a45046d"},{"author":{"_account_id":27977,"name":"Lakshmi Prasanna Goutham Pratapa","email":"lakshmi.pratapa@imaginea.com","username":"pratapagoutham"},"change_message_id":"b8b685a46ece624ea2842149cb5ba707deb6128f","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self.assertEqual(network_id, self.network[\u0027id\u0027])"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @decorators.idempotent_id(\u0027ee76bfaf-ac94-4d74-9ecc-4bbd4c583cb2\u0027)"},{"line_number":37,"context_line":"    def test_create_show_availabile_ip(self):"},{"line_number":38,"context_line":"        show_ips \u003d self.ip_availability_client.\\"},{"line_number":39,"context_line":"            show_available_ip(self.network[\u0027id\u0027])"},{"line_number":40,"context_line":"        self.assertEqual("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_4572e313","line":37,"range":{"start_line":37,"start_character":8,"end_line":37,"end_character":20},"in_reply_to":"3f79a3b5_b2a3fefe","updated":"2018-09-20 10:12:20.000000000","message":"Yes its my mistake will update it.","commit_id":"ee447e4d975787cbaf0910216fba99c01a45046d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"90c3ba4d044b125c3a6f18fd0f6a7fbf718dd094","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        for networks_available in available_ips[\u0027network_ip_availabilities\u0027]:"},{"line_number":34,"context_line":"            if \u0027network_id\u0027 in networks_available:"},{"line_number":35,"context_line":"                network_id \u003d networks_available[\u0027network_id\u0027]"},{"line_number":36,"context_line":"        self.assertEqual(network_id, self.network[\u0027id\u0027])"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @decorators.idempotent_id(\u0027440e7b68-bcbe-11e8-88fc-080027994ea3\u0027)"},{"line_number":39,"context_line":"    def test_show_available_ip(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_58bb84e3","line":36,"updated":"2018-09-21 17:07:24.000000000","message":"because \u0027network_id\u0027 is not found in networks_available like\n\nTraceback (most recent call last):\n  File \"tempest/api/network/test_ip_availability.py\", line 36, in test_list_available_ip\n    self.assertEqual(network_id, self.network[\u0027id\u0027])\n  File \"/opt/stack/tempest/.tox/tempest/local/lib/python2.7/site-packages/testtools/testcase.py\", line 411, in assertEqual\n    self.assertThat(observed, matcher, message)\n  File \"/opt/stack/tempest/.tox/tempest/local/lib/python2.7/site-packages/testtools/testcase.py\", line 498, in assertThat\n    raise mismatch_error\ntesttools.matchers._impl.MismatchError: None !\u003d u\u00274f970343-14cb-4305-b913-0a8e4b153d9d\u0027\n\nBTW how about changing here like\n\n network_id \u003d networks_available.get(\u0027network_id\u0027)\n\ninstead of\n\n if \u0027network_id\u0027 in networks_available:\n    network_id \u003d networks_available[\u0027network_id\u0027]","commit_id":"6aca350cf1c4f0c5e3b3ea67b455a026cebd511b"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"dd59afdbc718bdc12436ad6fb715dca4fd0f5336","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        for networks_available in available_ips[\u0027network_ip_availabilities\u0027]:"},{"line_number":34,"context_line":"            if \u0027network_id\u0027 in networks_available:"},{"line_number":35,"context_line":"                network_id \u003d networks_available[\u0027network_id\u0027]"},{"line_number":36,"context_line":"        self.assertEqual(network_id, self.network[\u0027id\u0027])"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @decorators.idempotent_id(\u0027440e7b68-bcbe-11e8-88fc-080027994ea3\u0027)"},{"line_number":39,"context_line":"    def test_show_available_ip(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_259f3c52","line":36,"in_reply_to":"3f79a3b5_58bb84e3","updated":"2018-09-26 07:05:39.000000000","message":"Yes, It\u0027s good to add like: \"network_id \u003d networks_available.get(\u0027network_id\u0027)\"\n\nIn this case there will be no need of defining \"network_id \u003d None\" as in l[32]","commit_id":"6aca350cf1c4f0c5e3b3ea67b455a026cebd511b"}],"tempest/lib/services/network/ip_availability_client.py":[{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"bf3c42a50c31869dffd76eb73be07040c3da0c5c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest.lib.services.network import base"},{"line_number":17,"context_line":"from tempest.lib.common import rest_client"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class IpAvailabilityClient(base.BaseNetworkClient):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_27e01297","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":42},"updated":"2018-09-20 05:48:43.000000000","message":"rest_client is not used anywhere","commit_id":"ee447e4d975787cbaf0910216fba99c01a45046d"},{"author":{"_account_id":27977,"name":"Lakshmi Prasanna Goutham Pratapa","email":"lakshmi.pratapa@imaginea.com","username":"pratapagoutham"},"change_message_id":"b8b685a46ece624ea2842149cb5ba707deb6128f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest.lib.services.network import base"},{"line_number":17,"context_line":"from tempest.lib.common import rest_client"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class IpAvailabilityClient(base.BaseNetworkClient):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_656d9f2d","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":42},"in_reply_to":"3f79a3b5_27e01297","updated":"2018-09-20 10:12:20.000000000","message":"missed it thanks.","commit_id":"ee447e4d975787cbaf0910216fba99c01a45046d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"90c3ba4d044b125c3a6f18fd0f6a7fbf718dd094","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from tempest.lib.services.network import base"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class IpAvailabilityClient(base.BaseNetworkClient):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def list_available_ip(self, project_id):"},{"line_number":22,"context_line":"        \"\"\"List the available IPs.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_b8bf38c8","line":19,"range":{"start_line":19,"start_character":6,"end_line":19,"end_character":25},"updated":"2018-09-21 17:07:24.000000000","message":"This should be\n\n NetworkIpAvailabilityClient\n\nbased on https://github.com/openstack/qa-specs/blob/master/specs/tempest/consistent-service-method-names.rst","commit_id":"6aca350cf1c4f0c5e3b3ea67b455a026cebd511b"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"90c3ba4d044b125c3a6f18fd0f6a7fbf718dd094","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class IpAvailabilityClient(base.BaseNetworkClient):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def list_available_ip(self, project_id):"},{"line_number":22,"context_line":"        \"\"\"List the available IPs.\"\"\""},{"line_number":23,"context_line":"        uri \u003d \"/network-ip-availabilities?ip_version\u003d4\u0026tenant_id\u003d{}\".\\"},{"line_number":24,"context_line":"            format(project_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_788c4034","line":21,"range":{"start_line":21,"start_character":13,"end_line":21,"end_character":25},"updated":"2018-09-21 17:07:24.000000000","message":"This should be\n\n list_network_ip_availabilities\n\nbecause of the above spec.","commit_id":"6aca350cf1c4f0c5e3b3ea67b455a026cebd511b"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"90c3ba4d044b125c3a6f18fd0f6a7fbf718dd094","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def list_available_ip(self, project_id):"},{"line_number":22,"context_line":"        \"\"\"List the available IPs.\"\"\""},{"line_number":23,"context_line":"        uri \u003d \"/network-ip-availabilities?ip_version\u003d4\u0026tenant_id\u003d{}\".\\"},{"line_number":24,"context_line":"            format(project_id)"},{"line_number":25,"context_line":"        return self.list_resources(uri)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def show_available_ip(self, network_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_f88e1030","line":24,"range":{"start_line":23,"start_character":41,"end_line":24,"end_character":30},"updated":"2018-09-21 17:07:24.000000000","message":"Please don\u0027t specify fixed queries on base part of list method.","commit_id":"6aca350cf1c4f0c5e3b3ea67b455a026cebd511b"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"90c3ba4d044b125c3a6f18fd0f6a7fbf718dd094","unresolved":false,"context_lines":[{"line_number":24,"context_line":"            format(project_id)"},{"line_number":25,"context_line":"        return self.list_resources(uri)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def show_available_ip(self, network_id):"},{"line_number":28,"context_line":"        \"\"\"Show the available IPs.\"\"\""},{"line_number":29,"context_line":"        uri \u003d \"/network-ip-availabilities/{}\".\\"},{"line_number":30,"context_line":"            format(network_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_187f4c17","line":27,"range":{"start_line":27,"start_character":8,"end_line":27,"end_character":25},"updated":"2018-09-21 17:07:24.000000000","message":"ditto: show_network_ip_availability","commit_id":"6aca350cf1c4f0c5e3b3ea67b455a026cebd511b"}],"tempest/tests/lib/services/network/test_ip_availability.py":[{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"dd59afdbc718bdc12436ad6fb715dca4fd0f5336","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        self.client \u003d ip_availability_client.IpAvailabilityClient("},{"line_number":54,"context_line":"            fake_auth, \u0027network\u0027, \u0027regionOne\u0027)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_list_available_ip(self, bytes_body\u003dFalse):"},{"line_number":57,"context_line":"        self.check_service_client_function("},{"line_number":58,"context_line":"            self.client.list_available_ip,"},{"line_number":59,"context_line":"            \u0027tempest.lib.common.rest_client.RestClient.get\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_65b45483","line":56,"range":{"start_line":56,"start_character":37,"end_line":56,"end_character":53},"updated":"2018-09-26 07:05:39.000000000","message":"Query: why we are using \"bytes_body\" here?","commit_id":"6aca350cf1c4f0c5e3b3ea67b455a026cebd511b"}]}