)]}'
{"tempest/api/volume/admin/test_volume_quota_classes.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"2ad3fd97cfb320b2bb6a85d875c7821e91663755","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @decorators.idempotent_id(\u0027abb9198e-67d0-4b09-859f-4f4a1418f176\u0027)"},{"line_number":46,"context_line":"    def test_show_default_quota(self):"},{"line_number":47,"context_line":"        default_quotas \u003d self.admin_quota_classes_client.show_quota_class_set("},{"line_number":48,"context_line":"            \u0027default\u0027)[\u0027quota_class_set\u0027]"},{"line_number":49,"context_line":"        self.assertEqual(\u0027default\u0027, default_quotas.pop(\u0027id\u0027))"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_fa8c362f","line":47,"updated":"2018-09-28 21:58:47.000000000","message":"nit: Would be good to add comment on L46 saying that the response body is validated by schema","commit_id":"bb1cc6736979ad37b56ae77f15977eb76990a6a8"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"7f18f1672254bd6acf1e793125ea7574041a2704","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @decorators.idempotent_id(\u0027abb9198e-67d0-4b09-859f-4f4a1418f176\u0027)"},{"line_number":46,"context_line":"    def test_show_default_quota(self):"},{"line_number":47,"context_line":"        default_quotas \u003d self.admin_quota_classes_client.show_quota_class_set("},{"line_number":48,"context_line":"            \u0027default\u0027)[\u0027quota_class_set\u0027]"},{"line_number":49,"context_line":"        self.assertEqual(\u0027default\u0027, default_quotas.pop(\u0027id\u0027))"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ec66b628","line":47,"in_reply_to":"3f79a3b5_fa8c362f","updated":"2018-09-30 00:47:32.000000000","message":"Done","commit_id":"bb1cc6736979ad37b56ae77f15977eb76990a6a8"}],"tempest/lib/api_schema/response/volume/quota_classes.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"2ad3fd97cfb320b2bb6a85d875c7821e91663755","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                    \u0027gigabytes\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":30,"context_line":"                    \u0027backup_gigabytes\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":31,"context_line":"                },"},{"line_number":32,"context_line":"                \u0027required\u0027: [\u0027volumes\u0027, \u0027snapshots\u0027, \u0027backups\u0027,"},{"line_number":33,"context_line":"                             \u0027per_volume_gigabytes\u0027, \u0027gigabytes\u0027,"},{"line_number":34,"context_line":"                             \u0027backup_gigabytes\u0027],"},{"line_number":35,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_7ac90658","line":32,"updated":"2018-09-28 21:58:47.000000000","message":"\u0027id\u0027 should always be here: https://github.com/openstack/cinder/blob/7f7716d584cd955162cab988c49c6fa3ac08f2e0/cinder/api/contrib/quota_classes.py#L37\n\nWhich is called by show: https://github.com/openstack/cinder/blob/7f7716d584cd955162cab988c49c6fa3ac08f2e0/cinder/api/contrib/quota_classes.py#L52","commit_id":"bb1cc6736979ad37b56ae77f15977eb76990a6a8"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"7f18f1672254bd6acf1e793125ea7574041a2704","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                    \u0027gigabytes\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":30,"context_line":"                    \u0027backup_gigabytes\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":31,"context_line":"                },"},{"line_number":32,"context_line":"                \u0027required\u0027: [\u0027volumes\u0027, \u0027snapshots\u0027, \u0027backups\u0027,"},{"line_number":33,"context_line":"                             \u0027per_volume_gigabytes\u0027, \u0027gigabytes\u0027,"},{"line_number":34,"context_line":"                             \u0027backup_gigabytes\u0027],"},{"line_number":35,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_0c6c5205","line":32,"in_reply_to":"3f79a3b5_7ac90658","updated":"2018-09-30 00:47:32.000000000","message":"Done","commit_id":"bb1cc6736979ad37b56ae77f15977eb76990a6a8"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1858bfa813611ef217ac664494494adbd0b3e719","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                    \u0027per_volume_gigabytes\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":29,"context_line":"                    \u0027gigabytes\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":30,"context_line":"                    \u0027backup_gigabytes\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":31,"context_line":"                },"},{"line_number":32,"context_line":"                \u0027required\u0027: [\u0027id\u0027, \u0027volumes\u0027, \u0027snapshots\u0027, \u0027backups\u0027,"},{"line_number":33,"context_line":"                             \u0027per_volume_gigabytes\u0027, \u0027gigabytes\u0027,"},{"line_number":34,"context_line":"                             \u0027backup_gigabytes\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_5b405407","line":31,"updated":"2018-10-04 20:47:56.000000000","message":"I guessed we need to specify additionalProperties: False like Nova response schema but it would be fine to discuss it later with Neutron team.\nI just want to wait for Ghanshyam\u0027s comment.","commit_id":"0e57890e49a812dba448a5e2e28d0fcfbc927135"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"0f866d40850dab41dfb98000eb202fce90b15fce","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                    \u0027per_volume_gigabytes\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":29,"context_line":"                    \u0027gigabytes\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":30,"context_line":"                    \u0027backup_gigabytes\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":31,"context_line":"                },"},{"line_number":32,"context_line":"                \u0027required\u0027: [\u0027id\u0027, \u0027volumes\u0027, \u0027snapshots\u0027, \u0027backups\u0027,"},{"line_number":33,"context_line":"                             \u0027per_volume_gigabytes\u0027, \u0027gigabytes\u0027,"},{"line_number":34,"context_line":"                             \u0027backup_gigabytes\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_3b75f400","line":31,"in_reply_to":"3f79a3b5_5b405407","updated":"2018-10-10 08:17:14.000000000","message":"Here additionalProperties can\u0027t be set to False because there will be fields like volumes_{volume_type}, e.g.,\n        \"volumes_lvmdriver-1\": -1,\n        \"volumes\": 10,\nSo how about Felipe\u0027s suggesion in https://review.openstack.org/#/c/603339/,\nadd \"additionalProperties\": {\u0027type\u0027: \u0027integer\u0027} for volumes_{volume_type}, etc","commit_id":"0e57890e49a812dba448a5e2e28d0fcfbc927135"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"87f5ad43b544df5314edcd7350fe3c7f22434202","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"show_quota_classes \u003d {"},{"line_number":16,"context_line":"    \u0027status_code\u0027: [200],"},{"line_number":17,"context_line":"    \u0027response_body\u0027: {"},{"line_number":18,"context_line":"        \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_2bd21dfe","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":18},"updated":"2019-08-21 03:12:43.000000000","message":"confirmed https://docs.openstack.org/api-ref/block-storage/v3/?expanded\u003dshow-group-type-details-detail,create-group-type-detail,delete-one-specific-group-spec-for-a-group-type-detail,list-group-types-detail,create-or-update-group-specs-for-a-group-type-detail,list-group-specs-for-a-group-type-detail,show-one-specific-group-spec-for-a-group-type-detail,delete-group-detail,show-group-details-detail,list-group-snapshots-detail,list-group-snapshots-with-details-detail,reset-group-snapshot-status-detail,update-group-type-detail,update-group-detail,create-group-from-source-detail,manage-an-existing-snapshot-detail#show-quotas-for-a-project\n\nincluding extra integer by types","commit_id":"e75e3cb1a14fa2c0b48b8547d7ebc1d55cc23b9b"}],"tempest/tests/lib/services/volume/v3/test_quota_classes_client.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"6d3905a3093af71251b037006ade70d74c7d05e8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        \"volumes\": 200,"},{"line_number":29,"context_line":"        \"snapshots\": 50,"},{"line_number":30,"context_line":"        \"backups\": 20,"},{"line_number":31,"context_line":"        \"groups\": 10,"},{"line_number":32,"context_line":"        \"backup_gigabytes\": 1500,"},{"line_number":33,"context_line":"        \"per_volume_gigabytes\": 500,"},{"line_number":34,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_aefbcfbc","line":31,"range":{"start_line":31,"start_character":9,"end_line":31,"end_character":15},"updated":"2018-09-30 14:14:27.000000000","message":"nit: I guess we can keep it, even though it\u0027s not required.","commit_id":"8893f58ba4fb70181f4b1683ed652d4eeb337b4e"}]}