)]}'
{"tempest/lib/services/network/networks_client.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d71bfda6207e358fc898218a4e1c510116b22cef","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        return self.list_resources(uri)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def list_availability_zones(self):"},{"line_number":79,"context_line":"        \"\"\"Shows list of availability zones."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        For a full list of available parameters, please refer to the official"},{"line_number":82,"context_line":"        API reference:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_72138a02","line":79,"range":{"start_line":79,"start_character":11,"end_line":79,"end_character":44},"updated":"2018-09-27 19:12:26.000000000","message":"List all availability zones","commit_id":"1d2e1db198a8e2826f5681002651d88f6b5696bc"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"5cc696dcc945240a2ded35e6468a64774324e691","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        uri \u003d \u0027/networks/%s/dhcp-agents\u0027 % network_id"},{"line_number":76,"context_line":"        return self.list_resources(uri)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def list_availability_zones(self):"},{"line_number":79,"context_line":"        \"\"\"Shows list of availability zones."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        For a full list of available parameters, please refer to the official"},{"line_number":82,"context_line":"        API reference:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_1c282483","line":79,"range":{"start_line":78,"start_character":8,"end_line":79,"end_character":43},"updated":"2018-09-28 05:12:04.000000000","message":"yeah, show is inconsistent with list, so better to use list here","commit_id":"1d2e1db198a8e2826f5681002651d88f6b5696bc"},{"author":{"_account_id":27977,"name":"Lakshmi Prasanna Goutham Pratapa","email":"lakshmi.pratapa@imaginea.com","username":"pratapagoutham"},"change_message_id":"0c0a3fa459a75f533a0130523d6a1d150c026515","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        uri \u003d \u0027/networks/%s/dhcp-agents\u0027 % network_id"},{"line_number":76,"context_line":"        return self.list_resources(uri)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def list_availability_zones(self):"},{"line_number":79,"context_line":"        \"\"\"Shows list of availability zones."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        For a full list of available parameters, please refer to the official"},{"line_number":82,"context_line":"        API reference:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_8dc72066","line":79,"range":{"start_line":78,"start_character":8,"end_line":79,"end_character":43},"in_reply_to":"3f79a3b5_1c282483","updated":"2018-09-28 08:27:46.000000000","message":"Changed thanks :)","commit_id":"1d2e1db198a8e2826f5681002651d88f6b5696bc"},{"author":{"_account_id":27977,"name":"Lakshmi Prasanna Goutham Pratapa","email":"lakshmi.pratapa@imaginea.com","username":"pratapagoutham"},"change_message_id":"0c0a3fa459a75f533a0130523d6a1d150c026515","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        return self.list_resources(uri)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def list_availability_zones(self):"},{"line_number":79,"context_line":"        \"\"\"Shows list of availability zones."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        For a full list of available parameters, please refer to the official"},{"line_number":82,"context_line":"        API reference:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_6dcc048a","line":79,"range":{"start_line":79,"start_character":11,"end_line":79,"end_character":44},"in_reply_to":"3f79a3b5_72138a02","updated":"2018-09-28 08:27:46.000000000","message":"Changed the name.","commit_id":"1d2e1db198a8e2826f5681002651d88f6b5696bc"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d71bfda6207e358fc898218a4e1c510116b22cef","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        https://developer.openstack.org/api-ref/network/v2/index.html#list-all-availability-zones"},{"line_number":84,"context_line":"        \"\"\""},{"line_number":85,"context_line":"        uri \u003d \u0027availability_zones\u0027"},{"line_number":86,"context_line":"        return self.show_resource(uri)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_921e660b","line":86,"range":{"start_line":86,"start_character":20,"end_line":86,"end_character":33},"updated":"2018-09-27 19:12:26.000000000","message":"Why not list_resources?","commit_id":"1d2e1db198a8e2826f5681002651d88f6b5696bc"},{"author":{"_account_id":27977,"name":"Lakshmi Prasanna Goutham Pratapa","email":"lakshmi.pratapa@imaginea.com","username":"pratapagoutham"},"change_message_id":"0c0a3fa459a75f533a0130523d6a1d150c026515","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        https://developer.openstack.org/api-ref/network/v2/index.html#list-all-availability-zones"},{"line_number":84,"context_line":"        \"\"\""},{"line_number":85,"context_line":"        uri \u003d \u0027availability_zones\u0027"},{"line_number":86,"context_line":"        return self.show_resource(uri)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_2dc60c6a","line":86,"range":{"start_line":86,"start_character":20,"end_line":86,"end_character":33},"in_reply_to":"3f79a3b5_921e660b","updated":"2018-09-28 08:27:46.000000000","message":"Done","commit_id":"1d2e1db198a8e2826f5681002651d88f6b5696bc"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"5cc696dcc945240a2ded35e6468a64774324e691","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        https://developer.openstack.org/api-ref/network/v2/index.html#list-all-availability-zones"},{"line_number":84,"context_line":"        \"\"\""},{"line_number":85,"context_line":"        uri \u003d \u0027availability_zones\u0027"},{"line_number":86,"context_line":"        return self.show_resource(uri)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_bca1f0f9","line":86,"range":{"start_line":86,"start_character":20,"end_line":86,"end_character":33},"in_reply_to":"3f79a3b5_921e660b","updated":"2018-09-28 05:12:04.000000000","message":"exactly it should be list_resources!\n\n@Felipe: But I have a confusion here. It seems, both \"show_resource\" and \"list_resources\" have same body. So is it ok to categorize them separately?","commit_id":"1d2e1db198a8e2826f5681002651d88f6b5696bc"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"f1d2cd7ebb97913e8f561df8f975b946a78b531b","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        uri \u003d \u0027/networks/%s/dhcp-agents\u0027 % network_id"},{"line_number":76,"context_line":"        return self.list_resources(uri)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def list_all_availability_zones(self):"},{"line_number":79,"context_line":"        \"\"\"List all availability zones."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        For a full list of available parameters, please refer to the official"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_176e9295","line":78,"range":{"start_line":78,"start_character":8,"end_line":78,"end_character":35},"updated":"2018-10-01 04:44:46.000000000","message":"Where this method is in use?","commit_id":"40360d763965bd21156fa539f384f6ba63d8ab5b"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"12d75e9a2a7eb124eb7ea6c807a650106657794d","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        uri \u003d \u0027/networks/%s/dhcp-agents\u0027 % network_id"},{"line_number":76,"context_line":"        return self.list_resources(uri)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def list_all_availability_zones(self):"},{"line_number":79,"context_line":"        \"\"\"List all availability zones."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        For a full list of available parameters, please refer to the official"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_87b32d4e","line":78,"range":{"start_line":78,"start_character":8,"end_line":78,"end_character":35},"in_reply_to":"3f79a3b5_176e9295","updated":"2018-10-02 17:47:12.000000000","message":"This method should be implemented in the separated client module, not networks_client.py because of different URI.\nPlease see https://github.com/openstack/qa-specs/blob/master/specs/tempest/consistent-service-method-names.rst","commit_id":"40360d763965bd21156fa539f384f6ba63d8ab5b"},{"author":{"_account_id":27977,"name":"Lakshmi Prasanna Goutham Pratapa","email":"lakshmi.pratapa@imaginea.com","username":"pratapagoutham"},"change_message_id":"de188c7c80c5493c8e01f65652df917ce3593005","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        uri \u003d \u0027/networks/%s/dhcp-agents\u0027 % network_id"},{"line_number":76,"context_line":"        return self.list_resources(uri)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def list_all_availability_zones(self):"},{"line_number":79,"context_line":"        \"\"\"List all availability zones."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        For a full list of available parameters, please refer to the official"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_7051d40c","line":78,"range":{"start_line":78,"start_character":8,"end_line":78,"end_character":35},"in_reply_to":"3f79a3b5_176e9295","updated":"2018-10-03 12:55:33.000000000","message":"Will be used in Neutron-tempest-plugin.\nhttps://review.openstack.org/#/c/605766/2/neutron_tempest_plugin/api/test_availability_zones.py","commit_id":"40360d763965bd21156fa539f384f6ba63d8ab5b"},{"author":{"_account_id":27977,"name":"Lakshmi Prasanna Goutham Pratapa","email":"lakshmi.pratapa@imaginea.com","username":"pratapagoutham"},"change_message_id":"de188c7c80c5493c8e01f65652df917ce3593005","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        uri \u003d \u0027/networks/%s/dhcp-agents\u0027 % network_id"},{"line_number":76,"context_line":"        return self.list_resources(uri)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def list_all_availability_zones(self):"},{"line_number":79,"context_line":"        \"\"\"List all availability zones."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        For a full list of available parameters, please refer to the official"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_1012e055","line":78,"range":{"start_line":78,"start_character":8,"end_line":78,"end_character":35},"in_reply_to":"3f79a3b5_7eca1746","updated":"2018-10-03 12:55:33.000000000","message":"Done","commit_id":"40360d763965bd21156fa539f384f6ba63d8ab5b"},{"author":{"_account_id":27977,"name":"Lakshmi Prasanna Goutham Pratapa","email":"lakshmi.pratapa@imaginea.com","username":"pratapagoutham"},"change_message_id":"de188c7c80c5493c8e01f65652df917ce3593005","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        uri \u003d \u0027/networks/%s/dhcp-agents\u0027 % network_id"},{"line_number":76,"context_line":"        return self.list_resources(uri)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def list_all_availability_zones(self):"},{"line_number":79,"context_line":"        \"\"\"List all availability zones."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        For a full list of available parameters, please refer to the official"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_701c7465","line":78,"range":{"start_line":78,"start_character":8,"end_line":78,"end_character":35},"in_reply_to":"3f79a3b5_87b32d4e","updated":"2018-10-03 12:55:33.000000000","message":"Seperated client can you please elaborate on this?","commit_id":"40360d763965bd21156fa539f384f6ba63d8ab5b"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"fced33049ae72a3abdde12d79600bae1b6fd1bd4","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        uri \u003d \u0027/networks/%s/dhcp-agents\u0027 % network_id"},{"line_number":76,"context_line":"        return self.list_resources(uri)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def list_all_availability_zones(self):"},{"line_number":79,"context_line":"        \"\"\"List all availability zones."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        For a full list of available parameters, please refer to the official"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_7eca1746","line":78,"range":{"start_line":78,"start_character":8,"end_line":78,"end_character":35},"in_reply_to":"3f79a3b5_87b32d4e","updated":"2018-10-02 21:27:10.000000000","message":"list_availability_zones should be fine. Including \"all\" is inconsistent with other list methods.","commit_id":"40360d763965bd21156fa539f384f6ba63d8ab5b"}],"tempest/tests/lib/services/network/test_networks_client.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d71bfda6207e358fc898218a4e1c510116b22cef","unresolved":false,"context_lines":[{"line_number":256,"context_line":"    def test_list_dhcp_agents_on_hosting_network_with_bytes_body(self):"},{"line_number":257,"context_line":"        self._test_list_dhcp_agents_on_hosting_network(bytes_body\u003dTrue)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def test_list_availability_zones(self):"},{"line_number":260,"context_line":"        self.check_service_client_function("},{"line_number":261,"context_line":"            self.networks_client.list_availability_zones,"},{"line_number":262,"context_line":"            \"tempest.lib.common.rest_client.RestClient.get\","}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_f2b55aee","line":259,"range":{"start_line":259,"start_character":8,"end_line":259,"end_character":36},"updated":"2018-09-27 19:12:26.000000000","message":"Need one with str_body and another with bytes_body.\n\nThat is:\n\n    def test_list_availability_zones_with_str_body(self):\n        self._test_list_availability_zones()\n\n    def test_list_availability_zones_with_bytes_body(self):\n        self._test_list_availability_zones(bytes_body\u003dTrue)","commit_id":"1d2e1db198a8e2826f5681002651d88f6b5696bc"},{"author":{"_account_id":27977,"name":"Lakshmi Prasanna Goutham Pratapa","email":"lakshmi.pratapa@imaginea.com","username":"pratapagoutham"},"change_message_id":"0c0a3fa459a75f533a0130523d6a1d150c026515","unresolved":false,"context_lines":[{"line_number":256,"context_line":"    def test_list_dhcp_agents_on_hosting_network_with_bytes_body(self):"},{"line_number":257,"context_line":"        self._test_list_dhcp_agents_on_hosting_network(bytes_body\u003dTrue)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def test_list_availability_zones(self):"},{"line_number":260,"context_line":"        self.check_service_client_function("},{"line_number":261,"context_line":"            self.networks_client.list_availability_zones,"},{"line_number":262,"context_line":"            \"tempest.lib.common.rest_client.RestClient.get\","}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_0da1d0a8","line":259,"range":{"start_line":259,"start_character":8,"end_line":259,"end_character":36},"in_reply_to":"3f79a3b5_f2b55aee","updated":"2018-09-28 08:27:46.000000000","message":"Done","commit_id":"1d2e1db198a8e2826f5681002651d88f6b5696bc"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"f1d2cd7ebb97913e8f561df8f975b946a78b531b","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    def _test_list_availability_zones(self, bytes_body\u003dFalse):"},{"line_number":224,"context_line":"        self.check_service_client_function("},{"line_number":225,"context_line":"            self.networks_client.list_availability_zones,"},{"line_number":226,"context_line":"            \"tempest.lib.common.rest_client.RestClient.get\","},{"line_number":227,"context_line":"            self.FAKE_AVAILABLE_ZONES,"},{"line_number":228,"context_line":"            bytes_body,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_b766bebb","line":225,"range":{"start_line":225,"start_character":33,"end_line":225,"end_character":56},"updated":"2018-10-01 04:44:46.000000000","message":"I think you want to use \"list_all_availability_zones\" not \"list_availability_zones\".\n\nlist_availability_zones is not defined anywhere","commit_id":"40360d763965bd21156fa539f384f6ba63d8ab5b"},{"author":{"_account_id":27977,"name":"Lakshmi Prasanna Goutham Pratapa","email":"lakshmi.pratapa@imaginea.com","username":"pratapagoutham"},"change_message_id":"de188c7c80c5493c8e01f65652df917ce3593005","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    def _test_list_availability_zones(self, bytes_body\u003dFalse):"},{"line_number":224,"context_line":"        self.check_service_client_function("},{"line_number":225,"context_line":"            self.networks_client.list_availability_zones,"},{"line_number":226,"context_line":"            \"tempest.lib.common.rest_client.RestClient.get\","},{"line_number":227,"context_line":"            self.FAKE_AVAILABLE_ZONES,"},{"line_number":228,"context_line":"            bytes_body,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_6a548654","line":225,"range":{"start_line":225,"start_character":33,"end_line":225,"end_character":56},"in_reply_to":"3f79a3b5_b766bebb","updated":"2018-10-03 12:55:33.000000000","message":"Thanks , I changed it.","commit_id":"40360d763965bd21156fa539f384f6ba63d8ab5b"}]}