)]}'
{"tempest/lib/api_schema/response/volume/scheduler_stats.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"53ed5a3b9c36be1fa421c810f73e300768150ba6","unresolved":false,"context_lines":[{"line_number":22,"context_line":"                \u0027items\u0027: {"},{"line_number":23,"context_line":"                    \u0027type\u0027: \u0027object\u0027,"},{"line_number":24,"context_line":"                    \u0027properties\u0027: {"},{"line_number":25,"context_line":"                        \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":26,"context_line":"                    },"},{"line_number":27,"context_line":"                    \u0027additionalProperties\u0027: False,"},{"line_number":28,"context_line":"                    \u0027required\u0027: [\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_da337a60","line":25,"range":{"start_line":25,"start_character":25,"end_line":25,"end_character":29},"updated":"2018-09-28 22:12:27.000000000","message":"LGTM as detail param says: \"Set to false to show only pool names. Default is false.\"","commit_id":"ec85e7f3e1414cf154aba525ba29c98f9c09b5b5"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"53ed5a3b9c36be1fa421c810f73e300768150ba6","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                    \u0027properties\u0027: {"},{"line_number":47,"context_line":"                        \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":48,"context_line":"                        \u0027capabilities\u0027: {"},{"line_number":49,"context_line":"                            \u0027type\u0027: \u0027object\u0027,"},{"line_number":50,"context_line":"                            \u0027properties\u0027: {"},{"line_number":51,"context_line":"                                \u0027updated\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":52,"context_line":"                                \u0027QoS_support\u0027: {\u0027type\u0027: \u0027boolean\u0027},"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_5a468aa9","line":49,"range":{"start_line":49,"start_character":37,"end_line":49,"end_character":43},"updated":"2018-09-28 22:12:27.000000000","message":"I do not think this is correct as per: \"The capabilities for the back end. The value is either null or a string value that indicates the capabilities for each pool.\"\n\nSo needs to handle null case as well. Code seems to confirm this too:\n\nhttp://git.openstack.org/cgit/openstack/cinder/tree/cinder/api/views/scheduler_stats.py#n40","commit_id":"ec85e7f3e1414cf154aba525ba29c98f9c09b5b5"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"512094c13304576ca225f42266f5d23e50db42f9","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                    \u0027properties\u0027: {"},{"line_number":47,"context_line":"                        \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":48,"context_line":"                        \u0027capabilities\u0027: {"},{"line_number":49,"context_line":"                            \u0027type\u0027: \u0027object\u0027,"},{"line_number":50,"context_line":"                            \u0027properties\u0027: {"},{"line_number":51,"context_line":"                                \u0027updated\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":52,"context_line":"                                \u0027QoS_support\u0027: {\u0027type\u0027: \u0027boolean\u0027},"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_ec3f96dc","line":49,"range":{"start_line":49,"start_character":37,"end_line":49,"end_character":43},"in_reply_to":"3f79a3b5_5a468aa9","updated":"2018-09-30 00:57:25.000000000","message":"Thanks, \u0027null\u0027 is added","commit_id":"ec85e7f3e1414cf154aba525ba29c98f9c09b5b5"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"53ed5a3b9c36be1fa421c810f73e300768150ba6","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                                \u0027updated\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":52,"context_line":"                                \u0027QoS_support\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":53,"context_line":"                                \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":54,"context_line":"                                \u0027total_capacity_gb\u0027: {\u0027type\u0027: \u0027number\u0027},"},{"line_number":55,"context_line":"                                \u0027volume_backend_name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":56,"context_line":"                                \u0027free_capacity_gb\u0027: {\u0027type\u0027: \u0027number\u0027},"},{"line_number":57,"context_line":"                                \u0027driver_version\u0027: {\u0027type\u0027: \u0027string\u0027},"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_9a398240","line":54,"range":{"start_line":54,"start_character":33,"end_line":54,"end_character":50},"updated":"2018-09-28 22:12:27.000000000","message":"We should fix this here: https://developer.openstack.org/api-ref/block-storage/v3/index.html#id386","commit_id":"ec85e7f3e1414cf154aba525ba29c98f9c09b5b5"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"512094c13304576ca225f42266f5d23e50db42f9","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                                \u0027updated\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":52,"context_line":"                                \u0027QoS_support\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":53,"context_line":"                                \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":54,"context_line":"                                \u0027total_capacity_gb\u0027: {\u0027type\u0027: \u0027number\u0027},"},{"line_number":55,"context_line":"                                \u0027volume_backend_name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":56,"context_line":"                                \u0027free_capacity_gb\u0027: {\u0027type\u0027: \u0027number\u0027},"},{"line_number":57,"context_line":"                                \u0027driver_version\u0027: {\u0027type\u0027: \u0027string\u0027},"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_4c348afb","line":54,"range":{"start_line":54,"start_character":33,"end_line":54,"end_character":50},"in_reply_to":"3f79a3b5_9a398240","updated":"2018-09-30 00:57:25.000000000","message":"I can\u0027t access https://developer.openstack.org/api-ref/block-storage/v3/index.html#id386, and Ic0690d12147fa63b903f3442eccde88c1d501711 will add the missing postfix _gb","commit_id":"ec85e7f3e1414cf154aba525ba29c98f9c09b5b5"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"53ed5a3b9c36be1fa421c810f73e300768150ba6","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                                \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":54,"context_line":"                                \u0027total_capacity_gb\u0027: {\u0027type\u0027: \u0027number\u0027},"},{"line_number":55,"context_line":"                                \u0027volume_backend_name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":56,"context_line":"                                \u0027free_capacity_gb\u0027: {\u0027type\u0027: \u0027number\u0027},"},{"line_number":57,"context_line":"                                \u0027driver_version\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":58,"context_line":"                                \u0027reserved_percentage\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":59,"context_line":"                                \u0027storage_protocol\u0027: {\u0027type\u0027: \u0027string\u0027}"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_5a3f6a21","line":56,"range":{"start_line":56,"start_character":33,"end_line":56,"end_character":49},"updated":"2018-09-28 22:12:27.000000000","message":"Ditto.","commit_id":"ec85e7f3e1414cf154aba525ba29c98f9c09b5b5"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"53ed5a3b9c36be1fa421c810f73e300768150ba6","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                                \u0027reserved_percentage\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":59,"context_line":"                                \u0027storage_protocol\u0027: {\u0027type\u0027: \u0027string\u0027}"},{"line_number":60,"context_line":"                            },"},{"line_number":61,"context_line":"                            \u0027required\u0027: [\u0027QoS_support\u0027, \u0027total_capacity_gb\u0027,"},{"line_number":62,"context_line":"                                         \u0027volume_backend_name\u0027,"},{"line_number":63,"context_line":"                                         \u0027free_capacity_gb\u0027, \u0027driver_version\u0027,"},{"line_number":64,"context_line":"                                         \u0027reserved_percentage\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_9a50a260","line":61,"updated":"2018-09-28 22:12:27.000000000","message":"Is \u0027name\u0027 not required?","commit_id":"ec85e7f3e1414cf154aba525ba29c98f9c09b5b5"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"512094c13304576ca225f42266f5d23e50db42f9","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                                \u0027reserved_percentage\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":59,"context_line":"                                \u0027storage_protocol\u0027: {\u0027type\u0027: \u0027string\u0027}"},{"line_number":60,"context_line":"                            },"},{"line_number":61,"context_line":"                            \u0027required\u0027: [\u0027QoS_support\u0027, \u0027total_capacity_gb\u0027,"},{"line_number":62,"context_line":"                                         \u0027volume_backend_name\u0027,"},{"line_number":63,"context_line":"                                         \u0027free_capacity_gb\u0027, \u0027driver_version\u0027,"},{"line_number":64,"context_line":"                                         \u0027reserved_percentage\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_2c182e82","line":61,"in_reply_to":"3f79a3b5_9a50a260","updated":"2018-09-30 00:57:25.000000000","message":"Yes name is not required","commit_id":"ec85e7f3e1414cf154aba525ba29c98f9c09b5b5"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"53ed5a3b9c36be1fa421c810f73e300768150ba6","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                        },"},{"line_number":67,"context_line":"                    },"},{"line_number":68,"context_line":"                    \u0027additionalProperties\u0027: False,"},{"line_number":69,"context_line":"                    \u0027required\u0027: [\u0027name\u0027, \u0027capabilities\u0027]"},{"line_number":70,"context_line":"                }"},{"line_number":71,"context_line":"            }"},{"line_number":72,"context_line":"        },"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_fa5f5672","line":69,"updated":"2018-09-28 22:12:27.000000000","message":"Looks good as per: http://git.openstack.org/cgit/openstack/cinder/tree/cinder/api/views/scheduler_stats.py#n40","commit_id":"ec85e7f3e1414cf154aba525ba29c98f9c09b5b5"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"5b4039d4b39f99b9bb8ed44850ee11b75b115383","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                                \u0027updated\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":52,"context_line":"                                \u0027QoS_support\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":53,"context_line":"                                \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":54,"context_line":"                                \u0027total_capacity_gb\u0027: {\u0027type\u0027: \u0027number\u0027},"},{"line_number":55,"context_line":"                                \u0027volume_backend_name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":56,"context_line":"                                \u0027free_capacity_gb\u0027: {\u0027type\u0027: \u0027number\u0027},"},{"line_number":57,"context_line":"                                \u0027driver_version\u0027: {\u0027type\u0027: \u0027string\u0027},"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_98ae2ae2","line":54,"range":{"start_line":54,"start_character":63,"end_line":54,"end_character":69},"updated":"2018-10-02 20:13:01.000000000","message":"This is not correct.\n\n\"A valid value is a string, such as unknown, or an integer.\"\n\nSo I\u0027m curious why not [\u0027string\u0027, \u0027integer\u0027]","commit_id":"54666f923c784b3a2ab24f5f75caf80bf1a55ad5"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"71a0c7a8bef82eaf495f26f7921580e704838342","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                                \u0027updated\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":52,"context_line":"                                \u0027QoS_support\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":53,"context_line":"                                \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":54,"context_line":"                                \u0027total_capacity_gb\u0027: {\u0027type\u0027: \u0027number\u0027},"},{"line_number":55,"context_line":"                                \u0027volume_backend_name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":56,"context_line":"                                \u0027free_capacity_gb\u0027: {\u0027type\u0027: \u0027number\u0027},"},{"line_number":57,"context_line":"                                \u0027driver_version\u0027: {\u0027type\u0027: \u0027string\u0027},"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_860f3338","line":54,"range":{"start_line":54,"start_character":63,"end_line":54,"end_character":69},"in_reply_to":"3f79a3b5_4084ad5d","updated":"2018-10-09 07:54:43.000000000","message":"Cinder patch Icd206ba3733adf9543a9e1384ef7245e287ee858 will modify the api doc","commit_id":"54666f923c784b3a2ab24f5f75caf80bf1a55ad5"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"25711376ee5d307fefd45092eeb1aeea132fa6c5","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                                \u0027updated\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":52,"context_line":"                                \u0027QoS_support\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":53,"context_line":"                                \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":54,"context_line":"                                \u0027total_capacity_gb\u0027: {\u0027type\u0027: \u0027number\u0027},"},{"line_number":55,"context_line":"                                \u0027volume_backend_name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":56,"context_line":"                                \u0027free_capacity_gb\u0027: {\u0027type\u0027: \u0027number\u0027},"},{"line_number":57,"context_line":"                                \u0027driver_version\u0027: {\u0027type\u0027: \u0027string\u0027},"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_00e447de","line":54,"range":{"start_line":54,"start_character":63,"end_line":54,"end_character":69},"in_reply_to":"3f79a3b5_860f3338","updated":"2018-11-05 06:58:38.000000000","message":"Cinder patch Icd206ba3733adf9543a9e1384ef7245e287ee858 is merged","commit_id":"54666f923c784b3a2ab24f5f75caf80bf1a55ad5"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"40f60f867b853f1e69a74065d383dbdec84b3010","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                                \u0027updated\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":52,"context_line":"                                \u0027QoS_support\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":53,"context_line":"                                \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":54,"context_line":"                                \u0027total_capacity_gb\u0027: {\u0027type\u0027: \u0027number\u0027},"},{"line_number":55,"context_line":"                                \u0027volume_backend_name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":56,"context_line":"                                \u0027free_capacity_gb\u0027: {\u0027type\u0027: \u0027number\u0027},"},{"line_number":57,"context_line":"                                \u0027driver_version\u0027: {\u0027type\u0027: \u0027string\u0027},"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_de048b80","line":54,"range":{"start_line":54,"start_character":63,"end_line":54,"end_character":69},"in_reply_to":"3f79a3b5_98ae2ae2","updated":"2018-10-02 21:28:16.000000000","message":"I also meant to ask, why number instead of integer?","commit_id":"54666f923c784b3a2ab24f5f75caf80bf1a55ad5"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"77b494ceafdc1688ba590b3d718990b4d9312b90","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                                \u0027updated\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":52,"context_line":"                                \u0027QoS_support\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":53,"context_line":"                                \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":54,"context_line":"                                \u0027total_capacity_gb\u0027: {\u0027type\u0027: \u0027number\u0027},"},{"line_number":55,"context_line":"                                \u0027volume_backend_name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":56,"context_line":"                                \u0027free_capacity_gb\u0027: {\u0027type\u0027: \u0027number\u0027},"},{"line_number":57,"context_line":"                                \u0027driver_version\u0027: {\u0027type\u0027: \u0027string\u0027},"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_4084ad5d","line":54,"range":{"start_line":54,"start_character":63,"end_line":54,"end_character":69},"in_reply_to":"3f79a3b5_ca36a9e9","updated":"2018-10-08 14:43:38.000000000","message":"If this supports floating point numbers then I think the Cinder API docs need to be updated: https://developer.openstack.org/api-ref/block-storage/v3/index.html#id389\n\n\"The total capacity for the back-end volume, in GBs. A valid value is a string, such as unknown, or an integer.\"\n\nShould be reworded to:\n\n\"The total capacity for the back-end volume, in GBs. A valid value is a string, such as unknown, or a number (integer or floating point).\" Something like that.","commit_id":"54666f923c784b3a2ab24f5f75caf80bf1a55ad5"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"f149f61e42fe66682167536ec6139977ba434999","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                                \u0027updated\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":52,"context_line":"                                \u0027QoS_support\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":53,"context_line":"                                \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":54,"context_line":"                                \u0027total_capacity_gb\u0027: {\u0027type\u0027: \u0027number\u0027},"},{"line_number":55,"context_line":"                                \u0027volume_backend_name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":56,"context_line":"                                \u0027free_capacity_gb\u0027: {\u0027type\u0027: \u0027number\u0027},"},{"line_number":57,"context_line":"                                \u0027driver_version\u0027: {\u0027type\u0027: \u0027string\u0027},"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_ca36a9e9","line":54,"range":{"start_line":54,"start_character":63,"end_line":54,"end_character":69},"in_reply_to":"3f79a3b5_de048b80","updated":"2018-10-08 01:41:55.000000000","message":"Yes \u0027string\u0027 should also be added.\nAnd here uses number because the value may be a float, like 2.4","commit_id":"54666f923c784b3a2ab24f5f75caf80bf1a55ad5"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"5b4039d4b39f99b9bb8ed44850ee11b75b115383","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                                \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":54,"context_line":"                                \u0027total_capacity_gb\u0027: {\u0027type\u0027: \u0027number\u0027},"},{"line_number":55,"context_line":"                                \u0027volume_backend_name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":56,"context_line":"                                \u0027free_capacity_gb\u0027: {\u0027type\u0027: \u0027number\u0027},"},{"line_number":57,"context_line":"                                \u0027driver_version\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":58,"context_line":"                                \u0027reserved_percentage\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":59,"context_line":"                                \u0027storage_protocol\u0027: {\u0027type\u0027: \u0027string\u0027}"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_18a3fa00","line":56,"range":{"start_line":56,"start_character":62,"end_line":56,"end_character":68},"updated":"2018-10-02 20:13:01.000000000","message":"This is not correct.\n\n\"A valid value is a string, such as unknown, or an integer.\"\n\nSo I\u0027m curious why not [\u0027string\u0027, \u0027integer\u0027]","commit_id":"54666f923c784b3a2ab24f5f75caf80bf1a55ad5"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"f149f61e42fe66682167536ec6139977ba434999","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                                \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":54,"context_line":"                                \u0027total_capacity_gb\u0027: {\u0027type\u0027: \u0027number\u0027},"},{"line_number":55,"context_line":"                                \u0027volume_backend_name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":56,"context_line":"                                \u0027free_capacity_gb\u0027: {\u0027type\u0027: \u0027number\u0027},"},{"line_number":57,"context_line":"                                \u0027driver_version\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":58,"context_line":"                                \u0027reserved_percentage\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":59,"context_line":"                                \u0027storage_protocol\u0027: {\u0027type\u0027: \u0027string\u0027}"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_ea3365f6","line":56,"range":{"start_line":56,"start_character":62,"end_line":56,"end_character":68},"in_reply_to":"3f79a3b5_18a3fa00","updated":"2018-10-08 01:41:55.000000000","message":"Done. \u0027string\u0027 is added.","commit_id":"54666f923c784b3a2ab24f5f75caf80bf1a55ad5"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"71a0c7a8bef82eaf495f26f7921580e704838342","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                                \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":54,"context_line":"                                \u0027total_capacity_gb\u0027: {\u0027type\u0027: \u0027number\u0027},"},{"line_number":55,"context_line":"                                \u0027volume_backend_name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":56,"context_line":"                                \u0027free_capacity_gb\u0027: {\u0027type\u0027: \u0027number\u0027},"},{"line_number":57,"context_line":"                                \u0027driver_version\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":58,"context_line":"                                \u0027reserved_percentage\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":59,"context_line":"                                \u0027storage_protocol\u0027: {\u0027type\u0027: \u0027string\u0027}"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_a6126f60","line":56,"range":{"start_line":56,"start_character":62,"end_line":56,"end_character":68},"in_reply_to":"3f79a3b5_e078597f","updated":"2018-10-09 07:54:43.000000000","message":"ditto","commit_id":"54666f923c784b3a2ab24f5f75caf80bf1a55ad5"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"77b494ceafdc1688ba590b3d718990b4d9312b90","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                                \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":54,"context_line":"                                \u0027total_capacity_gb\u0027: {\u0027type\u0027: \u0027number\u0027},"},{"line_number":55,"context_line":"                                \u0027volume_backend_name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":56,"context_line":"                                \u0027free_capacity_gb\u0027: {\u0027type\u0027: \u0027number\u0027},"},{"line_number":57,"context_line":"                                \u0027driver_version\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":58,"context_line":"                                \u0027reserved_percentage\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":59,"context_line":"                                \u0027storage_protocol\u0027: {\u0027type\u0027: \u0027string\u0027}"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_e078597f","line":56,"range":{"start_line":56,"start_character":62,"end_line":56,"end_character":68},"in_reply_to":"3f79a3b5_ea3365f6","updated":"2018-10-08 14:43:38.000000000","message":"Ditto about Cinder API docs.","commit_id":"54666f923c784b3a2ab24f5f75caf80bf1a55ad5"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"a29ca8b9a6b97cd2007d9435615f1debef53e44d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"get_pools_no_detail \u003d {"},{"line_number":16,"context_line":"    \u0027status_code\u0027: [200],"},{"line_number":17,"context_line":"    \u0027response_body\u0027: {"},{"line_number":18,"context_line":"        \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_cb62693e","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":19},"updated":"2019-08-21 03:24:08.000000000","message":"confirmed looking at detail (Optional) in request","commit_id":"4fe2e2ca062e562157f930aad09e1f17e09ca8fa"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"a29ca8b9a6b97cd2007d9435615f1debef53e44d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    }"},{"line_number":35,"context_line":"}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"get_pools_with_detail \u003d {"},{"line_number":38,"context_line":"    \u0027status_code\u0027: [200],"},{"line_number":39,"context_line":"    \u0027response_body\u0027: {"},{"line_number":40,"context_line":"        \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_8b58f189","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":21},"updated":"2019-08-21 03:24:08.000000000","message":"cconfirmed \nhttps://docs.openstack.org/api-ref/block-storage/v3/?expanded\u003dshow-group-type-details-detail,create-group-type-detail,delete-one-specific-group-spec-for-a-group-type-detail,list-group-types-detail,create-or-update-group-specs-for-a-group-type-detail,list-group-specs-for-a-group-type-detail,show-one-specific-group-spec-for-a-group-type-detail,delete-group-detail,show-group-details-detail,list-group-snapshots-detail,list-group-snapshots-with-details-detail,reset-group-snapshot-status-detail,update-group-type-detail,update-group-detail,create-group-from-source-detail,manage-an-existing-snapshot-detail,show-quotas-for-a-project-detail,manage-an-existing-volume-detail,list-all-back-end-storage-pools-detail#list-all-back-end-storage-pools","commit_id":"4fe2e2ca062e562157f930aad09e1f17e09ca8fa"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ad846c07ce6cccf3ada770b85d1f7c89ea05fc89","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                        \u0027capabilities\u0027: {"},{"line_number":49,"context_line":"                            \u0027type\u0027: [\u0027object\u0027, \u0027null\u0027],"},{"line_number":50,"context_line":"                            \u0027properties\u0027: {"},{"line_number":51,"context_line":"                                \u0027updated\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":52,"context_line":"                                \u0027QoS_support\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":53,"context_line":"                                \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":54,"context_line":"                                \u0027total_capacity_gb\u0027: {"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_eb282998","line":51,"range":{"start_line":51,"start_character":53,"end_line":51,"end_character":61},"updated":"2020-03-16 00:42:34.000000000","message":"this is date time data. \n\u0027parameter_type.date_time_or_null","commit_id":"4fe2e2ca062e562157f930aad09e1f17e09ca8fa"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"709403c3f1d257c81f9d937e8b6388f77bf6bec2","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                        \u0027capabilities\u0027: {"},{"line_number":49,"context_line":"                            \u0027type\u0027: [\u0027object\u0027, \u0027null\u0027],"},{"line_number":50,"context_line":"                            \u0027properties\u0027: {"},{"line_number":51,"context_line":"                                \u0027updated\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":52,"context_line":"                                \u0027QoS_support\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":53,"context_line":"                                \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":54,"context_line":"                                \u0027total_capacity_gb\u0027: {"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_b48cce35","line":51,"range":{"start_line":51,"start_character":53,"end_line":51,"end_character":61},"in_reply_to":"1fa4df85_eb282998","updated":"2020-03-16 08:51:17.000000000","message":"yes, done.","commit_id":"4fe2e2ca062e562157f930aad09e1f17e09ca8fa"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ad846c07ce6cccf3ada770b85d1f7c89ea05fc89","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                            \u0027properties\u0027: {"},{"line_number":51,"context_line":"                                \u0027updated\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":52,"context_line":"                                \u0027QoS_support\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":53,"context_line":"                                \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":54,"context_line":"                                \u0027total_capacity_gb\u0027: {"},{"line_number":55,"context_line":"                                    \u0027type\u0027: [\u0027number\u0027, \u0027string\u0027]"},{"line_number":56,"context_line":"                                },"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_4b137d67","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":59},"updated":"2020-03-16 00:42:34.000000000","message":"I cannot find this attribute under capability.\n- https://docs.openstack.org/api-ref/block-storage/v3/index.html?expanded\u003dlist-all-back-end-storage-pools-detail#back-end-storage-pools","commit_id":"4fe2e2ca062e562157f930aad09e1f17e09ca8fa"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"709403c3f1d257c81f9d937e8b6388f77bf6bec2","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                            \u0027properties\u0027: {"},{"line_number":51,"context_line":"                                \u0027updated\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":52,"context_line":"                                \u0027QoS_support\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":53,"context_line":"                                \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":54,"context_line":"                                \u0027total_capacity_gb\u0027: {"},{"line_number":55,"context_line":"                                    \u0027type\u0027: [\u0027number\u0027, \u0027string\u0027]"},{"line_number":56,"context_line":"                                },"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_74df363a","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":59},"in_reply_to":"1fa4df85_4b137d67","updated":"2020-03-16 08:51:17.000000000","message":"oh, in https://docs.openstack.org/api-ref/block-storage/v3/index.html#back-end-storage-pools,\nit shows:\nname body string The name of the backend pool.","commit_id":"4fe2e2ca062e562157f930aad09e1f17e09ca8fa"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"321b26252cfba88f99c6c468e85fd370936f8f49","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                            \u0027properties\u0027: {"},{"line_number":51,"context_line":"                                \u0027updated\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":52,"context_line":"                                \u0027QoS_support\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":53,"context_line":"                                \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":54,"context_line":"                                \u0027total_capacity_gb\u0027: {"},{"line_number":55,"context_line":"                                    \u0027type\u0027: [\u0027number\u0027, \u0027string\u0027]"},{"line_number":56,"context_line":"                                },"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_c062e4ad","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":59},"in_reply_to":"1fa4df85_74df363a","updated":"2020-03-16 12:37:38.000000000","message":"which is name of pool you defined at L47. under \u0027capability\u0027 object there is no name right?","commit_id":"4fe2e2ca062e562157f930aad09e1f17e09ca8fa"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"a8ce6b1e419b6b5be1b7c93183bac58a7483189d","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                            \u0027properties\u0027: {"},{"line_number":51,"context_line":"                                \u0027updated\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":52,"context_line":"                                \u0027QoS_support\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":53,"context_line":"                                \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":54,"context_line":"                                \u0027total_capacity_gb\u0027: {"},{"line_number":55,"context_line":"                                    \u0027type\u0027: [\u0027number\u0027, \u0027string\u0027]"},{"line_number":56,"context_line":"                                },"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_8cc89974","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":59},"in_reply_to":"1fa4df85_c062e4ad","updated":"2020-03-17 07:03:15.000000000","message":"oops, I see, done.","commit_id":"4fe2e2ca062e562157f930aad09e1f17e09ca8fa"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ad846c07ce6cccf3ada770b85d1f7c89ea05fc89","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                                \u0027reserved_percentage\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":63,"context_line":"                                \u0027storage_protocol\u0027: {\u0027type\u0027: \u0027string\u0027}"},{"line_number":64,"context_line":"                            },"},{"line_number":65,"context_line":"                            \u0027required\u0027: [\u0027QoS_support\u0027, \u0027total_capacity_gb\u0027,"},{"line_number":66,"context_line":"                                         \u0027volume_backend_name\u0027,"},{"line_number":67,"context_line":"                                         \u0027free_capacity_gb\u0027, \u0027driver_version\u0027,"},{"line_number":68,"context_line":"                                         \u0027reserved_percentage\u0027,"},{"line_number":69,"context_line":"                                         \u0027storage_protocol\u0027]"},{"line_number":70,"context_line":"                        },"},{"line_number":71,"context_line":"                    },"},{"line_number":72,"context_line":"                    \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_0b0d853d","line":69,"range":{"start_line":65,"start_character":0,"end_line":69,"end_character":60},"updated":"2020-03-16 00:42:34.000000000","message":"is there any doc from cinder side which provide contract on capabilities attributes. If not then I will suggest to leave those from required field.","commit_id":"4fe2e2ca062e562157f930aad09e1f17e09ca8fa"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"709403c3f1d257c81f9d937e8b6388f77bf6bec2","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                                \u0027reserved_percentage\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":63,"context_line":"                                \u0027storage_protocol\u0027: {\u0027type\u0027: \u0027string\u0027}"},{"line_number":64,"context_line":"                            },"},{"line_number":65,"context_line":"                            \u0027required\u0027: [\u0027QoS_support\u0027, \u0027total_capacity_gb\u0027,"},{"line_number":66,"context_line":"                                         \u0027volume_backend_name\u0027,"},{"line_number":67,"context_line":"                                         \u0027free_capacity_gb\u0027, \u0027driver_version\u0027,"},{"line_number":68,"context_line":"                                         \u0027reserved_percentage\u0027,"},{"line_number":69,"context_line":"                                         \u0027storage_protocol\u0027]"},{"line_number":70,"context_line":"                        },"},{"line_number":71,"context_line":"                    },"},{"line_number":72,"context_line":"                    \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_d41aaa15","line":69,"range":{"start_line":65,"start_character":0,"end_line":69,"end_character":60},"in_reply_to":"1fa4df85_0b0d853d","updated":"2020-03-16 08:51:17.000000000","message":"https://docs.openstack.org/api-ref/block-storage/v3/index.html#list-all-back-end-storage-pools\nShows that those fields are required in response","commit_id":"4fe2e2ca062e562157f930aad09e1f17e09ca8fa"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"321b26252cfba88f99c6c468e85fd370936f8f49","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                                \u0027reserved_percentage\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":63,"context_line":"                                \u0027storage_protocol\u0027: {\u0027type\u0027: \u0027string\u0027}"},{"line_number":64,"context_line":"                            },"},{"line_number":65,"context_line":"                            \u0027required\u0027: [\u0027QoS_support\u0027, \u0027total_capacity_gb\u0027,"},{"line_number":66,"context_line":"                                         \u0027volume_backend_name\u0027,"},{"line_number":67,"context_line":"                                         \u0027free_capacity_gb\u0027, \u0027driver_version\u0027,"},{"line_number":68,"context_line":"                                         \u0027reserved_percentage\u0027,"},{"line_number":69,"context_line":"                                         \u0027storage_protocol\u0027]"},{"line_number":70,"context_line":"                        },"},{"line_number":71,"context_line":"                    },"},{"line_number":72,"context_line":"                    \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_e06cc09d","line":69,"range":{"start_line":65,"start_character":0,"end_line":69,"end_character":60},"in_reply_to":"1fa4df85_d41aaa15","updated":"2020-03-16 12:37:38.000000000","message":"ok, I would like to get confirmation from cinder team on this as i cannot verify it from code. api-ref is something can lie to us :).","commit_id":"4fe2e2ca062e562157f930aad09e1f17e09ca8fa"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5cd7e623fc76558ef233905ce7b0819931204de9","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                                         \u0027volume_backend_name\u0027,"},{"line_number":67,"context_line":"                                         \u0027free_capacity_gb\u0027, \u0027driver_version\u0027,"},{"line_number":68,"context_line":"                                         \u0027reserved_percentage\u0027,"},{"line_number":69,"context_line":"                                         \u0027storage_protocol\u0027]"},{"line_number":70,"context_line":"                        },"},{"line_number":71,"context_line":"                    },"},{"line_number":72,"context_line":"                    \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_8cc41942","line":69,"updated":"2020-03-17 07:32:33.000000000","message":"i think vendor_name is also required here","commit_id":"86b47030a21b9c8a56bb47bd015396fa1527e58b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"276ccd3ca1c2f43dd565e04f3ddcb27dc33a5d14","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                                \u0027reserved_percentage\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":63,"context_line":"                                \u0027storage_protocol\u0027: {\u0027type\u0027: \u0027string\u0027}"},{"line_number":64,"context_line":"                            },"},{"line_number":65,"context_line":"                            \u0027required\u0027: [\u0027QoS_support\u0027, \u0027total_capacity_gb\u0027,"},{"line_number":66,"context_line":"                                         \u0027volume_backend_name\u0027,"},{"line_number":67,"context_line":"                                         \u0027free_capacity_gb\u0027, \u0027driver_version\u0027,"},{"line_number":68,"context_line":"                                         \u0027reserved_percentage\u0027,"},{"line_number":69,"context_line":"                                         \u0027storage_protocol\u0027]"},{"line_number":70,"context_line":"                        },"},{"line_number":71,"context_line":"                    },"},{"line_number":72,"context_line":"                    \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_acdeb5d7","line":69,"range":{"start_line":65,"start_character":41,"end_line":69,"end_character":59},"updated":"2020-03-17 08:17:28.000000000","message":"on second thoughts, you should reference [1] and [2] for pool level updates\n\n[1] https://github.com/openstack/cinder/blob/master/cinder/scheduler/host_manager.py#L276-L291\n[2] https://github.com/openstack/cinder/blob/master/cinder/scheduler/host_manager.py#L355-L387","commit_id":"86b47030a21b9c8a56bb47bd015396fa1527e58b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3a471129946ad46a6eb8c8484306f50ea4d28672","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                                \u0027reserved_percentage\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":63,"context_line":"                                \u0027storage_protocol\u0027: {\u0027type\u0027: \u0027string\u0027}"},{"line_number":64,"context_line":"                            },"},{"line_number":65,"context_line":"                            \u0027required\u0027: [\u0027QoS_support\u0027, \u0027total_capacity_gb\u0027,"},{"line_number":66,"context_line":"                                         \u0027volume_backend_name\u0027,"},{"line_number":67,"context_line":"                                         \u0027free_capacity_gb\u0027, \u0027driver_version\u0027,"},{"line_number":68,"context_line":"                                         \u0027reserved_percentage\u0027,"},{"line_number":69,"context_line":"                                         \u0027storage_protocol\u0027]"},{"line_number":70,"context_line":"                        },"},{"line_number":71,"context_line":"                    },"},{"line_number":72,"context_line":"                    \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff570b3c_215537c7","line":69,"range":{"start_line":65,"start_character":41,"end_line":69,"end_character":59},"in_reply_to":"1fa4df85_acdeb5d7","updated":"2020-05-14 00:00:44.000000000","message":"those are under if condition which means these fields can be missing right? \n\n\u0027required\u0027 mean all the fields listed in \u0027required\u0027 has to be present in API response in all cases.","commit_id":"86b47030a21b9c8a56bb47bd015396fa1527e58b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cb81e44f3cc57247be8762cabc505bd996c2f523","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                                \u0027reserved_percentage\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":63,"context_line":"                                \u0027storage_protocol\u0027: {\u0027type\u0027: \u0027string\u0027}"},{"line_number":64,"context_line":"                            },"},{"line_number":65,"context_line":"                            \u0027required\u0027: [\u0027QoS_support\u0027, \u0027total_capacity_gb\u0027,"},{"line_number":66,"context_line":"                                         \u0027volume_backend_name\u0027,"},{"line_number":67,"context_line":"                                         \u0027free_capacity_gb\u0027, \u0027driver_version\u0027,"},{"line_number":68,"context_line":"                                         \u0027reserved_percentage\u0027,"},{"line_number":69,"context_line":"                                         \u0027storage_protocol\u0027]"},{"line_number":70,"context_line":"                        },"},{"line_number":71,"context_line":"                    },"},{"line_number":72,"context_line":"                    \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff570b3c_3e60b532","line":69,"range":{"start_line":65,"start_character":41,"end_line":69,"end_character":59},"in_reply_to":"ff570b3c_215537c7","updated":"2020-05-14 04:57:00.000000000","message":"the if case is \u0027if they don\u0027t exist in pool then append them\u0027. These are the basic properties every backend should return in their capabilities and since we started supporting  pools, some part of backend info is mandatory to be in pools.\nThere\u0027s always the case of legacy volumes or backends that don\u0027t support pool so i\u0027m not really sure having a pool schema is a good idea cause it\u0027s backend specific.","commit_id":"86b47030a21b9c8a56bb47bd015396fa1527e58b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6b3424f5d242bb2b2672aaab1ee65276f0962cb0","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                                \u0027reserved_percentage\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":63,"context_line":"                                \u0027storage_protocol\u0027: {\u0027type\u0027: \u0027string\u0027}"},{"line_number":64,"context_line":"                            },"},{"line_number":65,"context_line":"                            \u0027required\u0027: [\u0027QoS_support\u0027, \u0027total_capacity_gb\u0027,"},{"line_number":66,"context_line":"                                         \u0027volume_backend_name\u0027,"},{"line_number":67,"context_line":"                                         \u0027free_capacity_gb\u0027, \u0027driver_version\u0027,"},{"line_number":68,"context_line":"                                         \u0027reserved_percentage\u0027,"},{"line_number":69,"context_line":"                                         \u0027storage_protocol\u0027]"},{"line_number":70,"context_line":"                        },"},{"line_number":71,"context_line":"                    },"},{"line_number":72,"context_line":"                    \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff570b3c_a0080c2c","line":69,"range":{"start_line":65,"start_character":41,"end_line":69,"end_character":59},"in_reply_to":"ff570b3c_3e60b532","updated":"2020-05-14 20:48:10.000000000","message":"yeah, it can start breaking legacy backends. let\u0027s remove these from required as there is no concrete API contract for these to be mandatory things to return.","commit_id":"86b47030a21b9c8a56bb47bd015396fa1527e58b"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"4a13e022657231db6ecea61adb97373f848fc5ce","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                                \u0027reserved_percentage\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":63,"context_line":"                                \u0027storage_protocol\u0027: {\u0027type\u0027: \u0027string\u0027}"},{"line_number":64,"context_line":"                            },"},{"line_number":65,"context_line":"                            \u0027required\u0027: [\u0027QoS_support\u0027, \u0027total_capacity_gb\u0027,"},{"line_number":66,"context_line":"                                         \u0027volume_backend_name\u0027,"},{"line_number":67,"context_line":"                                         \u0027free_capacity_gb\u0027, \u0027driver_version\u0027,"},{"line_number":68,"context_line":"                                         \u0027reserved_percentage\u0027,"},{"line_number":69,"context_line":"                                         \u0027storage_protocol\u0027]"},{"line_number":70,"context_line":"                        },"},{"line_number":71,"context_line":"                    },"},{"line_number":72,"context_line":"                    \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff570b3c_49463bc2","line":69,"range":{"start_line":65,"start_character":41,"end_line":69,"end_character":59},"in_reply_to":"ff570b3c_a0080c2c","updated":"2020-05-19 07:29:17.000000000","message":"Thanks, it\u0027s good to remove required fields for legacy backends","commit_id":"86b47030a21b9c8a56bb47bd015396fa1527e58b"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0445398938c1d1c57156bf674ee18d1ae01f1014","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                                \u0027vendor_name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":65,"context_line":"                                \u0027timestamp\u0027: parameter_types.date_time_or_null"},{"line_number":66,"context_line":"                            },"},{"line_number":67,"context_line":"                            # Because some legacy volumes or backends may not support pools,"},{"line_number":68,"context_line":"                            # so no required fields here."},{"line_number":69,"context_line":"                        },"},{"line_number":70,"context_line":"                    },"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff570b3c_5131c159","line":67,"updated":"2020-05-19 10:07:34.000000000","message":"pep8: E501 line too long (92 \u003e 79 characters)","commit_id":"8e24591dac4b26a4df2659edd37940624f895f59"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"4fe83196b0b5e0f617fce3ff00ad76452a8a7706","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                                \u0027vendor_name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":65,"context_line":"                                \u0027timestamp\u0027: parameter_types.date_time_or_null"},{"line_number":66,"context_line":"                            },"},{"line_number":67,"context_line":"                            # Because some legacy volumes or backends may not support"},{"line_number":68,"context_line":"                            # pools, so no required fields here."},{"line_number":69,"context_line":"                        },"},{"line_number":70,"context_line":"                    },"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_9e4192ac","line":67,"updated":"2020-05-19 23:44:56.000000000","message":"pep8: E501 line too long (85 \u003e 79 characters)","commit_id":"4b208a69e41341895b2454496b6729d579e42a51"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"778945ca3205a9a776e1f926af8d398cd5011c77","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                                \u0027vendor_name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":65,"context_line":"                                \u0027timestamp\u0027: parameter_types.date_time_or_null"},{"line_number":66,"context_line":"                            },"},{"line_number":67,"context_line":"                            # Because some legacy volumes or backends may not support"},{"line_number":68,"context_line":"                            # pools, so no required fields here."},{"line_number":69,"context_line":"                        },"},{"line_number":70,"context_line":"                    },"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_df6648ed","line":67,"updated":"2020-05-21 04:29:38.000000000","message":"pep8: E501 line too long (85 \u003e 79 characters)","commit_id":"4b208a69e41341895b2454496b6729d579e42a51"}],"tempest/tests/lib/services/volume/v3/test_scheduler_stats_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ad846c07ce6cccf3ada770b85d1f7c89ea05fc89","unresolved":false,"context_lines":[{"line_number":25,"context_line":"                \"name\": \"pool1\","},{"line_number":26,"context_line":"                \"capabilities\": {"},{"line_number":27,"context_line":"                    \"updated\": \"2014-10-28T00:00:00-00:00\","},{"line_number":28,"context_line":"                    \"total_capacity_gb\": 1024,"},{"line_number":29,"context_line":"                    \"free_capacity_gb\": 100,"},{"line_number":30,"context_line":"                    \"volume_backend_name\": \"pool1\","},{"line_number":31,"context_line":"                    \"reserved_percentage\": 0,"},{"line_number":32,"context_line":"                    \"driver_version\": \"1.0.0\","}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_2b5ac14f","line":29,"range":{"start_line":28,"start_character":0,"end_line":29,"end_character":44},"updated":"2020-03-16 00:42:34.000000000","message":"great","commit_id":"4fe2e2ca062e562157f930aad09e1f17e09ca8fa"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b36b6767de3b837517ed53e5796af6bddd1ad971","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                    \"volume_backend_name\": \"pool1\","},{"line_number":31,"context_line":"                    \"reserved_percentage\": 0,"},{"line_number":32,"context_line":"                    \"driver_version\": \"1.0.0\","},{"line_number":33,"context_line":"                    \"timestamp\": \"2014-10-28T00:00:00-00:00\","},{"line_number":34,"context_line":"                    \"storage_protocol\": \"iSCSI\","},{"line_number":35,"context_line":"                    \"vendor_name\": \"vendor\","},{"line_number":36,"context_line":"                    \"QoS_support\": False"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_d5b92079","line":33,"range":{"start_line":33,"start_character":21,"end_line":33,"end_character":30},"updated":"2020-05-20 09:26:22.000000000","message":"just to make sure, is timestamp and vendor_name really expected? I don\u0027t see them  in the doc: https://docs.openstack.org/api-ref/block-storage/v3/?expanded\u003dlist-all-back-end-storage-pools-detail","commit_id":"4b208a69e41341895b2454496b6729d579e42a51"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"5a6234321a862015513568c7693aaff08f315da5","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                    \"volume_backend_name\": \"pool1\","},{"line_number":31,"context_line":"                    \"reserved_percentage\": 0,"},{"line_number":32,"context_line":"                    \"driver_version\": \"1.0.0\","},{"line_number":33,"context_line":"                    \"timestamp\": \"2014-10-28T00:00:00-00:00\","},{"line_number":34,"context_line":"                    \"storage_protocol\": \"iSCSI\","},{"line_number":35,"context_line":"                    \"vendor_name\": \"vendor\","},{"line_number":36,"context_line":"                    \"QoS_support\": False"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_dc3db3c4","line":33,"range":{"start_line":33,"start_character":21,"end_line":33,"end_character":30},"in_reply_to":"ff570b3c_24b93714","updated":"2020-05-21 07:43:12.000000000","message":"I see, it\u0027s similar with my packstack deployment:\n\n[centos@mkopec-packstack ~]$ cinder get-pools --detail\n+-----------------------------+--------------------------------------------------------+\n| Property                    | Value                                                  |\n+-----------------------------+--------------------------------------------------------+\n| QoS_support                 | False                                                  |\n| allocated_capacity_gb       | 0                                                      |\n| backend_state               | up                                                     |\n| driver_version              | 3.0.0                                                  |\n| filter_function             | None                                                   |\n| free_capacity_gb            | 19.57                                                  |\n| goodness_function           | None                                                   |\n| location_info               | LVMVolumeDriver:mkopec-packstack:cinder-volumes:thin:0 |\n| max_over_subscription_ratio | 20.0                                                   |\n| multiattach                 | True                                                   |\n| name                        | mkopec-packstack@lvm#lvm                               |\n| pool_name                   | lvm                                                    |\n| provisioned_capacity_gb     | 0.0                                                    |\n| reserved_percentage         | 0                                                      |\n| storage_protocol            | iSCSI                                                  |\n| thick_provisioning_support  | False                                                  |\n| thin_provisioning_support   | True                                                   |\n| timestamp                   | 2020-05-21T07:39:55.177193                             |\n| total_capacity_gb           | 19.57                                                  |\n| total_volumes               | 1                                                      |\n| vendor_name                 | Open Source                                            |\n| volume_backend_name         | lvm                                                    |\n+-----------------------------+--------------------------------------------------------+\n\nor TripleO one:\n\n(overcloud) [stack@undercloud-0 ~]$ cinder get-pools --detail                       \n+-----------------------------+----------------------------------------------------+\n| Property                    | Value                                              |\n+-----------------------------+----------------------------------------------------+\n| QoS_support                 | False                                              |\n| allocated_capacity_gb       | 0                                                  |\n| backend_state               | up                                                 |\n| driver_version              | 3.0.0                                              |\n| filter_function             | None                                               |\n| free_capacity_gb            | 15.2                                               |\n| goodness_function           | None                                               |\n| location_info               | LVMVolumeDriver:controller-0:cinder-volumes:thin:0 |\n| max_over_subscription_ratio | 20.0                                               |\n| multiattach                 | True                                               |\n| name                        | hostgroup@tripleo_iscsi#tripleo_iscsi              |\n| pool_name                   | tripleo_iscsi                                      |\n| provisioned_capacity_gb     | 0.0                                                |                                                                                                        \n| reserved_percentage         | 0                                                  |                                                                                                        \n| storage_protocol            | iSCSI                                              |                                                                                                        \n| thick_provisioning_support  | False                                              |                                                                                                        \n| thin_provisioning_support   | True                                               |                                                                                                        \n| timestamp                   | 2020-05-21T07:28:45.166386                         |                                                                                                        \n| total_capacity_gb           | 15.2                                               |                                                                                                        \n| total_volumes               | 1                                                  |                                                                                                        \n| vendor_name                 | Open Source                                        |                                                                                                        \n| volume_backend_name         | tripleo_iscsi                                      |                                                                                                        \n+-----------------------------+----------------------------------------------------+\n\nso maybe it\u0027s a documentation bug?","commit_id":"4b208a69e41341895b2454496b6729d579e42a51"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"501ac6a1f7da00ae0227def6082737a1b69f3c2f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                    \"volume_backend_name\": \"pool1\","},{"line_number":31,"context_line":"                    \"reserved_percentage\": 0,"},{"line_number":32,"context_line":"                    \"driver_version\": \"1.0.0\","},{"line_number":33,"context_line":"                    \"timestamp\": \"2014-10-28T00:00:00-00:00\","},{"line_number":34,"context_line":"                    \"storage_protocol\": \"iSCSI\","},{"line_number":35,"context_line":"                    \"vendor_name\": \"vendor\","},{"line_number":36,"context_line":"                    \"QoS_support\": False"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_24b93714","line":33,"range":{"start_line":33,"start_character":21,"end_line":33,"end_character":30},"in_reply_to":"ff570b3c_d5b92079","updated":"2020-05-21 06:05:15.000000000","message":"Yes, below is the result of getting pool detail in my cloud, but it\u0027s strange why\n\n# cinder get-pools --detail\n+-----------------------------+----------------------------+\n| Property                    | Value                      |\n+-----------------------------+----------------------------+\n| QoS_support                 | True                       |\n| allocated_capacity_gb       | 1                          |\n| availability_zone           | nova                       |\n| backend_state               | up                         |\n| contiguous_capacity_gb      | 0                          |\n| display_name                | pool1                      |\n| driver_version              | 7.0.0                      |\n| free_capacity_gb            | 2773.0                     |\n| is_pool                     | True                       |\n| location_info               | 4c09b4b053ff               |\n| max_over_subscription_ratio | 1.0                        |\n| multiattach                 | True                       |\n| name                        | cinder@ZTE_IPSAN-1#pool1   |\n| pool_name                   | pool1                      |\n| provisioned_capacity_gb     | 575.0                      |\n| reserved_percentage         | 0                          |\n| storage_protocol            | iSCSI                      |\n| thick_provisioning_support  | True                       |\n| thin_provisioning_support   | False                      |\n| timestamp                   | 2020-05-20T09:39:29.017820 |\n| total_capacity_gb           | 3348.0                     |\n| vendor_name                 | ZTE                        |\n| volume_backend_name         | cd_cinder_backend          |\n+-----------------------------+----------------------------+","commit_id":"4b208a69e41341895b2454496b6729d579e42a51"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"8fb4455de77b2ff4cdd91420895edc069ad3c1a3","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                    \"volume_backend_name\": \"pool1\","},{"line_number":31,"context_line":"                    \"reserved_percentage\": 0,"},{"line_number":32,"context_line":"                    \"driver_version\": \"1.0.0\","},{"line_number":33,"context_line":"                    \"timestamp\": \"2014-10-28T00:00:00-00:00\","},{"line_number":34,"context_line":"                    \"storage_protocol\": \"iSCSI\","},{"line_number":35,"context_line":"                    \"vendor_name\": \"vendor\","},{"line_number":36,"context_line":"                    \"QoS_support\": False"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_b8efe7ae","line":33,"range":{"start_line":33,"start_character":21,"end_line":33,"end_character":30},"in_reply_to":"ff570b3c_dc3db3c4","updated":"2020-05-26 12:26:43.000000000","message":"https://bugs.launchpad.net/cinder/+bug/1880684","commit_id":"4b208a69e41341895b2454496b6729d579e42a51"}]}