)]}'
{"tempest/api/volume/admin/test_volume_types.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"67f0089c5be4779178f7e90c41bd5b84441eab6d","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        self.assertEqual(description, body[\u0027description\u0027],"},{"line_number":99,"context_line":"                         \"The created volume_type_description name is \""},{"line_number":100,"context_line":"                         \"not equal to the requested name\")"},{"line_number":101,"context_line":"        self.assertIsNotNone(body[\u0027id\u0027],"},{"line_number":102,"context_line":"                             \"Field volume_type id is empty or not found.\")"},{"line_number":103,"context_line":"        fetched_volume_type \u003d self.admin_volume_types_client.show_volume_type("},{"line_number":104,"context_line":"            body[\u0027id\u0027])[\u0027volume_type\u0027]"},{"line_number":105,"context_line":"        self.assertEqual(name, fetched_volume_type[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_8f687889","line":102,"range":{"start_line":101,"start_character":0,"end_line":102,"end_character":75},"updated":"2018-11-05 17:58:24.000000000","message":"This can also be removed.","commit_id":"387d3239ee0854bf93921fdfebdbfa664a738dc7"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"7ea7594663a01e4084e8440d8718cfd56871420c","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        self.assertEqual(description, body[\u0027description\u0027],"},{"line_number":99,"context_line":"                         \"The created volume_type_description name is \""},{"line_number":100,"context_line":"                         \"not equal to the requested name\")"},{"line_number":101,"context_line":"        self.assertIsNotNone(body[\u0027id\u0027],"},{"line_number":102,"context_line":"                             \"Field volume_type id is empty or not found.\")"},{"line_number":103,"context_line":"        fetched_volume_type \u003d self.admin_volume_types_client.show_volume_type("},{"line_number":104,"context_line":"            body[\u0027id\u0027])[\u0027volume_type\u0027]"},{"line_number":105,"context_line":"        self.assertEqual(name, fetched_volume_type[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_adc77597","line":102,"range":{"start_line":101,"start_character":0,"end_line":102,"end_character":75},"in_reply_to":"3f79a3b5_8f687889","updated":"2018-11-06 01:23:56.000000000","message":"Thanks, done.","commit_id":"387d3239ee0854bf93921fdfebdbfa664a738dc7"}],"tempest/lib/api_schema/response/volume/encryption_types.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"3c1d6920d496f89ed7d0c39c3ba2174aafb235aa","unresolved":false,"context_lines":[{"line_number":24,"context_line":"            \u0027control_location\u0027: {\u0027enum\u0027: [\u0027front-end\u0027, \u0027back-end\u0027]},"},{"line_number":25,"context_line":"            \u0027cipher\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":26,"context_line":"            \u0027deleted\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":27,"context_line":"            \u0027created_at\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":28,"context_line":"            \u0027updated_at\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":29,"context_line":"            \u0027deleted_at\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]}"},{"line_number":30,"context_line":"        },"},{"line_number":31,"context_line":"        \u0027additionalProperties\u0027: False,"},{"line_number":32,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_ca448c4b","line":29,"range":{"start_line":27,"start_character":11,"end_line":29,"end_character":54},"updated":"2018-10-05 02:04:05.000000000","message":"These should be datetime:\n\nhttps://developer.openstack.org/api-ref/block-storage/v3/index.html#id51\n\nAs you can see in examples, they are all iso-8601 formatted.\n\nThat is: [parameter_types.datetime, \u0027null\u0027]\n\n(I\u0027m just winging what the right parameter_types is, but you know what I mean).","commit_id":"a4b01c98566f527a6efc9d4a0dddbe272edea107"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"20fef0a6c5a34f256d26c56a30f4495a24568322","unresolved":false,"context_lines":[{"line_number":24,"context_line":"            \u0027control_location\u0027: {\u0027enum\u0027: [\u0027front-end\u0027, \u0027back-end\u0027]},"},{"line_number":25,"context_line":"            \u0027cipher\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":26,"context_line":"            \u0027deleted\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":27,"context_line":"            \u0027created_at\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":28,"context_line":"            \u0027updated_at\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":29,"context_line":"            \u0027deleted_at\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]}"},{"line_number":30,"context_line":"        },"},{"line_number":31,"context_line":"        \u0027additionalProperties\u0027: False,"},{"line_number":32,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_cab9ec16","line":29,"range":{"start_line":27,"start_character":11,"end_line":29,"end_character":54},"in_reply_to":"3f79a3b5_ca448c4b","updated":"2018-10-05 02:07:48.000000000","message":"parameter_types.date_time_or_null","commit_id":"a4b01c98566f527a6efc9d4a0dddbe272edea107"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"a897b25d38c08a40ff4e608cee9e804f2a8952ca","unresolved":false,"context_lines":[{"line_number":24,"context_line":"            \u0027control_location\u0027: {\u0027enum\u0027: [\u0027front-end\u0027, \u0027back-end\u0027]},"},{"line_number":25,"context_line":"            \u0027cipher\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":26,"context_line":"            \u0027deleted\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":27,"context_line":"            \u0027created_at\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":28,"context_line":"            \u0027updated_at\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":29,"context_line":"            \u0027deleted_at\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]}"},{"line_number":30,"context_line":"        },"},{"line_number":31,"context_line":"        \u0027additionalProperties\u0027: False,"},{"line_number":32,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_1ef37f0b","line":29,"range":{"start_line":27,"start_character":11,"end_line":29,"end_character":54},"in_reply_to":"3f79a3b5_cab9ec16","updated":"2018-10-08 07:44:23.000000000","message":"Done","commit_id":"a4b01c98566f527a6efc9d4a0dddbe272edea107"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"3c1d6920d496f89ed7d0c39c3ba2174aafb235aa","unresolved":false,"context_lines":[{"line_number":28,"context_line":"            \u0027updated_at\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":29,"context_line":"            \u0027deleted_at\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]}"},{"line_number":30,"context_line":"        },"},{"line_number":31,"context_line":"        \u0027additionalProperties\u0027: False,"},{"line_number":32,"context_line":"    }"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_aa9a70c1","line":31,"updated":"2018-10-05 02:04:05.000000000","message":"This is missing \u0027required\u0027 field.","commit_id":"a4b01c98566f527a6efc9d4a0dddbe272edea107"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"6108f10151fbe9ee57eefbdc04577ed2764fc5d9","unresolved":false,"context_lines":[{"line_number":28,"context_line":"            \u0027updated_at\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":29,"context_line":"            \u0027deleted_at\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]}"},{"line_number":30,"context_line":"        },"},{"line_number":31,"context_line":"        \u0027additionalProperties\u0027: False,"},{"line_number":32,"context_line":"    }"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_86b17304","line":31,"in_reply_to":"3f79a3b5_7ec0732c","updated":"2018-10-09 01:34:16.000000000","message":"Response body can be empty, so no required fields.","commit_id":"a4b01c98566f527a6efc9d4a0dddbe272edea107"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"a897b25d38c08a40ff4e608cee9e804f2a8952ca","unresolved":false,"context_lines":[{"line_number":28,"context_line":"            \u0027updated_at\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":29,"context_line":"            \u0027deleted_at\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]}"},{"line_number":30,"context_line":"        },"},{"line_number":31,"context_line":"        \u0027additionalProperties\u0027: False,"},{"line_number":32,"context_line":"    }"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_7ec0732c","line":31,"in_reply_to":"3f79a3b5_aa9a70c1","updated":"2018-10-08 07:44:23.000000000","message":"Done","commit_id":"a4b01c98566f527a6efc9d4a0dddbe272edea107"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"3c1d6920d496f89ed7d0c39c3ba2174aafb235aa","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                    \u0027key_size\u0027: {\u0027type\u0027: [\u0027integer\u0027, \u0027null\u0027]},"},{"line_number":56,"context_line":"                    \u0027provider\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":57,"context_line":"                    \u0027control_location\u0027: {\u0027enum\u0027: [\u0027front-end\u0027, \u0027back-end\u0027]},"},{"line_number":58,"context_line":"                    \u0027cipher\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":59,"context_line":"                },"},{"line_number":60,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":61,"context_line":"                \u0027required\u0027: [\u0027volume_type_id\u0027, \u0027encryption_id\u0027, \u0027provider\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_4a9f1cb3","line":58,"range":{"start_line":58,"start_character":39,"end_line":58,"end_character":47},"updated":"2018-10-05 02:04:05.000000000","message":"\u0027string\u0027, \u0027null\u0027","commit_id":"a4b01c98566f527a6efc9d4a0dddbe272edea107"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"a897b25d38c08a40ff4e608cee9e804f2a8952ca","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                    \u0027key_size\u0027: {\u0027type\u0027: [\u0027integer\u0027, \u0027null\u0027]},"},{"line_number":56,"context_line":"                    \u0027provider\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":57,"context_line":"                    \u0027control_location\u0027: {\u0027enum\u0027: [\u0027front-end\u0027, \u0027back-end\u0027]},"},{"line_number":58,"context_line":"                    \u0027cipher\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":59,"context_line":"                },"},{"line_number":60,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":61,"context_line":"                \u0027required\u0027: [\u0027volume_type_id\u0027, \u0027encryption_id\u0027, \u0027provider\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_9ea46fa5","line":58,"range":{"start_line":58,"start_character":39,"end_line":58,"end_character":47},"in_reply_to":"3f79a3b5_4a9f1cb3","updated":"2018-10-08 07:44:23.000000000","message":"Done","commit_id":"a4b01c98566f527a6efc9d4a0dddbe272edea107"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"3c1d6920d496f89ed7d0c39c3ba2174aafb235aa","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                    \u0027key_size\u0027: {\u0027type\u0027: [\u0027integer\u0027, \u0027null\u0027]},"},{"line_number":80,"context_line":"                    \u0027provider\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":81,"context_line":"                    \u0027control_location\u0027: {\u0027enum\u0027: [\u0027front-end\u0027, \u0027back-end\u0027]},"},{"line_number":82,"context_line":"                    \u0027cipher\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":83,"context_line":"                },"},{"line_number":84,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":85,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_6aa45808","line":82,"range":{"start_line":82,"start_character":40,"end_line":82,"end_character":46},"updated":"2018-10-05 02:04:05.000000000","message":"\u0027string\u0027, \u0027null\u0027","commit_id":"a4b01c98566f527a6efc9d4a0dddbe272edea107"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"a897b25d38c08a40ff4e608cee9e804f2a8952ca","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                    \u0027key_size\u0027: {\u0027type\u0027: [\u0027integer\u0027, \u0027null\u0027]},"},{"line_number":80,"context_line":"                    \u0027provider\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":81,"context_line":"                    \u0027control_location\u0027: {\u0027enum\u0027: [\u0027front-end\u0027, \u0027back-end\u0027]},"},{"line_number":82,"context_line":"                    \u0027cipher\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":83,"context_line":"                },"},{"line_number":84,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":85,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_bec60b4a","line":82,"range":{"start_line":82,"start_character":40,"end_line":82,"end_character":46},"in_reply_to":"3f79a3b5_6aa45808","updated":"2018-10-08 07:44:23.000000000","message":"Done","commit_id":"a4b01c98566f527a6efc9d4a0dddbe272edea107"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"3c1d6920d496f89ed7d0c39c3ba2174aafb235aa","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                    \u0027control_location\u0027: {\u0027enum\u0027: [\u0027front-end\u0027, \u0027back-end\u0027]},"},{"line_number":82,"context_line":"                    \u0027cipher\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":83,"context_line":"                },"},{"line_number":84,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":85,"context_line":"            }"},{"line_number":86,"context_line":"        },"},{"line_number":87,"context_line":"        \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_2aa6600f","line":84,"updated":"2018-10-05 02:04:05.000000000","message":"This is missing \u0027required\u0027 field","commit_id":"a4b01c98566f527a6efc9d4a0dddbe272edea107"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"a897b25d38c08a40ff4e608cee9e804f2a8952ca","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                    \u0027control_location\u0027: {\u0027enum\u0027: [\u0027front-end\u0027, \u0027back-end\u0027]},"},{"line_number":82,"context_line":"                    \u0027cipher\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":83,"context_line":"                },"},{"line_number":84,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":85,"context_line":"            }"},{"line_number":86,"context_line":"        },"},{"line_number":87,"context_line":"        \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_5eb817c6","line":84,"in_reply_to":"3f79a3b5_2aa6600f","updated":"2018-10-08 07:44:23.000000000","message":"No required field. But we can add a comment here","commit_id":"a4b01c98566f527a6efc9d4a0dddbe272edea107"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"67f0089c5be4779178f7e90c41bd5b84441eab6d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"            \u0027updated_at\u0027: parameter_types.date_time_or_null,"},{"line_number":31,"context_line":"            \u0027deleted_at\u0027: parameter_types.date_time_or_null"},{"line_number":32,"context_line":"        },"},{"line_number":33,"context_line":"        # response body can be empty, so no required fields.,"},{"line_number":34,"context_line":"        \u0027additionalProperties\u0027: False,"},{"line_number":35,"context_line":"    }"},{"line_number":36,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_cf243062","line":33,"range":{"start_line":33,"start_character":60,"end_line":33,"end_character":61},"updated":"2018-11-05 17:58:24.000000000","message":"nit: extra comma","commit_id":"387d3239ee0854bf93921fdfebdbfa664a738dc7"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"7ea7594663a01e4084e8440d8718cfd56871420c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"            \u0027updated_at\u0027: parameter_types.date_time_or_null,"},{"line_number":31,"context_line":"            \u0027deleted_at\u0027: parameter_types.date_time_or_null"},{"line_number":32,"context_line":"        },"},{"line_number":33,"context_line":"        # response body can be empty, so no required fields.,"},{"line_number":34,"context_line":"        \u0027additionalProperties\u0027: False,"},{"line_number":35,"context_line":"    }"},{"line_number":36,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_2db36537","line":33,"range":{"start_line":33,"start_character":60,"end_line":33,"end_character":61},"in_reply_to":"3f79a3b5_cf243062","updated":"2018-11-06 01:23:56.000000000","message":"Done","commit_id":"387d3239ee0854bf93921fdfebdbfa664a738dc7"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"77f117849c8d17110e37e485cfe36f8a051cffc4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 NEC Corporation.  All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_92136401","line":1,"updated":"2019-08-19 18:54:03.000000000","message":"Here should be updated.","commit_id":"7ac787486b29a019ee8c5e60ba6c9c246823a0ac"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"883bceb67c6975515f326b6f8b6d41a2315a31de","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 NEC Corporation.  All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_3b0608d0","line":1,"in_reply_to":"7faddb67_92136401","updated":"2019-08-20 00:52:11.000000000","message":"oops, done","commit_id":"7ac787486b29a019ee8c5e60ba6c9c246823a0ac"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"77f117849c8d17110e37e485cfe36f8a051cffc4","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from tempest.lib.api_schema.response.compute.v2_1 import parameter_types"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"show_encryption_type \u003d {"},{"line_number":18,"context_line":"    \u0027status_code\u0027: [200],"},{"line_number":19,"context_line":"    \u0027response_body\u0027: {"},{"line_number":20,"context_line":"        \u0027type\u0027: [\u0027object\u0027, \u0027null\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_12abf487","line":17,"updated":"2019-08-19 18:54:03.000000000","message":"LGTM as https://docs.openstack.org/api-ref/block-storage/v3/index.html?expanded\u003dshow-an-encryption-type-detail#show-an-encryption-type","commit_id":"7ac787486b29a019ee8c5e60ba6c9c246823a0ac"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"77f117849c8d17110e37e485cfe36f8a051cffc4","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    }"},{"line_number":37,"context_line":"}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"show_encryption_specs_item \u003d {"},{"line_number":40,"context_line":"    \u0027status_code\u0027: [200],"},{"line_number":41,"context_line":"    \u0027response_body\u0027: {"},{"line_number":42,"context_line":"        \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_328b901f","line":39,"updated":"2019-08-19 18:54:03.000000000","message":"LGTM as https://docs.openstack.org/api-ref/block-storage/v3/index.html?expanded\u003dshow-encryption-specs-item-detail#show-an-encryption-type","commit_id":"7ac787486b29a019ee8c5e60ba6c9c246823a0ac"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"77f117849c8d17110e37e485cfe36f8a051cffc4","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    }"},{"line_number":47,"context_line":"}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"create_encryption_type \u003d {"},{"line_number":50,"context_line":"    \u0027status_code\u0027: [200],"},{"line_number":51,"context_line":"    \u0027response_body\u0027: {"},{"line_number":52,"context_line":"        \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_b2a3009e","line":49,"updated":"2019-08-19 18:54:03.000000000","message":"LGTM as https://docs.openstack.org/api-ref/block-storage/v3/index.html?expanded\u003dcreate-an-encryption-type-detail#show-an-encryption-type","commit_id":"7ac787486b29a019ee8c5e60ba6c9c246823a0ac"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"77f117849c8d17110e37e485cfe36f8a051cffc4","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"delete_encryption_type \u003d {\u0027status_code\u0027: [202]}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"update_encryption_type \u003d {"},{"line_number":76,"context_line":"    \u0027status_code\u0027: [200],"},{"line_number":77,"context_line":"    \u0027response_body\u0027: {"},{"line_number":78,"context_line":"        \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_f2ae587f","line":75,"updated":"2019-08-19 18:54:03.000000000","message":"LGTM as https://docs.openstack.org/api-ref/block-storage/v3/index.html?expanded\u003dupdate-an-encryption-type-detail#show-an-encryption-type","commit_id":"7ac787486b29a019ee8c5e60ba6c9c246823a0ac"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"11a433153bf1c2953b25150a1014d7f39a31d1cd","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                    \u0027volume_type_id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":58,"context_line":"                    \u0027encryption_id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":59,"context_line":"                    \u0027key_size\u0027: {\u0027type\u0027: [\u0027integer\u0027, \u0027null\u0027]},"},{"line_number":60,"context_line":"                    \u0027provider\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":61,"context_line":"                    \u0027control_location\u0027: {\u0027enum\u0027: [\u0027front-end\u0027, \u0027back-end\u0027]},"},{"line_number":62,"context_line":"                    \u0027cipher\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":63,"context_line":"                },"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_8c7d646e","line":60,"range":{"start_line":60,"start_character":48,"end_line":60,"end_character":51},"updated":"2019-08-21 11:12:54.000000000","message":"this is limited to 255, so can we add - \n\u0027minLength\u0027: 0,\u0027maxLength\u0027: 255","commit_id":"c1e4b462390839b6f81ca888c5fd304a3d5c52b3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"949a10a8277be23445c48e9555d2e0a297ce85aa","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                    \u0027volume_type_id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":58,"context_line":"                    \u0027encryption_id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":59,"context_line":"                    \u0027key_size\u0027: {\u0027type\u0027: [\u0027integer\u0027, \u0027null\u0027]},"},{"line_number":60,"context_line":"                    \u0027provider\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":61,"context_line":"                    \u0027control_location\u0027: {\u0027enum\u0027: [\u0027front-end\u0027, \u0027back-end\u0027]},"},{"line_number":62,"context_line":"                    \u0027cipher\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":63,"context_line":"                },"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_baf9644e","line":60,"range":{"start_line":60,"start_character":48,"end_line":60,"end_character":51},"in_reply_to":"7faddb67_7a376cb1","updated":"2019-08-22 02:06:13.000000000","message":"I do not believe doc :) so always check code.\n\nin API request scheme it is limited to 255 [1] and that is what returned in POST response[2]\n\n[1] https://github.com/openstack/cinder/blob/7bb05f327aa207573246f8ab356e2565c7c805b0/cinder/api/schemas/volume_type_encryption.py#L29\n\n[2]  https://github.com/openstack/cinder/blob/7bb05f327aa207573246f8ab356e2565c7c805b0/cinder/api/contrib/volume_type_encryption.py#L110","commit_id":"c1e4b462390839b6f81ca888c5fd304a3d5c52b3"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"7d9ed2f38e6405469c6fbe03f21b391cd4d4fec5","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                    \u0027volume_type_id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":58,"context_line":"                    \u0027encryption_id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":59,"context_line":"                    \u0027key_size\u0027: {\u0027type\u0027: [\u0027integer\u0027, \u0027null\u0027]},"},{"line_number":60,"context_line":"                    \u0027provider\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":61,"context_line":"                    \u0027control_location\u0027: {\u0027enum\u0027: [\u0027front-end\u0027, \u0027back-end\u0027]},"},{"line_number":62,"context_line":"                    \u0027cipher\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":63,"context_line":"                },"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_7a376cb1","line":60,"range":{"start_line":60,"start_character":48,"end_line":60,"end_character":51},"in_reply_to":"7faddb67_8c7d646e","updated":"2019-08-22 00:58:18.000000000","message":"I seem don\u0027t see this limitation in \nhttps://docs.openstack.org/api-ref/block-storage/v3/index.html#create-an-encryption-type,\ndo I miss something?","commit_id":"c1e4b462390839b6f81ca888c5fd304a3d5c52b3"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"ed6a740805a760fa10507fa8bbedf18999b04dd7","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                    \u0027volume_type_id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":58,"context_line":"                    \u0027encryption_id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":59,"context_line":"                    \u0027key_size\u0027: {\u0027type\u0027: [\u0027integer\u0027, \u0027null\u0027]},"},{"line_number":60,"context_line":"                    \u0027provider\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":61,"context_line":"                    \u0027control_location\u0027: {\u0027enum\u0027: [\u0027front-end\u0027, \u0027back-end\u0027]},"},{"line_number":62,"context_line":"                    \u0027cipher\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":63,"context_line":"                },"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_0dade02f","line":60,"range":{"start_line":60,"start_character":48,"end_line":60,"end_character":51},"in_reply_to":"7faddb67_baf9644e","updated":"2019-08-22 03:35:30.000000000","message":"Yes I see the length limit in the code.\nAnd it seems we haven\u0027t add length limit check for too many fields, like server name, flavor name, keypair name, and so on. So maybe we can leave this for the future?","commit_id":"c1e4b462390839b6f81ca888c5fd304a3d5c52b3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"11a433153bf1c2953b25150a1014d7f39a31d1cd","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                    \u0027key_size\u0027: {\u0027type\u0027: [\u0027integer\u0027, \u0027null\u0027]},"},{"line_number":60,"context_line":"                    \u0027provider\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":61,"context_line":"                    \u0027control_location\u0027: {\u0027enum\u0027: [\u0027front-end\u0027, \u0027back-end\u0027]},"},{"line_number":62,"context_line":"                    \u0027cipher\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":63,"context_line":"                },"},{"line_number":64,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":65,"context_line":"                \u0027required\u0027: [\u0027volume_type_id\u0027, \u0027encryption_id\u0027, \u0027provider\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_2c98f0bd","line":62,"range":{"start_line":62,"start_character":57,"end_line":62,"end_character":58},"updated":"2019-08-21 11:12:54.000000000","message":"ditto\n\u0027minLength\u0027: 0, \u0027maxLength\u0027: 255","commit_id":"c1e4b462390839b6f81ca888c5fd304a3d5c52b3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"11a433153bf1c2953b25150a1014d7f39a31d1cd","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                    \u0027cipher\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":63,"context_line":"                },"},{"line_number":64,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":65,"context_line":"                \u0027required\u0027: [\u0027volume_type_id\u0027, \u0027encryption_id\u0027, \u0027provider\u0027]"},{"line_number":66,"context_line":"            }"},{"line_number":67,"context_line":"        },"},{"line_number":68,"context_line":"        \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_4cd8cc7d","line":65,"range":{"start_line":65,"start_character":74,"end_line":65,"end_character":75},"updated":"2019-08-21 11:12:54.000000000","message":"control_location is also mandatory.","commit_id":"c1e4b462390839b6f81ca888c5fd304a3d5c52b3"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"7d9ed2f38e6405469c6fbe03f21b391cd4d4fec5","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                    \u0027cipher\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":63,"context_line":"                },"},{"line_number":64,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":65,"context_line":"                \u0027required\u0027: [\u0027volume_type_id\u0027, \u0027encryption_id\u0027, \u0027provider\u0027]"},{"line_number":66,"context_line":"            }"},{"line_number":67,"context_line":"        },"},{"line_number":68,"context_line":"        \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_daaf80dd","line":65,"range":{"start_line":65,"start_character":74,"end_line":65,"end_character":75},"in_reply_to":"7faddb67_4cd8cc7d","updated":"2019-08-22 00:58:18.000000000","message":"Seems control_location is not mandatory?\nhttps://docs.openstack.org/api-ref/block-storage/v3/index.html#create-an-encryption-type","commit_id":"c1e4b462390839b6f81ca888c5fd304a3d5c52b3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"949a10a8277be23445c48e9555d2e0a297ce85aa","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                    \u0027cipher\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":63,"context_line":"                },"},{"line_number":64,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":65,"context_line":"                \u0027required\u0027: [\u0027volume_type_id\u0027, \u0027encryption_id\u0027, \u0027provider\u0027]"},{"line_number":66,"context_line":"            }"},{"line_number":67,"context_line":"        },"},{"line_number":68,"context_line":"        \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_daf46057","line":65,"range":{"start_line":65,"start_character":74,"end_line":65,"end_character":75},"in_reply_to":"7faddb67_daaf80dd","updated":"2019-08-22 02:06:13.000000000","message":"ditto. it is mandatory in request schema which is returned in the response (above link).","commit_id":"c1e4b462390839b6f81ca888c5fd304a3d5c52b3"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"ed6a740805a760fa10507fa8bbedf18999b04dd7","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                    \u0027cipher\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":63,"context_line":"                },"},{"line_number":64,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":65,"context_line":"                \u0027required\u0027: [\u0027volume_type_id\u0027, \u0027encryption_id\u0027, \u0027provider\u0027]"},{"line_number":66,"context_line":"            }"},{"line_number":67,"context_line":"        },"},{"line_number":68,"context_line":"        \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_4d9e7806","line":65,"range":{"start_line":65,"start_character":74,"end_line":65,"end_character":75},"in_reply_to":"7faddb67_daf46057","updated":"2019-08-22 03:35:30.000000000","message":"Yes now I\u0027m sure it\u0027s mandatory.\nAnd I think we should setup schema check according to api-ref, so I put https://review.opendev.org/677862 to fix the cinder api-ref:)","commit_id":"c1e4b462390839b6f81ca888c5fd304a3d5c52b3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"11a433153bf1c2953b25150a1014d7f39a31d1cd","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                \u0027type\u0027: \u0027object\u0027,"},{"line_number":82,"context_line":"                \u0027properties\u0027: {"},{"line_number":83,"context_line":"                    \u0027key_size\u0027: {\u0027type\u0027: [\u0027integer\u0027, \u0027null\u0027]},"},{"line_number":84,"context_line":"                    \u0027provider\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":85,"context_line":"                    \u0027control_location\u0027: {\u0027enum\u0027: [\u0027front-end\u0027, \u0027back-end\u0027]},"},{"line_number":86,"context_line":"                    \u0027cipher\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":87,"context_line":"                },"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_4c844cb1","line":84,"range":{"start_line":84,"start_character":48,"end_line":84,"end_character":51},"updated":"2019-08-21 11:12:54.000000000","message":"ditto","commit_id":"c1e4b462390839b6f81ca888c5fd304a3d5c52b3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"11a433153bf1c2953b25150a1014d7f39a31d1cd","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                    \u0027key_size\u0027: {\u0027type\u0027: [\u0027integer\u0027, \u0027null\u0027]},"},{"line_number":84,"context_line":"                    \u0027provider\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":85,"context_line":"                    \u0027control_location\u0027: {\u0027enum\u0027: [\u0027front-end\u0027, \u0027back-end\u0027]},"},{"line_number":86,"context_line":"                    \u0027cipher\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":87,"context_line":"                },"},{"line_number":88,"context_line":"                # all fields are optional"},{"line_number":89,"context_line":"                \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_6c9b4816","line":86,"range":{"start_line":86,"start_character":19,"end_line":86,"end_character":59},"updated":"2019-08-21 11:12:54.000000000","message":"ditto","commit_id":"c1e4b462390839b6f81ca888c5fd304a3d5c52b3"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"f7cd9c320e0ef6639b43b8ae60085792fdd237f5","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from tempest.lib.api_schema.response.compute.v2_1 import parameter_types"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"show_encryption_type \u003d {"},{"line_number":18,"context_line":"    \u0027status_code\u0027: [200],"},{"line_number":19,"context_line":"    \u0027response_body\u0027: {"},{"line_number":20,"context_line":"        \u0027type\u0027: [\u0027object\u0027, \u0027null\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"7faddb67_5a6937f6","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":20},"updated":"2019-08-23 00:53:25.000000000","message":"confirmed","commit_id":"8f04d0ff2c4237e36792d76768d6069998cfadcd"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"f7cd9c320e0ef6639b43b8ae60085792fdd237f5","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    }"},{"line_number":47,"context_line":"}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"create_encryption_type \u003d {"},{"line_number":50,"context_line":"    \u0027status_code\u0027: [200],"},{"line_number":51,"context_line":"    \u0027response_body\u0027: {"},{"line_number":52,"context_line":"        \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7faddb67_7ab99377","line":49,"range":{"start_line":49,"start_character":0,"end_line":49,"end_character":22},"updated":"2019-08-23 00:53:25.000000000","message":"confirmed","commit_id":"8f04d0ff2c4237e36792d76768d6069998cfadcd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"32db25e0f75d9f1fdbaf7bf99f2dafa749e54df0","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                    \u0027cipher\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":63,"context_line":"                },"},{"line_number":64,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":65,"context_line":"                \u0027required\u0027: [\u0027volume_type_id\u0027, \u0027encryption_id\u0027, \u0027provider\u0027,"},{"line_number":66,"context_line":"                             \u0027control_location\u0027]"},{"line_number":67,"context_line":"            }"},{"line_number":68,"context_line":"        },"}],"source_content_type":"text/x-python","patch_set":9,"id":"1fa4df85_ae78ff8e","line":65,"range":{"start_line":65,"start_character":48,"end_line":65,"end_character":61},"updated":"2020-03-16 01:20:55.000000000","message":"ditto\n- https://github.com/openstack/cinder/blob/7e98d14a5724efaa8b02d8dc1c5d28cde7ce0ea6/cinder/db/sqlalchemy/api.py#L4904","commit_id":"8f04d0ff2c4237e36792d76768d6069998cfadcd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"32db25e0f75d9f1fdbaf7bf99f2dafa749e54df0","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                    \u0027cipher\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":63,"context_line":"                },"},{"line_number":64,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":65,"context_line":"                \u0027required\u0027: [\u0027volume_type_id\u0027, \u0027encryption_id\u0027, \u0027provider\u0027,"},{"line_number":66,"context_line":"                             \u0027control_location\u0027]"},{"line_number":67,"context_line":"            }"},{"line_number":68,"context_line":"        },"}],"source_content_type":"text/x-python","patch_set":9,"id":"1fa4df85_2e640fe5","line":65,"range":{"start_line":65,"start_character":65,"end_line":65,"end_character":73},"updated":"2020-03-16 01:20:55.000000000","message":"ditto. it just update the presented value and \u0027provider\u0027 does not seems as mandatory.","commit_id":"8f04d0ff2c4237e36792d76768d6069998cfadcd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"32db25e0f75d9f1fdbaf7bf99f2dafa749e54df0","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                    \u0027cipher\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":63,"context_line":"                },"},{"line_number":64,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":65,"context_line":"                \u0027required\u0027: [\u0027volume_type_id\u0027, \u0027encryption_id\u0027, \u0027provider\u0027,"},{"line_number":66,"context_line":"                             \u0027control_location\u0027]"},{"line_number":67,"context_line":"            }"},{"line_number":68,"context_line":"        },"}],"source_content_type":"text/x-python","patch_set":9,"id":"1fa4df85_8e75039b","line":65,"range":{"start_line":65,"start_character":30,"end_line":65,"end_character":44},"updated":"2020-03-16 01:20:55.000000000","message":"this does not seem mandatory.\n\n\n- https://github.com/openstack/cinder/blob/7e98d14a5724efaa8b02d8dc1c5d28cde7ce0ea6/cinder/db/sqlalchemy/api.py#L4901","commit_id":"8f04d0ff2c4237e36792d76768d6069998cfadcd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d849504766f5ca08d029011b1ea611429a0186ec","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                    \u0027cipher\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":63,"context_line":"                },"},{"line_number":64,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":65,"context_line":"                \u0027required\u0027: [\u0027volume_type_id\u0027, \u0027encryption_id\u0027, \u0027provider\u0027,"},{"line_number":66,"context_line":"                             \u0027control_location\u0027]"},{"line_number":67,"context_line":"            }"},{"line_number":68,"context_line":"        },"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff570b3c_fb81194c","line":65,"range":{"start_line":65,"start_character":48,"end_line":65,"end_character":61},"in_reply_to":"1fa4df85_144a8226","updated":"2020-05-14 21:00:34.000000000","message":"ah i misread that in code. cinder adds \u0027volume_type_id\u0027, \u0027encryption_id\u0027 in response always even not present in requst but \u0027provider\u0027 can be missing is not in request.","commit_id":"8f04d0ff2c4237e36792d76768d6069998cfadcd"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"6ca1fc4ffaf15d318dff25e21c0261f4f362f4d2","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                    \u0027cipher\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":63,"context_line":"                },"},{"line_number":64,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":65,"context_line":"                \u0027required\u0027: [\u0027volume_type_id\u0027, \u0027encryption_id\u0027, \u0027provider\u0027,"},{"line_number":66,"context_line":"                             \u0027control_location\u0027]"},{"line_number":67,"context_line":"            }"},{"line_number":68,"context_line":"        },"}],"source_content_type":"text/x-python","patch_set":9,"id":"1fa4df85_144a8226","line":65,"range":{"start_line":65,"start_character":48,"end_line":65,"end_character":61},"in_reply_to":"1fa4df85_ae78ff8e","updated":"2020-03-16 08:34:07.000000000","message":"\u0027volume_type_id\u0027, \u0027encryption_id\u0027, \u0027provider\u0027 are mandatory in api ref?\nhttps://docs.openstack.org/api-ref/block-storage/v3/index.html#volume-types-types\n\nAnd the cinder code shows that they are not required in request?","commit_id":"8f04d0ff2c4237e36792d76768d6069998cfadcd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"32db25e0f75d9f1fdbaf7bf99f2dafa749e54df0","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                },"},{"line_number":64,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":65,"context_line":"                \u0027required\u0027: [\u0027volume_type_id\u0027, \u0027encryption_id\u0027, \u0027provider\u0027,"},{"line_number":66,"context_line":"                             \u0027control_location\u0027]"},{"line_number":67,"context_line":"            }"},{"line_number":68,"context_line":"        },"},{"line_number":69,"context_line":"        \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":9,"id":"1fa4df85_6e7207b0","line":66,"range":{"start_line":66,"start_character":30,"end_line":66,"end_character":46},"updated":"2020-03-16 01:20:55.000000000","message":"this is also listed as optional - https://docs.openstack.org/api-ref/block-storage/v3/index.html?expanded\u003dlist-all-back-end-storage-pools-detail,create-an-encryption-type-detail#volume-types-types","commit_id":"8f04d0ff2c4237e36792d76768d6069998cfadcd"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"6ca1fc4ffaf15d318dff25e21c0261f4f362f4d2","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                },"},{"line_number":64,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":65,"context_line":"                \u0027required\u0027: [\u0027volume_type_id\u0027, \u0027encryption_id\u0027, \u0027provider\u0027,"},{"line_number":66,"context_line":"                             \u0027control_location\u0027]"},{"line_number":67,"context_line":"            }"},{"line_number":68,"context_line":"        },"},{"line_number":69,"context_line":"        \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":9,"id":"1fa4df85_b4d4ce48","line":66,"range":{"start_line":66,"start_character":30,"end_line":66,"end_character":46},"in_reply_to":"1fa4df85_6e7207b0","updated":"2020-03-16 08:34:07.000000000","message":"control_location is optional, done.","commit_id":"8f04d0ff2c4237e36792d76768d6069998cfadcd"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"f7cd9c320e0ef6639b43b8ae60085792fdd237f5","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    }"},{"line_number":72,"context_line":"}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"delete_encryption_type \u003d {\u0027status_code\u0027: [202]}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"update_encryption_type \u003d {"},{"line_number":77,"context_line":"    \u0027status_code\u0027: [200],"}],"source_content_type":"text/x-python","patch_set":9,"id":"7faddb67_daa76750","line":74,"range":{"start_line":74,"start_character":0,"end_line":74,"end_character":22},"updated":"2019-08-23 00:53:25.000000000","message":"confirmed","commit_id":"8f04d0ff2c4237e36792d76768d6069998cfadcd"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"f7cd9c320e0ef6639b43b8ae60085792fdd237f5","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"delete_encryption_type \u003d {\u0027status_code\u0027: [202]}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"update_encryption_type \u003d {"},{"line_number":77,"context_line":"    \u0027status_code\u0027: [200],"},{"line_number":78,"context_line":"    \u0027response_body\u0027: {"},{"line_number":79,"context_line":"        \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7faddb67_ba64eb22","line":76,"range":{"start_line":76,"start_character":0,"end_line":76,"end_character":22},"updated":"2019-08-23 00:53:25.000000000","message":"confirmed","commit_id":"8f04d0ff2c4237e36792d76768d6069998cfadcd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"32db25e0f75d9f1fdbaf7bf99f2dafa749e54df0","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            \u0027encryption\u0027: {"},{"line_number":82,"context_line":"                \u0027type\u0027: \u0027object\u0027,"},{"line_number":83,"context_line":"                \u0027properties\u0027: {"},{"line_number":84,"context_line":"                    \u0027key_size\u0027: {\u0027type\u0027: [\u0027integer\u0027, \u0027null\u0027]},"},{"line_number":85,"context_line":"                    \u0027provider\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":86,"context_line":"                    \u0027control_location\u0027: {\u0027enum\u0027: [\u0027front-end\u0027, \u0027back-end\u0027]},"},{"line_number":87,"context_line":"                    \u0027cipher\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":88,"context_line":"                },"},{"line_number":89,"context_line":"                # all fields are optional"},{"line_number":90,"context_line":"                \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":9,"id":"1fa4df85_ee5d9715","line":87,"range":{"start_line":84,"start_character":0,"end_line":87,"end_character":59},"updated":"2020-03-16 01:20:55.000000000","message":"how about volume_type_id and encrypton_id as mentioned in https://docs.openstack.org/api-ref/block-storage/v3/index.html?expanded\u003dlist-all-back-end-storage-pools-detail,create-an-encryption-type-detail,update-an-encryption-type-detail#volume-types-types","commit_id":"8f04d0ff2c4237e36792d76768d6069998cfadcd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d849504766f5ca08d029011b1ea611429a0186ec","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            \u0027encryption\u0027: {"},{"line_number":82,"context_line":"                \u0027type\u0027: \u0027object\u0027,"},{"line_number":83,"context_line":"                \u0027properties\u0027: {"},{"line_number":84,"context_line":"                    \u0027key_size\u0027: {\u0027type\u0027: [\u0027integer\u0027, \u0027null\u0027]},"},{"line_number":85,"context_line":"                    \u0027provider\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":86,"context_line":"                    \u0027control_location\u0027: {\u0027enum\u0027: [\u0027front-end\u0027, \u0027back-end\u0027]},"},{"line_number":87,"context_line":"                    \u0027cipher\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":88,"context_line":"                },"},{"line_number":89,"context_line":"                # all fields are optional"},{"line_number":90,"context_line":"                \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff570b3c_5bc6459c","line":87,"range":{"start_line":84,"start_character":0,"end_line":87,"end_character":59},"in_reply_to":"1fa4df85_146922bd","updated":"2020-05-14 21:00:34.000000000","message":"yeah, they are part of path.","commit_id":"8f04d0ff2c4237e36792d76768d6069998cfadcd"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"6ca1fc4ffaf15d318dff25e21c0261f4f362f4d2","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            \u0027encryption\u0027: {"},{"line_number":82,"context_line":"                \u0027type\u0027: \u0027object\u0027,"},{"line_number":83,"context_line":"                \u0027properties\u0027: {"},{"line_number":84,"context_line":"                    \u0027key_size\u0027: {\u0027type\u0027: [\u0027integer\u0027, \u0027null\u0027]},"},{"line_number":85,"context_line":"                    \u0027provider\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":86,"context_line":"                    \u0027control_location\u0027: {\u0027enum\u0027: [\u0027front-end\u0027, \u0027back-end\u0027]},"},{"line_number":87,"context_line":"                    \u0027cipher\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":88,"context_line":"                },"},{"line_number":89,"context_line":"                # all fields are optional"},{"line_number":90,"context_line":"                \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":9,"id":"1fa4df85_146922bd","line":87,"range":{"start_line":84,"start_character":0,"end_line":87,"end_character":59},"in_reply_to":"1fa4df85_ee5d9715","updated":"2020-03-16 08:34:07.000000000","message":"volume_type_id and encryption_id seems to be only the fields of request?","commit_id":"8f04d0ff2c4237e36792d76768d6069998cfadcd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"32db25e0f75d9f1fdbaf7bf99f2dafa749e54df0","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                    \u0027control_location\u0027: {\u0027enum\u0027: [\u0027front-end\u0027, \u0027back-end\u0027]},"},{"line_number":87,"context_line":"                    \u0027cipher\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":88,"context_line":"                },"},{"line_number":89,"context_line":"                # all fields are optional"},{"line_number":90,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":91,"context_line":"            }"},{"line_number":92,"context_line":"        },"}],"source_content_type":"text/x-python","patch_set":9,"id":"1fa4df85_ce621bd9","line":89,"range":{"start_line":89,"start_character":0,"end_line":89,"end_character":41},"updated":"2020-03-16 01:20:55.000000000","message":"+1","commit_id":"8f04d0ff2c4237e36792d76768d6069998cfadcd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"db85cda1f0810925d7084a227e0e22927f3a53db","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                    \u0027cipher\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":63,"context_line":"                },"},{"line_number":64,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":65,"context_line":"                \u0027required\u0027: [\u0027volume_type_id\u0027, \u0027encryption_id\u0027, \u0027provider\u0027]"},{"line_number":66,"context_line":"            }"},{"line_number":67,"context_line":"        },"},{"line_number":68,"context_line":"        \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_bb3a0195","line":65,"range":{"start_line":65,"start_character":64,"end_line":65,"end_character":74},"updated":"2020-05-14 21:01:45.000000000","message":"this does not seems to be required, commented in previous PS comment","commit_id":"0f364d0c9d34fc55bf5ca94aa7efc42d7d8eda3d"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"3c8fdd8f124b0330661790eb5e9501e7946559de","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                    \u0027cipher\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":63,"context_line":"                },"},{"line_number":64,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":65,"context_line":"                \u0027required\u0027: [\u0027volume_type_id\u0027, \u0027encryption_id\u0027, \u0027provider\u0027]"},{"line_number":66,"context_line":"            }"},{"line_number":67,"context_line":"        },"},{"line_number":68,"context_line":"        \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_c959ab8e","line":65,"range":{"start_line":65,"start_character":64,"end_line":65,"end_character":74},"in_reply_to":"ff570b3c_bb3a0195","updated":"2020-05-19 07:32:46.000000000","message":"Done","commit_id":"0f364d0c9d34fc55bf5ca94aa7efc42d7d8eda3d"}]}