)]}'
{"tempest/cmd/account_generator.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cf4b083870ebff767477fe2447153ef039210f7b","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        else:"},{"line_number":186,"context_line":"            account[\u0027project_name\u0027] \u003d test_resource.tenant_name"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        # If the spec includes \u0027admin\u0027 credentials are defined via type,"},{"line_number":189,"context_line":"        # else they are defined via list of roles."},{"line_number":190,"context_line":"        if cred_type \u003d\u003d \u0027admin\u0027:"},{"line_number":191,"context_line":"            account[\u0027types\u0027] \u003d [cred_type]"},{"line_number":192,"context_line":"        elif cred_type not in [\u0027primary\u0027, \u0027alt\u0027]:"},{"line_number":193,"context_line":"            account[\u0027roles\u0027] \u003d cred_type"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_ad11635e","line":190,"range":{"start_line":188,"start_character":0,"end_line":190,"end_character":32},"updated":"2018-10-03 02:51:48.000000000","message":"you need to fix these also.","commit_id":"c4e12ea95286ff9712e8c147e91c72a610c45545"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"be90731a638c73ad7e0d7a283cb60d632acac84a","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        else:"},{"line_number":186,"context_line":"            account[\u0027project_name\u0027] \u003d test_resource.tenant_name"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        # If the spec includes \u0027admin\u0027 credentials are defined via type,"},{"line_number":189,"context_line":"        # else they are defined via list of roles."},{"line_number":190,"context_line":"        if cred_type \u003d\u003d \u0027admin\u0027:"},{"line_number":191,"context_line":"            account[\u0027types\u0027] \u003d [cred_type]"},{"line_number":192,"context_line":"        elif cred_type not in [\u0027primary\u0027, \u0027alt\u0027]:"},{"line_number":193,"context_line":"            account[\u0027roles\u0027] \u003d cred_type"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_53cf0c56","line":190,"range":{"start_line":188,"start_character":0,"end_line":190,"end_character":32},"in_reply_to":"3f79a3b5_ad11635e","updated":"2018-10-03 05:51:26.000000000","message":"Done","commit_id":"c4e12ea95286ff9712e8c147e91c72a610c45545"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"ac369b5fc4bd1ee91d9fddf6fe256a4c22805f1b","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        # If the spec includes \u0027admin\u0027 credentials are defined via type,"},{"line_number":189,"context_line":"        # else they are defined via list of roles."},{"line_number":190,"context_line":"        if cred_type \u003d\u003d CONF.identity.admin_role:"},{"line_number":191,"context_line":"            account[\u0027types\u0027] \u003d [cred_type]"},{"line_number":192,"context_line":"        elif cred_type not in [\u0027primary\u0027, \u0027alt\u0027]:"},{"line_number":193,"context_line":"            account[\u0027roles\u0027] \u003d cred_type"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_45f8a348","line":190,"range":{"start_line":190,"start_character":24,"end_line":190,"end_character":49},"updated":"2018-10-03 07:21:35.000000000","message":"Should this actually be configuration driven? I thought this was just the alias of the credential type (e.g. \u0027primary\u0027, \u0027alt\u0027, \u0027admin\u0027) not the name of the role itself.","commit_id":"ceaccda95c52858c8de86c093bdb8dbd047a3b37"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"d083968e78ea4e796f41eff4467aa9a94bb32f38","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        # If the spec includes \u0027admin\u0027 credentials are defined via type,"},{"line_number":189,"context_line":"        # else they are defined via list of roles."},{"line_number":190,"context_line":"        if cred_type \u003d\u003d CONF.identity.admin_role:"},{"line_number":191,"context_line":"            account[\u0027types\u0027] \u003d [cred_type]"},{"line_number":192,"context_line":"        elif cred_type not in [\u0027primary\u0027, \u0027alt\u0027]:"},{"line_number":193,"context_line":"            account[\u0027roles\u0027] \u003d cred_type"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_fb5e2ee7","line":190,"range":{"start_line":190,"start_character":24,"end_line":190,"end_character":49},"in_reply_to":"3f79a3b5_45f8a348","updated":"2018-10-03 08:44:35.000000000","message":"Yes, I think you are right. Seems no need.\nI think let\u0027s wait for gmann\u0027s opinion here!","commit_id":"ceaccda95c52858c8de86c093bdb8dbd047a3b37"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"f69513184736d4c213f91b7485b28ec0107eae60","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        # If the spec includes \u0027admin\u0027 credentials are defined via type,"},{"line_number":189,"context_line":"        # else they are defined via list of roles."},{"line_number":190,"context_line":"        if cred_type \u003d\u003d CONF.identity.admin_role:"},{"line_number":191,"context_line":"            account[\u0027types\u0027] \u003d [cred_type]"},{"line_number":192,"context_line":"        elif cred_type not in [\u0027primary\u0027, \u0027alt\u0027]:"},{"line_number":193,"context_line":"            account[\u0027roles\u0027] \u003d cred_type"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_bafe4904","line":190,"range":{"start_line":190,"start_character":24,"end_line":190,"end_character":49},"in_reply_to":"3f79a3b5_49f0a0fc","updated":"2018-10-04 16:49:11.000000000","message":"Ok then I will -1 because we should revert back to patch set 1, because I think we are in agreement? Besides that unit tests are  broken so that will require a respin.","commit_id":"ceaccda95c52858c8de86c093bdb8dbd047a3b37"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1d1f404261f4af3f370c5d68b06477dbdf942914","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        # If the spec includes \u0027admin\u0027 credentials are defined via type,"},{"line_number":189,"context_line":"        # else they are defined via list of roles."},{"line_number":190,"context_line":"        if cred_type \u003d\u003d CONF.identity.admin_role:"},{"line_number":191,"context_line":"            account[\u0027types\u0027] \u003d [cred_type]"},{"line_number":192,"context_line":"        elif cred_type not in [\u0027primary\u0027, \u0027alt\u0027]:"},{"line_number":193,"context_line":"            account[\u0027roles\u0027] \u003d cred_type"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_49f0a0fc","line":190,"range":{"start_line":190,"start_character":24,"end_line":190,"end_character":49},"in_reply_to":"3f79a3b5_fb5e2ee7","updated":"2018-10-04 10:17:50.000000000","message":"yeah this is just cred type name - https://github.com/openstack/tempest/blob/dfe511eef288dc36d8de18f0ccd081dfc6c534f6/tempest/lib/common/dynamic_creds.py#L334","commit_id":"ceaccda95c52858c8de86c093bdb8dbd047a3b37"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2741dd1370a9229c594c07b37e1731e9f2a90dcb","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        spec.append([CONF.object_storage.operator_role])"},{"line_number":164,"context_line":"        spec.append([CONF.object_storage.reseller_admin_role])"},{"line_number":165,"context_line":"    if admin:"},{"line_number":166,"context_line":"        spec.append(CONF.identity.admin_role)"},{"line_number":167,"context_line":"    resources \u003d []"},{"line_number":168,"context_line":"    for cred_type in spec:"},{"line_number":169,"context_line":"        resources.append((cred_type, cred_provider.get_credentials("}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_46f074db","line":166,"range":{"start_line":166,"start_character":8,"end_line":166,"end_character":45},"updated":"2018-10-05 07:32:15.000000000","message":"this is not needed, name in spec list is what checked in dump_accounts() function\n\nand in cred_provider.get_credentials() at L169.\n\n - https://github.com/openstack/tempest/blob/dfe511eef288dc36d8de18f0ccd081dfc6c534f6/tempest/lib/common/dynamic_creds.py#L334","commit_id":"c2caef0cf0d7956c8dadd43cb558ad5ec22a5f3a"}]}