)]}'
{"playbooks/devstack-tempest.yaml":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"78a04df8c20c9f94921082593a053af8f13d4325","unresolved":false,"context_lines":[{"line_number":8,"context_line":"# We run tests only on one node, regardless how many nodes are in the system"},{"line_number":9,"context_line":"- hosts: tempest"},{"line_number":10,"context_line":"  environment:"},{"line_number":11,"context_line":"    GABBI_TEMPEST_PATH: \"{{ gabbi_tempest_path }}\""},{"line_number":12,"context_line":"  roles:"},{"line_number":13,"context_line":"    - setup-tempest-run-dir"},{"line_number":14,"context_line":"    - setup-tempest-data-dir"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_80510934","line":11,"range":{"start_line":11,"start_character":47,"end_line":11,"end_character":50},"updated":"2018-10-24 14:16:55.000000000","message":"i think i have same question as tosky. cannot we move this on  gabbi-tempest repo? maintaining it on Tempest side will raise question about its usage in tempest jobs using this playbook.","commit_id":"c1b5a89996e3ca6bc39d02b925e679bf07eacd9b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"40b8bfe19a21c421f071ad239373f9d0575bf936","unresolved":false,"context_lines":[{"line_number":8,"context_line":"# We run tests only on one node, regardless how many nodes are in the system"},{"line_number":9,"context_line":"- hosts: tempest"},{"line_number":10,"context_line":"  environment:"},{"line_number":11,"context_line":"    GABBI_TEMPEST_PATH: \"{{ gabbi_tempest_path }}\""},{"line_number":12,"context_line":"  roles:"},{"line_number":13,"context_line":"    - setup-tempest-run-dir"},{"line_number":14,"context_line":"    - setup-tempest-data-dir"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_16d99153","line":11,"range":{"start_line":11,"start_character":47,"end_line":11,"end_character":50},"in_reply_to":"3f79a3b5_133763ff","updated":"2018-10-26 09:01:27.000000000","message":"+1.","commit_id":"c1b5a89996e3ca6bc39d02b925e679bf07eacd9b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8f6e2b212b64bbf6dfc30eed40de3b3411a5a17f","unresolved":false,"context_lines":[{"line_number":8,"context_line":"# We run tests only on one node, regardless how many nodes are in the system"},{"line_number":9,"context_line":"- hosts: tempest"},{"line_number":10,"context_line":"  environment:"},{"line_number":11,"context_line":"    GABBI_TEMPEST_PATH: \"{{ gabbi_tempest_path }}\""},{"line_number":12,"context_line":"  roles:"},{"line_number":13,"context_line":"    - setup-tempest-run-dir"},{"line_number":14,"context_line":"    - setup-tempest-data-dir"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_c0a6f60d","line":11,"range":{"start_line":11,"start_character":47,"end_line":11,"end_character":50},"in_reply_to":"3f79a3b5_136d51ca","updated":"2018-10-26 02:29:17.000000000","message":"i got it now. I am ok with having it in tox env and here too in tempest playbooks. But other idea is to add this env variable to tempest-gabbi job playbooks.\n\nreason is i am seeing tempest-gasbbi[1] as base job for any other gabbi jobs and that tempest-gabbi job own all the basic setup of gabbi testing/plugin. \n\nIt is not strong opinion not to have here. just want to know your thought before i can +2. \n\nand Note here about this env var usage is good idea for future ref. \n\n[1] https://review.openstack.org/#/c/611678/4/.zuul.yaml","commit_id":"c1b5a89996e3ca6bc39d02b925e679bf07eacd9b"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d79517d84372729008385dd3d85be96fd478e9bd","unresolved":false,"context_lines":[{"line_number":8,"context_line":"# We run tests only on one node, regardless how many nodes are in the system"},{"line_number":9,"context_line":"- hosts: tempest"},{"line_number":10,"context_line":"  environment:"},{"line_number":11,"context_line":"    GABBI_TEMPEST_PATH: \"{{ gabbi_tempest_path }}\""},{"line_number":12,"context_line":"  roles:"},{"line_number":13,"context_line":"    - setup-tempest-run-dir"},{"line_number":14,"context_line":"    - setup-tempest-data-dir"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_136d51ca","line":11,"range":{"start_line":11,"start_character":47,"end_line":11,"end_character":50},"in_reply_to":"3f79a3b5_80510934","updated":"2018-10-24 14:24:33.000000000","message":"Tosky\u0027s comments were about the additional job. I moved the job to gabbi-tempest in https://review.openstack.org/#/c/611678/ See that for a bit more on how this works.\n\nThe reason this change is here (as well as the change in tox.ini) is that we don\u0027t want to require any one who is going to be using this functionality to need to write their own playbook, which is where the \u0027environment\u0027 attribute needs to be.\n\nFor the tox change, we want to use an existing tox test environment for running tempest, but need that variable, so it has to be in tempest\u0027s setup.\n\nHere, in this file, to avoid confusion I could add a comment that explains that this value is only used if the gabbi-tempest plugin is being used.","commit_id":"c1b5a89996e3ca6bc39d02b925e679bf07eacd9b"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"e5ce03f4e53a381981e801a82519ab061d80e56d","unresolved":false,"context_lines":[{"line_number":8,"context_line":"# We run tests only on one node, regardless how many nodes are in the system"},{"line_number":9,"context_line":"- hosts: tempest"},{"line_number":10,"context_line":"  environment:"},{"line_number":11,"context_line":"    GABBI_TEMPEST_PATH: \"{{ gabbi_tempest_path }}\""},{"line_number":12,"context_line":"  roles:"},{"line_number":13,"context_line":"    - setup-tempest-run-dir"},{"line_number":14,"context_line":"    - setup-tempest-data-dir"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_133763ff","line":11,"range":{"start_line":11,"start_character":47,"end_line":11,"end_character":50},"in_reply_to":"3f79a3b5_c0a6f60d","updated":"2018-10-26 08:42:36.000000000","message":"The goal here is to not have to have a custom playbook for the tempest-gabbi job at all, and just use this one, so as to keep things as DRY as possible. Duplicating playbooks with only slight differences will lead to split brains and brokenness.\n\nI\u0027ll update this to add a comment about what the env var means.","commit_id":"c1b5a89996e3ca6bc39d02b925e679bf07eacd9b"}]}