)]}'
{"tempest/scenario/test_network_v6.py":[{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"2c3037a1a14f1f4da72372453ac4d4b4d8cc6d9a","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                    \u0027echo -e \"DEVICE\u003d%(nic)s\\\\nIPV6INIT\u003dyes\" | \u0027"},{"line_number":164,"context_line":"                    \u0027sudo tee /etc/sysconfig/network-scripts/ifcfg-%(nic)s; \u0027"},{"line_number":165,"context_line":"                    \u0027sudo /sbin/service network restart\u0027 % {\u0027nic\u0027: nic})"},{"line_number":166,"context_line":"            except exceptions.SSHExecCommandFailed:"},{"line_number":167,"context_line":"                pass"},{"line_number":168,"context_line":"        ssh.exec_command(\"sudo ip link set %s up\" % nic)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def _guest_os_is_rhel(self, ssh):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_20a67f0f","line":167,"range":{"start_line":166,"start_character":12,"end_line":167,"end_character":20},"updated":"2018-10-05 05:25:16.000000000","message":"Agreeing witk Kenichi, I too have doubt:\nFirstly, there seems no benefit of using exception here.\nSecond: If using exception then, some Log info/data should be there for debugging and to know the failure","commit_id":"7351ef221afda6927db480729d92343a94aee997"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"04b7ce29a5e22c2875c23e11eca3077ee1de94d4","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                    \u0027echo -e \"DEVICE\u003d%(nic)s\\\\nIPV6INIT\u003dyes\" | \u0027"},{"line_number":164,"context_line":"                    \u0027sudo tee /etc/sysconfig/network-scripts/ifcfg-%(nic)s; \u0027"},{"line_number":165,"context_line":"                    \u0027sudo /sbin/service network restart\u0027 % {\u0027nic\u0027: nic})"},{"line_number":166,"context_line":"            except exceptions.SSHExecCommandFailed:"},{"line_number":167,"context_line":"                pass"},{"line_number":168,"context_line":"        ssh.exec_command(\"sudo ip link set %s up\" % nic)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def _guest_os_is_rhel(self, ssh):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_9b4cac76","line":167,"range":{"start_line":166,"start_character":0,"end_line":167,"end_character":20},"updated":"2018-10-04 20:43:52.000000000","message":"Why this try-except is necessary?\nI am not sure this can make debugging difficult if the above configuration is failed.","commit_id":"7351ef221afda6927db480729d92343a94aee997"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"dc827918fff6b754b911077ea34d96333f07bfb8","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                    \u0027echo -e \"DEVICE\u003d%(nic)s\\\\nIPV6INIT\u003dyes\" | \u0027"},{"line_number":164,"context_line":"                    \u0027sudo tee /etc/sysconfig/network-scripts/ifcfg-%(nic)s; \u0027"},{"line_number":165,"context_line":"                    \u0027sudo /sbin/service network restart\u0027 % {\u0027nic\u0027: nic})"},{"line_number":166,"context_line":"            except exceptions.SSHExecCommandFailed:"},{"line_number":167,"context_line":"                pass"},{"line_number":168,"context_line":"        ssh.exec_command(\"sudo ip link set %s up\" % nic)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def _guest_os_is_rhel(self, ssh):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_6045576f","line":167,"range":{"start_line":166,"start_character":12,"end_line":167,"end_character":20},"in_reply_to":"3f79a3b5_20a67f0f","updated":"2018-10-05 06:54:08.000000000","message":"In fact I had few times during the test error here because of some error from network manager in guest os. But even then doing ip link set up below was fine and IP address was configured properly every time. So because of that I added this try except to not fail if that is not necessary.\nIn fact even if there will be some other error here and IP address will not be later configured, test will fail below.\n\nI will add logging of error message spotted here as DEBUG message.","commit_id":"7351ef221afda6927db480729d92343a94aee997"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"04b7ce29a5e22c2875c23e11eca3077ee1de94d4","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    def _guest_os_is_rhel(self, ssh):"},{"line_number":171,"context_line":"        release \u003d ssh.exec_command("},{"line_number":172,"context_line":"            \u0027if [ -e /etc/redhat-release ]; then cat /etc/redhat-release; fi\u0027)"},{"line_number":173,"context_line":"        return \"Red Hat\" in release"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def _prepare_and_test(self, address6_mode, n_subnets6\u003d1, dualnet\u003dFalse):"},{"line_number":176,"context_line":"        net_list \u003d self.prepare_network(address6_mode\u003daddress6_mode,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_9b9a6cc2","line":173,"range":{"start_line":173,"start_character":8,"end_line":173,"end_character":35},"updated":"2018-10-04 20:43:52.000000000","message":"When existing a /etc/redhat-release, could that be RHEL distribution without checking the content?\n\nBTW this issue(?) will be fixed on a new RHEL in the future?\nI guess we need to check the version of RHEL here.","commit_id":"7351ef221afda6927db480729d92343a94aee997"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"be92be8062d9896f03f0db4163b4e60a275a6fd6","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    def _guest_os_is_rhel(self, ssh):"},{"line_number":171,"context_line":"        release \u003d ssh.exec_command("},{"line_number":172,"context_line":"            \u0027if [ -e /etc/redhat-release ]; then cat /etc/redhat-release; fi\u0027)"},{"line_number":173,"context_line":"        return \"Red Hat\" in release"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def _prepare_and_test(self, address6_mode, n_subnets6\u003d1, dualnet\u003dFalse):"},{"line_number":176,"context_line":"        net_list \u003d self.prepare_network(address6_mode\u003daddress6_mode,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_09892f6e","line":173,"range":{"start_line":173,"start_character":8,"end_line":173,"end_character":35},"in_reply_to":"3f79a3b5_06f59c51","updated":"2018-10-05 08:28:50.000000000","message":"As I was checking at least on Centos it works fine. I don\u0027t want to do too much to not e.g. override this config file for eth1 if it would already be in Fedora for example).\n\nAlso I just checked that this problem not exists in RHEL 6.10 also, so I reported it as a bug: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1636350","commit_id":"7351ef221afda6927db480729d92343a94aee997"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"dc827918fff6b754b911077ea34d96333f07bfb8","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    def _guest_os_is_rhel(self, ssh):"},{"line_number":171,"context_line":"        release \u003d ssh.exec_command("},{"line_number":172,"context_line":"            \u0027if [ -e /etc/redhat-release ]; then cat /etc/redhat-release; fi\u0027)"},{"line_number":173,"context_line":"        return \"Red Hat\" in release"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def _prepare_and_test(self, address6_mode, n_subnets6\u003d1, dualnet\u003dFalse):"},{"line_number":176,"context_line":"        net_list \u003d self.prepare_network(address6_mode\u003daddress6_mode,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_e050872f","line":173,"range":{"start_line":173,"start_character":8,"end_line":173,"end_character":35},"in_reply_to":"3f79a3b5_9b9a6cc2","updated":"2018-10-05 06:54:08.000000000","message":"When /etc/redhat-release exists, it can be also Centos or Fedora or something else, so we need to check content of this file.\n\nI don\u0027t know if this issue will be fixed or not and when it may be fixed.","commit_id":"7351ef221afda6927db480729d92343a94aee997"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"fb34cb8c57518f5e6796b940e2d9f5817da7800d","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    def _guest_os_is_rhel(self, ssh):"},{"line_number":171,"context_line":"        release \u003d ssh.exec_command("},{"line_number":172,"context_line":"            \u0027if [ -e /etc/redhat-release ]; then cat /etc/redhat-release; fi\u0027)"},{"line_number":173,"context_line":"        return \"Red Hat\" in release"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def _prepare_and_test(self, address6_mode, n_subnets6\u003d1, dualnet\u003dFalse):"},{"line_number":176,"context_line":"        net_list \u003d self.prepare_network(address6_mode\u003daddress6_mode,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_06f59c51","line":173,"range":{"start_line":173,"start_character":8,"end_line":173,"end_character":35},"in_reply_to":"3f79a3b5_e050872f","updated":"2018-10-05 08:05:59.000000000","message":"We could also do it for Centos/Fedora (so more generic), as it should not hurt to have this net configuration specified? (better ask for ipv6 support twice than none)","commit_id":"7351ef221afda6927db480729d92343a94aee997"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"6c4fede7c78d4819d5e17daf32f22b0ab19a1374","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        nic \u003d ssh.get_nic_name_by_mac(mac6)"},{"line_number":162,"context_line":"        # NOTE(slaweq): on RHEL 7 based OS ifcfg file for new interface is"},{"line_number":163,"context_line":"        # needed to make IPv6 working on it"},{"line_number":164,"context_line":"        if self._guest_os_is_rhel(ssh):"},{"line_number":165,"context_line":"            try:"},{"line_number":166,"context_line":"                ssh.exec_command("},{"line_number":167,"context_line":"                    \u0027echo -e \"DEVICE\u003d%(nic)s\\\\nIPV6INIT\u003dyes\" | \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_05b6c026","line":164,"range":{"start_line":164,"start_character":29,"end_line":164,"end_character":33},"updated":"2018-10-08 19:02:18.000000000","message":"s/rhel/rhel7/","commit_id":"c3489ac853c70f9564d564d118cb053a8663307e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"2d300162fbc732b494d37f6a44668ddfc686abe8","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        nic \u003d ssh.get_nic_name_by_mac(mac6)"},{"line_number":162,"context_line":"        # NOTE(slaweq): on RHEL 7 based OS ifcfg file for new interface is"},{"line_number":163,"context_line":"        # needed to make IPv6 working on it"},{"line_number":164,"context_line":"        if self._guest_os_is_rhel(ssh):"},{"line_number":165,"context_line":"            try:"},{"line_number":166,"context_line":"                ssh.exec_command("},{"line_number":167,"context_line":"                    \u0027echo -e \"DEVICE\u003d%(nic)s\\\\nIPV6INIT\u003dyes\" | \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_50ef94f9","line":164,"range":{"start_line":164,"start_character":29,"end_line":164,"end_character":33},"in_reply_to":"3f79a3b5_05b6c026","updated":"2018-10-08 19:58:17.000000000","message":"Done","commit_id":"c3489ac853c70f9564d564d118cb053a8663307e"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"6c4fede7c78d4819d5e17daf32f22b0ab19a1374","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                          {\u0027nic\u0027: nic, \u0027error\u0027: e})"},{"line_number":174,"context_line":"        ssh.exec_command(\"sudo ip link set %s up\" % nic)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def _guest_os_is_rhel(self, ssh):"},{"line_number":177,"context_line":"        release \u003d ssh.exec_command("},{"line_number":178,"context_line":"            \u0027if [ -e /etc/redhat-release ]; then cat /etc/redhat-release; fi\u0027)"},{"line_number":179,"context_line":"        return (\"Red Hat\" in release and \"release 7\" in release)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_45bcb806","line":176,"range":{"start_line":176,"start_character":21,"end_line":176,"end_character":25},"updated":"2018-10-08 19:02:18.000000000","message":"s/rhel/rhel7/","commit_id":"c3489ac853c70f9564d564d118cb053a8663307e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"2d300162fbc732b494d37f6a44668ddfc686abe8","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                          {\u0027nic\u0027: nic, \u0027error\u0027: e})"},{"line_number":174,"context_line":"        ssh.exec_command(\"sudo ip link set %s up\" % nic)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def _guest_os_is_rhel(self, ssh):"},{"line_number":177,"context_line":"        release \u003d ssh.exec_command("},{"line_number":178,"context_line":"            \u0027if [ -e /etc/redhat-release ]; then cat /etc/redhat-release; fi\u0027)"},{"line_number":179,"context_line":"        return (\"Red Hat\" in release and \"release 7\" in release)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_f0fd80b2","line":176,"range":{"start_line":176,"start_character":21,"end_line":176,"end_character":25},"in_reply_to":"3f79a3b5_45bcb806","updated":"2018-10-08 19:58:17.000000000","message":"Done","commit_id":"c3489ac853c70f9564d564d118cb053a8663307e"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"7728370f047d7d39d2ccc62bc0bf955d2d05c4df","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def _guest_os_is_rhel7(self, ssh):"},{"line_number":177,"context_line":"        release \u003d ssh.exec_command("},{"line_number":178,"context_line":"            \u0027if [ -e /etc/redhat-release ]; then cat /etc/redhat-release; fi\u0027)"},{"line_number":179,"context_line":"        return (\"Red Hat\" in release and \"release 7\" in release)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def _prepare_and_test(self, address6_mode, n_subnets6\u003d1, dualnet\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_ea36cc02","line":178,"updated":"2018-10-10 06:28:01.000000000","message":"if you would test the existence of \u0027/etc/sysconfig/network-scripts/\u0027 presence probably the same way could work also with fedora and and earlier/newer rhel as well.","commit_id":"acf05f364b5ca8e54a318b12eac5d18683483c01"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"117e74962e6f70780ac87dc58f9575be1822c107","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def _guest_os_is_rhel7(self, ssh):"},{"line_number":177,"context_line":"        release \u003d ssh.exec_command("},{"line_number":178,"context_line":"            \u0027if [ -e /etc/redhat-release ]; then cat /etc/redhat-release; fi\u0027)"},{"line_number":179,"context_line":"        return (\"Red Hat\" in release and \"release 7\" in release)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def _prepare_and_test(self, address6_mode, n_subnets6\u003d1, dualnet\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_1a2a527d","line":178,"in_reply_to":"3f79a3b5_23fe1baf","updated":"2018-10-11 11:06:50.000000000","message":"Done","commit_id":"acf05f364b5ca8e54a318b12eac5d18683483c01"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"411f88027dcaedb91bcd906f2ac3083ff96813c5","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def _guest_os_is_rhel7(self, ssh):"},{"line_number":177,"context_line":"        release \u003d ssh.exec_command("},{"line_number":178,"context_line":"            \u0027if [ -e /etc/redhat-release ]; then cat /etc/redhat-release; fi\u0027)"},{"line_number":179,"context_line":"        return (\"Red Hat\" in release and \"release 7\" in release)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def _prepare_and_test(self, address6_mode, n_subnets6\u003d1, dualnet\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_23fe1baf","line":178,"in_reply_to":"3f79a3b5_ea36cc02","updated":"2018-10-10 19:52:59.000000000","message":"From what I tested locally it works fine with at least Centos 7 and RHEL 6.10. But maybe checking only if this directory and file exists or not can work for all such systems.\nI will check that and update patch if necessary","commit_id":"acf05f364b5ca8e54a318b12eac5d18683483c01"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"7a20458b7cb57bd8dcfe3b9ac08bcc1451ff964f","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                    \u0027sudo tee /etc/sysconfig/network-scripts/ifcfg-%(nic)s; \u0027"},{"line_number":171,"context_line":"                    \u0027sudo /sbin/service network restart\u0027 % {\u0027nic\u0027: nic})"},{"line_number":172,"context_line":"            except exceptions.SSHExecCommandFailed as e:"},{"line_number":173,"context_line":"                LOG.debug(\"Error during restarting %(nic)s interface on \""},{"line_number":174,"context_line":"                          \"instance. Error message: %(error)s\","},{"line_number":175,"context_line":"                          {\u0027nic\u0027: nic, \u0027error\u0027: e})"},{"line_number":176,"context_line":"        ssh.exec_command(\"sudo ip link set %s up\" % nic)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_5c6af1eb","line":173,"updated":"2018-10-12 07:58:21.000000000","message":"I feel this should be the warning level not debug? Is there any particular reason? And can we ignore this exception(SSHExecCommandFailed)?\n\nAh, after I read the PS1\u0027s your comment, I got it, partially. But it\u0027s good to add a comment/note for this. This code looks weird for me at least.","commit_id":"674cafb98f3ac6329d6df1fd2c55b2ed4f22aefd"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f72b9288d3249ad2295df1734cb7dfc74f602fa9","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                    \u0027sudo tee /etc/sysconfig/network-scripts/ifcfg-%(nic)s; \u0027"},{"line_number":171,"context_line":"                    \u0027sudo /sbin/service network restart\u0027 % {\u0027nic\u0027: nic})"},{"line_number":172,"context_line":"            except exceptions.SSHExecCommandFailed as e:"},{"line_number":173,"context_line":"                LOG.debug(\"Error during restarting %(nic)s interface on \""},{"line_number":174,"context_line":"                          \"instance. Error message: %(error)s\","},{"line_number":175,"context_line":"                          {\u0027nic\u0027: nic, \u0027error\u0027: e})"},{"line_number":176,"context_line":"        ssh.exec_command(\"sudo ip link set %s up\" % nic)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_554946b5","line":173,"in_reply_to":"3f79a3b5_5c6af1eb","updated":"2018-10-14 13:04:45.000000000","message":"I added comment here","commit_id":"674cafb98f3ac6329d6df1fd2c55b2ed4f22aefd"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"f815eddf33b8562d3eb7a917dc02a90a32565f3c","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                # guest os."},{"line_number":176,"context_line":"                # But even then doing ip link set up below is fine and"},{"line_number":177,"context_line":"                # IP address should be configured properly."},{"line_number":178,"context_line":"                LOG.debug(\"Error during restarting %(nic)s interface on \""},{"line_number":179,"context_line":"                          \"instance. Error message: %(error)s\","},{"line_number":180,"context_line":"                          {\u0027nic\u0027: nic, \u0027error\u0027: e})"},{"line_number":181,"context_line":"        ssh.exec_command(\"sudo ip link set %s up\" % nic)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_beae6f7d","line":178,"updated":"2018-10-15 13:11:16.000000000","message":"Does not sounds good, I hope it can be improved later on..","commit_id":"c5c7ba997eb194e8428bfcb802bfabfdfb5ef5fe"}]}