)]}'
{"tempest/lib/api_schema/response/volume/manage_volume.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a703f2c5849073fe626756c689b3d6979b1371ab","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from tempest.lib.api_schema.response.compute.v2_1 import parameter_types"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"manage_volume \u003d {"},{"line_number":18,"context_line":"    \u0027status_code\u0027: [202],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_2215954c","line":15,"range":{"start_line":15,"start_character":37,"end_line":15,"end_character":44},"updated":"2018-11-07 03:16:38.000000000","message":"As an aside, I noticed this should now go into common (I mean for parameter_types). This is not just for compute anymore.","commit_id":"3a1aab3ea85820452f76181dcb00d2644d4386f7"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"13ad18c2b8efba118fdba5f5bd02257dd1cfa2ba","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from tempest.lib.api_schema.response.compute.v2_1 import parameter_types"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"manage_volume \u003d {"},{"line_number":18,"context_line":"    \u0027status_code\u0027: [202],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_8bd28532","line":15,"range":{"start_line":15,"start_character":37,"end_line":15,"end_character":44},"in_reply_to":"3f79a3b5_2215954c","updated":"2018-11-07 05:38:05.000000000","message":"Yes, and I plan to move it after the bundle of volume schema check patches are commited, otherwise I\u0027ll have to trigger ci job  for many patches again:)","commit_id":"3a1aab3ea85820452f76181dcb00d2644d4386f7"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"762ef2716951cebed7deff8bfcb64f11218ece01","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from tempest.lib.api_schema.response.compute.v2_1 import parameter_types"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"manage_volume \u003d {"},{"line_number":18,"context_line":"    \u0027status_code\u0027: [202],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_69527f6c","line":15,"range":{"start_line":15,"start_character":37,"end_line":15,"end_character":44},"in_reply_to":"3f79a3b5_8bd28532","updated":"2018-11-07 22:44:33.000000000","message":"Makes sense, agree.","commit_id":"3a1aab3ea85820452f76181dcb00d2644d4386f7"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a703f2c5849073fe626756c689b3d6979b1371ab","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                \u0027type\u0027: \u0027object\u0027,"},{"line_number":24,"context_line":"                \u0027properties\u0027: {"},{"line_number":25,"context_line":"                    \u0027status\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":26,"context_line":"                    \u0027migration_status\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":27,"context_line":"                    \u0027user_id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":28,"context_line":"                    \u0027attachments\u0027: {"},{"line_number":29,"context_line":"                        \u0027type\u0027: \u0027array\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_c2a94125","line":26,"range":{"start_line":26,"start_character":60,"end_line":26,"end_character":66},"updated":"2018-11-07 03:16:38.000000000","message":"Is this possible? status is usually an enum of values; null shouldn\u0027t be possible?\n\nhttps://github.com/openstack/cinder/blob/cf5b3b56a3e7530c14d425e77517f7b9e4e5af13/cinder/api/v2/views/volumes.py#L56","commit_id":"3a1aab3ea85820452f76181dcb00d2644d4386f7"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"13ad18c2b8efba118fdba5f5bd02257dd1cfa2ba","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                \u0027type\u0027: \u0027object\u0027,"},{"line_number":24,"context_line":"                \u0027properties\u0027: {"},{"line_number":25,"context_line":"                    \u0027status\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":26,"context_line":"                    \u0027migration_status\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":27,"context_line":"                    \u0027user_id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":28,"context_line":"                    \u0027attachments\u0027: {"},{"line_number":29,"context_line":"                        \u0027type\u0027: \u0027array\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_abe66113","line":26,"range":{"start_line":26,"start_character":60,"end_line":26,"end_character":66},"in_reply_to":"3f79a3b5_c2a94125","updated":"2018-11-07 05:38:05.000000000","message":"From ci log, I search for \"migration_status\", and I see most \nmigration_status is null, \u003c\"migration_status\": null, \u003e","commit_id":"3a1aab3ea85820452f76181dcb00d2644d4386f7"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a703f2c5849073fe626756c689b3d6979b1371ab","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                        \u0027type\u0027: \u0027array\u0027,"},{"line_number":30,"context_line":"                        \u0027items\u0027: {"},{"line_number":31,"context_line":"                            \u0027type\u0027: \u0027object\u0027,"},{"line_number":32,"context_line":"                            \u0027properties\u0027: {"},{"line_number":33,"context_line":"                                \u0027status\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":34,"context_line":"                                \u0027instance\u0027: {\u0027type\u0027: \u0027string\u0027,"},{"line_number":35,"context_line":"                                             \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":36,"context_line":"                                \u0027id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":37,"context_line":"                                \u0027volume_id\u0027: {\u0027type\u0027: \u0027string\u0027,"},{"line_number":38,"context_line":"                                              \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":39,"context_line":"                            },"},{"line_number":40,"context_line":"                            \u0027additionalProperties\u0027: False,"},{"line_number":41,"context_line":"                            \u0027required\u0027: [\u0027status\u0027, \u0027instance\u0027,"},{"line_number":42,"context_line":"                                         \u0027id\u0027, \u0027volume_id\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_2866d7f1","line":39,"range":{"start_line":32,"start_character":0,"end_line":39,"end_character":30},"updated":"2018-11-07 03:16:38.000000000","message":"This takes some additional parameters, see: https://github.com/openstack/cinder/blob/cf5b3b56a3e7530c14d425e77517f7b9e4e5af13/cinder/api/v2/views/volumes.py#L115\n\nCalled here: https://github.com/openstack/cinder/blob/cf5b3b56a3e7530c14d425e77517f7b9e4e5af13/cinder/api/v2/views/volumes.py#L78\n\nCalled here: https://github.com/openstack/cinder/blob/cf5b3b56a3e7530c14d425e77517f7b9e4e5af13/cinder/api/contrib/volume_manage.py#L152","commit_id":"3a1aab3ea85820452f76181dcb00d2644d4386f7"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"640dd82d296240e8e1d715509901489b29a53699","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                        \u0027type\u0027: \u0027array\u0027,"},{"line_number":30,"context_line":"                        \u0027items\u0027: {"},{"line_number":31,"context_line":"                            \u0027type\u0027: \u0027object\u0027,"},{"line_number":32,"context_line":"                            \u0027properties\u0027: {"},{"line_number":33,"context_line":"                                \u0027status\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":34,"context_line":"                                \u0027instance\u0027: {\u0027type\u0027: \u0027string\u0027,"},{"line_number":35,"context_line":"                                             \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":36,"context_line":"                                \u0027id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":37,"context_line":"                                \u0027volume_id\u0027: {\u0027type\u0027: \u0027string\u0027,"},{"line_number":38,"context_line":"                                              \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":39,"context_line":"                            },"},{"line_number":40,"context_line":"                            \u0027additionalProperties\u0027: False,"},{"line_number":41,"context_line":"                            \u0027required\u0027: [\u0027status\u0027, \u0027instance\u0027,"},{"line_number":42,"context_line":"                                         \u0027id\u0027, \u0027volume_id\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_9a5dd455","line":39,"range":{"start_line":32,"start_character":0,"end_line":39,"end_character":30},"in_reply_to":"3f79a3b5_096aeb16","updated":"2018-11-08 07:03:27.000000000","message":"Yes I think you are right. And the API docs is generally right.","commit_id":"3a1aab3ea85820452f76181dcb00d2644d4386f7"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"13ad18c2b8efba118fdba5f5bd02257dd1cfa2ba","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                        \u0027type\u0027: \u0027array\u0027,"},{"line_number":30,"context_line":"                        \u0027items\u0027: {"},{"line_number":31,"context_line":"                            \u0027type\u0027: \u0027object\u0027,"},{"line_number":32,"context_line":"                            \u0027properties\u0027: {"},{"line_number":33,"context_line":"                                \u0027status\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":34,"context_line":"                                \u0027instance\u0027: {\u0027type\u0027: \u0027string\u0027,"},{"line_number":35,"context_line":"                                             \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":36,"context_line":"                                \u0027id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":37,"context_line":"                                \u0027volume_id\u0027: {\u0027type\u0027: \u0027string\u0027,"},{"line_number":38,"context_line":"                                              \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":39,"context_line":"                            },"},{"line_number":40,"context_line":"                            \u0027additionalProperties\u0027: False,"},{"line_number":41,"context_line":"                            \u0027required\u0027: [\u0027status\u0027, \u0027instance\u0027,"},{"line_number":42,"context_line":"                                         \u0027id\u0027, \u0027volume_id\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_eb1bf919","line":39,"range":{"start_line":32,"start_character":0,"end_line":39,"end_character":30},"in_reply_to":"3f79a3b5_2866d7f1","updated":"2018-11-07 05:38:05.000000000","message":"a \u003d {\u0027id\u0027: attachment.get(\u0027volume_id\u0027),\n                     \u0027attachment_id\u0027: attachment.get(\u0027id\u0027),\n                     \u0027volume_id\u0027: attachment.get(\u0027volume_id\u0027),\n                     \u0027server_id\u0027: attachment.get(\u0027instance_uuid\u0027),\n                     \u0027host_name\u0027: attachment.get(\u0027attached_host\u0027),\n                     \u0027device\u0027: attachment.get(\u0027mountpoint\u0027),\n                     \u0027attached_at\u0027: attachment.get(\u0027attach_time\u0027),\n                     }\nThis seems to be the parameters for attachement in show_volume?","commit_id":"3a1aab3ea85820452f76181dcb00d2644d4386f7"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"762ef2716951cebed7deff8bfcb64f11218ece01","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                        \u0027type\u0027: \u0027array\u0027,"},{"line_number":30,"context_line":"                        \u0027items\u0027: {"},{"line_number":31,"context_line":"                            \u0027type\u0027: \u0027object\u0027,"},{"line_number":32,"context_line":"                            \u0027properties\u0027: {"},{"line_number":33,"context_line":"                                \u0027status\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":34,"context_line":"                                \u0027instance\u0027: {\u0027type\u0027: \u0027string\u0027,"},{"line_number":35,"context_line":"                                             \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":36,"context_line":"                                \u0027id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":37,"context_line":"                                \u0027volume_id\u0027: {\u0027type\u0027: \u0027string\u0027,"},{"line_number":38,"context_line":"                                              \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":39,"context_line":"                            },"},{"line_number":40,"context_line":"                            \u0027additionalProperties\u0027: False,"},{"line_number":41,"context_line":"                            \u0027required\u0027: [\u0027status\u0027, \u0027instance\u0027,"},{"line_number":42,"context_line":"                                         \u0027id\u0027, \u0027volume_id\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_096aeb16","line":39,"range":{"start_line":32,"start_character":0,"end_line":39,"end_character":30},"in_reply_to":"3f79a3b5_eb1bf919","updated":"2018-11-07 22:44:33.000000000","message":"The API code says this:\n\n       \"From an API perspective, this operation behaves very much like a\n        volume creation operation, except that properties such as image,\n        snapshot and volume references don\u0027t make sense, because we are taking\n        an existing storage object into Cinder management.\"\n\nThe API docs say this for attachments:\n\n\"Instance attachment information. If this volume is attached to a server instance, the attachments list includes the UUID of the attached server, an attachment UUID, the name of the attached host, if any, the volume UUID, the device, and the device UUID. Otherwise, this list is empty.\"\n\nSo that should be 6 params. The code above I included has 7 (the extra one being attached_at). Maybe the API docs are wrong, not sure.","commit_id":"3a1aab3ea85820452f76181dcb00d2644d4386f7"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a703f2c5849073fe626756c689b3d6979b1371ab","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                    \u0027volume_type\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":53,"context_line":"                    \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":54,"context_line":"                    \u0027replication_status\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":55,"context_line":"                    \u0027consistencygroup_id\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":56,"context_line":"                    \u0027source_volid\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":57,"context_line":"                    \u0027snapshot_id\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":58,"context_line":"                    \u0027multiattach\u0027: {\u0027type\u0027: \u0027boolean\u0027},"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_62506d2e","line":55,"range":{"start_line":55,"start_character":54,"end_line":55,"end_character":60},"updated":"2018-11-07 03:16:38.000000000","message":"This is a UUID as per API docs so should have format: \u0027uuid\u0027","commit_id":"3a1aab3ea85820452f76181dcb00d2644d4386f7"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"762ef2716951cebed7deff8bfcb64f11218ece01","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                    \u0027volume_type\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":53,"context_line":"                    \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":54,"context_line":"                    \u0027replication_status\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":55,"context_line":"                    \u0027consistencygroup_id\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":56,"context_line":"                    \u0027source_volid\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":57,"context_line":"                    \u0027snapshot_id\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":58,"context_line":"                    \u0027multiattach\u0027: {\u0027type\u0027: \u0027boolean\u0027},"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_89303b56","line":55,"range":{"start_line":55,"start_character":54,"end_line":55,"end_character":60},"in_reply_to":"3f79a3b5_2bac91a6","updated":"2018-11-07 22:44:33.000000000","message":"I would imagine this should work:\n\n    \u0027consistencygroup_id\u0027: {\n      \u0027anyOf\u0027: [\n        {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},\n        {\u0027type\u0027: \u0027null\u0027}\n      ]\n    }","commit_id":"3a1aab3ea85820452f76181dcb00d2644d4386f7"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"13ad18c2b8efba118fdba5f5bd02257dd1cfa2ba","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                    \u0027volume_type\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":53,"context_line":"                    \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":54,"context_line":"                    \u0027replication_status\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":55,"context_line":"                    \u0027consistencygroup_id\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":56,"context_line":"                    \u0027source_volid\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":57,"context_line":"                    \u0027snapshot_id\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":58,"context_line":"                    \u0027multiattach\u0027: {\u0027type\u0027: \u0027boolean\u0027},"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_2bac91a6","line":55,"range":{"start_line":55,"start_character":54,"end_line":55,"end_character":60},"in_reply_to":"3f79a3b5_62506d2e","updated":"2018-11-07 05:38:05.000000000","message":"Here because id can be null, so if I add {\u0027format\u0027: \u0027uuid\u0027}, then if id is null, the validation will fail.\nSo how to express \"type can be null or uuid string\"?","commit_id":"3a1aab3ea85820452f76181dcb00d2644d4386f7"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"640dd82d296240e8e1d715509901489b29a53699","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                    \u0027volume_type\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":53,"context_line":"                    \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":54,"context_line":"                    \u0027replication_status\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":55,"context_line":"                    \u0027consistencygroup_id\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":56,"context_line":"                    \u0027source_volid\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":57,"context_line":"                    \u0027snapshot_id\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":58,"context_line":"                    \u0027multiattach\u0027: {\u0027type\u0027: \u0027boolean\u0027},"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_5a63bc18","line":55,"range":{"start_line":55,"start_character":54,"end_line":55,"end_character":60},"in_reply_to":"3f79a3b5_89303b56","updated":"2018-11-08 07:03:27.000000000","message":"Thanks, I think it should work.","commit_id":"3a1aab3ea85820452f76181dcb00d2644d4386f7"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a703f2c5849073fe626756c689b3d6979b1371ab","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                    \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":54,"context_line":"                    \u0027replication_status\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":55,"context_line":"                    \u0027consistencygroup_id\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":56,"context_line":"                    \u0027source_volid\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":57,"context_line":"                    \u0027snapshot_id\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":58,"context_line":"                    \u0027multiattach\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":59,"context_line":"                    \u0027metadata\u0027: {"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_824d8994","line":56,"range":{"start_line":56,"start_character":47,"end_line":56,"end_character":53},"updated":"2018-11-07 03:16:38.000000000","message":"Ditto.","commit_id":"3a1aab3ea85820452f76181dcb00d2644d4386f7"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a703f2c5849073fe626756c689b3d6979b1371ab","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                    \u0027replication_status\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":55,"context_line":"                    \u0027consistencygroup_id\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":56,"context_line":"                    \u0027source_volid\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":57,"context_line":"                    \u0027snapshot_id\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":58,"context_line":"                    \u0027multiattach\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":59,"context_line":"                    \u0027metadata\u0027: {"},{"line_number":60,"context_line":"                        \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_4231b109","line":57,"range":{"start_line":57,"start_character":46,"end_line":57,"end_character":52},"updated":"2018-11-07 03:16:38.000000000","message":"Ditto.","commit_id":"3a1aab3ea85820452f76181dcb00d2644d4386f7"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"f316802a405804ba96c7a1906148adb5bb910978","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":74,"context_line":"                \u0027required\u0027: [\u0027status\u0027, \u0027user_id\u0027, \u0027attachments\u0027, \u0027links\u0027,"},{"line_number":75,"context_line":"                             \u0027bootable\u0027, \u0027encrypted\u0027, \u0027created_at\u0027,"},{"line_number":76,"context_line":"                             \u0027description\u0027, \u0027updated_at\u0027, \u0027volume_type\u0027,"},{"line_number":77,"context_line":"                             \u0027name\u0027, \u0027consistencygroup_id\u0027, \u0027multiattach\u0027,"},{"line_number":78,"context_line":"                             \u0027metadata\u0027, \u0027id\u0027, \u0027size\u0027]"},{"line_number":79,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_0b45e1b3","line":76,"range":{"start_line":76,"start_character":30,"end_line":76,"end_character":41},"updated":"2019-08-21 03:16:42.000000000","message":"this is optional \nhttps://docs.openstack.org/api-ref/block-storage/v3/?expanded\u003dshow-group-type-details-detail,create-group-type-detail,delete-one-specific-group-spec-for-a-group-type-detail,list-group-types-detail,create-or-update-group-specs-for-a-group-type-detail,list-group-specs-for-a-group-type-detail,show-one-specific-group-spec-for-a-group-type-detail,delete-group-detail,show-group-details-detail,list-group-snapshots-detail,list-group-snapshots-with-details-detail,reset-group-snapshot-status-detail,update-group-type-detail,update-group-detail,create-group-from-source-detail,manage-an-existing-snapshot-detail#show-quotas-for-a-project","commit_id":"094aac096921a41cc779e7aa4968f37d488b300e"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"33711034e9b0ea433be3754019da14740d2229b5","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":74,"context_line":"                \u0027required\u0027: [\u0027status\u0027, \u0027user_id\u0027, \u0027attachments\u0027, \u0027links\u0027,"},{"line_number":75,"context_line":"                             \u0027bootable\u0027, \u0027encrypted\u0027, \u0027created_at\u0027,"},{"line_number":76,"context_line":"                             \u0027description\u0027, \u0027updated_at\u0027, \u0027volume_type\u0027,"},{"line_number":77,"context_line":"                             \u0027name\u0027, \u0027consistencygroup_id\u0027, \u0027multiattach\u0027,"},{"line_number":78,"context_line":"                             \u0027metadata\u0027, \u0027id\u0027, \u0027size\u0027]"},{"line_number":79,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_eb98851b","line":76,"range":{"start_line":76,"start_character":30,"end_line":76,"end_character":41},"in_reply_to":"7faddb67_0b45e1b3","updated":"2019-08-21 03:33:33.000000000","message":"Thanks, done","commit_id":"094aac096921a41cc779e7aa4968f37d488b300e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3a6892a4bb9b1e78a128c66d1c0c642f376f5630","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                    \u0027size\u0027: {\u0027type\u0027: \u0027integer\u0027}"},{"line_number":72,"context_line":"                },"},{"line_number":73,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":74,"context_line":"                \u0027required\u0027: [\u0027status\u0027, \u0027user_id\u0027, \u0027attachments\u0027, \u0027links\u0027,"},{"line_number":75,"context_line":"                             \u0027bootable\u0027, \u0027encrypted\u0027, \u0027created_at\u0027,"},{"line_number":76,"context_line":"                             \u0027updated_at\u0027, \u0027volume_type\u0027, \u0027name\u0027,"},{"line_number":77,"context_line":"                             \u0027consistencygroup_id\u0027, \u0027multiattach\u0027,"},{"line_number":78,"context_line":"                             \u0027metadata\u0027, \u0027id\u0027, \u0027size\u0027]"},{"line_number":79,"context_line":"            }"},{"line_number":80,"context_line":"        },"},{"line_number":81,"context_line":"        \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_6e2447b0","line":78,"range":{"start_line":74,"start_character":0,"end_line":78,"end_character":54},"updated":"2020-03-16 00:59:49.000000000","message":"below attributes that are mandatory in response[1] are missing in the required field. please add them in same order as they are in schema.\n\navailability_zone, description, replication_status, source_volid, snapshot_id\n\n[1] https://github.com/openstack/cinder/blob/e5fe9b881cc06d94a077efd0fa4c73abb1781766/cinder/api/v2/views/volumes.py#L68","commit_id":"09dba565fa64df071e2555f8809bce1cf1f88d02"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e1c8f8fc9d25da7dad81901833ec6671b7464e95","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                    \u0027size\u0027: {\u0027type\u0027: \u0027integer\u0027}"},{"line_number":72,"context_line":"                },"},{"line_number":73,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":74,"context_line":"                \u0027required\u0027: [\u0027status\u0027, \u0027user_id\u0027, \u0027attachments\u0027, \u0027links\u0027,"},{"line_number":75,"context_line":"                             \u0027bootable\u0027, \u0027encrypted\u0027, \u0027created_at\u0027,"},{"line_number":76,"context_line":"                             \u0027updated_at\u0027, \u0027volume_type\u0027, \u0027name\u0027,"},{"line_number":77,"context_line":"                             \u0027consistencygroup_id\u0027, \u0027multiattach\u0027,"},{"line_number":78,"context_line":"                             \u0027metadata\u0027, \u0027id\u0027, \u0027size\u0027]"},{"line_number":79,"context_line":"            }"},{"line_number":80,"context_line":"        },"},{"line_number":81,"context_line":"        \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_80ce2cb2","line":78,"range":{"start_line":74,"start_character":0,"end_line":78,"end_character":54},"in_reply_to":"1fa4df85_51348c4a","updated":"2020-03-16 12:33:32.000000000","message":"volume manage use the volume show response only - https://github.com/openstack/cinder/blob/fcbfa927a39add44d633b7ef8e987a9ed109fc54/cinder/api/contrib/volume_manage.py#L152\n\napi-ref might be buggy here, can you propose the patch to fix them and once cinder team is happy there we can merge this.\n\nI am going with what code behaves and that is what API contract is. api-ref are not so reliable especially when they are manually constructed.","commit_id":"09dba565fa64df071e2555f8809bce1cf1f88d02"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6d473ee82f860cdd7befd544d598ac44313130bb","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                    \u0027size\u0027: {\u0027type\u0027: \u0027integer\u0027}"},{"line_number":72,"context_line":"                },"},{"line_number":73,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":74,"context_line":"                \u0027required\u0027: [\u0027status\u0027, \u0027user_id\u0027, \u0027attachments\u0027, \u0027links\u0027,"},{"line_number":75,"context_line":"                             \u0027bootable\u0027, \u0027encrypted\u0027, \u0027created_at\u0027,"},{"line_number":76,"context_line":"                             \u0027updated_at\u0027, \u0027volume_type\u0027, \u0027name\u0027,"},{"line_number":77,"context_line":"                             \u0027consistencygroup_id\u0027, \u0027multiattach\u0027,"},{"line_number":78,"context_line":"                             \u0027metadata\u0027, \u0027id\u0027, \u0027size\u0027]"},{"line_number":79,"context_line":"            }"},{"line_number":80,"context_line":"        },"},{"line_number":81,"context_line":"        \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_9b6e1d93","line":78,"range":{"start_line":74,"start_character":0,"end_line":78,"end_character":54},"in_reply_to":"1fa4df85_51348c4a","updated":"2020-05-14 21:06:58.000000000","message":"yeah, manage-volume also use the show volume view - https://github.com/openstack/cinder/blob/e5fe9b881cc06d94a077efd0fa4c73abb1781766/cinder/api/contrib/volume_manage.py#L152","commit_id":"09dba565fa64df071e2555f8809bce1cf1f88d02"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"5028d45deb7780aaa521a788e1b5ea0e44d6d0f5","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                    \u0027size\u0027: {\u0027type\u0027: \u0027integer\u0027}"},{"line_number":72,"context_line":"                },"},{"line_number":73,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":74,"context_line":"                \u0027required\u0027: [\u0027status\u0027, \u0027user_id\u0027, \u0027attachments\u0027, \u0027links\u0027,"},{"line_number":75,"context_line":"                             \u0027bootable\u0027, \u0027encrypted\u0027, \u0027created_at\u0027,"},{"line_number":76,"context_line":"                             \u0027updated_at\u0027, \u0027volume_type\u0027, \u0027name\u0027,"},{"line_number":77,"context_line":"                             \u0027consistencygroup_id\u0027, \u0027multiattach\u0027,"},{"line_number":78,"context_line":"                             \u0027metadata\u0027, \u0027id\u0027, \u0027size\u0027]"},{"line_number":79,"context_line":"            }"},{"line_number":80,"context_line":"        },"},{"line_number":81,"context_line":"        \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_51348c4a","line":78,"range":{"start_line":74,"start_character":0,"end_line":78,"end_character":54},"in_reply_to":"1fa4df85_6e2447b0","updated":"2020-03-16 07:13:46.000000000","message":"Sorry I\u0027m a little confused, in the api ref\nhttps://docs.openstack.org/api-ref/block-storage/v3/index.html#manage-an-existing-volume\nreplication_status is required and now is added, as to the other fields, they are optional in api ref.\n\nhttps://github.com/openstack/cinder/blob/e5fe9b881cc06d94a077efd0fa4c73abb1781766/cinder/api/v2/views/volumes.py#L68\nseems to be the result of show-volume, so does the result of manage-volume need to be same with that?","commit_id":"09dba565fa64df071e2555f8809bce1cf1f88d02"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9a0775a3691d1cf25916b8084f872d7875760b7a","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                    \u0027size\u0027: {\u0027type\u0027: \u0027integer\u0027}"},{"line_number":72,"context_line":"                },"},{"line_number":73,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":74,"context_line":"                \u0027required\u0027: [\u0027status\u0027, \u0027user_id\u0027, \u0027attachments\u0027, \u0027links\u0027,"},{"line_number":75,"context_line":"                             \u0027bootable\u0027, \u0027encrypted\u0027, \u0027created_at\u0027,"},{"line_number":76,"context_line":"                             \u0027updated_at\u0027, \u0027volume_type\u0027, \u0027name\u0027,"},{"line_number":77,"context_line":"                             \u0027consistencygroup_id\u0027, \u0027multiattach\u0027,"},{"line_number":78,"context_line":"                             \u0027metadata\u0027, \u0027id\u0027, \u0027size\u0027]"},{"line_number":79,"context_line":"            }"},{"line_number":80,"context_line":"        },"},{"line_number":81,"context_line":"        \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_7b5069d5","line":78,"range":{"start_line":74,"start_character":0,"end_line":78,"end_character":54},"in_reply_to":"1fa4df85_80ce2cb2","updated":"2020-05-14 21:03:24.000000000","message":"so we can file bug on api-ref but let\u0027s make them mandatory here","commit_id":"09dba565fa64df071e2555f8809bce1cf1f88d02"}]}