)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a4654e0b9b7cb5dbf42e06e7e516b502b01b8ee1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"5e0cd5bb_b2cda4b3","updated":"2021-12-10 22:59:53.000000000","message":"please rebase if this is still needed. as there is no activity on this since long we will abandon it next week if no updates","commit_id":"29c6d255286d6f4674a01928db253122a088f5ff"}],"tempest/tests/cmd/test_account_generator.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"45d13c764f18dc689dbbf1bf64e9a0d863cb63b9","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        self.mock_config_and_opts(self.identity_version)"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    def assertRunExit(self, cmd, expected):"},{"line_number":336,"context_line":"        p \u003d subprocess.Popen(cmd, stdout\u003dsubprocess.PIPE,"},{"line_number":337,"context_line":"                             stderr\u003dsubprocess.PIPE)"},{"line_number":338,"context_line":"        out, err \u003d p.communicate()"},{"line_number":339,"context_line":"        msg \u003d (\"Running %s got an unexpected returncode\\n\""},{"line_number":340,"context_line":"               \"Stdout: %s\\nStderr: %s\" % (\u0027 \u0027.join(cmd), out, err))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_9d30d5eb","line":337,"range":{"start_line":336,"start_character":0,"end_line":337,"end_character":52},"updated":"2018-10-09 12:40:19.000000000","message":"with different process, mock would not work (till we have hack for that but i donot know).\n\nWE can test it by calling the take_action() function on TempestAccountGenerator and pass the all arg options. in that case, mocked config file will work fine.","commit_id":"1601f5382707bdd1bc45fa00a75f8433f79c4ebd"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"205700d445a5983bb297369667ebbe3a0ce658bc","unresolved":false,"context_lines":[{"line_number":372,"context_line":"        self.useFixture(fixtures.MockPatch("},{"line_number":373,"context_line":"            self.cred_client + \u0027.assign_user_role\u0027))"},{"line_number":374,"context_line":"        self.useFixture(fixtures.MockPatch("},{"line_number":375,"context_line":"            self.cred_client + \u0027._check_role_exists\u0027,"},{"line_number":376,"context_line":"            return_value\u003ddict(id\u003d\u0027fake_role_id\u0027, name\u003d\u0027fake_role\u0027)))"},{"line_number":377,"context_line":"        self.useFixture(fixtures.MockPatch("},{"line_number":378,"context_line":"            self.dynamic_creds + \u0027._create_network\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"5fc1f717_bcfc9fb5","line":375,"range":{"start_line":375,"start_character":33,"end_line":375,"end_character":51},"updated":"2019-03-22 00:40:47.000000000","message":"nit: I would think this is a HEAD request that doesn\u0027t return anything? So why do we need return_value, but maybe I am mistaken.","commit_id":"2f15b8436c75b76615a95c6a80b19a3d976b9817"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"205700d445a5983bb297369667ebbe3a0ce658bc","unresolved":false,"context_lines":[{"line_number":363,"context_line":"        super(TestAccountGeneratorCliCheck, self).setUp()"},{"line_number":364,"context_line":"        self.mock_config_and_opts(self.identity_version)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        self.user_create_fixture \u003d self.useFixture(fixtures.MockPatch("},{"line_number":367,"context_line":"            self.cred_client + \u0027.create_user\u0027,"},{"line_number":368,"context_line":"            return_value\u003ddict(id\u003d\u0027fake_user_id\u0027, name\u003d\u0027fake_user\u0027)))"},{"line_number":369,"context_line":"        self.useFixture(fixtures.MockPatch("},{"line_number":370,"context_line":"            self.cred_client + \u0027.create_project\u0027,"},{"line_number":371,"context_line":"            return_value\u003ddict(id\u003d\u0027fake_project_id\u0027, name\u003d\u0027fake_project\u0027)))"},{"line_number":372,"context_line":"        self.useFixture(fixtures.MockPatch("},{"line_number":373,"context_line":"            self.cred_client + \u0027.assign_user_role\u0027))"},{"line_number":374,"context_line":"        self.useFixture(fixtures.MockPatch("},{"line_number":375,"context_line":"            self.cred_client + \u0027._check_role_exists\u0027,"},{"line_number":376,"context_line":"            return_value\u003ddict(id\u003d\u0027fake_role_id\u0027, name\u003d\u0027fake_role\u0027)))"},{"line_number":377,"context_line":"        self.useFixture(fixtures.MockPatch("},{"line_number":378,"context_line":"            self.dynamic_creds + \u0027._create_network\u0027,"},{"line_number":379,"context_line":"            return_value\u003ddict(id\u003d\u0027fake_network_id\u0027, name\u003d\u0027fake_network\u0027)))"},{"line_number":380,"context_line":"        self.useFixture(fixtures.MockPatch("},{"line_number":381,"context_line":"            self.dynamic_creds + \u0027._create_subnet\u0027,"},{"line_number":382,"context_line":"            return_value\u003ddict(id\u003d\u0027fake_subnet_id\u0027, name\u003d\u0027fake_subnet\u0027)))"},{"line_number":383,"context_line":"        self.useFixture(fixtures.MockPatch("},{"line_number":384,"context_line":"            self.dynamic_creds + \u0027._create_router\u0027,"},{"line_number":385,"context_line":"            return_value\u003ddict(id\u003d\u0027fake_router_id\u0027, name\u003d\u0027fake_router\u0027)))"},{"line_number":386,"context_line":"        self.useFixture(fixtures.MockPatch("},{"line_number":387,"context_line":"            self.dynamic_creds + \u0027._add_router_interface\u0027,"},{"line_number":388,"context_line":"            return_value\u003ddict(id\u003d\u0027fake_interface_id\u0027, name\u003d\u0027fake_interface\u0027)))"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"    def _setup_test_dirs(self):"},{"line_number":391,"context_line":"        self.directory \u003d tempfile.mkdtemp(prefix\u003d\u0027tempest-unit\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"5fc1f717_dce5eb0b","line":388,"range":{"start_line":366,"start_character":8,"end_line":388,"end_character":78},"updated":"2019-03-22 00:40:47.000000000","message":"Actually most of this looks like a copy/paste of https://review.openstack.org/#/c/608878/14/tempest/tests/cmd/test_account_generator.py@53\n\nI think we can just call self.mock_resource_creation() instead?","commit_id":"2f15b8436c75b76615a95c6a80b19a3d976b9817"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"205700d445a5983bb297369667ebbe3a0ce658bc","unresolved":false,"context_lines":[{"line_number":393,"context_line":"        self.test_dir \u003d os.path.join(self.directory, \u0027tests\u0027)"},{"line_number":394,"context_line":"        os.mkdir(self.test_dir)"},{"line_number":395,"context_line":"        # Change directory, run wrapper and check result"},{"line_number":396,"context_line":"        self.addCleanup(os.chdir, os.path.abspath(os.curdir))"},{"line_number":397,"context_line":"        os.chdir(self.directory)"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    def test_account_generator_no_config_file(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"5fc1f717_9c1a0315","line":396,"range":{"start_line":396,"start_character":8,"end_line":396,"end_character":61},"updated":"2019-03-22 00:40:47.000000000","message":"nit: not really needed since the dir is going to be deleted immediately afterward.","commit_id":"2f15b8436c75b76615a95c6a80b19a3d976b9817"}]}