)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"efcf3338f6dda0f9069caccdbc9063ea826a3c77","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Besides, totalSnapshotsUsed should be integer in the response"},{"line_number":11,"context_line":"of \"Show absolute limits for project\", I48f61f50defe9782d5a7afb7d7fa245f562785a0"},{"line_number":12,"context_line":"will fix the api doc."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I245dd944f29681f3f41febafa7901f8f233a2776"},{"line_number":15,"context_line":"partially-implements: blueprint volume-response-schema-validation"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_93f3a16d","line":13,"updated":"2018-10-11 20:17:19.000000000","message":"May we add a Depends-On: https://review.openstack.org/#/c/609639/1 here?","commit_id":"456f84f4ba26c6e600af775564c3dddfd35d785a"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"1c1f56bda695655c60b01c89a6cf76bb9da62e29","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Besides, totalSnapshotsUsed should be integer in the response"},{"line_number":11,"context_line":"of \"Show absolute limits for project\", I48f61f50defe9782d5a7afb7d7fa245f562785a0"},{"line_number":12,"context_line":"will fix the api doc."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I245dd944f29681f3f41febafa7901f8f233a2776"},{"line_number":15,"context_line":"partially-implements: blueprint volume-response-schema-validation"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_96492130","line":13,"in_reply_to":"3f79a3b5_93f3a16d","updated":"2018-10-15 06:18:56.000000000","message":"Because I\u0027m afraid that Cinder api patch will need lasting modification, so I didn\u0027t add it here.","commit_id":"456f84f4ba26c6e600af775564c3dddfd35d785a"}],"tempest/lib/api_schema/response/volume/limits.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"efcf3338f6dda0f9069caccdbc9063ea826a3c77","unresolved":false,"context_lines":[{"line_number":20,"context_line":"            \u0027limits\u0027: {"},{"line_number":21,"context_line":"                \u0027type\u0027: \u0027object\u0027,"},{"line_number":22,"context_line":"                \u0027properties\u0027: {"},{"line_number":23,"context_line":"                    \u0027rate\u0027: {\u0027type\u0027: \u0027array\u0027},"},{"line_number":24,"context_line":"                    \u0027absolute\u0027: {"},{"line_number":25,"context_line":"                        \u0027type\u0027: \u0027object\u0027,"},{"line_number":26,"context_line":"                        \u0027properties\u0027: {"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_53c98922","line":23,"range":{"start_line":23,"start_character":36,"end_line":23,"end_character":44},"updated":"2018-10-11 20:17:19.000000000","message":"The API docs are not so helpful here but maybe later can be expanded to include this: https://github.com/openstack/cinder/blob/a2d4a9569e0feba086ac996cb6d17f33e76c2eb8/cinder/api/views/limits.py#L86","commit_id":"456f84f4ba26c6e600af775564c3dddfd35d785a"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"1c1f56bda695655c60b01c89a6cf76bb9da62e29","unresolved":false,"context_lines":[{"line_number":20,"context_line":"            \u0027limits\u0027: {"},{"line_number":21,"context_line":"                \u0027type\u0027: \u0027object\u0027,"},{"line_number":22,"context_line":"                \u0027properties\u0027: {"},{"line_number":23,"context_line":"                    \u0027rate\u0027: {\u0027type\u0027: \u0027array\u0027},"},{"line_number":24,"context_line":"                    \u0027absolute\u0027: {"},{"line_number":25,"context_line":"                        \u0027type\u0027: \u0027object\u0027,"},{"line_number":26,"context_line":"                        \u0027properties\u0027: {"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_f653b5dc","line":23,"range":{"start_line":23,"start_character":36,"end_line":23,"end_character":44},"in_reply_to":"3f79a3b5_53c98922","updated":"2018-10-15 06:18:56.000000000","message":"Yes wish somebody can do that:)","commit_id":"456f84f4ba26c6e600af775564c3dddfd35d785a"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"efcf3338f6dda0f9069caccdbc9063ea826a3c77","unresolved":false,"context_lines":[{"line_number":24,"context_line":"                    \u0027absolute\u0027: {"},{"line_number":25,"context_line":"                        \u0027type\u0027: \u0027object\u0027,"},{"line_number":26,"context_line":"                        \u0027properties\u0027: {"},{"line_number":27,"context_line":"                            \u0027totalSnapshotsUsed\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":28,"context_line":"                            \u0027maxTotalBackups\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":29,"context_line":"                            \u0027maxTotalVolumeGigabytes\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":30,"context_line":"                            \u0027maxTotalSnapshots\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":31,"context_line":"                            \u0027maxTotalBackupGigabytes\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":32,"context_line":"                            \u0027totalBackupGigabytesUsed\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":33,"context_line":"                            \u0027maxTotalVolumes\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":34,"context_line":"                            \u0027totalVolumesUsed\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":35,"context_line":"                            \u0027totalBackupsUsed\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":36,"context_line":"                            \u0027totalGigabytesUsed\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":37,"context_line":"                        }"},{"line_number":38,"context_line":"                    }"},{"line_number":39,"context_line":"                },"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_93dac1e3","line":36,"range":{"start_line":27,"start_character":0,"end_line":36,"end_character":70},"updated":"2018-10-11 20:17:19.000000000","message":"If these are optional (because required is missing with them) then that should be conveyed in API docs via (optional) e.g. totalSnapshotsUsed (optional).\n\nhttps://developer.openstack.org/api-ref/block-storage/v3/index.html#show-absolute-limits-for-project\n\nIt\u0027s not easy to say by looking at view code for limits in https://github.com/openstack/cinder/blob/a2d4a9569e0feba086ac996cb6d17f33e76c2eb8/cinder/api/views/limits.py whether they are optional or not. But either way if they are optional here they should also be in the API docs.","commit_id":"456f84f4ba26c6e600af775564c3dddfd35d785a"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"1c1f56bda695655c60b01c89a6cf76bb9da62e29","unresolved":false,"context_lines":[{"line_number":24,"context_line":"                    \u0027absolute\u0027: {"},{"line_number":25,"context_line":"                        \u0027type\u0027: \u0027object\u0027,"},{"line_number":26,"context_line":"                        \u0027properties\u0027: {"},{"line_number":27,"context_line":"                            \u0027totalSnapshotsUsed\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":28,"context_line":"                            \u0027maxTotalBackups\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":29,"context_line":"                            \u0027maxTotalVolumeGigabytes\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":30,"context_line":"                            \u0027maxTotalSnapshots\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":31,"context_line":"                            \u0027maxTotalBackupGigabytes\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":32,"context_line":"                            \u0027totalBackupGigabytesUsed\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":33,"context_line":"                            \u0027maxTotalVolumes\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":34,"context_line":"                            \u0027totalVolumesUsed\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":35,"context_line":"                            \u0027totalBackupsUsed\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":36,"context_line":"                            \u0027totalGigabytesUsed\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":37,"context_line":"                        }"},{"line_number":38,"context_line":"                    }"},{"line_number":39,"context_line":"                },"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_165751cb","line":36,"range":{"start_line":27,"start_character":0,"end_line":36,"end_character":70},"in_reply_to":"3f79a3b5_93dac1e3","updated":"2018-10-15 06:18:56.000000000","message":"Now I set them all required:)","commit_id":"456f84f4ba26c6e600af775564c3dddfd35d785a"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"582dc152a3719204868eed8e1be39e10aa1b822f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"show_limits \u003d {"},{"line_number":16,"context_line":"    \u0027status_code\u0027: [200],"},{"line_number":17,"context_line":"    \u0027response_body\u0027: {"},{"line_number":18,"context_line":"        \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_7f59acfa","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":11},"updated":"2019-08-21 11:31:21.000000000","message":"confirmed \nhttps://docs.openstack.org/api-ref/block-storage/v3/?expanded\u003dshow-group-type-details-detail,create-group-type-detail,delete-one-specific-group-spec-for-a-group-type-detail,list-group-types-detail,create-or-update-group-specs-for-a-group-type-detail,list-group-specs-for-a-group-type-detail,show-one-specific-group-spec-for-a-group-type-detail,delete-group-detail,show-group-details-detail,list-group-snapshots-detail,list-group-snapshots-with-details-detail,reset-group-snapshot-status-detail,update-group-type-detail,update-group-detail,create-group-from-source-detail,manage-an-existing-snapshot-detail,show-quotas-for-a-project-detail,manage-an-existing-volume-detail,list-all-back-end-storage-pools-detail,show-absolute-limits-for-project-detail#show-absolute-limits-for-project","commit_id":"40bbe0c91e88b22951de9961176b52c92945447f"}]}