)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"673e4e289234a1f32d451b57319d6885816e7ce0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In test_add_remove_fixed_ip there is a potential issue where the user"},{"line_number":10,"context_line":"running the test does not have the ability to create a server with a"},{"line_number":11,"context_line":"fixed ip. As pointed out by zhufl (in review of change"},{"line_number":12,"context_line":"I10a34fb12b595400fc15d935070f130c8e3d3963) This commit fixes the issue"},{"line_number":13,"context_line":"so that we properly skip if tempest is not configured in a way where it"},{"line_number":14,"context_line":"can create a server with the fixed ip."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_d7dec569","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":41},"updated":"2018-10-13 03:41:36.000000000","message":"The code also is present here: https://review.openstack.org/#/c/610073/1/tempest/api/compute/servers/test_attach_interfaces.py@257","commit_id":"ab1ce195d3659ad9d68bf034a3c4e4c2b43a2053"}],"tempest/api/compute/servers/test_attach_interfaces.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"673e4e289234a1f32d451b57319d6885816e7ce0","unresolved":false,"context_lines":[{"line_number":339,"context_line":"    @utils.services(\u0027network\u0027)"},{"line_number":340,"context_line":"    def test_add_remove_fixed_ip(self):"},{"line_number":341,"context_line":"        # NOTE(zhufl) By default only project that is admin or network owner"},{"line_number":342,"context_line":"        # or project with role advsvc is authorised to create interfaces with"},{"line_number":343,"context_line":"        # fixed-ip, so if we don\u0027t create network for each project, do not"},{"line_number":344,"context_line":"        # test _test_create_interface_by_fixed_ips."},{"line_number":345,"context_line":"        if not (CONF.auth.use_dynamic_credentials and"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_77c9f1a8","line":342,"range":{"start_line":342,"start_character":55,"end_line":342,"end_character":72},"updated":"2018-10-13 03:41:36.000000000","message":"This test below doesn\u0027t appear to be creating interfaces?","commit_id":"ab1ce195d3659ad9d68bf034a3c4e4c2b43a2053"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"d049eb818a0d8ec7500c5f48c2feb6616b627aeb","unresolved":false,"context_lines":[{"line_number":339,"context_line":"    @utils.services(\u0027network\u0027)"},{"line_number":340,"context_line":"    def test_add_remove_fixed_ip(self):"},{"line_number":341,"context_line":"        # NOTE(zhufl) By default only project that is admin or network owner"},{"line_number":342,"context_line":"        # or project with role advsvc is authorised to create interfaces with"},{"line_number":343,"context_line":"        # fixed-ip, so if we don\u0027t create network for each project, do not"},{"line_number":344,"context_line":"        # test _test_create_interface_by_fixed_ips."},{"line_number":345,"context_line":"        if not (CONF.auth.use_dynamic_credentials and"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_b761c9aa","line":342,"range":{"start_line":342,"start_character":55,"end_line":342,"end_character":72},"in_reply_to":"3f79a3b5_77c9f1a8","updated":"2018-10-13 03:53:20.000000000","message":"Done","commit_id":"ab1ce195d3659ad9d68bf034a3c4e4c2b43a2053"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"673e4e289234a1f32d451b57319d6885816e7ce0","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        # NOTE(zhufl) By default only project that is admin or network owner"},{"line_number":342,"context_line":"        # or project with role advsvc is authorised to create interfaces with"},{"line_number":343,"context_line":"        # fixed-ip, so if we don\u0027t create network for each project, do not"},{"line_number":344,"context_line":"        # test _test_create_interface_by_fixed_ips."},{"line_number":345,"context_line":"        if not (CONF.auth.use_dynamic_credentials and"},{"line_number":346,"context_line":"                CONF.auth.create_isolated_networks and"},{"line_number":347,"context_line":"                not CONF.network.shared_physical_network):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_17d99d82","line":344,"range":{"start_line":344,"start_character":15,"end_line":344,"end_character":50},"updated":"2018-10-13 03:41:36.000000000","message":"This part is not correct in this context.","commit_id":"ab1ce195d3659ad9d68bf034a3c4e4c2b43a2053"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"d049eb818a0d8ec7500c5f48c2feb6616b627aeb","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        # NOTE(zhufl) By default only project that is admin or network owner"},{"line_number":342,"context_line":"        # or project with role advsvc is authorised to create interfaces with"},{"line_number":343,"context_line":"        # fixed-ip, so if we don\u0027t create network for each project, do not"},{"line_number":344,"context_line":"        # test _test_create_interface_by_fixed_ips."},{"line_number":345,"context_line":"        if not (CONF.auth.use_dynamic_credentials and"},{"line_number":346,"context_line":"                CONF.auth.create_isolated_networks and"},{"line_number":347,"context_line":"                not CONF.network.shared_physical_network):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_975ccdf0","line":344,"range":{"start_line":344,"start_character":15,"end_line":344,"end_character":50},"in_reply_to":"3f79a3b5_17d99d82","updated":"2018-10-13 03:53:20.000000000","message":"Done","commit_id":"ab1ce195d3659ad9d68bf034a3c4e4c2b43a2053"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"28cf4816979b9a1e327ca518464ce45808c4b2dc","unresolved":false,"context_lines":[{"line_number":338,"context_line":"    @decorators.idempotent_id(\u0027c7e0e60b-ee45-43d0-abeb-8596fd42a2f9\u0027)"},{"line_number":339,"context_line":"    @utils.services(\u0027network\u0027)"},{"line_number":340,"context_line":"    def test_add_remove_fixed_ip(self):"},{"line_number":341,"context_line":"        # NOTE(zhufl) By default only project that is admin or network owner"},{"line_number":342,"context_line":"        # or project with role advsvc is authorised to add interfaces with"},{"line_number":343,"context_line":"        # fixed-ip, so if we don\u0027t create network for each project, do not"},{"line_number":344,"context_line":"        # test"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_a1128760","line":341,"range":{"start_line":341,"start_character":10,"end_line":341,"end_character":21},"updated":"2018-10-18 06:26:17.000000000","message":"I think you mistakenly used zhufl\u0027s name here from L[249]. Could you please add your user name or you intentionally kept it?\nSecondly, for  proper syntax \":\" is missing.\ne.g. # NOTE(user):","commit_id":"524da9898ac17e94d391b8dde1e00c9d10cf4336"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"dc8bce557341fd8c9fa5acbfac85e881bb9f94a3","unresolved":false,"context_lines":[{"line_number":338,"context_line":"    @decorators.idempotent_id(\u0027c7e0e60b-ee45-43d0-abeb-8596fd42a2f9\u0027)"},{"line_number":339,"context_line":"    @utils.services(\u0027network\u0027)"},{"line_number":340,"context_line":"    def test_add_remove_fixed_ip(self):"},{"line_number":341,"context_line":"        # NOTE(zhufl) By default only project that is admin or network owner"},{"line_number":342,"context_line":"        # or project with role advsvc is authorised to add interfaces with"},{"line_number":343,"context_line":"        # fixed-ip, so if we don\u0027t create network for each project, do not"},{"line_number":344,"context_line":"        # test"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_cd21ed51","line":341,"range":{"start_line":341,"start_character":10,"end_line":341,"end_character":21},"in_reply_to":"3f79a3b5_a1128760","updated":"2018-10-18 14:13:57.000000000","message":"It is OK to use someone else\u0027s name. In this case, it is a small nit, because while the comment was slightly changed, it still contains the original intent of the comment.","commit_id":"524da9898ac17e94d391b8dde1e00c9d10cf4336"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"203c74f5fa40923d9e4510bc7c9a468895cd5d61","unresolved":false,"context_lines":[{"line_number":338,"context_line":"    @decorators.idempotent_id(\u0027c7e0e60b-ee45-43d0-abeb-8596fd42a2f9\u0027)"},{"line_number":339,"context_line":"    @utils.services(\u0027network\u0027)"},{"line_number":340,"context_line":"    def test_add_remove_fixed_ip(self):"},{"line_number":341,"context_line":"        # NOTE(zhufl) By default only project that is admin or network owner"},{"line_number":342,"context_line":"        # or project with role advsvc is authorised to add interfaces with"},{"line_number":343,"context_line":"        # fixed-ip, so if we don\u0027t create network for each project, do not"},{"line_number":344,"context_line":"        # test"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_e2e2b336","line":341,"range":{"start_line":341,"start_character":10,"end_line":341,"end_character":21},"in_reply_to":"3f79a3b5_cd21ed51","updated":"2018-10-18 14:58:54.000000000","message":"yeah that is from L249","commit_id":"524da9898ac17e94d391b8dde1e00c9d10cf4336"}]}