)]}'
{"tempest/api/compute/keypairs/test_keypairs.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"9ae2281fd114162917b90a6a9615b108f0c56906","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def test_keypair_create_delete(self):"},{"line_number":72,"context_line":"        # Keypair should be created, verified and deleted"},{"line_number":73,"context_line":"        k_name \u003d data_utils.rand_name(\u0027keypair-\u0027)"},{"line_number":74,"context_line":"        resp, keypair \u003d self._create_keypair(k_name)"},{"line_number":75,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":76,"context_line":"        private_key \u003d keypair[\u0027private_key\u0027]"},{"line_number":77,"context_line":"        key_name \u003d keypair[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F8%2BIA%3D","line":74,"updated":"2013-12-18 09:13:54.000000000","message":"better to add addCleanup() after self.assertEqual(200, resp.status) because that means keypair creation succeeded and we should delete it.\n\nHow about just adding \"self.addCleanup(self.client.delete_keypair, k_name)\" like the existing code?","commit_id":"58d507705add587f037b7e36d2bbba0409a71bd1"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"d26e3b3f7c1a9f210966a7daa52acef4725a7870","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def test_keypair_create_delete(self):"},{"line_number":72,"context_line":"        # Keypair should be created, verified and deleted"},{"line_number":73,"context_line":"        k_name \u003d data_utils.rand_name(\u0027keypair-\u0027)"},{"line_number":74,"context_line":"        resp, keypair \u003d self._create_keypair(k_name)"},{"line_number":75,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":76,"context_line":"        private_key \u003d keypair[\u0027private_key\u0027]"},{"line_number":77,"context_line":"        key_name \u003d keypair[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F89SY%3D","line":74,"in_reply_to":"AAAATn%2F8%2BIA%3D","updated":"2013-12-18 12:08:37.000000000","message":"On an error response an exception will be raised automatically, before the addCleanup call.","commit_id":"58d507705add587f037b7e36d2bbba0409a71bd1"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"fe95d09282cc71044d1de3c7987235719be4de30","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def test_keypair_create_delete(self):"},{"line_number":72,"context_line":"        # Keypair should be created, verified and deleted"},{"line_number":73,"context_line":"        k_name \u003d data_utils.rand_name(\u0027keypair-\u0027)"},{"line_number":74,"context_line":"        resp, keypair \u003d self._create_keypair(k_name)"},{"line_number":75,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":76,"context_line":"        private_key \u003d keypair[\u0027private_key\u0027]"},{"line_number":77,"context_line":"        key_name \u003d keypair[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F89ks%3D","line":74,"in_reply_to":"AAAATn%2F8%2BIA%3D","updated":"2013-12-18 11:09:41.000000000","message":"the create now automatically does the delete, I actually really like that pattern","commit_id":"58d507705add587f037b7e36d2bbba0409a71bd1"}],"tempest/api/compute/keypairs/test_keypairs_negative.py":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"6fc9e4722306fdbb236c2b6e58460e4b565b067b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        super(KeyPairsNegativeTestJSON, cls).setUpClass()"},{"line_number":31,"context_line":"        cls.client \u003d cls.keypairs_client"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _create_keypair(self, keypair_name, pub_key\u003dNone):"},{"line_number":34,"context_line":"        self.client.create_keypair(keypair_name, pub_key)"},{"line_number":35,"context_line":"        self.addCleanup(self.client.delete_keypair, keypair_name)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9dJI%3D","line":33,"updated":"2013-12-11 10:57:21.000000000","message":"Probably a good idea to have a similar  _create_keypair function that can be used in the non negative testcase file as well (I guess they have to be different because this one doesn\u0027t want to fail if it can\u0027t delete the keypair).","commit_id":"bf8fd356b022b353e4a3ce6e477e5ca22b4c19ac"}]}