)]}'
{"tempest/scenario/test_network_basic_ops.py":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"d8532ec9aed807e2d73ef116904c2283d2b535cb","unresolved":false,"context_lines":[{"line_number":473,"context_line":"        \"\"\""},{"line_number":474,"context_line":"        self._setup_network_and_servers()"},{"line_number":475,"context_line":"        self._check_public_network_connectivity(should_connect\u003dTrue)"},{"line_number":476,"context_line":"        self._check_network_internal_connectivity(network\u003dself.network)"},{"line_number":477,"context_line":"        self._check_network_external_connectivity()"},{"line_number":478,"context_line":"        self._create_new_network(create_gateway\u003dTrue)"},{"line_number":479,"context_line":"        new_server \u003d self._create_server(self.new_net)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ae4dab3d","line":476,"range":{"start_line":476,"start_character":13,"end_line":476,"end_character":49},"updated":"2018-10-17 10:10:55.000000000","message":"We\u0027re still pinging the DHCP port here right? shouldn\u0027t we boot then another VM or change the test? If we don\u0027t want to rely on DHCP ports being able to respond to pings I think we should change this. What do you think?","commit_id":"2c208dc1017a0b02ac9a7ffc0a89a4bad81dac98"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"501cd102cf1101b02eb3582cd5dc4e901bde9bba","unresolved":false,"context_lines":[{"line_number":473,"context_line":"        \"\"\""},{"line_number":474,"context_line":"        self._setup_network_and_servers()"},{"line_number":475,"context_line":"        self._check_public_network_connectivity(should_connect\u003dTrue)"},{"line_number":476,"context_line":"        self._check_network_internal_connectivity(network\u003dself.network)"},{"line_number":477,"context_line":"        self._check_network_external_connectivity()"},{"line_number":478,"context_line":"        self._create_new_network(create_gateway\u003dTrue)"},{"line_number":479,"context_line":"        new_server \u003d self._create_server(self.new_net)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_0e74df36","line":476,"range":{"start_line":476,"start_character":13,"end_line":476,"end_character":49},"in_reply_to":"3f79a3b5_ae4dab3d","updated":"2018-10-17 10:19:14.000000000","message":"Yes it will ping the DHCP port here but the port will belong to the same network as the VM.\n\nNot sure if that\u0027s a concern since this method (_check_network_internal_connectivity) is used all over with that intent.\n\nMy concern with this test is that prior to this change it was trying to ping a DHCP port that lives on a different network.","commit_id":"2c208dc1017a0b02ac9a7ffc0a89a4bad81dac98"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"18c118ce2826a734e578b0361ff3855231a513cc","unresolved":false,"context_lines":[{"line_number":477,"context_line":"        self._check_network_external_connectivity()"},{"line_number":478,"context_line":"        self._create_new_network(create_gateway\u003dTrue)"},{"line_number":479,"context_line":"        new_server \u003d self._create_server(self.new_net)"},{"line_number":480,"context_line":"        self._check_network_internal_connectivity(network\u003dself.new_net,"},{"line_number":481,"context_line":"                                                  should_connect\u003dFalse)"},{"line_number":482,"context_line":"        router_id \u003d self.router[\u0027id\u0027]"},{"line_number":483,"context_line":"        self.routers_client.add_router_interface("},{"line_number":484,"context_line":"            router_id, subnet_id\u003dself.new_subnet[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_db946444","line":481,"range":{"start_line":480,"start_character":0,"end_line":481,"end_character":71},"updated":"2018-10-17 12:18:51.000000000","message":"actually we should change this too","commit_id":"2c208dc1017a0b02ac9a7ffc0a89a4bad81dac98"}]}